Re: [asterisk-dev] Re: [svn-commits] file: trunk r54711 - /trunk/main/manager.c

2007-02-16 Thread Joshua Colp
locked for reading. Have you checked the 1.4 branch? It most likely has the same bug. I did, it doesn't. Joshua Colp Software Developer Digium, Inc. ___ --Bandwidth and Colocation provided by Easynews.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] Bug #7531 (call not terminated after timelimit expires) fixed in 1.2?

2007-02-21 Thread Joshua Colp
version of 1.2 from SVN or even the latest release version and this is still an issue then file a new bug with the appropriate information (Dial line, console output, expected behavior, etc) and someone will look at it asap. Joshua Colp Software Developer Digium, Inc

Re: [asterisk-dev] chan_bridge concept

2007-08-16 Thread Joshua Colp
. If there are any specific questions you have about the bridging API feel free to ask or I can give a general overview for general list consumption. -- Joshua Colp Software Developer Digium, Inc. - The Genuine Asterisk Experience (TM) ___ --Bandwidth

Re: [asterisk-dev] chan_bridge concept

2007-08-16 Thread Joshua Colp
Tony Mountifield wrote: In article [EMAIL PROTECTED], Joshua Colp [EMAIL PROTECTED] wrote: I've been working on the bridging API rather heavily over the past week or so. It can currently handle bridging two channels together and multi-channel bridges fine and dandy, as is demonstrated

[asterisk-dev] Bridging API

2007-08-16 Thread Joshua Colp
. I don't think I've missed anything... but if anyone has any questions or comments reply back and I'll address them. -- Joshua Colp Software Developer Digium, Inc. - The Genuine Asterisk Experience (TM) ___ --Bandwidth and Colocation Provided by http

Re: [asterisk-dev] bweschke: branch 1.4 r87514 - /branches/1.4/apps/app_followme.c

2007-10-30 Thread Joshua Colp
though and perhaps this will make it show up on his radar twice :) Joshua Colp Software Developer Digium, Inc. ___ --Bandwidth and Colocation Provided by http://www.api-digital.com-- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] Audiohooks-1.4

2007-11-15 Thread Joshua Colp
a MixMonitor against a SIP to SIP channel and getting a Seg Fault 11 in channel.c:3587 because app_mixmonitor.c:169 is sending over a chan pointer to address 0. Since this is off the main branches, do I still open a bugs report on it? Just add a note to one of the existing bugs. Joshua Colp

Re: [asterisk-dev] Asterisk developer Philippe SULTAN member of XSF - XMPP Standards Foundation

2007-11-19 Thread Joshua Colp
Johansson Olle E wrote: Join me in congratulations to Philppe for this election! Congrats Philippe! Blueberry muffin for you. -- Joshua Colp Software Developer Digium, Inc. ___ --Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [asterisk-commits] file: trunk r89637 - /trunk/main/utils.c

2007-11-27 Thread Joshua Colp
... I tested both platforms before putting the change in and it worked fine on both, but it could be undefined. More exploring is required I suppose. Joshua Colp Software Developer Digium, Inc. ___ --Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] Bug #9650 - no ringing on transfer

2007-12-05 Thread Joshua Colp
production customers willy-nilly (ie. I actually want to read the diff). Cheers, Nic. The relevant revisions have been added as a note to the bug. Joshua Colp Software Developer Digium, Inc. ___ --Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 2987: ARI: Don't leak information about implementation details

2013-11-21 Thread Joshua Colp
://reviewboard.asterisk.org/r/2987/#comment19576 sanitize branches/12/include/asterisk/stasis.h https://reviewboard.asterisk.org/r/2987/#comment19577 sanitize - Joshua Colp On Nov. 11, 2013, 3:12 p.m., opticron wrote

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-11-21 Thread Joshua Colp
On Nov. 21, 2013, 12:59 a.m., Paul Belanger wrote: branches/12/rest-api/api-docs/device_states.json, line 11 https://reviewboard.asterisk.org/r/3025/diff/1/?file=48553#file48553line11 Hmm, not a fan of this URL schema. At first glance, what about just /states.

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10240 --- Ship it! Ship It! - Joshua Colp On Nov. 20, 2013, 9:12 p.m

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread Joshua Colp
for review too and mark it as dependent on the AMI commands/events review (you can do that in Reviewboard now! yay!). Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10235 --- Ship it! Ship It! - Joshua Colp On Nov. 20, 2013, 9:12 p.m

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-21 Thread Joshua Colp
... shouldn't you have specified the requirement of a Yay event in your test-config.yaml? - Joshua Colp On Nov. 20, 2013, 9:12 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3003/#review10253 --- On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-11-21 Thread Joshua Colp
On Nov. 21, 2013, 12:59 a.m., Paul Belanger wrote: Thanks for this, I plan to spend some time over the weekend trying this out. My comments are mostly from the ARIs POV, specifically what is a device in ARI? and is that the same as an endpoint? I'd akin this more to a virtual generic

Re: [asterisk-dev] [Code Review] 3017: PickupChan: Add ability to specify channel uniqueids as well as channel names.

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3017/#review10233 --- Ship it! - Joshua Colp On Nov. 18, 2013, 9:25 p.m

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Joshua Colp
is why not just treat the variable as a temporary return variable in the case when you have multiple MixMonitor instances and use Set in the dialplan to set another variable to the value. *shrug* - Joshua Colp On Nov. 20, 2013, 9:12 p.m., Mark Michelson wrote

Re: [asterisk-dev] [Code Review] 3015: Testsuite: CONFBRIDGE_RESULT test

2013-11-21 Thread Joshua Colp
/confbridge_result/configs/ast1/extensions.conf https://reviewboard.asterisk.org/r/3015/#comment19580 I'm picky but to a casual reader of this perhaps something descriptive instead of sausage would be nice? - Joshua Colp On Nov. 21, 2013, 3:40 p.m., Mark Michelson wrote

Re: [asterisk-dev] [Code Review] 2996: allow uncached realtime sip peers to be queue members

2013-11-21 Thread Joshua Colp
On Nov. 7, 2013, 3:37 p.m., Joshua Colp wrote: To make sure I better understand the situation... Is it caching an old stale entry without address? Then when device state is queried it uses that old stale entry instead of requerying realtime... so it thinks it has no address when

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-22 Thread Joshua Colp
-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3026: ari: Add playback and recording events.

2013-11-22 Thread Joshua Colp
/3026/diff/ Testing --- Did playbacks and recordings, confirmed events came over the Websocket. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-23 Thread Joshua Colp
! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3026: ari: Add playback and recording events.

2013-11-23 Thread Joshua Colp
/branches/12/res/ari/ari_model_validators.c 403005 /branches/12/res/ari/ari_model_validators.h 403005 Diff: https://reviewboard.asterisk.org/r/3026/diff/ Testing --- Did playbacks and recordings, confirmed events came over the Websocket. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-23 Thread Joshua Colp
/res_stasis_playback.c 403119 Diff: https://reviewboard.asterisk.org/r/3028/diff/ Testing --- Executed playback with the various URI schemes. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-23 Thread Joshua Colp
--- On Nov. 23, 2013, 2:35 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3028

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-23 Thread Joshua Colp
On Nov. 23, 2013, 5:38 p.m., Paul Belanger wrote: Wouldn't this be the same path as /dial? I know asterisk has native functionality to play numbers however, feel like libraries on top of ARI could handle this. /me shrugs. Joshua Colp wrote: To play numbers in various languages

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-26 Thread Joshua Colp
to construct a complete sentence if you desire. Diffs (updated) - /branches/12/res/res_stasis_playback.c 403158 Diff: https://reviewboard.asterisk.org/r/3028/diff/ Testing --- Executed playback with the various URI schemes. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

2013-11-26 Thread Joshua Colp
/res_pjsip.c 403158 /branches/12/include/asterisk/res_pjsip.h 403158 Diff: https://reviewboard.asterisk.org/r/3022/diff/ Testing --- Set the option, confirmed it was used. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 2851: chan_sip: Remove requirement for resolving host when outbound proxy in use

2013-11-27 Thread Joshua Colp
returned to normal. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] [Code Review] 2963: chan_pjsip: Extend redirect handling support

2013-11-27 Thread Joshua Colp
that they work as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3007: ARI: Snoop tests

2013-11-27 Thread Joshua Colp
PRE-CREATION /asterisk/trunk/tests/rest_api/channels/snoop_spy/channel_spy.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3007/diff/ Testing --- Ran tests, they passed. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-27 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3036: res_pjsip_transport_websocket: Fix crash with security events and improve implementation

2013-11-28 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3036/diff/ Testing --- Connected using JsSIP, confirmed no crash and that traffic is sent out the proper connection. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3036: res_pjsip_transport_websocket: Fix crash with security events and improve implementation

2013-11-28 Thread Joshua Colp
is sent out the proper connection. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3036: res_pjsip_transport_websocket: Fix crash with security events and improve implementation

2013-12-01 Thread Joshua Colp
and that traffic is sent out the proper connection. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] SIP request

2013-12-01 Thread Joshua Colp
the new PJSIP based modules DO provide various APIs to allow you to do exactly this. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Joshua Colp
here since it is scoped, unless I'm crazy. branches/12/res/res_pjsip_messaging.c https://reviewboard.asterisk.org/r/2944/#comment19687 You could make this error a bit more ... warm. ;) - Joshua Colp On Dec. 3, 2013, 8:12 p.m., Kevin Harwell wrote

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-05 Thread Joshua Colp
As this is now changed by a task in an async manner this is no longer safe, check needs to go into the task. - Joshua Colp On Dec. 4, 2013, 6:32 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-05 Thread Joshua Colp
://reviewboard.asterisk.org/r/3035/#comment19693 Unable to turn endpoint configuration for '%s' into queryable information? I dunno :P - Joshua Colp On Nov. 28, 2013, 4:29 a.m., Matt Jordan wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3044: Switch PJSIP auth to use a vector

2013-12-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3044/#review10306 --- Ship it! Ship It! - Joshua Colp On Dec. 4, 2013, 10 p.m

[asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-05 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3046/diff/ Testing --- Ran fax tests, confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

[asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-05 Thread Joshua Colp
/pjsip.conf PRE-CREATION /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3048/diff/ Testing --- Ran tests with framehook patch, all passed. Looked at logs and confirmed happy. Thanks, Joshua

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-05 Thread Joshua Colp
On Dec. 5, 2013, 12:56 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_messaging.c, lines 155-156 https://reviewboard.asterisk.org/r/2944/diff/3/?file=48992#file48992line155 I don't like this. Falling back to the default outbound endpoint if the specified one could

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-05 Thread Joshua Colp
as advertised, but my comment about uncharted territory remains. - Joshua Colp On Dec. 5, 2013, 6:14 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3042

[asterisk-dev] [Code Review] 3054: ARI: Add call forwarding events and automatically follow new channel

2013-12-06 Thread Joshua Colp
forwarding was also received over the ARI WebSocket. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

2013-12-07 Thread Joshua Colp
/res_pjsip.c 403425 /branches/12/include/asterisk/res_pjsip.h 403425 Diff: https://reviewboard.asterisk.org/r/3022/diff/ Testing --- Set the option, confirmed it was used. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-08 Thread Joshua Colp
--- Ran fax tests, confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-12-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10336 --- Ship it! Ship It! - Joshua Colp On Nov. 26, 2013, 5:07 p.m

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-10 Thread Joshua Colp
. 9, 2013, 1:27 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046/ --- (Updated Dec. 9, 2013, 1:27 a.m

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-10 Thread Joshua Colp
already returned a frame that was in the next slot and/or interpolated a frame. Maybe only certain framehooks should be called again if a frame they previously passed on is transformed. Joshua Colp wrote: I don't think you can really group that into certain types of frames, it's really up

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10349 --- Ship it! Ship It! - Joshua Colp On Dec. 10, 2013, 2:34 a.m

Re: [asterisk-dev] [Code Review] 3039: Add manager event for presence state changes

2013-12-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3039/#review10350 --- Ship it! Ship It! - Joshua Colp On Dec. 5, 2013, 9:30 p.m

Re: [asterisk-dev] Fwd: [svn-commits] jrose: trunk r403588 - in /trunk: ./ channels/chan_pjsip.c

2013-12-10 Thread Joshua Colp
with a modified version of the patch, but assume that the session object has to be protected as well. I think pending some other miracle or delaying the fixup not being as bad as we all think it is... that'll be the solution. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-10 Thread Joshua Colp
should keep performance and penalties in mind. - Joshua Colp On Dec. 9, 2013, 9:51 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-10 Thread Joshua Colp
. - Joshua Colp On Dec. 8, 2013, 10:29 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057

Re: [asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-11 Thread Joshua Colp
--- Ran tests with framehook patch, all passed. Looked at logs and confirmed happy. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2013-12-11 Thread Joshua Colp
for the lifetime of tdata (and since it wouldn't it would need to be documented as such). - Joshua Colp On Dec. 5, 2013, 7:06 p.m., opticron wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

[asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-12 Thread Joshua Colp
, ran tests, all work as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-13 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3046/diff/ Testing --- Ran fax tests, confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3054: ARI: Add call forwarding events and automatically follow new channel

2013-12-14 Thread Joshua Colp
. Confirmed that further channel events from the newly created channel as a result of the call forwarding was also received over the ARI WebSocket. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

2013-12-14 Thread Joshua Colp
/res_pjsip/location.c 403425 /branches/12/res/res_pjsip.c 403425 /branches/12/include/asterisk/res_pjsip.h 403425 Diff: https://reviewboard.asterisk.org/r/3022/diff/ Testing --- Set the option, confirmed it was used. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3068: ARI: provide a default format capability to channels that are created

2013-12-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3068/#review10422 --- Ship it! Ship It! - Joshua Colp On Dec. 12, 2013, 5:55 p.m

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-17 Thread Joshua Colp
Diff: https://reviewboard.asterisk.org/r/3067/diff/ Testing --- Placed calls, ran tests, all work as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046/#review10434 --- Ship it! Ship It! - Joshua Colp On Dec. 13, 2013, 4:28 p.m

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-17 Thread Joshua Colp
the hook that has produced the frame. Diffs - /branches/12/main/framehook.c 403747 Diff: https://reviewboard.asterisk.org/r/3046/diff/ Testing --- Ran fax tests, confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-17 Thread Joshua Colp
Diff: https://reviewboard.asterisk.org/r/3067/diff/ Testing --- Placed calls, ran tests, all work as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
there. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10442 --- On Dec. 17, 2013, 11:20 p.m., Joshua Colp

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Joshua Colp
: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 12, 2013, 9:59 p.m.) Review request for Asterisk Developers, Joshua

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10449 --- Ship it! - Joshua Colp On Dec. 12, 2013, 6:03 p.m., Matt

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
404134 Diff: https://reviewboard.asterisk.org/r/3067/diff/ Testing --- Placed calls, ran tests, all work as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread Joshua Colp
On Dec. 19, 2013, 3:10 p.m., opticron wrote: Ship It! Matt Jordan wrote: Well, hold on. Don't Ship It! just yet. :-) The fact that this isn't called in Asterisk 1.8 doesn't mean it shouldn't be called - it just means someone, at some point in time, fixed the glitch. If

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-19 Thread Joshua Colp
://reviewboard.asterisk.org/r/3061/#comment19930 See my previous finding about this. - Joshua Colp On Dec. 19, 2013, 6:49 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061

Re: [asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-23 Thread Joshua Colp
://reviewboard.asterisk.org/r/3048/diff/ Testing --- Ran tests with framehook patch, all passed. Looked at logs and confirmed happy. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3092: http: Properly reject requests with Transfer-Encoding set

2013-12-24 Thread Joshua Colp
/3092/#comment19946 Might as well go and make this a generic function to get the value of a header for potential future usage. /branches/12/main/http.c https://reviewboard.asterisk.org/r/3092/#comment19947 This is incorrect. - Joshua Colp On Dec. 23, 2013, 11:09 p.m., David Lee wrote

Re: [asterisk-dev] [Code Review] 3092: http: Properly reject requests with Transfer-Encoding set

2013-12-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3092/#review10493 --- Ship it! Ship It! - Joshua Colp On Dec. 24, 2013, 3:39 p.m

Re: [asterisk-dev] chan_pjsip + ZRTP

2013-12-28 Thread Joshua Colp
Kristijan Vrban wrote: Hi, great to see pjsip in asterisk. And since pjsip has support for zrtp, should be manageable to get zrtp also working in chan_pjsip? ZRTP is available for pjmedia, which is the RTP layer. This is not used in Asterisk at this time. Cheers, -- Joshua Colp Digium

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3093/#review10512 --- On Dec. 25, 2013, 2:53 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-03 Thread Joshua Colp
to an extension from a device that uses dialog-info+xml. Confirmed NOTIFY messages going out contain the expected content. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

[asterisk-dev] Asterisk Media Performance

2014-01-06 Thread Joshua Colp
it only once. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] Asterisk Media Performance

2014-01-06 Thread Joshua Colp
are just FUD. Just something to think about. By responding to your email I can confirm that I have thought about it at least briefly. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-06 Thread Joshua Colp
configurations. 1. Two transports each bound to specific interfaces 2. One transport bound to 0.0.0.0 Confirmed that the correct IP address for each interface went into the message. Some additional testing by others would be nice. Thanks, Joshua Colp

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
. For testing our implementation, indeed. More is always better. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] ARI leaking memory?

2014-01-09 Thread Joshua Colp
for bringing this up! This wasn't a known reported bug but I've tracked down what is happening and filed an issue so now it has magically become one. ;) You can track progress here: https://issues.asterisk.org/jira/browse/ASTERISK-23128 Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-09 Thread Joshua Colp
, remove path_dup, and get rid of your own generic string hdr creation. /trunk/res/res_pjsip_path.c https://reviewboard.asterisk.org/r/3050/#comment19982 My same question applies here. - Joshua Colp On Jan. 6, 2014, 9:52 p.m., opticron wrote

Re: [asterisk-dev] [Code Review] 3113: PJSIP: Print unknown instead of a UUID for artificial PJSIP endpoints' account IDs in security events

2014-01-09 Thread Joshua Colp
. - Joshua Colp On Jan. 9, 2014, 3:57 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3113

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Joshua Colp
the message). - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10540 --- On Jan. 6, 2014, 8:06 p.m., Joshua Colp wrote

[asterisk-dev] [Code Review] 3119: res_ari: Fix memory leaks.

2014-01-09 Thread Joshua Colp
. Stopped, confirmed output showed no leaks in ARI. I also ran with MALLOC_DEBUG enabled and did a memory show summary. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] ARI leaking memory?

2014-01-09 Thread Joshua Colp
! A follow-up on this: I've now got a code review up at https://reviewboard.asterisk.org/r/3119/ which fixes the memory leaks I identified. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com

[asterisk-dev] [Code Review] 3120: res_ari: Provide transfer messages and enable transfers

2014-01-12 Thread Joshua Colp
405018 /branches/12/res/ari/ari_model_validators.h 405018 /branches/12/main/stasis_bridges.c 405018 Diff: https://reviewboard.asterisk.org/r/3120/diff/ Testing --- Did various transfers, looked at messages, profited. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3119: res_ari: Fix memory leaks.

2014-01-12 Thread Joshua Colp
--- Ran under valgrind and invoked some ARI operations which cover the various fixed cases. Stopped, confirmed output showed no leaks in ARI. I also ran with MALLOC_DEBUG enabled and did a memory show summary. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2014-01-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/#review10576 --- Ship it! Ship It! - Joshua Colp On Jan. 9, 2014, 5:34 p.m

Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

2014-01-13 Thread Joshua Colp
it. - Joshua Colp On Jan. 13, 2014, 6:33 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124

Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

2014-01-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/#review10579 --- Ship it! Ship It! - Joshua Colp On Jan. 13, 2014, 8:48 p.m

Re: [asterisk-dev] [Code Review] 3123: chan_pjsip: initial device state on endpoints is INVALID

2014-01-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3123/#review10594 --- Ship it! Ship It! - Joshua Colp On Jan. 13, 2014, 6:12 p.m

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-15 Thread Joshua Colp
to an extension from a device that uses dialog-info+xml. Confirmed NOTIFY messages going out contain the expected content. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] Asterisk Media Performance

2014-01-15 Thread Joshua Colp
/AST/Media+Format+Rewrite -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided

  1   2   3   4   5   6   7   8   9   10   >