Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/#review12901 --- Ship it! Ship It! - Joshua Colp On July 24, 2014, 3:58 p.m

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-29 Thread Joshua Colp
modifications. Thoughts? - Joshua Colp On July 25, 2014, 2:20 p.m., rnewton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-07-29 Thread Joshua Colp
-CREATION Diff: https://reviewboard.asterisk.org/r/3780/diff/ Testing --- Set up two Asterisk instances, configured both sides to publish to eachother, made calls and manipulated voicemail. Watched PUBLISH messages go between them and state change. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

2014-07-29 Thread Joshua Colp
sscanf this. - Joshua Colp On July 25, 2014, 2:47 p.m., Michael Young wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3856

Re: [asterisk-dev] [Code Review] 3833: Allow sending voicemail to multiple email addresses

2014-07-29 Thread Joshua Colp
this review or the commit you won't know it's possible. - Joshua Colp On July 21, 2014, 9:54 p.m., Jason Parker wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3833

Re: [asterisk-dev] [Code Review] 3810: res_hep_rtcp: Add module that sends RTCP information to a Homer Server

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3810/#review12908 --- Ship it! Ship It! - Joshua Colp On July 27, 2014, 3:39 p.m

[asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-07-30 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-07-31 Thread Joshua Colp
-CREATION Diff: https://reviewboard.asterisk.org/r/3780/diff/ Testing --- Set up two Asterisk instances, configured both sides to publish to eachother, made calls and manipulated voicemail. Watched PUBLISH messages go between them and state change. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-03 Thread Joshua Colp
, it passes. Sabotaged test, it fails. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-03 Thread Joshua Colp
them and state change. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-03 Thread Joshua Colp
Olle E. Johansson wrote: On 31 Jul 2014, at 17:28, Joshua Colp reviewbo...@asterisk.org mailto:reviewbo...@asterisk.org wrote: This adds two PJSIP modules which add outbound PUBLISH support and an 'asterisk' event type. I don't think it's a good idea to mix different events in one event

Re: [asterisk-dev] Read dtmf after ast_bridge_call

2014-08-03 Thread Joshua Colp
digits before execute ast_bridge_call. I made something wrong but I don't know :-) thank to help me Have you waited for frames on the channel using something like ast_waitfor? If you try to read when nothing is available on the channel you will see the message above. Cheers, -- Joshua Colp Digium

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-08-03 Thread Joshua Colp
so we can get a consensus on the exact behavior that should occur here. I realize that this solves the problem for you but I want to make sure everyone is on the same page and in agreement for the resulting behavior. - Joshua Colp On July 30, 2014, 11:19 p.m., Corey Farrell wrote

Re: [asterisk-dev] Read dtmf after ast_bridge_call

2014-08-04 Thread Joshua Colp
it will unbridge/return when it receives DTMF on the respective channel you want. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] Read dtmf after ast_bridge_call

2014-08-04 Thread Joshua Colp
simultaneously, even with locking internally. It won't work as you expect/want as only a single thread can service a channel. You would essentially end up with two threads fighting over the frames, with some going to one thread and some going to the other. -- Joshua Colp Digium, Inc. | Senior Software

Re: [asterisk-dev] [Code Review] 3870: alembic: Adjust sippeers, queue_members, and voicemail_messages tables.

2014-08-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3870/#review12980 --- Ship it! Ship It! - Joshua Colp On Aug. 4, 2014, 9:39 p.m

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread Joshua Colp
and 12-12 that makes it so we need to remove the newly added ones? - Joshua Colp On Aug. 4, 2014, 10:47 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3889

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread Joshua Colp
On Aug. 5, 2014, 1:03 p.m., Joshua Colp wrote: Can you elaborate on what actually happens here between 11-12 and 12-12 that makes it so we need to remove the newly added ones? rmudgett wrote: The format compatibility bits need to remain frozen to new codecs because chan_iax2

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Joshua Colp
/#review12996 --- On Aug. 3, 2014, 10:58 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Joshua Colp
, it passes. Sabotaged test, it fails. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-05 Thread Joshua Colp
-CREATION Diff: https://reviewboard.asterisk.org/r/3780/diff/ Testing --- Set up two Asterisk instances, configured both sides to publish to eachother, made calls and manipulated voicemail. Watched PUBLISH messages go between them and state change. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3780/#review13027 --- On Aug. 5, 2014, 5:37 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-06 Thread Joshua Colp
-CREATION Diff: https://reviewboard.asterisk.org/r/3780/diff/ Testing --- Set up two Asterisk instances, configured both sides to publish to eachother, made calls and manipulated voicemail. Watched PUBLISH messages go between them and state change. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-07 Thread Joshua Colp
5316 Diff: https://reviewboard.asterisk.org/r/3869/diff/ Testing --- Executed test, it passes. Sabotaged test, it fails. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-07 Thread Joshua Colp
PUBLISH messages go between them and state change. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 3914: res_http_websocket: Fix bug where query parameters are not present in client request

2014-08-15 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3914/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3914: res_http_websocket: Fix bug where query parameters are not present in client request

2014-08-17 Thread Joshua Colp
. This change ensures they are present in the resulting HTTP GET request. Diffs - /branches/13/res/res_http_websocket.c 421123 Diff: https://reviewboard.asterisk.org/r/3914/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
://reviewboard.asterisk.org/r/3917/#comment23547 Add a comment explaining why this is being done. - Joshua Colp On Aug. 15, 2014, 3:53 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

2014-08-18 Thread Joshua Colp
://reviewboard.asterisk.org/r/3856/#comment23548 strcpy with a comment that it's safe is fine here - Joshua Colp On Aug. 6, 2014, 6:38 p.m., Michael Young wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3893: fromdomainport used even if not set

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3893/#review13097 --- Ship it! This applies to 1.8+ - Joshua Colp On Aug. 7

Re: [asterisk-dev] [Code Review] 3907: ARI: Fix implicit answer of channel when playback is initiated on unanswered channels

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3907/#review13098 --- Ship it! Ship It! - Joshua Colp On Aug. 13, 2014, 10:04

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
On Aug. 18, 2014, 2:24 p.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Jonathan Rose wrote: Honestly, I don't believe

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
://reviewboard.asterisk.org/r/3917/#comment23552 a new PBX - Joshua Colp On Aug. 18, 2014, 3:27 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917

Re: [asterisk-dev] [Code Review] 3913: chan_pjsip: Attended transfer does not update connected line name.

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3913/#review13104 --- Ship it! Ship It! - Joshua Colp On Aug. 15, 2014, 1:55 a.m

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
expected to be invoked at #3 - do you think this is possible at all? - Joshua Colp On Aug. 24, 2014, 3:52 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: My only concern with this is that we somehow have code which expected to be invoked at #3 - do you think this is possible at all? It may also be useful to document your flow discovery above within the code somewhere for future reference

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: My only concern with this is that we somehow have code which expected to be invoked at #3 - do you think this is possible at all? Joshua Colp wrote: It may also be useful to document your flow discovery above within the code

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
, and also run through all the PJSIP tests. Do that and this is good to go. - Joshua Colp On Aug. 24, 2014, 11:37 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
On Aug. 25, 2014, 1:12 p.m., Joshua Colp wrote: Review your doxygen because I think you are repeating yourself, and also run through all the PJSIP tests. Do that and this is good to go. Mark Michelson wrote: I don't see the doxygen problem. One states that on transaction state

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-27 Thread Joshua Colp
/res_pjsip_session.h https://reviewboard.asterisk.org/r/3930/#comment23664 Document the default value for this. - Joshua Colp On Aug. 26, 2014, 10:44 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] PJSIP insecure fonctionality

2014-08-29 Thread Joshua Colp
=identify section. In the future for this type of help the asterisk-users mailing list would be more appropriate. [1] https://wiki.asterisk.org/wiki/display/AST/Configuring+res_pjsip Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US

Re: [asterisk-dev] 12.5.0 cache_entry_compute_hash/app_meeme crash

2014-08-30 Thread Joshua Colp
this or something similar in asterisk-13.0.0-beta1. This issue was reported here[1] and has been fixed in SVN. The fix will be in the next releases. Cheers, [1] https://issues.asterisk.org/jira/browse/ASTERISK-24234 -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW

[asterisk-dev] [Code Review] 3981: chan_rtp: Add unicast RTP support to chan_multicast_rtp.

2014-09-07 Thread Joshua Colp
and sent it to a Playback. Confirmed that RTP was sent to the provided IP address/port with the given format. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

[asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-07 Thread Joshua Colp
/asterisk/rtp_engine.h 422835 Diff: https://reviewboard.asterisk.org/r/3982/diff/ Testing --- Sabotaged the code so the only candidates I sent were of the relay type. Confirmed bidirectional media flow using the TURN relay. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3981: chan_rtp: Add unicast RTP support to chan_multicast_rtp.

2014-09-07 Thread Joshua Colp
Johann Steinwendtner wrote: On 2014-09-07 17:07, Joshua Colp wrote: This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3981/ Testing Originated a call to a UnicastRTP channel and sent it to a Playback. Confirmed that RTP was sent to the provided

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-10 Thread Joshua Colp
/res_rtp_asterisk.c 422898 /branches/13/include/asterisk/rtp_engine.h 422898 Diff: https://reviewboard.asterisk.org/r/3982/diff/ Testing --- Sabotaged the code so the only candidates I sent were of the relay type. Confirmed bidirectional media flow using the TURN relay. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Joshua Colp
/3985/#comment23754 It's still possible for this to occur under extreme circumstances (out of memory). - Joshua Colp On Sept. 9, 2014, 5:04 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3986: config: bug: fix truncation of included config files on permissions error

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3986/#review13270 --- Ship it! Ship It! - Joshua Colp On Sept. 10, 2014, 1:34

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
Magic number. Define this somewhere. /branches/13/res/res_pjsip/pjsip_options.c https://reviewboard.asterisk.org/r/3954/#comment23758 Same may or may not be true thing applies from above. - Joshua Colp On Sept. 4, 2014, 11:41 p.m., rmudgett wrote

Re: [asterisk-dev] [Code Review] 3978: Testsuite: Test for RLS large NOTIFY requests

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3978/#review13272 --- Ship it! Ship It! - Joshua Colp On Sept. 4, 2014, 8:11 p.m

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3985/#review13273 --- - Joshua Colp On Sept. 9, 2014, 5:04 p.m., Jonathan Rose

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
On Sept. 10, 2014, 11:51 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c, lines 2478-2480 https://reviewboard.asterisk.org/r/3954/diff/3/?file=67221#file67221line2478 I'm hesitant to say that this will always be true. I fear that due to the asynchronous nature of things

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/3988/#comment23764 Test this and make sure that the PJSIP digest authentication doesn't freak. :P - Joshua Colp On Sept. 10, 2014, 5:53 p.m., Sean Bright wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] SIPit 31

2014-09-11 Thread Joshua Colp
Olivier wrote: snip Resource List Subscriptions ? This is definitely something I've wanted to test but forgot to add it to the list. Now added! Thanks, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3985/#review13281 --- Ship it! Ship It! - Joshua Colp On Sept. 10, 2014, 9:31

Re: [asterisk-dev] [Code Review] 3987: Bridging: Fix bouncing native bridge

2014-09-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3987/#review13282 --- Ship it! Ship It! - Joshua Colp On Sept. 10, 2014, 3:56

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-11 Thread Joshua Colp
/r/3954/#comment23767 Looking at the pjproject code why wouldn't the following return values cover these cases for when the callback is not called: PJ_EINVAL PJ_EINVALIDOP PJ_ENOMEM Handling those as special would reduce the memory leak possibility. - Joshua Colp

Re: [asterisk-dev] [Code Review] 3981: chan_rtp: Add unicast RTP support to chan_multicast_rtp.

2014-09-12 Thread Joshua Colp
/chan_multicast_rtp.c 422835 Diff: https://reviewboard.asterisk.org/r/3981/diff/ Testing --- Originated a call to a UnicastRTP channel and sent it to a Playback. Confirmed that RTP was sent to the provided IP address/port with the given format. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-09-13 Thread Joshua Colp
://reviewboard.asterisk.org/r/2964/diff/ Testing --- Registered to an ITSP, placed an inbound call from them, confirmed matched using line parameter. Registered to a chan_sip instance, placed an inbound call from it, confirmed matched using line parameter. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-09-13 Thread Joshua Colp
Optimistic Off Success (Encrypted) Mandatory Optimistic On Success (Encrypted) Optional Optimistic Off Success (Encrypted) Optional Optimistic On Success (Encrypted) Thanks, Joshua Colp

Re: [asterisk-dev] udptl ports

2014-09-14 Thread Joshua Colp
it. The UDPTL and RTP stacks don't share sockets and the RTP side keeps the port open while UDPTL is going on so even if the UDPTL side wanted to use the same port it couldn't bind to it. Can you provide the trace of this with SDP and logging? -- Joshua Colp Digium, Inc. | Senior Software Developer 445

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-09-15 Thread Joshua Colp
, 2014, 12:25 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ --- (Updated Sept. 14, 2014, 12:25 a.m

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-16 Thread Joshua Colp
of the relay type. Confirmed bidirectional media flow using the TURN relay. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-18 Thread Joshua Colp
://reviewboard.asterisk.org/r/3999/#comment23811 Despite it not changing behavior I'd still use 20 here to match 12. - Joshua Colp On Sept. 16, 2014, 9:28 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/#review1 --- Ship it! Ship It! - Joshua Colp On Sept. 15, 2014, 7:27

Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3999/#review13337 --- Ship it! Ship It! - Joshua Colp On Sept. 16, 2014, 9:28

[asterisk-dev] [Code Review] 4008: res_pjsip_session: Add additional checks to prevent session refresh in unpossible states.

2014-09-19 Thread Joshua Colp
://reviewboard.asterisk.org/r/4008/diff/ Testing --- Modified the dialing API to change callerID at certain points (after call but before handling responses, after handling responses). Confirmed that new code correctly defers sending COLP updates. Thanks, Joshua Colp

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
=trunk, itsp, phone, etc. Lower level blocks remain the same and additional logic on top can be added to handle this sort of thing. I look forward to seeing what others think! Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
that people are familiar with they're fine. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
George Joseph wrote: snip Or separate objects from a config file perspective but implemented in pjsip_configuration with endpoint. Completely separate. Mixing the two defeats the purpose of having a clear boundary. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
George Joseph wrote: On Sat, Sep 20, 2014 at 1:10 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: George Joseph wrote: snip Or separate objects from a config file perspective but implemented in pjsip_configuration with endpoint

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
, identify, outbound registrations, etc existing but that fact is an underlying detail they don't worry or care about. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
George Joseph wrote: On Sat, Sep 20, 2014 at 2:20 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: George Joseph wrote: snip I was thinking that we probably don't want to create hard coded objects called trunk, user, etc. Instead let the user

Re: [asterisk-dev] Opinions Needed: PJSIP Outboud Registration with multiple server_uris

2014-09-20 Thread Joshua Colp
= notverysecret context = trusted disallow = all allow = g722 mailboxes = 1000 Are you OK with a separate config file? It would make manipulating it easier since there'd be no duplicate section names. Yes. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW

Re: [asterisk-dev] beta2 compile failure

2014-09-22 Thread Joshua Colp
have an old install as well as a new? -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13378 --- Ship it! Ship It! - Joshua Colp On Sept. 19, 2014, 10:02

Re: [asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

2014-09-23 Thread Joshua Colp
://reviewboard.asterisk.org/r/4016/#comment23871 This is actually incorrect. p-outboundproxy may point to a statically allocated outbound proxy. To ensure both cases are met use ref_proxy to set it to NULL. This will unref if it should and otherwise not unref. - Joshua Colp On Sept. 22, 2014, 8:30 p.m

Re: [asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4016/#review13380 --- Ship it! Ship It! - Joshua Colp On Sept. 23, 2014, 12:18

Re: [asterisk-dev] beta2 compile failure

2014-09-23 Thread Joshua Colp
Paul Albrecht wrote: On Sep 22, 2014, at 3:47 PM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: Paul Albrecht wrote: Asterisk 13 beta2 compile fails: . . . [CC] chan_pjsip.c - chan_pjsip.o [CC] pjsip/dialplan_functions.c - pjsip/dialplan_functions.o [LD] chan_pjsip.o pjsip

Re: [asterisk-dev] [Code Review] 4008: res_pjsip_session: Add additional checks to prevent session refresh in unpossible states.

2014-09-27 Thread Joshua Colp
handling responses). Confirmed that new code correctly defers sending COLP updates. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread Joshua Colp
://reviewboard.asterisk.org/r/4032/#comment23885 What will this do for UDP transport? For those the transport should be empty. - Joshua Colp On Sept. 29, 2014, 7:25 p.m., opticron wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread Joshua Colp
On Sept. 29, 2014, 7:47 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_nat.c, line 49 https://reviewboard.asterisk.org/r/4032/diff/1/?file=67680#file67680line49 What will this do for UDP transport? For those the transport should be empty. opticron wrote: udp is also

Re: [asterisk-dev] PJSIP Configuration Wizard (Was: Opinions Needed: PJSIP Outboud Registration with multiple server_uris)

2014-10-07 Thread Joshua Colp
I'm down with proposal #2 but I have to ask: would this work with realtime, and how? -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-07 Thread Joshua Colp
no candidates for RTCP? It would still crash. - Joshua Colp On Oct. 1, 2014, 3:43 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039

[asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-08 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-08 Thread Joshua Colp
On Oct. 7, 2014, 6:45 p.m., Joshua Colp wrote: I don't think this goes far enough. What if I receive no candidates for RTCP? It would still crash. Kevin Harwell wrote: I tested for this. The only time it crashes is when there are no RTP candidates in the list

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13475 --- Ship it! Ship It! - Joshua Colp On Oct. 9, 2014, 3:44 p.m

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-09 Thread Joshua Colp
--- Performed calls and ran tests. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-10-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/2964/diff/ Testing --- Registered to an ITSP, placed an inbound call from them, confirmed matched using line parameter. Registered to a chan_sip instance, placed an inbound call from it, confirmed matched using line parameter. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-10-10 Thread Joshua Colp
(Encrypted) Optional Optimistic On Success (Encrypted) Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

2014-10-10 Thread Joshua Colp
/bridge_native_rtp.c 424850 Diff: https://reviewboard.asterisk.org/r/4057/diff/ Testing --- Performed calls and ran tests. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] License issue

2014-10-13 Thread Joshua Colp
then the person had a valid license agreement at the time it was uploaded. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

[asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
/asterisk/res_pjsip.h 425395 Diff: https://reviewboard.asterisk.org/r/4073/diff/ Testing --- Sent outgoing calls with various users (numbers, number+letters, letters) and confirmed that user=phone was set when it should be. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
/r/4073/#review13498 --- On Oct. 13, 2014, 4:54 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4073

Re: [asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

2014-10-13 Thread Joshua Colp
/diff/ Testing --- Sent outgoing calls with various users (numbers, number+letters, letters) and confirmed that user=phone was set when it should be. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-13 Thread Joshua Colp
! - Joshua Colp On Oct. 13, 2014, 5:32 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/ --- (Updated

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-14 Thread Joshua Colp
://reviewboard.asterisk.org/r/3997/#comment24038 No, AST_LIST_FIRST and AST_LIST_LAST would return the same thing since it's a linked list containing one channel. - Joshua Colp On Oct. 13, 2014, 5:32 p.m., Matt Jordan wrote

[asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Joshua Colp
the message went out. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-15 Thread Joshua Colp
://reviewboard.asterisk.org/r/3997/#comment24060 glue1 will always exist so this can just become an else - Joshua Colp On Oct. 14, 2014, 7:11 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13531 --- Ship it! Otherwise g2g - Joshua Colp On Oct. 14, 2014, 7

<    1   2   3   4   5   6   7   8   9   10   >