Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-17 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- (Updated July 17, 2014, 2:02 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-15 Thread Sean Bright
On July 14, 2014, 8:37 p.m., Sean Bright wrote: Looks fine to me. Should probably throw libmxml-dev into contrib/scripts/install_prereq while you're at it. This also might be a good opportunity to dump mxml altogether as we already use libxml2 in asterisk itself. One less

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12633 --- Ship it! Looks fine to me. Should probably throw libmxml-dev

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 3:37 p.m., Sean Bright wrote: Looks fine to me. Should probably throw libmxml-dev into contrib/scripts/install_prereq while you're at it. This also might be a good opportunity to dump mxml altogether as we already use libxml2 in asterisk itself. One less

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- (Updated July 14, 2014, 4:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12636 --- Shouldn't this add to CHANGES? I being this up mostly due to

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Shaun Ruffell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12637 --- a) awesome. b) If at all possible I believe moving the code

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 4:30 p.m., Corey Farrell wrote: Shouldn't this add to CHANGES? I being this up mostly due to the new required external dependency. Yes, it should, and the new dependency should be in the UPGRADE notes. - Matt

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 4:52 p.m., Shaun Ruffell wrote: a) awesome. b) If at all possible I believe moving the code and modifying it should be two separate steps. This will make it easier, when generating an official git repo, to graft the menuselect history onto the git repository, in

[asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- Review request for Asterisk Developers. Repository: Asterisk