Mark Michelson has posted comments on this change.
Change subject: res_pjsip: Add external PJSIP resolver implementation using
core DNS API.
..
Patch Set 1:
(3 comments)
Mark Michelson has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/86
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/85
To unsubscribe, visit
Mark Michelson has submitted this change and it was merged.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore files with a .gz
Mark Michelson has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/82
To unsubscribe, visit
David M. Lee has uploaded a new patch set (#2).
Change subject: For OS X, change -Xlinker to -Wl,
..
For OS X, change -Xlinker to -Wl,
For [reasons unknown][], newer versions of GCC, when compiling the
Homebrew formula for
Mark Michelson has submitted this change and it was merged.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the asterisk repo.
NB: You can
Mark Michelson has submitted this change and it was merged.
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all build results.
Mark Michelson has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/84
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/83
To unsubscribe, visit
Mark Michelson has submitted this change and it was merged.
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all build results.
David M. Lee has uploaded a new change for review.
https://gerrit.asterisk.org/88
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left
David M. Lee has uploaded a new change for review.
https://gerrit.asterisk.org/90
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left
David M. Lee has uploaded a new change for review.
https://gerrit.asterisk.org/89
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left
I have created a wiki page [1] with a test plan for DNS NAPTR/SRV for
PJSIP. Please take a moment to have a look at the page and provide any
feedback (on this list, not on the page please) about the test plan. Are
there any test cases that I left out that should be covered? Are there
any test
David M. Lee has uploaded a new change for review.
https://gerrit.asterisk.org/87
Change subject: For OS X, change -Xlinker to -Wl,
..
For OS X, change -Xlinker to -Wl,
For [reasons unknown][], newer versions of GCC, when
Mark Michelson has submitted this change and it was merged.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the asterisk repo.
NB: You can
Mark Michelson has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/81
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: mapmantis: Remove dependency on digium_jira
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/68
To unsubscribe, visit
Hello Jared K. Smith,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/69
to look at the new patch set (#2).
Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST
client
Jared K. Smith has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/88
To unsubscribe, visit
Jared K. Smith has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/89
To unsubscribe, visit
Mark Michelson has submitted this change and it was merged.
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left behind that was causing
Mark Michelson has submitted this change and it was merged.
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left behind that was causing
Mark Michelson has submitted this change and it was merged.
Change subject: Fixing extconf compile
..
Fixing extconf compile
During the mass code deletion for clang support, a stray backslash was
left behind that was causing
Mark Michelson has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/90
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/89
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/88
To unsubscribe, visit
Mark Michelson has submitted this change and it was merged.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore files with a .gz
Mark Michelson has posted comments on this change.
Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST
client
..
Patch Set 2:
(2 comments)
https://gerrit.asterisk.org/#/c/69/2/digium_jira.py
File
Jared K. Smith has posted comments on this change.
Change subject: Fixing extconf compile
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/90
To unsubscribe, visit
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/91
Change subject: python/asterisk/version: Update version handling for Git
migration
..
python/asterisk/version: Update version handling for Git
Matt Jordan has submitted this change and it was merged.
Change subject: PEP8 fixes
..
PEP8 fixes
* Add tox.ini for pep8 to set max-line-length=90
* Resolve most PEP8 findings in runtests.py and lib.
Change-Id:
George Joseph has uploaded a new patch set (#2).
Change subject: pjsip/options: Add tests for qualify_timeout and
max_initial_qualify_time
..
pjsip/options: Add tests for qualify_timeout and max_initial_qualify_time
Renamed
Matt Jordan has uploaded a new patch set (#2).
Change subject: python/asterisk/version: Update version handling for Git
migration
..
python/asterisk/version: Update version handling for Git migration
This patch updates the
Matt Jordan has uploaded a new patch set (#3).
Change subject: python/asterisk/version: Update version handling for Git
migration
..
python/asterisk/version: Update version handling for Git migration
This patch updates the
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/92
Change subject: pjsip/options: Add tests for qualify_timeout and
max_initial_qualify_time
..
pjsip/options: Add tests for qualify_timeout
Matt Jordan has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/40
To unsubscribe, visit https://gerrit.asterisk.org/settings
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4612/
---
Review request for Asterisk Developers.
Bugs:
Matt Jordan has posted comments on this change.
Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint'
variable
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/41
To
Matt Jordan has submitted this change and it was merged.
Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint'
variable
..
tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable
The
George Joseph has uploaded a new patch set (#2).
Change subject: pjsip_options: Add qualify_timeout processing and eventing
..
pjsip_options: Add qualify_timeout processing and eventing
This is the second follow-on to
On Mon, Apr 13, 2015 at 5:15 PM, George Joseph george.jos...@fairview5.com
wrote:
On Mon, Apr 13, 2015 at 5:02 PM, Matthew Jordan mjor...@digium.com
wrote:
On Mon, Apr 13, 2015 at 5:52 PM, Matthew Jordan mjor...@digium.com
wrote:
On Sun, Apr 12, 2015 at 1:57 AM, George Joseph
On April 13, 2015, 2:41 a.m., Corey Farrell wrote:
So I think this looks pretty good. Next steps:
* We've migrated to git. Take a look at [1] for information on how to use
gerrit to post a git review. Don't worry you won't be facing the full
review again, we've already dealt with
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4612/#review15193
---
The Asterisk project has migrated to Gerrit. Reviews on Review
On Mon, Apr 13, 2015 at 5:52 PM, Matthew Jordan mjor...@digium.com wrote:
On Sun, Apr 12, 2015 at 1:57 AM, George Joseph
george.jos...@fairview5.com wrote:
On Sat, Apr 11, 2015 at 10:15 PM, Matthew Jordan mjor...@digium.com wrote:
snip
Further updates after Day 2 (3?):
1. Due to popular
On Mon, Apr 13, 2015 at 5:02 PM, Matthew Jordan mjor...@digium.com wrote:
On Mon, Apr 13, 2015 at 5:52 PM, Matthew Jordan mjor...@digium.com
wrote:
On Sun, Apr 12, 2015 at 1:57 AM, George Joseph
george.jos...@fairview5.com wrote:
On Sat, Apr 11, 2015 at 10:15 PM, Matthew Jordan
On Sun, Apr 12, 2015 at 7:04 PM, George Joseph
george.jos...@fairview5.com wrote:
menuextender: Allows the creation of additional menu items. I'd suggest
using this for adding links to various wiki pages, git.asterisk.org, etc.
reviewers-by-blame: This might be a little too much but it
On Sun, Apr 12, 2015 at 1:57 AM, George Joseph
george.jos...@fairview5.com wrote:
On Sat, Apr 11, 2015 at 10:15 PM, Matthew Jordan mjor...@digium.com wrote:
I'm wondering if we can do this...
You submit a review on the lowest target branch, using 13 as an example.
The review gets reviewed
On April 13, 2015, 7:41 p.m., Corey Farrell wrote:
So I think this looks pretty good. Next steps:
* We've migrated to git. Take a look at [1] for information on how to use
gerrit to post a git review. Don't worry you won't be facing the full
review again, we've already dealt with
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3603/
---
(Updated April 14, 2015, 12:12 a.m.)
Status
--
This change has been
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/81
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/84
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/85
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/82
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the
Matt Jordan has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/82
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/81
To unsubscribe, visit
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/86
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/83
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/85
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/86
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/84
To unsubscribe, visit
Corey Farrell has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/86
To unsubscribe, visit
Jared K. Smith has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
Simple, straighforward patch
--
To view, visit https://gerrit.asterisk.org/85
To
George Joseph has uploaded a new change for review.
https://gerrit.asterisk.org/83
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all
Jared K. Smith has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
Simple, straightforward patch
--
To view, visit https://gerrit.asterisk.org/86
To
Jared K. Smith has posted comments on this change.
Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST
client
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/69
To
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 5: Code-Review+1
Used grep, found a few tests that were still using parameters with the new
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 2: Code-Review-1
(1 comment)
Missed one spot where we should conditionally return Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/#review15190
---
So I think this looks pretty good. Next steps:
* We've
Hello George Joseph,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/58
to look at the new patch set (#5).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
git
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2:
(2 comments)
The PJSIP tests no longer fail. I have a full run of the testsuite going now,
so far no issues.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4586/
---
(Updated April 13, 2015, 7:59 a.m.)
Status
--
This change has been
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/74
Change subject: AMI: Fix improper handling of lines that are exactly 1025 bytes
long.
..
AMI: Fix improper handling of lines that are exactly
Matt Jordan has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 2:
(1 comment)
https://gerrit.asterisk.org/#/c/60/2/main/asterisk.c
File main/asterisk.c:
Line 539:
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/73
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Optional API: Fix handling of sources that are both
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/60
to look at the new patch set (#3).
Change subject: git migration: Remove support for file versions
..
git migration:
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/72
Change subject: res_monitor: Add dependency on func_periodic_hook.
..
res_monitor: Add dependency on func_periodic_hook.
OPTIONAL_API has
Matt Jordan has posted comments on this change.
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/73
To
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4590/
---
(Updated April 13, 2015, 7:37 a.m.)
Status
--
This change has been
Corey Farrell has posted comments on this change.
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Patch Set 1:
This was previously posted for review at
Matt Jordan has posted comments on this change.
Change subject: res_monitor: Add dependency on func_periodic_hook.
..
Patch Set 1: Code-Review+1
Unfortunate, but apparently necessary.
--
To view, visit
Joshua Colp has posted comments on this change.
Change subject: Optional API: Fix handling of sources that are both provider
and user.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/73
Matt Jordan has posted comments on this change.
Change subject: AMI: Fix improper handling of lines that are exactly 1025 bytes
long.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/74
To
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/60
To unsubscribe, visit
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/61
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4441/
---
(Updated April 13, 2015, 1:30 p.m.)
Review request for Asterisk
Joshua Colp has uploaded a new patch set (#2).
Change subject: pjsip: Add basic resolver tests covering A/, SRV, and NAPTR.
..
pjsip: Add basic resolver tests covering A/, SRV, and NAPTR.
These tests cover the
On April 10, 2015, 5:45 p.m., rmudgett wrote:
trunk/main/tcptls.c, lines 841-858
https://reviewboard.asterisk.org/r/4441/diff/2/?file=73366#file73366line841
This is effectively the same code duplicated for ecc and dsa. Make a
subroutine that takes the variants as parameters:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4441/
---
(Updated April 13, 2015, 1:28 p.m.)
Review request for Asterisk
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2: -Code-Review
It appears that it's not this change that is broken, it's my computer.
--
To view, visit
Matt Jordan has submitted this change and it was merged.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
build_tools/make_version: Update version parsing for Git migration
External
Matt Jordan has posted comments on this change.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/77
To
Matt Jordan has submitted this change and it was merged.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
build_tools/make_version: Update version parsing for Git migration
External
Matt Jordan has posted comments on this change.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/79
To
Matt Jordan has posted comments on this change.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/78
To
Matt Jordan has submitted this change and it was merged.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
build_tools/make_version: Update version parsing for Git migration
External
Matt Jordan has posted comments on this change.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit https://gerrit.asterisk.org/80
To
Matt Jordan has posted comments on this change.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/76
To
Matt Jordan has submitted this change and it was merged.
Change subject: build_tools/make_version: Update version parsing for Git
migration
..
build_tools/make_version: Update version parsing for Git migration
External
1 - 100 of 122 matches
Mail list logo
