[asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-04-28 Thread Diederik de Groot
/trunk/configure.ac 413043 /trunk/Makefile 413043 Diff: https://reviewboard.asterisk.org/r/3488/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-04-28 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-05-15 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/#review11849 --- On May 15, 2014, 10:57 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-05-15 Thread Diederik de Groot
/Makefile 413043 Diff: https://reviewboard.asterisk.org/r/3488/diff/ Testing (updated) --- Just a proof of concept, to show how asterisk could be made clang compatible again. Thanks, Diederik de Groot -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2014-07-03 Thread Diederik de Groot
--- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2014-07-03 Thread Diederik de Groot
: -I/usr/include/libxml2 -g3 Diffs - /trunk/build_tools/mkpkgconfig 417800 Diff: https://reviewboard.asterisk.org/r/3707/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2014-07-03 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3707/#review12462 --- On July 3, 2014, 2:12 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2014-07-03 Thread Diederik de Groot
have been: Cflags: -I/usr/include/libxml2 -g3 Diffs (updated) - /trunk/build_tools/mkpkgconfig 417800 Diff: https://reviewboard.asterisk.org/r/3707/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2015-01-14 Thread Diederik de Groot
contains: Cflags: -I/usr/include/libxml2-g3 Which should have been: Cflags: -I/usr/include/libxml2 -g3 Diffs - /trunk/build_tools/mkpkgconfig 417800 Diff: https://reviewboard.asterisk.org/r/3707/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
try to compile. If the support doesn't exist it's just not going to work and having configure succeed is just putting off the inevitable failure. Matt Jordan wrote: AC_MSG_ERROR it is. Diederik de Groot wrote: There is another little issue, in my initial configure.ac patch. I

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
/ --- (Updated Feb. 20, 2015, 5:09 a.m.) Review request for Asterisk Developers and Diederik de Groot. Bugs: ASTERISK-20850 https://issues.asterisk.org/jira/browse/ASTERISK-20850 Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Diederik de Groot
On Jan. 26, 2015, 6:36 a.m., Diederik de Groot wrote: /branches/11/include/asterisk/inline_api.h, lines 44-51 https://reviewboard.asterisk.org/r/4370/diff/1/?file=71056#file71056line44 You might want to check out: #define forceinline __inline__ __attribute__((always_inline

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-01-25 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/#review14277 --- On May 15, 2014, 10:57 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-01-25 Thread Diederik de Groot
/3488/#review14277 --- On May 15, 2014, 10:57 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-01-25 Thread Diederik de Groot
. 25, 2015, 11:26 p.m.) Review request for Asterisk Developers and Diederik de Groot. Bugs: ASTERISK-20850 https://issues.asterisk.org/jira/browse/ASTERISK-20850 Repository: Asterisk Description --- This is a continuation of the patch put up for review on r3488

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-12 Thread Diederik de Groot
On March 12, 2015, 2:27 a.m., Diederik de Groot wrote: Ship It! Diederik de Groot wrote: Have you made a plan for addressing the warnings generated by clang's static analysis ? There are quite a number of them, some of which seem to be quite helpfull in pointing out some sore

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-03-12 Thread Diederik de Groot
Diff: https://reviewboard.asterisk.org/r/3488/diff/ Testing --- Just a proof of concept, to show how asterisk could be made clang compatible again. Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14655 --- Ship it! Ship It! - Diederik de Groot On Feb. 21, 2015, 3

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
: https://reviewboard.asterisk.org/r/4370/ --- (Updated Feb. 21, 2015, 3:35 a.m.) Review request for Asterisk Developers and Diederik de Groot. Bugs: ASTERISK-20850 https://issues.asterisk.org/jira/browse/ASTERISK-20850

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
On March 12, 2015, 2:27 a.m., Diederik de Groot wrote: Ship It! Have you made a plan for addressing the warnings generated by clang's static analysis ? There are quite a number of them, some of which seem to be quite helpfull in pointing out some sore points, not sure if they uncover any

[asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
- /branches/13/include/asterisk/stringfields.h 433444 /branches/13/channels/iax2/parser.c 433444 /branches/13/channels/chan_iax2.c 433444 /branches/13/apps/app_agent_pool.c 433444 Diff: https://reviewboard.asterisk.org/r/4554/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
On March 29, 2015, 1:49 a.m., Diederik de Groot wrote: The fixes for unused-value to chan_iax2, to compile smoothly should be seen as a showcase that this can be off potential benefit. Would have been nice if ao2_ref(..., -1) would have behaved in the same way, so that ao2_ref(..., -1

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
Attachments ASTCFLAGS=-Wno-error=unused-value make | grep [-W -B1 -A2 https://reviewboard.asterisk.org/media/uploaded/files/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4554/#comment25570 function is being called with (peer = 0x0), which showed up after messing with the code above. Either this is a real issue, or caused by fiddling with the code. - Diederik de Groot On March 29, 2015, 1:44 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4535: clang compiler warning: -Wenum-conversion

2015-03-29 Thread Diederik de Groot
433444 /branches/13/channels/chan_pjsip.c 433444 Diff: https://reviewboard.asterisk.org/r/4535/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4525: clang compiler warning: -Wabsolute-value

2015-03-29 Thread Diederik de Groot
/branches/13/main/jitterbuf.c 433444 /branches/13/channels/sip/dialplan_functions.c 433444 /branches/13/channels/chan_iax2.c 433444 /branches/13/apps/app_queue.c 433444 Diff: https://reviewboard.asterisk.org/r/4525/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

2015-03-29 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4545: clang compiler warning: -Wunused-command-line-argument

2015-03-29 Thread Diederik de Groot
/ errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wunused-command-line-argument Diffs - /branches/13/Makefile.rules 433444 Diff: https://reviewboard.asterisk.org/r/4545/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

2015-03-29 Thread Diederik de Groot
. To reply, visit: https://reviewboard.asterisk.org/r/4530/#review14961 --- On March 30, 2015, 3:52 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4543/#comment25573 Added a simple script to contrib, to show how to perform a scan-build using clang/llvm-gcc which uses the extensive llvm static analyzer. An html report will be generated in the created scanbuild-output subdirectory - Diederik de Groot On March 29, 2015, 5:01

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
process - Diederik de Groot On March 29, 2015, 4:57 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
that where needed in chan_iax2.c and apps/app_agent_pool.c. Some others a less interesting, for example the SCHED_DEL fixes. Will wait for you guys to respond, before continuing. Will needs some more people to finish the '-Wunused-value' task, would be way to much for one person. - Diederik de Groot

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-30 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4551: clang compiler warning: -Wnon-literal-null-conversion

2015-03-30 Thread Diederik de Groot
warning:-Wnon-literal-null-conversion Diffs (updated) - /branches/13/res/stasis_recording/stored.c 433444 /branches/13/channels/chan_skinny.c 433444 /branches/13/channels/chan_sip.c 433444 Diff: https://reviewboard.asterisk.org/r/4551/diff/ Testing --- Thanks, Diederik de

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15013 --- On April 1, 2015, 4:52 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
, no callers currently care about the return value. You changed this because clang had a problem in test_semi1() in tests/test_strings.c. There is a better way. Diederik de Groot wrote: Actually as i tried to mention in the description i changed this according to the tests being

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-31 Thread Diederik de Groot
/4554/#review14999 --- On March 29, 2015, 1:44 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4555/#review15000 --- On April 1, 2015, 3:30 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15003 --- On March 30, 2015, 1:08 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
433444 /branches/13/main/astobj2_hash.c 433444 /branches/13/include/asterisk/vector.h 433444 /branches/13/include/asterisk/linkedlists.h 433444 /branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- On April 1, 2015, 3:59 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4526/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-26 Thread Diederik de Groot
(_USER, -1) instead. Which would not have generated this unused warning, and after compilation they would both result in the same code (inline). - Diederik de Groot On March 26, 2015, 6:47 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-26 Thread Diederik de Groot
compiler warning:-Wunused-function Diffs - /branches/13/main/dsp.c 433444 /branches/13/main/config.c 433444 /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4527/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-26 Thread Diederik de Groot
- /branches/13/main/dsp.c 433444 /branches/13/main/config.c 433444 /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4527/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

2015-03-26 Thread Diederik de Groot
Diffs - /branches/13/pbx/pbx_config.c 433444 Diff: https://reviewboard.asterisk.org/r/4529/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-26 Thread Diederik de Groot
. - Diederik de Groot On March 26, 2015, 6:32 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

2015-03-27 Thread Diederik de Groot
. Since escaped is a char *, I'd go ahead and strdup it here, and free it before the loop continues. Diederik de Groot wrote: Ooh damn, you are right, missed that one. Maybe someone can come up with another way where this tmp_escaped is not necessary at all. There was a less

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-27 Thread Diederik de Groot
/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

2015-03-27 Thread Diederik de Groot
warning:-Wno-sometimes-uninitialized Diffs (updated) - /branches/13/pbx/pbx_config.c 433444 Diff: https://reviewboard.asterisk.org/r/4529/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

2015-03-27 Thread Diederik de Groot
--- On March 26, 2015, 7:12 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4530

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:52 p.m., Diederik de Groot wrote: /branches/13/channels/chan_iax2.c, lines 2026-2032 https://reviewboard.asterisk.org/r/4527/diff/1/?file=72928#file72928line2026 user_ref function not being used, may/might actually indicate a refcount issue. Because

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

2015-03-27 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/#review14874 --- On March 26, 2015, 7:03 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

Re: [asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

2015-03-27 Thread Diederik de Groot
/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4537/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 11:13 p.m., Diederik de Groot wrote: /branches/13/channels/pjsip/dialplan_functions.c, line 869 https://reviewboard.asterisk.org/r/4533/diff/1/?file=72956#file72956line869 len is of type size_t, which is unsigned. It will not be able to hold a value 0 Matt

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-27 Thread Diederik de Groot
warning:-Wunused-function Diffs (updated) - /branches/13/main/dsp.c 433444 /branches/13/main/config.c 433470 /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4527/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

2015-03-27 Thread Diederik de Groot
Diffs - /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4537/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

2015-03-27 Thread Diederik de Groot
- /branches/13/main/framehook.c 433444 Diff: https://reviewboard.asterisk.org/r/4540/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 4525: clang compiler warning: -Wabsolute-value

2015-03-27 Thread Diederik de Groot
433444 /branches/13/channels/chan_iax2.c 433444 /branches/13/apps/app_queue.c 433444 Diff: https://reviewboard.asterisk.org/r/4525/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

2015-03-27 Thread Diederik de Groot
) and use a different value for it. Not sure which method would be preferred, leaving that decision to the code owner. Diffs - /branches/13/res/res_pjsip/config_transport.c 433444 Diff: https://reviewboard.asterisk.org/r/4539/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

2015-03-27 Thread Diederik de Groot
Diffs - /branches/13/res/res_pjsip/config_transport.c 433444 Diff: https://reviewboard.asterisk.org/r/4539/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

2015-03-27 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4540/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-27 Thread Diederik de Groot
Diffs - /branches/13/res/res_smdi.c 433444 /branches/13/channels/chan_pjsip.c 433444 /branches/13/apps/app_queue.c 433444 /branches/13/apps/app_minivm.c 433444 Diff: https://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-27 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: /branches/13/funcs/func_env.c, line 728 https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728 Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command

[asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-27 Thread Diederik de Groot
/ Updating variable from inside a _block Diffs - /branches/13/include/asterisk/utils.h 433444 Diff: https://reviewboard.asterisk.org/r/4543/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/#review14978 --- On March 31, 2015, 6:05 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
to help avoid. It appears that the warning is intended to get rid of extra parentheses where they are unnecessary. The problem is that I don't see anything wrong with having them there, especially in macro definitions. Diederik de Groot wrote: Ok you know that to prevent an unintendet

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
to help avoid. It appears that the warning is intended to get rid of extra parentheses where they are unnecessary. The problem is that I don't see anything wrong with having them there, especially in macro definitions. Diederik de Groot wrote: Ok you know that to prevent an unintendet

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4550/#review14987 --- On March 29, 2015, 7:14 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-29 Thread Diederik de Groot
Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/vector.h 433444 /branches/13/include/asterisk/linkedlists.h 433444 /branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
blows up/crashes when running ast_alloca(0) (ie:__builtin_alloca(0)) possible solutions: - report issue to clang / llvm - add check to ast_alloca and enforce return value on error - or make sure we don't call ast_alloca with a size of 0 ever. - Diederik de Groot On March 29

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
https://reviewboard.asterisk.org/r/4555/#comment25576 Woops. Debugging remnant, should not have been here. - Diederik de Groot On March 29, 2015, 7:24 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4539/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4531: clang compiler warning: -Wparentheses-equality

2015-03-28 Thread Diederik de Groot
/branches/13/res/Makefile 433444 /branches/13/main/channel.c 433444 /branches/13/apps/app_voicemail.c 433444 /branches/13/apps/app_dictate.c 433444 Diff: https://reviewboard.asterisk.org/r/4531/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-28 Thread Diederik de Groot
/chan_pjsip.c 433444 /branches/13/cel/cel_sqlite3_custom.c 433444 /branches/13/apps/app_queue.c 433444 Diff: https://reviewboard.asterisk.org/r/4526/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
On March 28, 2015, 1:28 p.m., Diederik de Groot wrote: /branches/13/configure.ac, lines 1179-1183 https://reviewboard.asterisk.org/r/4546/diff/2/?file=73163#file73163line1179 Test is not working as i hoped yet. Tests inside configure don't seem to get optimized to the same level

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
/autoconfig.h.in - Diederik de Groot On March 28, 2015, 3:01 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4546

  1   2   >