Diff: https://reviewboard.asterisk.org/r/3600/diff/
Testing
---
Ran tests, mangled the expectations to create failures for each test.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://ww
5094
Diff: https://reviewboard.asterisk.org/r/3600/diff/
Testing
---
Ran tests, mangled the expectations to create failures for each test.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://ww
/asterisk/trunk/lib/python/asterisk/sipp.py 5094
Diff: https://reviewboard.asterisk.org/r/3600/diff/
Testing
---
Ran tests, mangled the expectations to create failures for each test.
Thanks,
Jonathan Rose
mixed tabs and
spaces in here that need to be cleaned up per Asterisk coding guidelines
(https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines)
- Jonathan Rose
On May 22, 2011, 1:59 a.m., astmiv wrote:
>
> ---
> T
what it is still
relevant given the changes to call parking that went into 12.
- Jonathan Rose
On June 16, 2010, 5:43 a.m., Paul Belanger wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On June 17, 2014, 10:44 a.m., Jonathan Rose wrote:
> > This review should probably be closed. There is absolutely no what it is
> > still relevant given the changes to call parking that went into 12.
s/no what/no wa
> On June 17, 2014, 10:44 a.m., Jonathan Rose wrote:
> > This review should probably be closed. There is absolutely no what it is
> > still relevant given the changes to call parking that went into 12.
>
> Jonathan Rose wrote:
> s/no what/no way/
That said, this
> On June 17, 2014, 10:37 a.m., Jonathan Rose wrote:
> > You have a lot of instances of trailing whitespace and some of mixed tabs
> > and spaces in here that need to be cleaned up per Asterisk coding
> > guidelines (https://wiki.asterisk.org/wiki/display/AST/Coding+Guide
> On June 17, 2014, 10:37 a.m., Jonathan Rose wrote:
> > You have a lot of instances of trailing whitespace and some of mixed tabs
> > and spaces in here that need to be cleaned up per Asterisk coding
> > guidelines (https://wiki.asterisk.org/wiki/display/AST/Coding+Guid
anager.c 416556
Diff: https://reviewboard.asterisk.org/r/3626/diff/
Testing
---
Made sure Asterisk doesn't crash on load, made sure the manager commands are
registered and have the appropriate documentation.
Th
extension with/without '/' in extension and made sure the rest of
the field was used as a CID value and that it worked the same as the CLI
command equivalent
Tested remove extension with/without priority
Tested remove extension with/without '/' in extension and made sure that
iff: https://reviewboard.asterisk.org/r/3651/diff/
Testing
---
Checked that the AMI command does logger rotation in the same manner as the
logger rotate CLI command.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provid
g/r/3650/#comment22256>
caught the accidentally capitalized N in ApplicatioNData while writing the
description. Ignore please.
- Jonathan Rose
On June 19, 2014, 11:41 a.m., Jonathan Rose wrote:
>
> ---
> This is an automati
nerated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12200
---
On June 19, 2014, 11:41 a.m., Jonathan Rose wrote:
>
> ---
> This is an automatic
n and made sure that if CID
was included that it deleted the CID including extension.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
nd this is
derived from doesn't support them either.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12200
---
On June 19, 2014, 12:33 p.m., Jonathan Rose wrote:
>
-
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12211
---
On June 19, 2014, 12:33 p.m., Jonathan Rose wrote:
>
>
ecution of many of the test AMI commands to guarantee that if above
failures occurred that the test would fail
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev maili
On June 19, 2014, 12:33 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3650/
> ---
add extension with/without '/' in extension and made sure the rest of
the field was used as a CID value and that it worked the same as the CLI
command equivalent
Tested remove extension with/without priority
Tested remove extension with/without '/' in extension and made sure
LI command.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
ands are
registered and have the appropriate documentation.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update op
hanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
https://reviewboard.asterisk.org/r/3666/diff/
>
>
> Testing
> ---
>
> Created some simple transmit/receive fax sessions by originating calls
> to/from faxsend/faxreceive extensions and then ran each of these commands.
> Did the above with and without action_id
> On June 23, 2014, 4:36 p.m., Matt Jordan wrote:
> > /trunk/res/res_fax.c, line 4084
> > <https://reviewboard.asterisk.org/r/3666/diff/1/?file=60383#file60383line4084>
> >
> > This call can fail. If it does, emit an error and bail appropriately.
>
>
send/faxreceive extensions and then ran each of these commands.
Did the above with and without action_id included to make sure it would be
reproduced across events and responses.
Checked the output of documentation for events and actions for sanity.
Thanks,
created (that is, answered)"
That isn't going to be the case for all originates by design. When attempting
to originate to an extension that has been deleted, the call isn't meant to be
answered.
- Jonathan
-----
with and without all parameters to make sure all error
messages could be observed as expected and that the commands did what I
expected them to do.
Reviewed documentation for AMI commands within Asterisk
Thanks,
Jonathan Rose
--
__
results if result[0])
> > test_object.set_passed(passed)
> >
> > deferds = []
> > for channel in self.originates:
> > deferred = self.ami.originate(...)
> > deferred.addErrback(self.handle_originate_failure)
> >
races for every AMI action I defined in the config.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12339
---
reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12339
---
On June 20, 2014, 1:42 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically g
ensions.conf
PRE-CREATION
/asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that
63
Diff: https://reviewboard.asterisk.org/r/3681/diff/
Testing
---
Used each AMI command with and without all parameters to make sure all error
messages could be observed as expected and that the commands did what I
expected them to do.
Reviewed documentation for AMI comm
luded to make sure it would be
reproduced across events and responses.
Checked the output of documentation for events and actions for sanity.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://ww
-
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3681/#review12353
---
On June 26, 2014, 2:50 p.m., Jonathan Rose wrote:
>
>
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the test would fail
Thanks,
Jonathan Rose
--
_
-- B
ed remove extension with/without priority
Tested remove extension with/without '/' in extension and made sure that if CID
was included that it deleted the CID including extension.
Thanks,
Jonathan Rose
--
_
-- B
RE-CREATION
/asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3684/#review12355
---
Ship it!
Ship It!
- Jonathan Rose
On June 26, 2014, 2:32
I just did it.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12356
---
On June 26, 2014, 4:1
RE-CREATION
/asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12362
---
s/ends Asterisk/ends the test/
- Jonathan Rose
On June 26
hanging up as a
general rule and its role in the test is over.
Changed to:
"""Responds to Hangup manager events and stops the test once each originate
action receives a corresponding hangup."""
- Jonathan Rose
On June
> On June 26, 2014, 5:33 p.m., Jonathan Rose wrote:
> > /asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py, line
> > 129
> > <https://reviewboard.asterisk.org/r/3660/diff/4/?file=61095#file61095line129>
> >
> > Bleh, this is inaccu
-
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12367
---
On June 26, 2014, 4:12 p.m., Jonathan Rose wrote:
>
>
th/without priority
Tested remove extension with/without '/' in extension and made sure that if CID
was included that it deleted the CID including extension.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Pr
message and the ActionID will be with it.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12418
---
On June 26, 2014, 5:30 p.m., Jonathan Rose wrote:
>
> -
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12418
---
On June 26, 2014, 5:30 p.m., Jonathan Rose wrote:
>
> ---
;/' in extension and made sure that if CID
was included that it deleted the CID including extension.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing li
ed documentation for AMI commands within Asterisk
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://li
mail. To reply, visit:
https://reviewboard.asterisk.org/r/3666/#review12360
---
On June 26, 2014, 2:54 p.m., Jonathan Rose wrote:
>
> ---
> This is an automa
essions by originating calls to/from
faxsend/faxreceive extensions and then ran each of these commands.
Did the above with and without action_id included to make sure it would be
reproduced across events and responses.
Checked the output of documentation for events and actions for sanity.
Thanks,
Jon
ension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the test would fail
Thanks,
Jonathan Rose
--
eritance of the same type
(previously unavailable with the AUDIOHOOK_INHERIT function)
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or upda
org/r/3721/#comment22774>
Unnecessary remnant of something I tried. Removed.
- Jonathan Rose
On July 7, 2014, 5:21 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
lly generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3721/#review12527
---
On July 7, 2014, 5:21 p.m., Jonathan Rose wrote:
>
> ---
> This is an aut
)
for instance.
Diffs
-
/branches/1.8/funcs/func_uri.c 418366
Diff: https://reviewboard.asterisk.org/r/3745/diff/
Testing
---
Checked to make sure the warning doesn't get generated anymore. It doesn't.
diff/
Testing
---
Checked to make sure the warning doesn't get generated anymore. It doesn't.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev maili
warning doesn't get generated anymore. It doesn't.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options vis
all from one IAX softphone on my laptop to an
IAX softphone on my desktop. Received audio going both ways. Codec
preferences didn't have an effect unfortunately while they did in twelve.
Instead, all audio chosen was GSM, presumably because it has the lowest for
prefs list, so it gets added back to the cap by the for
loop on the next pass.
I guess what I need is for another function to come along and remove
preferences from the order list if they aren't enabled by the formats bitfield.
- Jonathan Rose
On July 11, 2014, 3:01 p.m., Jonathan
/format_compatibility.c
<https://reviewboard.asterisk.org/r/3747/#comment22855>
didn't shift pref->framing[y] back with order.
- Jonathan Rose
On July 11, 2014, 3:01 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatical
didn't have an effect unfortunately while they did in twelve.
Instead, all audio chosen was GSM, presumably because it has the lowest format
value. I'm still looking into that.
Thanks,
Jonathan Rose
--
_
-- Bandwidth
/format_compatibility.c
<https://reviewboard.asterisk.org/r/3747/#comment22857>
should be y = x... not y = 0.
- Jonathan Rose
On July 11, 2014, 3:59 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail.
-------
On July 11, 2014, 3:59 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3747/
> ---
TP engine and the solution was to
> > figure out why the format is NULL. Should the format ever reasonably be
> > NULL here?
>
> Jonathan Rose wrote:
> I'm inclined to say this is reasonable because when the format was NULL
> when entering this function, it was usually an
TP engine and the solution was to
> > figure out why the format is NULL. Should the format ever reasonably be
> > NULL here?
>
> Jonathan Rose wrote:
> I'm inclined to say this is reasonable because when the format was NULL
> when entering this function, it was usually an
all audio chosen was GSM, presumably because it has the lowest format
value. I'm still looking into that.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mail
reviewboard.asterisk.org/r/3747/#review12591
-------
On July 11, 2014, 5:57 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3747/
> --
nstead, all audio chosen was GSM, presumably because it has the lowest format
value. I'm still looking into that.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
ated anymore. It doesn't.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
nstead, all audio chosen was GSM, presumably because it has the lowest format
value. I'm still looking into that.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
ffect unfortunately while they did in twelve.
Instead, all audio chosen was GSM, presumably because it has the lowest format
value. I'm still looking into that.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation P
o make sure the warning doesn't get generated anymore. It doesn't.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or upda
ble transcoding costs.
deskbox -> lappy
It was GSM for both endpoints in all cases because deskbox favors gsm and lappy
supports it.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digit
y list
for choosing the best codec based on audio quality which I don't believe we
have anymore, so I dropped the option. If we need to reimplement this for some
reason, I can look into that.
- Jonathan Rose
On July 15, 2014, 3:58 p.m., Jon
<https://reviewboard.asterisk.org/r/3800/#comment22943>
Ref leak here when the format type isn't audio.
- Jonathan Rose
On July 15, 2014, 3:58 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically genera
ppy was ulaw. Codec chosen for deskbox was alaw,
again presumably because of favorable transcoding costs.
deskbox -> lappy
It was GSM for both endpoints in all cases because deskbox favors gsm and lappy
supports it.
Thanks,
Jonatha
change.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3721/#review12527
---
On July 7, 2014, 5:21 p.m., Jonathan Rose wrote:
>
> -
ohooks and multiple framehooks for
inheritance. Audiohooks were tested for multiple inheritance of the same type
(previously unavailable with the AUDIOHOOK_INHERIT function)
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocat
eanup
Heh, right. Fixed.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3800/#review12679
---
On July 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3732/#review12690
---
Ship it!
Ship It!
- Jonathan Rose
On July 10, 2014, 8:35
behavior when
migrating to trunk:
https://reviewboard.asterisk.org/r/3721/
- Jonathan Rose
On June 13, 2014, 1:48 p.m., Corey Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviewboard.asterisk.org/r/3731/#comment22969>
The condition is redundant to ao2_cleanup
- Jonathan Rose
On July 10, 2014, 8:35 a.m., opticron wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
<https://reviewboard.asterisk.org/r/3733/#comment22970>
The opposite of a 'relative' path is actually called an 'absolute' path
rather than a 'defined' path.
- Jonathan Rose
On July 9, 2014
e)
To get rid of the string concatenation operations.
This SO post leaves me thinking the format method is preferable to the
string concatenation method:
http://stackoverflow.com/questions/376461/string-concatenation-vs-string-substitution-in-python
- Jonathan Rose
On July 9, 2014
> On July 16, 2014, 1:01 p.m., Jonathan Rose wrote:
> > /asterisk/trunk/lib/python/asterisk/pluggable_modules.py, lines 398-401
> > <https://reviewboard.asterisk.org/r/3733/diff/2/?file=62566#file62566line398>
> >
> >
> > http://stackoverflow.com/ques
erisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
---
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the
,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
418783
Diff: https://reviewboard.asterisk.org/r/3817/diff/
Testing
---
Used existing endpoint notification and compared it to similar notifies done
against URIs. The outgoing messages looked the same as far as the details I
was concerned with went.
Th
e in
> > this review is appropriate.
Slightly cumbersome, but OK.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3721/#review12717
---
ou would
expect it to. I also tested multiple audiohooks and multiple framehooks for
inheritance. Audiohooks were tested for multiple inheritance of the same type
(previously unavailable with the AUDIOHOOK_INHERIT func
<https://reviewboard.asterisk.org/r/3816/#comment23039>
debug instead of notice log?
/trunk/main/bridge_basic.c
<https://reviewboard.asterisk.org/r/3816/#comment23037>
debug instead of notice log?
- Jonathan Rose
On July 17, 2014, 1:01 p.m., Ma
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3721/#review12729
---
On July 17, 2014, 3:10 p.m., Jonathan Rose wrote:
>
> --
SIPP scenario so that Romaine was just called Roman
(who has ever heard of Roman lettuce?) and received the expected failure.
Thanks,
Jonathan Rose
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
ast
these commands.
Did the above with and without action_id included to make sure it would be
reproduced across events and responses.
Checked the output of documentation for events and actions for sanity.
Thanks,
Jonathan
uld
expect it to. I also tested multiple audiohooks and multiple framehooks for
inheritance. Audiohooks were tested for multiple inheritance of the same type
(previously unavailable with the AUDIOHOOK_INHERIT function)
ed e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/#review12744
-------
On July 17, 2014, 2:27 p.m., Jonathan Rose wrote:
>
> ---
> This is an a
lines 1195-1203
> > <https://reviewboard.asterisk.org/r/3817/diff/2/?file=64713#file64713line1195>
> >
> > This function isn't necessary. When PJSIP is passed a URI string, PJSIP
> > will perform URI validation for us and return an error if a badly-formed
> > UR
/res_pjsip.h 418868
Diff: https://reviewboard.asterisk.org/r/3817/diff/
Testing
---
Used existing endpoint notification and compared it to similar notifies done
against URIs. The outgoing messages looked the same as far as the details I
was concerned with went.
Thanks,
Jonathan Rose
1 - 100 of 630 matches
Mail list logo
