Re: [PATCH] net: ath10k: santity check for ep connectivity

2021-01-18 Thread Kalle Valo
sb.c. > > Signed-off-by: Zekun Shen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d18ba9f1351c ath10k: sanitity check for ep connectivity -- https://patchwork.kernel.org/project/linux-wireless/patch/20200622022055.16028-1-bruceshe...@gmail.com/ https

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

2020-12-23 Thread Kalle Valo
Abhishek Kumar writes: > On Tue, Dec 15, 2020 at 9:24 AM Youghandhar Chintala > wrote: >> >> From: Rakesh Pillai >> >> Currently after the hardware restart triggered from the driver, >> the station interface connection remains intact, since a disconnect >> trigger is not sent to userspace. This

Re: [PATCH] ath: add support for special 0x0 regulatory domain

2020-12-23 Thread Kalle Valo
Brian Norris writes: > On Mon, Dec 21, 2020 at 7:43 PM Wen Gong wrote: >> >> On 2020-12-21 05:06, Sustek Goran wrote: >> > Hi, on my ath10k Chipset, >> > QCA9984(https://compex.com.sg/shop/wifi-module/802-11ac-wave-2/wle1216v5-20-2/) >> > afetr this patch i can not longer to initialize my card.

Re: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2020-12-21 Thread Kalle Valo
Brian Norris writes: > Hi, > > On Sun, Dec 20, 2020 at 5:53 PM Miaoqing Pan wrote: >> >> Failed to transmit wmi management frames: >> >> [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full >> [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet, >> dropping: -28 >>

Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery

2020-12-21 Thread Kalle Valo
Rakesh Pillai writes: > This patch series includes some fixes when the device > is in recovery mode, i.e. when the firmware goes down. > > - Pausing TX queues when FW goes down > - Removed unwanted/extra error logging in pkt TX path > - Skipping wait for FW response for delete cmds > - Handling t

Re: [PATCH v2] ath10k: Per-chain rssi should sum the secondary channels

2020-12-21 Thread Kalle Valo
gree...@candelatech.com wrote: > From: Ben Greear > > This makes per-chain RSSI be more consistent between HT20, HT40, HT80. > Instead of doing precise log math for adding dbm, I did a rough estimate, > it seems to work good enough. > > Tested on ath10k-ct 9984 firmware. > > Signed-off-by: Ben

Re: [PATCH][master/pending] ath10k: assign new interfaces type to parent type

2020-12-21 Thread Kalle Valo
Isaac Hermida writes: > This is needed to have the AP mode working for SDIO. > Tested with lastest master/pending code on a QCA6564 chip with firmware > firmware-sdio-6.bin_WLAN.RMH.4.4.1-00011-QCARMSWP-2 > > Signed-off-by: Isaac Hermida > --- > drivers/net/wireless/ath/ath10k/mac.c | 3 +++ >

[PATCH] ath10k: remove unused struct ath10k::dev_type

2020-12-21 Thread Kalle Valo
It's unused so let's get rid of it. Compile tested only, no functional changes. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/co

Re: [PATCH] net: ath10k: santity check for ep connectivity

2020-12-21 Thread Kalle Valo
Zekun Shen writes: > Function ep_rx_complete is being called without NULL checking > in ath10k_htc_rx_completion_handler. Without such check, mal- > formed packet is able to cause jump to NULL. > > ep->service_id seems a good candidate for sanity check as it is > used in usb.c. > > Signed-off-by:

Re: [PATCH] ath10k:add support for multicast rate control

2020-12-21 Thread Kalle Valo
Pradeep Kumar Chitrapu wrote: > Issues wmi command to firmware when multicast rate change is received > with the new BSS_CHANGED_MCAST_RATE flag. > > Signed-off-by: Pradeep Kumar Chitrapu (Cleaning up my backlog, this is from 2018.) I don't understand the issue from commit log, please clarify

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-16 Thread Kalle Valo
ED, and then napi_synchronize will enter dead loop > becuase bit NAPI_STATE_SCHED is set by napi_disable. > > function of napi_synchronize > static inline void napi_synchronize(const struct napi_struct *n) > { > if (IS_ENABLED(CONFIG_SMP)) > while (test_bit(NAP

Re: [PATCH] ath10k: Fix error handling in case of CE pipe init failure

2020-12-16 Thread Kalle Valo
45af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990") > Signed-off-by: Rakesh Pillai > Reviewed-by: Brian Norris > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 31561e8557cd ath10k: Fix error handling in case of CE pipe init failure

Re: [PATCH v2] ath10k: Remove voltage regulator votes during wifi disable

2020-12-16 Thread Kalle Valo
wer on/off in SNOC targets, so that these voltage > regulator votes are there only when wlan is enabled. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git,

ath10k and ath11k lists added to lore.kernel.org

2020-12-15 Thread Kalle Valo
Hi, ath10k and ath11k list archives are now available from lore.kernel.org: https://lore.kernel.org/ath10k/ https://lore.kernel.org/ath11k/ They have full archives starting when lists were created (ath10k 2013 and ath11k 2019). So I recommend using lore archives over lists.infradead.org as infr

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-15 Thread Kalle Valo
Wen Gong writes: > On 2020-12-09 23:00, Ben Greear wrote: >> On 12/9/20 1:24 AM, Kalle Valo wrote: >>> Wen Gong writes: >>> >>>> On 2020-09-08 00:22, Kalle Valo wrote: >>>> >>>>> Just like with the recent firmware restart patch,

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-14 Thread Kalle Valo
Ben Greear writes: > On 12/9/20 1:24 AM, Kalle Valo wrote: >> Wen Gong writes: >> >>> On 2020-09-08 00:22, Kalle Valo wrote: >>> >>>> Just like with the recent firmware restart patch, isn't >>>> ar->napi_enabled >>

Re: [PATCH v6] ath10k: add atomic protection for device recovery

2020-12-11 Thread Kalle Valo
O WLAN.RMH.4.4.1-00049 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5dadbe4e3718 ath10k: add atomic protection for device recovery -- https://patchwork.kernel.org/project/linux-wireless/patch/010101746bead6a0-d5e97c66-dedd-4

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-11 Thread Kalle Valo
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 > Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > Signed-off-by: Abhishek Kumar > Reviewed-by: Douglas Anderson > Reviewed-by: Rake

Re: [PATCH wireless -next] wireless/ath10k: simplify the return expression of ath10k_ahb_chip_reset()

2020-12-10 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/ath/ath10k/ahb.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ahb.c > b/drivers/net/wireless/ath/ath10k/ahb.c

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Kalle Valo
Wen Gong writes: > On 2020-09-08 00:22, Kalle Valo wrote: > >> Just like with the recent firmware restart patch, isn't >> ar->napi_enabled >> racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? >> >> Or are we holdin

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Kalle Valo
Krishna Chaitanya writes: > On Fri, Aug 28, 2020 at 5:53 PM Wen Gong wrote: >> >> It happened "Kernel panic - not syncing: hung_task: blocked tasks" when >> test simulate crash and ifconfig down/rmmod meanwhile. (editing out hundreds of lines of unnecessary text, please edit your quotes) > LGT

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-08 Thread Kalle Valo
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 > Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > Signed-off-by: Abhishek Kumar > Reviewed-by: Douglas Anderson > Reviewed-by: Rakesh

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-12-07 Thread Kalle Valo
Bjorn Andersson writes: > On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > >> Hi Rob, Bjorn, Kalle, >> >> On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson >> wrote: >> > >> > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: >> > >> > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:

Re: [PATCH v2] ath10k: skip the wait for completion to recovery in shutdown path

2020-12-07 Thread Kalle Valo
Brian Norris writes: > On Thu, Nov 26, 2020 at 9:16 AM Youghandhar Chintala > wrote: >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device >> *pdev) >> >> reinit_compl

Re: [PATCH] ath10k: fix a check patch warning returnNonBoolInBooleanFunction of sdio.c

2020-12-07 Thread Kalle Valo
on] > return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW; > > Reported-by: kernel test robot > > Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7f881a721716 ath10k: fix a check pa

Re: [PATCH 1/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou ---

2020-12-07 Thread Kalle Valo
zhoulian...@126.com wrote: > From: lzhou The subject and commit log is badly formatted, see patchwork link below. But how is schedule_timeout_interruptible() better than msleep()? Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20201203033729.38208

Re: [PATCH net-next 2/2] ath10k: Constify static qmi structs

2020-12-02 Thread Kalle Valo
: Rikard Falkeborn > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ad37a46e8cb5 ath10k: Constify static qmi structs -- https://patchwork.kernel.org/project/linux-wireless/patch/20201122234031.33432-3-rikard.falkeb...@gmail.com/ https://wireless.wiki.ker

Re: [PATCH 1/2] ath10k: Fix an error handling path

2020-12-02 Thread Kalle Valo
Christophe JAILLET wrote: > If 'ath10k_usb_create()' fails, we should release some resources and report > an error instead of silently continuing. > > Fixes: 4db66499df91 ("ath10k: add initial USB support") > Signed-off-by: Christophe JAILLET > Signed-off

Re: [PATCH v3] ath10k: Fix the parsing error in service available event

2020-12-02 Thread Kalle Valo
Doug Anderson writes: > Hi, > > On Sun, Nov 15, 2020 at 8:35 PM Rakesh Pillai wrote: >> >> The wmi service available event has been >> extended to contain extra 128 bit for new services >> to be indicated by firmware. >> >> Currently the presence of any optional TLVs in >> the wmi service availa

Re: [PATCH v3] ath10k: Fix the parsing error in service available event

2020-12-02 Thread Kalle Valo
AN.HL.3.2.2-00720-QCAHLSWMTPL-1 > > Fixes: cea19a6ce8bf ("ath10k: add WMI_SERVICE_AVAILABLE_EVENT support") > Signed-off-by: Rakesh Pillai > Reviewed-by: Douglas Anderson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c7cee9c0f499

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-24 Thread Kalle Valo
Jakub Kicinski writes: > On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote: >> These are only used as input arguments to qmi_handle_init() which >> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them >> const to allow the compiler to put them in read-only memory. >> >>

Re: [PATCH] ath10k: add target IRAM recovery feature support

2020-11-23 Thread Kalle Valo
ing hif_memcpy. > > This IRAM recovery feature prevent target assert in case of > unexpected target IRAM corruptions. > > This patch also introduce a new feature flag 'iram-recovery' for > backward compatibility. > > Tested-on: QCA9888 10.4-3.9.0.2-00094 > >

Re: [PATCH 0/9] relay: cleanup and const callbacks, take 2

2020-11-23 Thread Kalle Valo
.nik...@intel.com > > > Cc: linux-bl...@vger.kernel.org > Cc: Jens Axboe > Cc: ath...@lists.infradead.org > Cc: ath10k@lists.infradead.org > Cc: Kalle Valo > Cc: linux-wirel...@vger.kernel.org > Cc: QCA ath9k Development > Cc: intel-...@lists.freedesktop.org

Re: [PATCH 3/6] ath10k: make relay callbacks const

2020-11-18 Thread Kalle Valo
Jani Nikula writes: > Now that relay_open() accepts const callbacks, make relay callbacks > const. > > Cc: Kalle Valo > Cc: ath10k@lists.infradead.org > Signed-off-by: Jani Nikula I assume this goes via some other tree: Acked-by: Kalle Valo -- https://patchwork.kernel

Re: drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool

2020-11-15 Thread Kalle Valo
+ ath10k list kernel test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 > commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add > firmware coredump support > compiler: nios2-lin

Re: [PATCH] ath10k: add option for chip-id based BDF selection

2020-11-10 Thread Kalle Valo
Abhishek Kumar writes: > Apologies for the delay, was busy so could not work on V2 . I have > started working on V2 patch. Will upload by today/tomorrow. Thanks, I'll then drop this v1. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers

Re: [PATCH v2] wireless: remove unneeded break

2020-11-07 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix Patch applied to wireless-drivers-next.git, thanks. 3287953b0399 wireless: remove unneeded break -- https://patchwork.kernel.org/project/linux-wireless/patch/2020102012

Re: [PATCH] ath10k: cancel rx worker in hif_stop for SDIO

2020-11-07 Thread Kalle Valo
IO will call napi_schedule, it > should have no napi_schedule before napi_synchronize, otherwise it > lead napi_synchronize wait untill napi_complete. > > Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to a

Re: [PATCH 2/2] ath10k: Don't iterate over not-sdata-in-driver interfaces.

2020-11-07 Thread Kalle Valo
-- > > Similar logic was tested for years in ath10k-ct driver and various firmware. > > Also tested with stock kernel plus this patch, with firmware > 10.2.4-1.0-00037 > > This test case was to bring up 5 vap on a radio and fake a firmware > crash. Make sure ap interfaces co

Re: [PATCH] ath10k: fix compilation warning

2020-11-07 Thread Kalle Valo
> Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Tamizh Chelvam > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b91626451178 ath10k: fix compilation warning -- https://patchwork.kernel.org/project/linux-wireles

Re: [PATCH] ath10k: cancel rx worker in hif_stop for SDIO

2020-11-05 Thread Kalle Valo
Wen Gong writes: > The rx worker of SDIO should be cancelled after disable interrupt, and > release rx sk_buff in queue, otherwise the rx worker maybe still run > after hif_stop. And it should be cancelled before napi_synchronize in > hif_stop, because the rx worker of SDIO will call napi_schedul

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-11-05 Thread Kalle Valo
Doug Anderson writes: >> static int ath10k_wmi_tlv_op_pull_svc_avail(struct ath10k *ar, >> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c >> b/drivers/net/wireless/ath/ath10k/wmi.c >> index 1fa7107..2e4b561 100644 >> --- a/drivers/net/wireless/ath/ath10k/wmi.c >> +++ b/drivers/net/wireless/

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-11-05 Thread Kalle Valo
Rakesh Pillai writes: > The wmi service available event has been > extended to contain extra 128 bit for new services > to be indicated by firmware. > > Currently the presence of any optional TLVs in > the wmi service available event leads to a parsing > error with the below error message: > ath1

Re: [PATCH] ath10k: Fix the parsing error in service available event

2020-11-05 Thread Kalle Valo
"Rakesh Pillai" writes: >> > diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c >> b/drivers/net/wireless/ath/ath10k/wmi-tlv.c >> > index 932266d..3b49e29 100644 >> > --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c >> > +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c >> > @@ -1404,9 +1404,12

Re: [PATCH] ath10k: add option for chip-id based BDF selection

2020-11-05 Thread Kalle Valo
Abhishek Kumar wrote: > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option looks as follows > board name 'bus=sn

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-11-05 Thread Kalle Valo
ine for clarity > > Addresses-Coverity: 1496984 ("Null pointer dereferences) > Suggested-by: Saeed Mahameed > Signed-off-by: Alex Dewar > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. dbeb101d28eb ath10k: sdio: remove redundant check in for loop -- h

Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.

2020-11-05 Thread Kalle Valo
Brian Norris writes: > + ath10k > > [ I realize I replied to the "wrong" RFC v1; I fell trap to Kalle's note: > > "When you submit a new version mark it as "v2". Otherwise people don't > know what's the latest version." ] > > On Tue, Nov 3, 2020 at 11:32 PM Carl Huang wrote: >> On 2020-11-04 10:

Re: ath10k-firmware: QCA4019 hw1.0: Add Linksys MR8300 specific BDFs

2020-11-04 Thread Kalle Valo
Christian Lamparter writes: > Hello, > > On 2020-09-15 17:02, Hans Geiblinger wrote: >> The support for this device is currently being added into OpenWrt. This AP >> requires >> two special BDFs to get the Wi-Fi PHYs working (correctly). >> >> * description for what hardware this is: >> >>-

Re: drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

2020-11-03 Thread Kalle Valo
+ ath10k list Dan Carpenter writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3cea11cd5e3b00d91caf0b4730194039b45c5891 > commit: 7b2531d93bac6bea67e9c7f49901e9e8796d6d57 ath10k: Add new api to > support TID specific configuration > config:

Re: [PATCH v5 2/2] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-11-01 Thread Kalle Valo
> Cc: Joerg Roedel > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Linus Walleij > Cc: Vinod Koul > Cc: Kalle Valo > Cc: Maulik Shah > Cc: Lina Iyer > Cc: Saravana Kannan > Cc: Todd Kjos > Cc: Greg Kroah-Hartman > Cc: linux-arm-...

Re: [PATCH 1/2] ath10k: remove repeated words in comments

2020-10-28 Thread Kalle Valo
Kalle Valo wrote: > Found by latest checkpatch. > > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 762fd1aec588 ath10k: remove repeated words in comments d2f3f68864a4 ath10k: ath10k_pci_init_irq(): workaround for checkpatch fallthrough warning

[PATCH 1/2] ath10k: remove repeated words in comments

2020-10-27 Thread Kalle Valo
Found by latest checkpatch. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c| 2 +- drivers/net/wireless/ath/ath10k/debug.c | 2 +- drivers/net/wireless/ath/ath10k/mac.c | 2 +- drivers/net/wireless/ath/ath10k/rx_desc.h | 2 +- drivers/net/wireless/ath/ath10k

[PATCH 2/2] ath10k: ath10k_pci_init_irq(): workaround for checkpatch fallthrough warning

2020-10-27 Thread Kalle Valo
Latest checkpatch complains about use of fall-through comment. But as this is a switch statement just reword the comment to workaround the problem. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PULL] ath10k & ath11k firmware 20201023

2020-10-23 Thread Kalle Valo
.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 (2020-10-23 18:42:08 +0300) ---- Kalle Valo (11): ath10k: QCA6174 hw3.0: update firmware-6.bin to WLAN.RM.4.4.1-00157-QCARMSWPZ-1 ath10k: QCA6174 hw3.0: update board-2.bin ath10k: QCA98

Re: [PULL] ath10k & ath11k firmware 20201022

2020-10-22 Thread Kalle Valo
Kalle Valo writes: > Hi linux-firmware maintainers, > > here's a pull request for ath10k and ath11k drivers. For ath10k there > is a firmware for new hardware QCA6174 hw3.0 SDIO. For ath11k there > are firmwares for new hardware IPQ8074 hw2.0, IPQ6018 hw1.0 and > QCA6

[PULL] ath10k & ath11k firmware 20201022

2020-10-22 Thread Kalle Valo
X86-1 (2020-10-22 11:06:49 +0300) Kalle Valo (11): ath10k: QCA6174 hw3.0: update firmware-6.bin to WLAN.RM.4.4.1-00157-QCARMSWPZ-1 ath10k: QCA6174 hw3.0: update board-2.bin ath10k: QCA9888 hw2.0: update firmware-5.bin to

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-29 Thread Kalle Valo
G_V01 error message. > Tried ath10k/WCN3990/hw1.0/wlanmdsp.mbn from the upstream > linux-firmware project but it didn't help and neither did > building board-2.bin file from stock bdwlan* files. > > This workaround will be removed once we have a viable fix. > Thanks to pos

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-29 Thread Kalle Valo
Alex Dewar writes: >> I agree. Anyone can come up with a patch? > > Hi Kalle, > > I was thinking of having a go at this. Have you applied the v2 of this > patch yet though? I couldn't see it in wireless-drivers-next. I just > don't want to have to rebase the patch if you were going to apply this

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-24 Thread Kalle Valo
Amit Pundir writes: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. > > We suspect either the host

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-24 Thread Kalle Valo
Julian Calaby writes: > On Thu, Sep 17, 2020 at 3:09 AM Alex Dewar wrote: >> >> The for loop checks whether cur_section is NULL on every iteration, but >> we know it can never be NULL as there is another check towards the >> bottom of the loop body. Refactor to avoid this unnecessary check. >> >

Re: [PATCH v2] ath10k: Use bdf calibration variant for snoc targets

2020-09-22 Thread Kalle Valo
e the boarddata identifiers for the board-2.bin search > > * bus=snoc,qmi-board-id=16,qmi-chip-id=0,variant=xyz-v1 > * bus=snoc,qmi-board-id=17,qmi-chip-id=0,variant=xyz-v2 > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh P

Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery

2020-09-15 Thread Kalle Valo
"Rakesh Pillai" writes: >> -Original Message- >> From: Rakesh Pillai >> Sent: Saturday, June 27, 2020 12:24 AM >> To: ath10k@lists.infradead.org >> Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org; Rakesh >> Pillai >> Subject: [PATCH v2 0/2] ath10k: Fixes during subsyste

Re: [PATCH] ath10k: Remove unused macro ATH10K_ROC_TIMEOUT_HZ

2020-09-11 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 42a08ff79ff5 ath10k: Remove unused macro ATH10K_ROC_TIMEOUT_HZ -- https://patchwork.kernel.org/pa

Re: lockdep splat in kvallo ath tree

2020-09-11 Thread Kalle Valo
+ ath10k Ben Greear writes: > The patch below adds a call to ath10k_debug_fw_stats_request(ar), > which expects ar->conf_mutex to be held, but it is *not* held in > this code path. This leads to warnings when lockdep is enabled. > > > greearb@bendt7 ath10k]$ git show 4913e675630ec > commit 4913

Re: [PATCH v2 2/2] ath10k: allow dynamic SAR power limits to be configured

2020-09-07 Thread Kalle Valo
0029. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo The plan is to have a common API for SAR limits, not use vendor API. Patch set to Rejected. -- https://patchwork.kernel.org/patch/11686327/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 1/2] nl80211: vendor-cmd: qca: add dynamic SAR power limits

2020-09-07 Thread Kalle Valo
Johannes Berg writes: > On Fri, 2020-07-24 at 12:26 +0300, Kalle Valo wrote: > >> > > So to me it feels like the best solution forward is to go with the >> > > vendor API, do you agree? We can, of course, later switch to the common >> > > API if w

Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990

2020-09-07 Thread Kalle Valo
Rakesh Pillai wrote: > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai > Reviewed-by: Douglas Anderson > Acked-by: Rob Herring > Si

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-09-07 Thread Kalle Valo
Wen Gong writes: > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands, either can reproduce the hang for PCIe, SDIO and SNOC. > echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/sim

Re: [PATCH] ath10k: Use bdf calibration variant for snoc targets

2020-09-07 Thread Kalle Valo
"Rakesh Pillai" writes: >> > --- a/drivers/net/wireless/ath/ath10k/qmi.c >> > +++ b/drivers/net/wireless/ath/ath10k/qmi.c >> > @@ -576,6 +576,8 @@ static int ath10k_qmi_cap_send_sync_msg(struct >> ath10k_qmi *qmi) >> >if (resp->chip_info_valid) { >> >qmi->chip_info.chip_id = resp-

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-09-07 Thread Kalle Valo
Govind Singh writes: > On 2020-08-28 18:22, Kalle Valo wrote: >> Amit Pundir writes: >> >>> On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: >>>> > I don't agree with this. If you read through the replies to the bug >>>> > report, >

Re: [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting

2020-09-07 Thread Kalle Valo
Doug Anderson writes: > Hi, > > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai wrote: >> >> Add the support to vote for the chain-1 >> voltage regulator for WCN3990. This is >> added as an optional property. >> >> Rakesh Pillai (2): >> dt: bindings: Add new regulator as optional property for W

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-09-07 Thread Kalle Valo
Ben Greear writes: >> Here is my original patch to fix this, it is not complex. >> >> https://patchwork.kernel.org/patch/10249363/ > Sure, I have shared your patch above :). Sent a bit early, any idea why this wasn't upstreamed earlier? >>> >>> No, one comment from Michal ind

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-09-07 Thread Kalle Valo
Wen Gong writes: > On 2020-08-15 01:19, Kalle Valo wrote: > ... >> >> I have been thinking a different approach for this. I think another >> option is to have a function like this: >> >> ath10k_core_firmware_crashed() >> { >> queue_work(

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-09-07 Thread Kalle Valo
Wen Gong writes: > On 2020-08-15 01:19, Kalle Valo wrote: >> Wen Gong writes: >> > ... >>> diff --git a/drivers/net/wireless/ath/ath10k/core.c >>> b/drivers/net/wireless/ath/ath10k/core.c >>> index 91f131b87efc..0e31846e6c89 100644 >>>

Re: CVE-2020-3702: Firmware updates for ath9k and ath10k chips

2020-09-07 Thread Kalle Valo
Baptiste Jonglez writes: > Hi, > > Cross-posting to openwrt-devel because we are backporting the necessary fixes. > > On 12-08-20, Jouni Malinen wrote: >> On Wed, Aug 12, 2020 at 11:17:47AM +0200, Toke H?iland-J?rgensen wrote: >> > Pali Roh?r writes: >> > > Could somebody react and provide some

Re: ath10k-firmware: QCA6174A hw3.2: Add Killer Networking/Surface Go specific board

2020-09-07 Thread Kalle Valo
Blaž Hrastnik writes: > Hi Kalle, are you still taking board file submissions? I saw that no > newly submitted board files were merged in 2020. I am, it's just that they are currently on the bottom of my todo list :/ -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat

Re: [PATCH] ath10k: Use bdf calibration variant for snoc targets

2020-09-02 Thread Kalle Valo
Rakesh Pillai writes: > Board Data File (BDF) is loaded upon driver boot-up procedure. > The right board data file is identified using bus and qmi-board-id. > > The problem, however, can occur when the (default) board data > file cannot fulfill with the vendor requirements and it is > necessary t

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
Doug Anderson writes: > On Wed, Aug 26, 2020 at 7:51 AM Kalle Valo wrote: >> >> Douglas Anderson wrote: >> >> > If we have a per CE (Copy Engine) IRQ then we have no summary >> > register. Right now the code generates a summary register by >> &g

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
t keep track > of the IRQs that fire. Then we can effectively generate our own > summary without ever needing to read the Copy Engines. > > Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 > > Signed-off-by: Douglas Anderson > Reviewed-by: Rakesh Pillai > Reviewed-by:

Re: [PATCH] ath10k: Add interrupt summary based CE processing

2020-09-01 Thread Kalle Valo
red. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai > Reviewed-by: Douglas Anderson > Tested-by: Douglas Anderson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b92aba35d39d ath10k: Add i

Re: [PATCH][next] ath10k: wmi: Use struct_size() helper in ath10k_wmi_alloc_skb()

2020-08-31 Thread Kalle Valo
fixed manually. > > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e96eecdb290a ath10k: wmi: Use struct_size() helper in ath10k_wmi_alloc_skb() -- https://patchwork.kernel.org/patch/11608745/ https://w

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-08-28 Thread Kalle Valo
Amit Pundir writes: > On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: >> > I don't agree with this. If you read through the replies to the bug report, >> > it is clear that NS migration uncovered a corner case or even a bug. So we >> > should try to fix t

Re: [PATCH] Revert "ath: add support for special 0x0 regulatory domain"

2020-08-27 Thread Kalle Valo
Alvin Šipraga writes: > Hi Kalle, > > On 7/30/20 2:49 PM, Alvin Šipraga wrote: >> This reverts commit 2dc016599cfa9672a147528ca26d70c3654a5423. >> >> Per Atheros documentation to manufacturers, the EEPROM regulatory domain >> code 0x0 must always map to "US". In particular, it should not map to a

Re: [PATCHv2 1/4] ath10k: Add wmi command support for station specific TID config

2020-08-26 Thread Kalle Valo
EER_TID_CONFIGS_SUPPORT flag is added to advertise > this support. > > Tested-on: QCA9984 hw1.0 PCI 10.4-3.9.0.2-00021 > > Signed-off-by: Tamizh Chelvam > Signed-off-by: Kalle Valo 4 patches applied to ath-next branch of ath.git, thanks. 5d582be0bc66 ath10k: Add wmi comman

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-08-26 Thread Kalle Valo
t keep track > of the IRQs that fire. Then we can effectively generate our own > summary without ever needing to read the Copy Engines. > > Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 > > Signed-off-by: Douglas Anderson > Reviewed-by: Rakesh Pillai > Reviewed-by: Br

Re: [PATCH] ath10k: Add interrupt summary based CE processing

2020-08-26 Thread Kalle Valo
(Guys, PLEASE edit your quotes. These long emails my use of patchwork horrible.) "Rakesh Pillai" writes: >> -Original Message- >> From: Peter Oh >> Sent: Tuesday, July 21, 2020 7:03 AM >> To: Kalle Valo >> Cc: Brian Norris ; Doug Anderson >&g

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Kalle Valo
Wen Gong writes: > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands > echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash;sleep > 0.05;ifconfig wlan0 down > echo

Re: [PATCH v4 1/2] ath10k: add bus type for each layout of coredump

2020-08-19 Thread Kalle Valo
Wen Gong wrote: > For some hw version, it has more than one bus type, it need to add bus > type to distinguish different chip. > > Tested-on: QCA6174 SDIO WLAN.RMH.4.4.1-00018-QCARMSWP-1 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo 2 patches applied to ath-n

Re: [PATCH v4 2/2] ath10k: add fw coredump for sdio when firmware assert

2020-08-19 Thread Kalle Valo
Wen Gong writes: > On 2020-08-15 00:36, Kalle Valo wrote: >> Wen Gong writes: >> >> I did some changes in the pending branch, please check: >> > I compared this patch with patch in pending branch, it is OK for me. Great, thanks for testing. I also did some chang

Re: [ath6kl:pending 106/110] drivers/net/wireless/ath/ath10k/mac.c:3033:6-25: duplicated argument to && or || (fwd)

2020-08-19 Thread Kalle Valo
ll > Subject: [ath6kl:pending 106/110] > drivers/net/wireless/ath/ath10k/mac.c:3033:6-25: duplicated argument to && > or || > > CC: kbuild-...@lists.01.org > CC: Kalle Valo > CC: ath10k@lists.infradead.org > TO: Tamizh Chelvam > CC: Kalle Valo > >

Re: [PATCH] ath10k: fix VHT NSS calculation when STBC is enabled

2020-08-18 Thread Kalle Valo
A9984 10.4-3.10-00047 > > Signed-off-by: Sathishkumar Muruganandam > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 99f41b8e43b8 ath10k: fix VHT NSS calculation when STBC is enabled -- https://patchwork.kernel.org/patch/11713837/ https://wireless

Re: [PATCH] ath10k: Register shutdown handler

2020-08-18 Thread Kalle Valo
n > driver and avoid any dma operations. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. caf275463d37 ath10k: Register shutdown handler

Re: [PATCH] ath10k: move enable_pll_clk call to ath10k_core_start()

2020-08-18 Thread Kalle Valo
Kalle Valo wrote: > There's no reason to have call for enable_pll_clk in ath10k_bmi_start(), move > it to ath10k_core_start() instead. This way it's possible to call > ath10k_bmi_start() from sdio.c during firmware dump creation. And also the > function call is more visib

Re: [PATCH] ath10k: fix the status check and wrong return

2020-08-18 Thread Kalle Valo
Tang Bin writes: > 在 2020/8/17 22:26, Kalle Valo 写道: >>> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't >>> return NULL. Thus use IS_ERR() and PTR_ERR() to validate >>> the returned value instead of IS_ERR_OR_NULL(). >> Why? What'

Re: [PATCH] ath10k: fix the status check and wrong return

2020-08-17 Thread Kalle Valo
Tang Bin writes: > In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't > return NULL. Thus use IS_ERR() and PTR_ERR() to validate > the returned value instead of IS_ERR_OR_NULL(). Why? What's the benefit of this patch? Or what harm does IS_ERR_OR_NULL() create? > Signed-off-by: Zhan

Re: [PATCHv2 3/4] ath10k: Add new api to support TID specific configuration

2020-08-17 Thread Kalle Valo
plied > for the station which supports vht rates). > > Tested-on: QCA9984 hw1.0 PCI 10.4-3.9.0.2-00021 > > Signed-off-by: Tamizh Chelvam > Signed-off-by: Kalle Valo There few checkpatch warnings which I fixed and also I did some whitespace changes to improve readability. Others were

Re: [PATCH][next] ath10k: Use fallthrough pseudo-keyword

2020-08-17 Thread Kalle Valo
v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1885c0f76dc0 ath10k: Use fallthrough pseudo-keyword -- https://patchw

Re: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path

2020-08-17 Thread Kalle Valo
by: Christophe JAILLET > Reviewed-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 454530a9950b ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path -- https://patchwork.kernel.org/patch/11696383/

Re: ath10k regression on 5.8.0 on Dell XPS?

2020-08-17 Thread Kalle Valo
Alex Bennée writes: > Hi, > > In attempting to fix a somewhat intermittent bluetooth startup on my > Dell XPS15 9560 I upgraded the kernel to 5.8.0 and lost all connectivity > (wireless and bluetooth). I had debugging turned on so got a log full of > complaints as the driver tried to startup: > >

Re: CVE-2020-3702: Firmware updates for ath9k and ath10k chips

2020-08-17 Thread Kalle Valo
Pali Rohár writes: > ESET engineers on their blog published some information about new > security vulnerability CVE-2020-3702 in ath9k wifi cards: > https://www.welivesecurity.com/2020/08/06/beyond-kr00k-even-more-wifi-chips-vulnerable-eavesdropping/ > > According to Qualcomm security bulletin th

<    1   2   3   4   5   6   7   8   9   10   >