tats_info of its
> hw_params is true, it is true only for QCA6174 currently.
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-nex
in ath10k_peer_stats_enabled and ath10k_sta_statistics pass check.
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
3 patches applied to ath-next branc
Wen Gong writes:
> When it has more than one restart_work queued meanwhile, the 2nd
> restart_work is very esay to break the 1st restart work and lead
> recovery fail.
>
> Add a ref count to allow only one restart work running untill
> device successfully recovered.
>
> Tested with QCA6174 SDIO w
; Fix them by making the existing invalid channel width
> cases the default, as the introduced channel widths
> currently don't make sense in 2 or 5GHz either.
>
> Fixes: e5cb3d34a66d ("nl80211: S1G band and channel definitions")
> Signed-off-by: Thomas Pedersen
I assum
Wen Gong writes:
> When firmware assert, it need coredump to analyze, this patch will
> collect the register and memory info for sdio chip.
>
> The coredump configuration is different between PCIE and SDIO for
> the same reversion, so this patch add bus type to distinguish PCIE
> and SDIO chip fo
ctional changes, compile tested only.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/bmi.c | 8
drivers/net/wireless/ath/ath10k/core.c | 7 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/bmi.c
b/drivers/net/wireless/a
uot;
> will be reasonable.
>
> This patch only effect sdio chips.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
2fd3c8f34d08 ath10k: st
Brian Norris writes:
> On Thu, Jul 16, 2020 at 2:35 AM Kalle Valo wrote:
>> Brian Norris writes:
>> > Really, I could live with per-vendor APIs. My primary goal is to get
>> > these upstream in some form, so vendors can stop using things like
>> > this as a
Hauke Mehrtens wrote:
> This fixes a NULL pointer dereference in the probe path for AHB devices.
> There attr parameter in the ath10k_ce_alloc_pipe() function is not
> initialized, but accessed. This function is called by
> ath10k_pci_setup_resource() which is called by ath10k_ahb_probe().
>
> T
12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014
> [ 15.600438] Workqueue: ath10k_wq ath10k_core_register_work [ath10k_core]
> [ 15.601389] RIP: 0010:__ath10k_htt_rx_ring_fill_n
> (linux/drivers/net/wireless/ath/ath10k/htt_rx.c:173) ath10k_core
>
> Signed-off-by: Zekun Shen
> Signed
Brian Norris writes:
> Really, I could live with per-vendor APIs. My primary goal is to get
> these upstream in some form, so vendors can stop using things like
> this as a reason for shipping us non-upstream code, and so we can
> reduce the delta between upstream and Chrome OS kernels.
>
> I als
Brian Norris writes:
> On Fri, Jun 26, 2020 at 2:49 PM Doug Anderson wrote:
>> I should also note that, while I'm not terribly familiar with Kalle's
>> workflow, I would have expected to see him in the "To:" list. I've
>> added him, but it's possible he'll need you to repost the patch with
>> h
Kieran Bingham wrote:
> The word 'descriptor' is misspelled throughout the tree.
>
> Fix it up accordingly:
> decriptors -> descriptors
>
> Signed-off-by: Kieran Bingham
Patch applied to wireless-drivers-next.git, thanks.
0e20c3e10333 wireless: Fix trivial spelling
--
https://patchwork
Zekun Shen writes:
> The idx in __ath10k_htt_rx_ring_fill_n function lives in
> consistent dma region writable by the device. Malfunctional
> or malicious device could manipulate such idx to have a OOB
> write. Either by
> htt->rx_ring.netbufs_ring[idx] = skb;
> or by
> ath10k_htt_set_pad
Kieran Bingham wrote:
> The word 'descriptor' is misspelled throughout the tree.
>
> Fix it up accordingly:
> decriptors -> descriptors
>
> Signed-off-by: Kieran Bingham
I recommend splitting wan and wireless changes to separate patches as I
cannot take changes to wan subsystem.
Patch se
Wen Gong writes:
> On 2020-06-17 16:25, Wen Gong wrote:
>>> +
>>> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
>>> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
>> https://patchwork.kernel.org/patch/2947291/
>> (https://git.kernel.org/pub/scm/linux/k
; input. The value comes from "nbytes" in ath10k_pci_bmi_recv_data,
> which is set inside _ath10k_ce_completed_recv_next_nolock with the line
>
> nbytes = __le16_to_cpu(sdesc.nbytes);
>
> sdesc is a stream dma region which device can write to.
>
> Signed-off-by
Kalle Valo wrote:
> It is expected that the returned counters by .get_survey are monotonic
> increasing. But the data from ath10k gets reset to zero regularly. Channel
> active/busy time are then showing incorrect values (less than previous or
> sometimes zero) for the currently ac
00104
> Tested-on: QCA9882 PCI 10.2.4-1.0-00047
>
> Signed-off-by: Venkateswara Naralasetty
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
67b927f98208 ath10k: fix retry packets update in station dump
--
https://patchwork.kernel.org/patch/1159
nterrupt sources
> firing that need to be cleared. If one of those sources was the one
> that caused the IRQ handler to be called it would also be important to
> double-check that the interrupt we cared about actually fired.
>
> Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1
Doug Anderson writes:
> On Mon, Jun 15, 2020 at 7:32 AM Kalle Valo wrote:
>>
>> Douglas Anderson wrote:
>>
>> > On wcn3990 we have "per_ce_irq = true". That makes the
>> > ath10k_ce_interrupt_summary() function always return 0xfff. The
>>
John Deere <24601dee...@gmail.com>
[s...@narfation.org: adjust commit message]
Signed-off-by: Sven Eckelmann
Signed-off-by: Kalle Valo
---
v6:
* cc linux-wireless so patchwork sees this
v5:
* add additional tested devices
* restructure commit message
v4:
* updated signed-off-by
v3:
* Rebased
nterrupt sources
> firing that need to be cleared. If one of those sources was the one
> that caused the IRQ handler to be called it would also be important to
> double-check that the interrupt we cared about actually fired.
>
> Signed-off-by: Douglas Anderson
> Signed-off-by: Kall
Robert Marko writes:
> Enable advertising support for 5G channels: 32, 68 and 96.
> These channels are legal and available for use in ETSI countries.
> So lets advertise these and they will be available in accordance with the
> regulatory domain used.
>
> Signed-off-by: Robert Marko
> Cc: Luka
ng management")
> Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64
> descriptor")
> Signed-off-by: Evan Green
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
a738e766e3ed ath10k: Acquire tx_lock in tx error paths
--
h
Evan Green writes:
> ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock
> is held. Acquire the lock in a couple of error paths when calling that
> function to ensure this condition is met.
>
> Fixes: 6421969f248fd ("ath10k: refactor tx pending management")
> Fixes: e62ee5c381c
Manivannan Sadhasivam writes:
> On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote:
>> On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote:
>> > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris
>> > wrote:
>> > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz
>> > > wrote:
>> > > >
>> > > >
Govind Singh wrote:
> With kernel qrtr switch from user space qrtr, fw crash is seen
> during reboot. During reboot modem rproc shutdown causes wlan qmi
> service exit and msa region gets unmapped. Since pdev is not suspended
> hw still accessing the msa region and this results in fw crash as
>
by returning early in
> ath10k_qmi_event_server_exit().
>
> A better solution is very much desired!
>
> Feedback and suggestions welcome!
>
> Cc: Rakesh Pillai
> Cc: Govind Singh
> Cc: Bjorn Andersson
> Cc: Niklas Cassel
> Cc: Manivannan Sadhasivam
> Cc: A
Sebastian Gottschall writes:
>> Yeah, that patch is buggy but this should fix it:
>>
>> commit 32221df6765b3773ff1af37c77f8531ebc48f246
>> Author: Arnd Bergmann
>> AuthorDate: Sat May 9 14:06:33 2020 +0200
>> Commit: Kalle Valo
>>
xes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Douglas Anderson
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
23cc6bb5a2e6 ath10k: Remove ath10k_qmi_register_service_notifier() declaration
--
https://p
Sebastian Gottschall writes:
> Am 05.05.2020 um 09:34 schrieb Kalle Valo:
>
>> Maharaja Kennadyrajan wrote:
>>
>>> As the exisiting CE configurations are defined in global, there
>>> are the chances of QCA99X0 family chipsets CE configura
Sven Eckelmann writes:
> On Monday, 25 May 2020 11:22:13 CEST Sven Eckelmann wrote:
> [...]
>> And it still can with this OpenWrt version. But it doesn't seem to happen
>> with
>> the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000
>> commits inbetween. So no idea what
Christian Hewitt writes:
>> On 24 May 2020, at 8:34 pm, Josh Boyer wrote:
>>
>> On Sun, May 24, 2020 at 9:59 AM Christian Hewitt
>> wrote:
>>>
>>> This commit adds the SDIO firmware for ath10k/QCA9377 cards. The file
>>> is from the Boundary Devices repo [1] and has the same license as the
>>
Pali Rohár writes:
> Also replace generic MANUFACTURER macros by proper SDIO IDs macros.
>
> Check for "AR6003 or later" is slightly modified to use SDIO device IDs.
> This allows removal of all custom MANUFACTURER macros from ath6kl.
>
> Signed-off-by: Pali
Pali Rohár writes:
> Add _WLAN suffix to macro names for consistency with other Marvell macros.
> These IDs represents wlan function of combo bt/wlan cards. Other functions
> of these cards have different IDs.
>
> Signed-off-by: Pali Rohár
Acked-by: Kalle V
(please don't top post)
Sebastian Gottschall writes:
> this code is not in use in its original form for ipq4019. i have seen
> that his patch is also dropped from ath.git but is still in use by
> openwrt. could somone clarify the state here and why it was dropped?
I dropped the patch because of
Markus Theil writes:
> I've seen this patch got dropped again from the ath.git pending branch.
> On which hw/firmware combination did it fail to operate?
It's deferred at the moment:
https://patchwork.kernel.org/patch/11532357/
The conclusion from the other thread was not clear for me, so I pu
+ ath11k
kbuild test robot writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head: 6303acc5b03a5fc3bf6cf5fa072ae0dc9aaa5dd0
> commit: 398a800c183de17a49a5779550e72fbc3ba1e592 [21/24] ath11k: Add msi
> config init for QCA6390
>
> If you fix the issue, ki
| ^~~
>
> Make records[] a flexible array member to allow this, moving it behind
> the other zero-length member that is not accessed in a way that gcc
> warns about.
>
> Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
&
Arnd Bergmann writes:
> On Mon, May 11, 2020 at 2:03 PM Kalle Valo wrote:
>> "Gustavo A. R. Silva" writes:
>
>> >
>> > This treewide patch no longer contains changes for ath10k. I removed them
>> > since Monday (05/04/2020). So, this "Fixes
Govind Singh wrote:
> ath10k(sdio/snoc) is no longer experimental. Remove experimental tag for
> SDIO/SNOC from ath10k Kconfig.
>
> Signed-off-by: Govind Singh
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
4d0f3604c4d1 ath10k: remove experi
le.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva
> Signed-off-by: Kalle Valo
Patch applied to ath-ne
Kalle Valo wrote:
> Sparse warned:
>
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect
> type in assignment (different base types)
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34:expected
> restricted __le32 [usertype] reset_after_request
> dri
ket over
> wmi fails.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support
> over wmi")
> Signed-off-by: Rakesh Pillai
> Signed-off-by: Kalle Valo
Patch applied to a
s not reset its qmi state.
>
> Hence skip the processing of del_server event when the
> driver is unloading.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
>
Kalle Valo writes:
> Arnd Bergmann writes:
>
>> gcc-10 correctly points out a bug with a zero-length array in
>> struct ath10k_pci:
>>
>> drivers/net/wireless/ath/ath10k/ahb.c: In function 'ath10k_ahb_remove':
>> drivers/net/wireless/ath/ath10k/ahb.
Arnd Bergmann writes:
> gcc-10 correctly points out a bug with a zero-length array in
> struct ath10k_pci:
>
> drivers/net/wireless/ath/ath10k/ahb.c: In function 'ath10k_ahb_remove':
> drivers/net/wireless/ath/ath10k/ahb.c:30:9: error: array subscript 0
> is outside the bounds of an interior zero
"Gustavo A. R. Silva" writes:
> Arnd,
>
> On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote:
>> gcc-10 started warning about out-of-bounds access for zero-length
>> arrays:
>>
>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>> from drivers/net/wir
writes:
> Yes, The change you did is correct and better.
Thanks for checking.
> So should I be sending a v3 for this patch ?
No need, the patch with this change is now in my pending branch and I'll
apply it to ath-next it in the next few days.
--
https://wireless.wiki.kernel.org/en/developer
Rakesh Pillai writes:
> Currently when the sending of any management pkt
> via wmi command fails, the packet is being unmapped
> freed in the error handling. But the idr entry added,
> which is used to track these packet is not getting removed.
>
> Hence, during unload, in wmi cleanup, all the en
:3013:34:got unsigned int
[usertype] reset
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Fixes: 0f7cb26830a6 ("ath10k: add rx bitrate report for SDIO")
Signed-off-by: Wen Gong
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +-
1 file
"Gustavo A. R. Silva" wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int
Rakesh Pillai wrote:
> Add a wifi-firmware subnode for the wifi node.
> This wifi-firmware subnode is needed for the
> targets which do not support TrustZone.
>
> Signed-off-by: Rakesh Pillai
> Acked-by: Rob Herring
> Signed-off-by: Kalle Valo
3 patches applied to ath-n
ETECT WoWLAN feature")
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
d431f8939c14 ath10k: remove the max_sched_scan_reqs value
--
https://patchwork.kernel.org/patch/11243015/
https
;
> Tested hardware: QCA9888 & QCA6174
> Tested firmware: 10.4-3.10-00047 & WLAN.RM.4.4.1.c3-00058
>
> Signed-off-by: Maharaja Kennadyrajan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
521fc37be3d8 ath10k: Avoid override CE5 config
"Gustavo A. R. Silva" writes:
> On 5/4/20 06:54, Kalle Valo wrote:
>> "Gustavo A. R. Silva" writes:
>>
>>> Hi Arnd,
>>>
>>> On 4/30/20 16:30, Arnd Bergmann wrote:
>>>> gcc-10 started warning about out-of-bounds acces
"Gustavo A. R. Silva" writes:
> Hi Arnd,
>
> On 4/30/20 16:30, Arnd Bergmann wrote:
>> gcc-10 started warning about out-of-bounds access for zero-length
>> arrays:
>>
>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>> from drivers/net/wireless/ath/ath10k/htt_
(Fixing top posting and adding Yibo)
John Deere <24601dee...@gmail.com> writes:
> On 4/30/20 6:28 PM, Kalle Valo wrote:
>> John Deere <24601dee...@gmail.com> writes:
>>
>>> Hello,
>>>
>>>> Firmwares tested : 10.4-3.9.0.1-00036
>>&g
quot;)
> Signed-off-by: Wei Yongjun
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
2326aa011967 ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
--
https://patchwork.kernel.org/patch/11511841/
https://wireless.wiki.kernel.org/en/d
John Deere <24601dee...@gmail.com> writes:
> Hello,
>
>> Firmwares tested : 10.4-3.9.0.1-00036
>
> The firmware above is unavailable anywhere.
It's here:
https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036
--
https://wireless.wiki.kernel
Sven Eckelmann writes:
> On Wednesday, 1 April 2020 09:00:49 CEST Sven Eckelmann wrote:
>> On Wednesday, 5 February 2020 20:10:43 CEST Linus Lüssing wrote:
>> > From: Linus Lüssing
>> >
>> > Before, only frames with a maximum size of 1528 bytes could be
>> > transmitted between two 802.11s node
Arvind Bakshi writes:
> Getting 1 mbps link speed and average signal strength, even on
> standing next to router on every linux distro whereas windows 10 gives
> 150 mbps link speeds and excellent signal strength even standing quite
> far off from router. Tested on Fedora 30/31 and ubuntu 18.04/2
Wei Yongjun writes:
> 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed
> before leaving from the error handling cases, otherwise it will cause
> memory leak.
>
> Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO")
> Signed-off-by: Wei Yongjun
> ---
>
Kalle Valo writes:
> Wen Gong wrote:
>
>> For wmi tlv type, firmware disable peer stats info by default, after
>> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if
>> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
>>
>&g
will not report
> it without receive request WMI command.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
4 patches applied to ath-next branch of ath.git, thanks.
2289bef25e32 ath10k: enable fir
Wen Gong wrote:
> For wmi tlv type, firmware disable peer stats info by default, after
> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if
> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
>
> Enable it will only set a flag in firmware, firmware will not report
>
ly sent after condition
> checked by ath10k_peer_stats_enabled in ath10k_sta_statistics.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
: 991
> tx bytes: 98765577
> tx packets: 64624
> tx retries: 14682
> tx failed: 47086
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch ap
Wen Gong wrote:
> When test simulate firmware crash, it is easy to trigger error.
> command:
> echo soft > /sys/kernel/debug/ieee80211/phyxx/ath10k/simulate_fw_crash.
>
> If input more than two times continuously, then it will have error.
> Error message:
> ath10k_pci :02:00.0: failed to set
Wen Gong wrote:
> Upstream kernel has an interface to help adjust sk_pacing_shift to help
> improve TCP UL throughput.
> The sk_pacing_shift is 8 in mac80211, this is based on test with 11N
> WiFi chips with ath9k. For QCA6174/QCA9377 PCI 11AC chips, the 11AC
> VHT80 TCP UL throughput testing res
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8347784d6f5f ath10k: drop the TX packet which size exceed credit size for sdio
--
https://patchwork.kernel.org/patch/11503309/
https://wireless.wiki.kernel.org/
nding the pdev set command to the firmware.
>
> Tested hardware: QCA9888
> Tested firmware: 10.4-3.10-00047
>
> Signed-off-by: Maharaja Kennadyrajan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
aac392d8553f ath10k: Fix the invalid tx/r
Kalle Valo writes:
> Nicola Mori writes:
>
>> Hi, I have an issue with the WiFi card in my laptop, that keeps
>> disconnecting from the network in a strange way: randomly every 1-2
>> hours I can't access web pages or even ping the gateway, but existing
>
Wen Gong wrote:
> sdio chip use DMA buffer to receive TX packet from ath10k, and it has
> limitation of each buffer, if the packet size exceed the credit size,
> it will trigger error in firmware.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWP-1.
>
> Signed-off-by: W
25377.878497: ath10k_log_dbg: ath10k_sdio mmc1:0001:1
> bundle tx complete, eid:1, pending complete count:13
> <...>-1488 [001] 25377.919927: ath10k_log_dbg: ath10k_sdio mmc1:0001:1
> credit update: delta:11
> <...>-1488 [001] 25377.919932: ath10k_lo
NOC etc.
> It only enable bundle for sdio chip.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWP-1.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
2 patches applied to ath-next branch of ath.git, thanks.
c8334512f3dd ath10k: add htt TX
Kalle Valo wrote:
> Convert ath10k_hif_swap_mailbox() to a more generic op so that bus drivers can
> do more than just swap the mailbox, for example set power save settings like
> in
> the following sdio patch.
>
> No functional changes, compile tested only.
>
> Signe
Wen Gong writes:
> On 2020-04-16 20:27, Kalle Valo wrote:
>> Kalle Valo writes:
>>
>
>>> How much does it drop? Please add the justification (with numbers) for
>>> the new thread to the commit log, so that the reason is properly
>>> documented.
>&
Wen Gong writes:
> On 2020-04-16 20:38, Kalle Valo wrote:
>> Wen Gong writes:
>>
>
>>
>>> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar,
>>> bool enable_sleep)
>>> +{
>>> + if (ar->hif.ops->set_mbox_sleep)
&
Wen Gong writes:
> This patch is to set register to allow the mbox enter sleep status
> if it does not have tx traffic and wakeup it if tx traffic arrive.
> After mbox enter sleep status, the soc will enter sleep status by
> firmware, this will save power. The power consume drops from about
> 90m
Nicola Mori writes:
> Hi, I have an issue with the WiFi card in my laptop, that keeps
> disconnecting from the network in a strange way: randomly every 1-2
> hours I can't access web pages or even ping the gateway, but existing
> connections (like existing ssh sessions or Zoom videoconferences)
ux.org/viewtopic.php?id=254535
So if I read the link correctly this commit causes the regression (which
was introduced in v5.6-rc1):
commit 2dc016599cfa9672a147528ca26d70c3654a5423
Author: Wen Gong
AuthorDate: Fri Nov 29 07:34:09 2019 +
Commit: Kalle Valo
CommitDate: Mon Dec 2 12:08
Kalle Valo writes:
> Wen Gong writes:
>
>> On 2020-04-09 22:53, Kalle Valo wrote:
>>> Wen Gong writes:
>>>
>>>> + ar->workqueue_tx_complete =
>>>> + create_singlethread_workqueue("ath10k_tx_complete_wq");
>>&
The _hif_ prefix should be used only on functions part of ath10k_hif_ops, so
remove it from functions which should not have it.
No functional changes, compile tested only.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/sdio.c | 34 +-
1 file
Convert ath10k_hif_swap_mailbox() to a more generic op so that bus drivers can
do more than just swap the mailbox, for example set power save settings like in
the following sdio patch.
No functional changes, compile tested only.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k
That way we don't need to have an empty function in sdio.c.
No functional changes, compile tested only.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/hif.h | 3 ++-
drivers/net/wireless/ath/ath10k/sdio.c | 12
drivers/net/wireless/ath/ath10k/usb.c
10mW with this patch.
This patch only effect sdio chip.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
Signed-off-by: Wen Gong
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/sdio.c | 130 ++---
drivers/net/wireless/ath/ath10k/sdio.h
Hi,
here's a patchset for improving power consumption on SDIO with some refactoring
and some small cleanups afterwards.
v2:
* rename ath10k_hif_swap_mailbox() to make it usable for this
* small cleanups found while doing the refactoring
* compile tested only
Kalle Valo (3):
ath10k: r
Kalle Valo wrote:
> From: Wen Gong
>
> Add support for a vendor command for STATION, the command
> QCA_NL80211_VENDOR_SUBCMD_SET_SAR_LIMITS which is already defined in
> git://w1.fi/hostap.git (src/command/qca-vendor.h). This allows user
> space to configure power limits for
Mamatha Telu wrote:
> Fix some typo:
> s/fnrom/from
> s/pkgs/pkts/
> s/AMSUs/AMSDUs/
>
> Signed-off-by: Mamatha Telu
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8a7968bee8d0 ath10k: Fix typo in warning messages
--
https:/
Wen Gong writes:
> On 2020-04-09 22:53, Kalle Valo wrote:
>> Wen Gong writes:
>>
>>> + ar->workqueue_tx_complete =
>>> + create_singlethread_workqueue("ath10k_tx_complete_wq");
>>> + if (!ar->workqueue_tx_complete)
>>
Wen Gong writes:
> On 2020-04-09 23:05, Kalle Valo wrote:
>
>>> + ep->tx_credits -= credits;
>>> + ath10k_dbg(ar, ATH10K_DBG_HTC,
>>> + "htc ep %d consumed %d credits (total %d)\n",
&
Wen Gong writes:
> The transmission utilization ratio for sdio bus for small packet is
> slow, because the space and time cost for sdio bus is same for large
> length packet and small length packet. So the speed of data for large
> length packet is higher than small length.
>
> Test result of dif
Wen Gong writes:
> The transmission utilization ratio for sdio bus for small packet is
> slow, because the space and time cost for sdio bus is same for large
> length packet and small length packet. So the speed of data for large
> length packet is higher than small length.
>
> Test result of dif
nd "tx failed" since all tx packet's status
> is success.
>
> This patch only effect sdio chip, it will not effect PCI, SNOC etc.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1
>
> Signed-off-by: Wen Gong
> Signed-off-by: K
slate the rate from 'Mbps' to 'kbps' for QCA9888.
>
> Tested with:
> QCA6174 PCIe with firmware WLAN.RM.4.4.1.c3-00031.
> QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
> QCA9888 PCIe with firmware 10.4-3.9.0.2-00040.
>
> Signed-off-by: Yu Wang
> Signed
For some reason these comments didn't go to patchwork so resending them
again:
Kalle Valo writes:
> Yu Wang writes:
>
>> +for (i = 0; i < sband->n_bitrates; i++) {
>> +bitrates = &sband->bitrates[i];
>> +if (ath10k_ma
Wen Gong writes:
> On 2020-04-07 13:44, Kalle Valo wrote:
>
>> This has new warnings:
>>
>> drivers/net/wireless/ath/ath10k/htt_tx.c: In function
>> 'ath10k_htt_htc_tx_complete':
>> drivers/net/wireless/ath/ath10k/htt_tx.c:566:30: warning: 'msg_
nd "tx failed" since all tx packet's status
> is success.
>
> This patch only effect sdio chip, it will not effect PCI, SNOC etc.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1
>
> Signed-off-by: Wen Gong
> Signed-off-by: K
601 - 700 of 3044 matches
Mail list logo
