Re: ath10k: Kconfig build warnings

2018-10-16 Thread Niklas Cassel
On Mon, Oct 15, 2018 at 03:07:18PM -0700, Jeff Kirsher wrote: > Not sure if you aware, with David Miller's latest net-next tree, doing a > 'make allmodconfig' produces the following Kconfig errors: > > [15:06:06]$ make allmodconfig > scripts/kconfig/conf --allmodconfig Kconfig > > WARNING:

Re: [PATCH v5 0/6] *** Add support for wifi QMI client handshakes ***

2018-10-12 Thread Niklas Cassel
On Mon, Oct 08, 2018 at 05:36:30PM -0700, Brian Norris wrote: > + linux-msm > > Hi Govind, Kalle, > > On Wed, Aug 15, 2018 at 02:56:31PM +0530, Govind Singh wrote: > > Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. > > This module is responsible for communicating WLAN

Re: [PATCH v4 0/6] *** Add support for wifi QMI client handshakes ***

2018-07-24 Thread Niklas Cassel
nt driver implementation is based on qmi framework > https://lwn.net/Articles/729924/. For whole series: Acked-by: Niklas Cassel ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v3 0/6] *** Add support for wifi QMI client handshakes ***

2018-07-19 Thread Niklas Cassel
On Fri, Jul 06, 2018 at 02:26:17PM +0530, Govind Singh wrote: > Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. > This module is responsible for communicating WLAN control messages to FW > over QMI interface. This patch series enables the qmi handshakes required for >

Re: [2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST

2018-07-04 Thread Niklas Cassel
On Wed, Jul 04, 2018 at 09:59:13AM +, Kalle Valo wrote: > Niklas Cassel wrote: > > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > > > Signed-off-by: Niklas Cassel > > Note to myself, I see these dependencies in linux-next

Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle

2018-06-29 Thread Niklas Cassel
On Fri, Jun 29, 2018 at 04:51:51PM +0300, Kalle Valo wrote: > Niklas Cassel writes: > > > On Fri, Jun 29, 2018 at 02:53:44PM +0300, Kalle Valo wrote: > >> Kalle Valo writes: > >> > >> > Niklas Cassel writes: > >> > > >

Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle

2018-06-29 Thread Niklas Cassel
On Fri, Jun 29, 2018 at 02:53:44PM +0300, Kalle Valo wrote: > Kalle Valo writes: > > > Niklas Cassel writes: > > > >> All packets in a bundle should use the same endpoint id as the > >> first lookahead. > >> > >> This matches how t

[PATCH 3/3] ath10k: sdio: set skb len for all rx packets

2018-06-20 Thread Niklas Cassel
Without this, packets larger than 1500 will silently be dropped. Easily reproduced by sending a ping packet with a size larger than 1500. Signed-off-by: Alagu Sankar Signed-off-by: Niklas Cassel --- drivers/net/wireless/ath/ath10k/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle

2018-06-20 Thread Niklas Cassel
: ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224 ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12 ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12 Signed-off-by: Alagu Sankar Signed-off-by: Niklas Cassel --- drivers/net/wireless/ath/ath10k

[PATCH 0/3] ath10k: sdio: essential sdio fixes

2018-06-20 Thread Niklas Cassel
et working sdio support for ath10k. Other patches are needed to get working sdio support, including the high-latency patch series from Erik Stromdahl. Niklas Cassel (3): ath10k: sdio: use same endpoint id for all packets in a bundle ath10k: sdio: allocate correct size for RECV_1MORE_BLOCK

[PATCH 2/3] ath10k: sdio: allocate correct size for RECV_1MORE_BLOCK rx packets

2018-06-20 Thread Niklas Cassel
. Signed-off-by: Alagu Sankar Signed-off-by: Niklas Cassel --- drivers/net/wireless/ath/ath10k/htc.h | 1 + drivers/net/wireless/ath/ath10k/sdio.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index 348

Re: [PATCH v2 6/6] ath10k: Add QMI message handshake for wcn3990 client

2018-06-19 Thread Niklas Cassel
On Tue, Jun 05, 2018 at 06:07:32PM +0530, Govind Singh wrote: > Add WCN3990 QMI client handshakes for Q6 integrated WLAN connectivity > subsystem. This layer is responsible for communicating qmi control > messages to wifi fw QMI service using QMI messaging protocol. > > Qualcomm MSM

Re: [PATCH v2 5/6] firmware: qcom: scm: Add WLAN VMID for Qualcomm SCM interface

2018-06-19 Thread Niklas Cassel
Acked-by: Niklas Cassel On Tue, Jun 05, 2018 at 06:07:09PM +0530, Govind Singh wrote: > Add WLAN related VMID's to support wlan driver to set up > the remote's permissions call via TrustZone. > > Signed-off-by: Govind Singh > --- > include/linux/qcom_scm.h | 4 +++- &g

Re: [PATCH v2 2/6] ath10k: Add support to create boardname for non-bmi target

2018-06-19 Thread Niklas Cassel
Acked-by: Niklas Cassel On Tue, Jun 05, 2018 at 06:04:48PM +0530, Govind Singh wrote: > From: Rakesh Pillai > > Add support to create the boardname for non-bmi targets > like WCN3990, which uses qmi for bdf download. This > boardname is used to parse the board data f

Re: [PATCH v2 4/6] ath10k: Add debug mask for QMI layer

2018-06-19 Thread Niklas Cassel
Acked-by: Niklas Cassel On Tue, Jun 05, 2018 at 06:06:51PM +0530, Govind Singh wrote: > Add debug mask to control debug info of ath10k qmi > messaging layer. > > Signed-off-by: Govind Singh > --- > drivers/net/wireless/ath/ath10k/debug.h | 1 + > 1 file changed, 1 inserti

Re: [PATCH v2 1/6] ath10k: Add qmi service helpers for wcn3990 qmi client

2018-06-19 Thread Niklas Cassel
On Tue, Jun 05, 2018 at 06:03:40PM +0530, Govind Singh wrote: > WLAN qmi server running in Q6 exposes host to target > cold boot qmi handshakes. Add WLAN QMI service helpers > for ath10k wcn3990 qmi client. > > Signed-off-by: Govind Singh > --- > .../net/wireless/ath/ath10k/qmi_wlfw_v01.c|

Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST

2018-06-14 Thread Niklas Cassel
On Thu, Jun 14, 2018 at 05:09:04PM +0300, Kalle Valo wrote: > Niklas Cassel writes: > > > On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > >> On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > >> > On 201

Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST

2018-06-13 Thread Niklas Cassel
On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > > On 2018-06-12 17:45, Govind Singh wrote: > > > -Original Message- > > > From: ath10k On Behalf Of Niklas > > > Cassel >

[PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig

2018-06-12 Thread Niklas Cassel
Do not mix spaces and tabs in Kconfig. Signed-off-by: Niklas Cassel --- drivers/net/wireless/ath/ath10k/Kconfig | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig index

[PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST

2018-06-12 Thread Niklas Cassel
ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. Signed-off-by: Niklas Cassel --- drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k

Re: [PATCH net-next] ath10k: make some functions static

2018-06-04 Thread Niklas Cassel
On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: > Wei Yongjun writes: > > > Fixes the following sparse warnings: > > > > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: > > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be > > static? > >

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-25 Thread Niklas Cassel
On Fri, May 25, 2018 at 08:50:23AM -0400, Bob Copeland wrote: > On Fri, May 25, 2018 at 02:36:56PM +0200, Niklas Cassel wrote: > > A spin lock does have the advantage of ordering: memory operations issued > > before the spin_unlock_bh() will be completed before the spin_unlock_bh(

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-25 Thread Niklas Cassel
On Thu, May 24, 2018 at 11:50:34AM -0400, Bob Copeland wrote: > On Mon, May 21, 2018 at 10:37:01PM +0200, Niklas Cassel wrote: > > On Thu, May 17, 2018 at 03:26:25PM -0700, Adrian Chadd wrote: > > > On Thu, 17 May 2018 at 16:16, Niklas Cassel <niklas.cas...@li

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Niklas Cassel
On Wed, May 23, 2018 at 06:25:49PM +0200, Erik Stromdahl wrote: > > > On 05/22/2018 11:15 PM, Niklas Cassel wrote: > > > > > > > > Earlier we observed performance issues in calling push_pending from each > > > tx completion. IMHO this change may in

Re: [PATCH v3] ath10k: transmit queued frames after processing rx packets

2018-05-23 Thread Niklas Cassel
On Thu, May 24, 2018 at 12:15:08AM +0200, Niklas Cassel wrote: > This problem cannot be reproduced on low-latency devices, e.g. pci, > since they call ath10k_mac_tx_push_pending() from > ath10k_htt_txrx_compl_task(). ath10k_htt_txrx_compl_task() is not called > on high-latency de

[PATCH v3] ath10k: transmit queued frames after processing rx packets

2018-05-23 Thread Niklas Cassel
we are calling ath10k_mac_tx_push_pending() directly, we also need to export it. Signed-off-by: Niklas Cassel <niklas.cas...@linaro.org> --- Changes since V2: Moved ath10k_mac_tx_push_pending() call to ath10k_sdio_irq_handler(). drivers/net/wireless/ath/ath10k/mac.c | 1 + drivers/net/wi

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-22 Thread Niklas Cassel
On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: > On 2018-05-21 13:43, Niklas Cassel wrote: > > The following problem was observed when running iperf: > [...] > > > > In order to avoid trying to flush the queue every time we free a frame, > >

[PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-21 Thread Niklas Cassel
or less frames pending, and while we actually have frames in the queue. This logic was copied from mt76_txq_schedule (mt76), one of few other drivers that are actually using wake_tx_queue. Suggested-by: Toke Høiland-Jørgensen <t...@toke.dk> Signed-off-by: Niklas Cassel <niklas.cas...@l

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-21 Thread Niklas Cassel
On Thu, May 17, 2018 at 03:26:25PM -0700, Adrian Chadd wrote: > On Thu, 17 May 2018 at 16:16, Niklas Cassel <niklas.cas...@linaro.org> > wrote: > > > diff --git a/drivers/net/wireless/ath/ath10k/txrx.c > b/drivers/net/wireless/ath/ath10k/txrx.c > > index cda

Re: ath10k wake_tx_queue issues

2018-05-17 Thread Niklas Cassel
On Wed, May 16, 2018 at 07:28:21PM +0200, Erik Stromdahl wrote: > Hello Niklas > > Quick question: > Are you using my patch: "ath10k: add htt_tx num_pending window"? Nope, but I definitely think that your patch should be merged, since the current code can lock/unlock/lock a lot of times for no

[PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Niklas Cassel
or less frames pending, and while we actually have frames in the queue. This logic was copied from mt76_txq_schedule (mt76), one of few other drivers that are actually using wake_tx_queue. Suggested-by: Toke Høiland-Jørgensen <t...@toke.dk> Signed-off-by: Niklas Cassel <niklas.cas...@l

Re: ath10k wake_tx_queue issues

2018-05-15 Thread Niklas Cassel
On Tue, May 15, 2018 at 04:13:48PM +0200, Toke Høiland-Jørgensen wrote: > [ Adding Felix ] > > > Niklas Cassel <niklas.cas...@linaro.org> writes: > > > Hello mac80211 and ath10k people > > > > Using ath10k, TX stops working when running iperf > > >

ath10k wake_tx_queue issues

2018-05-15 Thread Niklas Cassel
Hello mac80211 and ath10k people Using ath10k, TX stops working when running iperf [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec [ 3] 3.0- 4.0 sec 655 KBytes 5.36 Mbits/sec [ 3] 4.0- 5.0