[PATCHv2 0/4] Add support to dump tx stats histogram

2018-09-04 Thread akolli
From: Anilkumar Kolli This patch series adds support to dump per station tx stats histogram. These stats can be enabled through ath10k/enable_extd_tx_stats debugfs entry, enabling this may impact in cpu usage and throughput. ath10k/enable_extd_tx_stats is disabled by default. Tx histogram has

[PATCHv2 2/4] ath10k: add debugfs entry to enable extended tx stats

2018-09-04 Thread akolli
From: Anilkumar Kolli This patch adds debugfs entry to enable/disable extended tx statistics. Extended tx statistics are from peer stats feature. Signed-off-by: Anilkumar Kolli --- V2: - fix kbuild error: 'struct ath10k' has no member named 'debug' drivers/net/wireless/ath/ath10k/core.h |

Re: [PATCH v2] ath10k: Implement get_expected_throughput callback

2018-03-28 Thread akolli
On 2018-03-26 12:52, Sven Eckelmann wrote: On Freitag, 23. März 2018 19:37:14 CEST Anilkumar Kolli wrote: +static u32 ath10k_get_expected_throughput(struct ieee80211_hw *hw, + struct ieee80211_sta *sta) +{ + struct ath10k_sta *arsta = (struct

Re: [PATCH] ath10k: Implement get_expected_throughput callback

2018-03-23 Thread akolli
On 2018-03-23 19:14, Johannes Berg wrote: On Fri, 2018-03-23 at 19:11 +0530, ako...@codeaurora.org wrote: > > + > > + sinfo->expected_throughput = > > + > > ewma_sta_txrate_read(>ave_sta_txrate); > > + sinfo->filled |= > > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT); > > +} Yes.

Re: [PATCH] ath10k: Implement get_expected_throughput callback

2018-03-23 Thread akolli
Hi Sven, Thanks for the review. On 2018-03-23 13:39, Sven Eckelmann wrote: On Freitag, 23. März 2018 13:07:00 CET Anilkumar Kolli wrote: [...] +static u32 ath10k_get_expected_throughput(struct ieee80211_hw *hw, + struct ieee80211_sta *sta) +{ +

Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters

2018-03-05 Thread akolli
On 2018-03-05 13:12, Sven Eckelmann wrote: On Montag, 5. März 2018 12:29:08 CET Anilkumar Kolli wrote: @@ -496,6 +497,8 @@ struct ath10k_debug { u32 reg_addr; u32 nf_cal_period; void *cal_data; + u32 fw_test_param_id; + u32 fw_test_param_value; }; Why is

Re: [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal

2017-12-11 Thread akolli
On 2017-12-08 19:10, Sven Eckelmann wrote: On Freitag, 8. Dezember 2017 18:05:38 CET ako...@codeaurora.org wrote: On 2017-12-08 17:42, Sven Eckelmann wrote: > On Donnerstag, 25. Mai 2017 16:21:23 CET ako...@qti.qualcomm.com wrote: >> From: Anilkumar Kolli >> >>

Re: [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal

2017-12-08 Thread akolli
On 2017-12-08 17:42, Sven Eckelmann wrote: On Donnerstag, 25. Mai 2017 16:21:23 CET ako...@qti.qualcomm.com wrote: From: Anilkumar Kolli QCA99X0, QCA9888, QCA9984 supports calibration data in either OTP or DT/pre-cal file. Current ath10k supports Calibration data from

[PATCHv2 1/3] ath10k: remove MAC80211_DEBUGFS dependency on ath10k_sta_statistics

2017-12-05 Thread akolli
From: Anilkumar Kolli Remove CONFIG_MAC80211_DEBUGFS dependency on ath10k_sta_statistics(). ath10k_sta_statistics() has per sta tx/rx stats and this should not be dependent on MAC80211_DEBUGFS. No changes in functionality. Signed-off-by: Anilkumar Kolli

[PATCHv2 2/3] ath10k: move pktlog_filter out of ath10k_debug

2017-12-05 Thread akolli
From: Anilkumar Kolli Move pktlog_filter from struct ath10k_debug to struct ath10k so that pktlog can be enabled even when debugfs is not enabled, needed to enable peer tx stats for 10.2.4. No changes in functionality. Signed-off-by: Anilkumar Kolli

[PATCHv2 3/3] ath10k: add per peer tx stats support for 10.2.4

2017-12-05 Thread akolli
From: Anilkumar Kolli 10.2.4 firmware branch (used in QCA988X) does not support HTT_10_4_T2H_MSG_TYPE_PEER_STATS and that's why ath10k does not provide tranmission rate statistics to user space, instead it just shows hardcoded 6 Mbit/s. But pktlog firmware facility

[PATCHv2 0/3] ath10k: tx stats for 10.2.4

2017-12-05 Thread akolli
From: Anilkumar Kolli Add tx stats supoort for QCA988X. Parse peer stats from pktlog packets and update the tx rate information per STA. This way user space can query about transmit rate with iw. V2: - Added patch ath10k: remove MAC80211_DEBUGFS dependency on

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
On 2017-12-04 19:53, Maxime Bizon wrote: On Mon, 2017-12-04 at 18:54 +0530, ako...@codeaurora.org wrote: Hope 10.2.4-1.0-00029 Firmware binary works for you. it does I will check this warning. fixed by applying patch: "[PATCH] ath10k: fix recent bandwidth conversion bug" as suggested

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
On 2017-12-01 20:35, Maxime Bizon wrote: On Fri, 2017-12-01 at 19:18 +0530, ako...@codeaurora.org wrote: Hope CONFIG_MAC80211_DEBUGFS is enabled in your build. it wasn't and IMHO it's confusing because tx rate is filled by the other drivers without it. I now have the following warning: [

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
Parse peer stats from pktlog packets and update the tx rate information per STA. This way user space can query about transmit rate with iw: everything works ok, ath10k_update_per_peer_tx_stats() is called and ath10k_sta fields are updated correctly but tx bitrate is still 6 MBit/s in

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread akolli
Hello, Thanks for verifying the patch. On 2017-12-01 16:15, Maxime Bizon wrote: On Thu, 2017-11-30 at 18:28 +0530, ako...@qti.qualcomm.com wrote: Hello, Tested on QCA9880 with firmware version 10.2.4.70.48. This should also work with firmware branch 10.2.4-1.0-00029 I tried using your

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-11-30 Thread akolli
On 2017-11-30 22:08, Kalle Valo wrote: Toke Høiland-Jørgensen writes: +struct ath10k_10_2_peer_tx_stats { + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; + u8

[PATCH 0/2] ath10k: tx stats for 10.2.4

2017-11-30 Thread akolli
From: Anilkumar Kolli Add tx stats supoort for QCA988X. Parse peer stats from pktlog packets and update the tx rate information per STA. This way user space can query about transmit rate with iw. Anilkumar Kolli (2): ath10k: move pktlog_filter out of ath10k_debug

[PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug

2017-11-30 Thread akolli
From: Anilkumar Kolli Move pktlog_filter from struct ath10k_debug to struct ath10k so that pktlog can be enabled even when debugfs is not enabled, needed to enable peer tx stats for 10.2.4. No changes in functionality. Signed-off-by: Anilkumar Kolli

Re: ath10k: Fix reported HT MCS rates with NSS > 1

2017-11-20 Thread akolli
On 2017-11-20 17:40, Kalle Valo wrote: Peter Oh writes: On 11/06/2017 01:02 AM, Sven Eckelmann wrote: On Montag, 6. November 2017 09:28:42 CET Sebastian Gottschall wrote: Am 06.11.2017 um 09:23 schrieb Sven Eckelmann: On Sonntag, 5. November 2017 10:22:22 CET

[PATCH] ath10k: fix sending wmi cmd during the tdls teardown

2017-10-05 Thread akolli
From: Anilkumar Kolli The current firmware 10.4-3.5.1-00035 on QCA9888 supports TDLS explicit mode, it expects WMI_TDLS_ENABLE_PASSIVE for tdls setup and WMI_TDLS_DISABLE for tdls teardown. Signed-off-by: Anilkumar Kolli ---

[PATCH 2/2] ath10k: block offchannel operations if TDLS session is active

2017-10-05 Thread akolli
From: Anilkumar Kolli Do not allow off channel operations like scans/roc when there are active TDLS sessions. The Current firmware 10.4-3.5.1-00035 on QCA9888 does not supports any offchannel operations on active TDLS sessions, either driver needs to block the

[PATCH 1/2] ath10k: move ath10k_mac_tdls_vif*() functions

2017-10-05 Thread akolli
From: Anilkumar Kolli To be able to use ath10k_mac_tdls_vif_stations_count() in ath10k_hw_scan() in the following patch, move the functions earlier in the file. This commit is pure code move, no functional changes. Signed-off-by: Anilkumar Kolli

[PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal

2017-05-25 Thread akolli
From: Anilkumar Kolli QCA99X0, QCA9888, QCA9984 supports calibration data in either OTP or DT/pre-cal file. Current ath10k supports Calibration data from OTP only. If caldata is loaded from DT/pre-cal file, fetching board id and applying calibration parameters like tx

Re: QCA4019: calibration files and board files

2017-02-09 Thread akolli
On 2017-02-08 16:33, Sven Eckelmann wrote: Hi Anilkumar Kolli, we've noticed that your change in QSDK [1] removed the call to ath10k_download_and_run_otp in ath10k_download_cal_data after the call to ath10k_core_get_board_id_from_otp. We reported [2] this to ath10k when we asked for some

[PATCHv3 2/2] ath10k: add support for per sta tx bitrate

2016-11-15 Thread akolli
From: Anilkumar Kolli Per STA tx bitrate info is filled from peer stats. Export per sta txrate info to cfg80211/nl80211 Signed-off-by: Anilkumar Kolli --- v2: * address Kalle's comments drivers/net/wireless/ath/ath10k/debugfs_sta.c | 13

[PATCHv2 2/2] ath10k: add support for per sta tx bitrate

2016-10-18 Thread akolli
From: Anilkumar Kolli Per STA tx bitrate info is filled from peer stats. Export per sta txrate info to cfg80211/nl80211 Signed-off-by: Anilkumar Kolli --- v2: * addressed kalle's comments drivers/net/wireless/ath/ath10k/debugfs_sta.c | 13

[PATCHv2 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-18 Thread akolli
From: Anilkumar Kolli Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' event, Firmware sends one HTT event for every four PPDUs. HTT payload has success pkts/bytes, failed pkts/bytes, retry pkts/bytes and rate info per ppdu. Peer stats are enabled through

[PATCHv2 0/2] ath10k: add support for tx bitrate

2016-10-18 Thread akolli
From: Anilkumar Kolli This patch series adds support for tx bitrate using .sta_statistics callback. tx bitrate tested on QCA4019 using iw. Anilkumar Kolli (2): ath10k: add per peer htt tx stats support for 10.4 ath10k: add support for per sta tx bitrate

[PATCHv2 0/2] ath10k: add support for tx bitrate

2016-10-18 Thread akolli
From: Anilkumar Kolli This patch series adds support for tx bitrate using .sta_statistics callback. tx bitrate tested on QCA4019 using iw. Anilkumar Kolli (2): ath10k: add per peer htt tx stats support for 10.4 ath10k: add support for per sta tx bitrate

[PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-18 Thread akolli
From: Anilkumar Kolli Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' event, Firmware sends one HTT event for every four PPDUs. HTT payload has success pkts/bytes, failed pkts/bytes, retry pkts/bytes and rate info per ppdu. Peer stats are enabled through

[PATCHv2 0/2] ath10k: add support for tx bitrate

2016-10-18 Thread akolli
From: Anilkumar Kolli This patch series adds support for tx bitrate using .sta_statistics callback. tx bitrate tested on QCA4019 using iw. Anilkumar Kolli (2): ath10k: add per peer htt tx stats support for 10.4 ath10k: add support for per sta tx bitrate

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-17 Thread akolli
On 2016-10-12 10:29, Valo, Kalle wrote: writes: From: Anilkumar Kolli Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' event, Firmware sends one HTT event for every four PPDUs. HTT payload has success pkts/bytes, failed

[PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-07 Thread akolli
From: Anilkumar Kolli Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' event, Firmware sends one HTT event for every four PPDUs. HTT payload has success pkts/bytes, failed pkts/bytes, retry pkts/bytes and rate info per ppdu. Peer stats are enabled through

[PATCH 2/2] ath10k: add support for per sta tx bitrate

2016-10-07 Thread akolli
From: Anilkumar Kolli Per STA tx bitrate info is filled from peer stats. Export per sta txrate info to cfg80211/nl80211 Signed-off-by: Anilkumar Kolli --- drivers/net/wireless/ath/ath10k/debugfs_sta.c | 13 + 1 file changed, 13

[PATCH 0/2] ath10k: add support for tx bitrate

2016-10-07 Thread akolli
From: Anilkumar Kolli This patch series adds support for tx bitrate using .sta_statistics callback. tx bitrate tested on QCA4019 using iw. Anilkumar Kolli (2): ath10k: add per peer htt tx stats support for 10.4 ath10k: add support for per sta tx bitrate

[PATCH] ath10k: add cc_wraparound type for QCA9888 and QCA9884

2016-09-16 Thread akolli
From: Anilkumar Kolli During offchannel scan, iw survey dump shows wrong values. Fix this by assigning cycle counter wranarround type for QCA9888 and QCA9884, they share same config with QCA4019. Signed-off-by: Anilkumar Kolli ---

[PATCH 2/2] ath10k: Enable support for QCA9888

2016-06-20 Thread akolli
From: Anilkumar Kolli QCA9888 shares the same configuration with QCA99X0 with NSS=2. Signed-off-by: Anilkumar Kolli --- drivers/net/wireless/ath/ath10k/core.c | 26 ++ drivers/net/wireless/ath/ath10k/hw.c |9

[PATCH 1/2] ath10k: remove unused member in ath10k_hw_regs

2016-06-20 Thread akolli
From: Anilkumar Kolli rtc_state_cold_reset_mask is unused in ath10k_hw_regs. instead fixed delays are used. Signed-off-by: Anilkumar Kolli --- drivers/net/wireless/ath/ath10k/hw.c |3 --- drivers/net/wireless/ath/ath10k/hw.h |2 -- 2

[PATCH v2] ath10k: fix debugfs pktlog_filter write

2016-03-10 Thread akolli
From: Anilkumar Kolli It is observed that, we are disabling the packet log if we write same value to the pktlog_filter for the second time. Always enable pktlogs on non zero filter. Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter") Cc:

[PATCH] ath10k: fix debugfs pktlog_filter write

2016-03-10 Thread akolli
From: Anilkumar Kolli It is observed that, we are disabling the packet log if we write same value to the pktlog_filter for the second time. Always enable pktlogs on non zero filter. Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter") Signed-off-by:

[PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0

2015-09-28 Thread akolli
From: Anilkumar Kolli This patch disables PCI PS for QCA988X and QCA99X0, Since PCI PS is validated for QCA6174, let it be enabled only for QCA6174. It would be better to execute PCI PS related functions only for the supported devices. PCI time out issue is observed