Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-09-24 Thread Kalle Valo
Erik Stromdahl wrote: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > > The reason for this is most likely that the per-ac lock (active_txq_lock) > in mac80211 will be held by the CPU iterating the

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-09-24 Thread Kalle Valo
Erik Stromdahl wrote: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > > The reason for this is most likely that the per-ac lock (active_txq_lock) > in mac80211 will be held by the CPU iterating the

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-26 Thread Kalle Valo
Erik Stromdahl writes: > On 4/16/19 9:07 PM, Toke Høiland-Jørgensen wrote: >> Erik Stromdahl writes: >> >>> On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: Erik Stromdahl writes: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-17 Thread Erik Stromdahl
On 4/16/19 9:07 PM, Toke Høiland-Jørgensen wrote: Erik Stromdahl writes: On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: Erik Stromdahl writes: Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems.

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-16 Thread Toke Høiland-Jørgensen
Erik Stromdahl writes: > On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: >> Erik Stromdahl writes: >> >>> Iterating the TX queue and thereby dequeuing all available packets in the >>> queue could result in performance penalties on some SMP systems. >>> >>> The reason for this is most likely

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-16 Thread Erik Stromdahl
On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: Erik Stromdahl writes: Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems. The reason for this is most likely that the per-ac lock (active_txq_lock) in

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-01 Thread Yibo Zhao
On 2019-03-29 15:47, Erik Stromdahl wrote: On 3/27/19 6:49 PM, Peter Oh wrote: On 03/27/2019 09:29 AM, Erik Stromdahl wrote: Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems. Please share the test

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-01 Thread Toke Høiland-Jørgensen
Erik Stromdahl writes: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > > The reason for this is most likely that the per-ac lock (active_txq_lock) > in mac80211 will be held by the CPU iterating the

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-03-29 Thread Erik Stromdahl
On 3/27/19 6:49 PM, Peter Oh wrote: On 03/27/2019 09:29 AM, Erik Stromdahl wrote: Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems. Please share the test results and numbers you've run to help others

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-03-27 Thread Peter Oh
On 03/27/2019 09:29 AM, Erik Stromdahl wrote: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > Please share the test results and numbers you've run to help others thoughts. Thanks, Peter

[PATCH] ath10k: remove iteration in wake_tx_queue

2019-03-27 Thread Erik Stromdahl
Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems. The reason for this is most likely that the per-ac lock (active_txq_lock) in mac80211 will be held by the CPU iterating the current queue. This will lock up