Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-18 Thread Yibo Zhao
On 2019-09-18 18:16, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: On 2019-09-18 05:12, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: On 2019-09-16 23:27, Johannes Berg wrote: Without really looking at the code - If station is ineligible for transmission in

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-18 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-18 05:12, Toke Høiland-Jørgensen wrote: >> Yibo Zhao writes: >> >>> On 2019-09-16 23:27, Johannes Berg wrote: Without really looking at the code - > If station is ineligible for transmission in > ieee80211_txq_may_transmit(), > no packet

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-16 23:27, Johannes Berg wrote: >> Without really looking at the code - >> >>> If station is ineligible for transmission in >>> ieee80211_txq_may_transmit(), >>> no packet will be delivered to FW. During the tests in push-pull mode >>> with >>> many clients,

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-17 Thread Johannes Berg
On Tue, 2019-09-17 at 14:36 +0800, Yibo Zhao wrote: > > Do you mean it should be something like: > > Co-developed-by: Toke Høiland-Jørgensen > Signed-off-by: Yibo Zhao > Signed-off-by: Toke Høiland-Jørgensen Yes, I think you mean the right thing. For the record, it seems to me it should be

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-17 Thread Yibo Zhao
On 2019-09-16 23:27, Johannes Berg wrote: Without really looking at the code - If station is ineligible for transmission in ieee80211_txq_may_transmit(), no packet will be delivered to FW. During the tests in push-pull mode with many clients, after several seconds, not a single station is an

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-16 Thread Johannes Berg
Without really looking at the code - > If station is ineligible for transmission in ieee80211_txq_may_transmit(), > no packet will be delivered to FW. During the tests in push-pull mode with > many clients, after several seconds, not a single station is an eligible > candidate for transmission

[PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-16 Thread Yibo Zhao
If station is ineligible for transmission in ieee80211_txq_may_transmit(), no packet will be delivered to FW. During the tests in push-pull mode with many clients, after several seconds, not a single station is an eligible candidate for transmission since global time is smaller than all the