[PATCH] ath10k: Fix the tx stats bytes & packets parsing

In tx_stats debugfs, txrate->flags may contain multiple bits. For example, RATE_INFO_FLAGS_SHORT_GI could be set, and tx stats bytes and packets will be not updated correctly. Fix this issue by using bit operation to check txrate->flags. Tested HW: QCA9984 Tested Firmware: 10.4-3.9.0.1-7

Re: FW: [PATCH] ath10k: fix return value check in wake_tx_q op

On 2019-03-11 14:44, Erik Stromdahl wrote: Hi Yibo, Sorry for a late reply, but I have been busy with other projects lately. I have added my comments below On 3/4/19 2:56 AM, Yibo Zhao wrote: 在 2019-02-25 12:40，Yibo Zhao 写道： 在 2019-02-07 22:25，Kalle Valo 写道： Yibo Zhao writes: I have a

Re: FW: [PATCH] ath10k: fix return value check in wake_tx_q op

Hi Yibo, Sorry for a late reply, but I have been busy with other projects lately. I have added my comments below On 3/4/19 2:56 AM, Yibo Zhao wrote: 在 2019-02-25 12:40，Yibo Zhao 写道： 在 2019-02-07 22:25，Kalle Valo 写道： Yibo Zhao writes: We have met performance issue on our two-core system

Re: [PATCHv3 8/9] ath10k: Add new api to support TID specific configuration

Hi Tamizh, url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-Add-support-for-TID-specific-configuration/20190308-195433 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master smatch warnings:

[PATCHv4 5/9] nl80211: Add netlink attribute to configure TID specific tx rate

Introduce NL80211_ATTR_TID_CONFIG_TX_RATES in nl80211_attr_tid_config to accept data TID specific TX bitrate configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the this configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID attribute. TX bitrate mask values

[PATCHv4 7/9] ath10k: Add wmi command support for station specific TID config

This patch adds WMI interface to configure station specific TID configuration . Host needs to send station's MAC address along with TID number and its configuration to target through WMI_10_4_PER_PEER_PER_TID_CONFIG_CMDID. WMI_SERVICE_PEER_TID_CONFIGS_SUPPORT flag is added to advertise this

[PATCHv4 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS

Introduce NL80211_ATTR_TID_CONFIG_RTSCTS_CTRL in nl80211_attr_tid_config to accept TID specific RTS_CTS enable/disable configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the RTS_CTS control configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID attribute. When

[PATCHv4 2/9] nl80211: Add new netlink attribute for TID speicific retry count

This patch introduced below NL attributes to add support for configuring data TID specific retry count NL80211_ATTR_TID_CONFIG_RETRY NL80211_ATTR_TID_CONFIG_RETRY_LONG NL80211_ATTR_TID_CONFIG_RETRY_SHORT These attributes are added in NL80211_ATTR_TID_CONFIG nested attribute. This will be useful

[PATCHv4 0/9] cfg80211/mac80211: Add support for TID specific configuration

Add infrastructure to support per TID configurations like noack policy, retry count, AMPDU control(disable/enable), RTSCTS control(enable/disable) and TX rate mask configurations. This will be useful for the driver which can supports data TID specific configuration rather than phy level

[PATCHv4 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable

Introduce NL80211_ATTR_TID_CONFIG_AMPDU_CTRL in nl80211_attr_tid_config to accept TID specific AMPDU aggregation enable/disable configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the aggregation control configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID

[PATCHv4 9/9] ath10k: Add extended TID configuration support

This patch extend TID configuration support to configure RTS_CTS control and TX rate limit. Tx rate limit is similar to auto rate but it will be limited to the user configured rate mask rather than the station's highest supported rate mask. Here ext_tid_cfg_bitmap added to notify the target which

[PATCHv4 8/9] ath10k: Add new api to support TID specific configuration

This patch add ops for set_tid_config to support TID specific configuration. STA information along with the TID config change mask to notify driver that which configuration needs to be applied for this current command. If the STA info not available in the command then the configuration will be

[PATCHv4 1/9] nl80211: New netlink command for TID specific configuration

Add a new NL command, NL80211_CMD_SET_TID_CONFIG to support data TID specific configuration. This per TID configurations are passed in NL80211_ATTR_TID_CONFIG which is a nested attribute. This patch adds support to configure per TID noack policy through NL80211_ATTR_TID_CONFIG_NOACK attribute.

[PATCHv4 6/9] mac80211: Add api to support configuring TID specific configuration

Implement drv_set_tid_config api to allow TID specific configuration. This per-TID configuration will be applied for all the connected stations when MAC is NULL. Signed-off-by: Tamizh chelvam --- include/net/mac80211.h| 38 ++ net/mac80211/cfg.c

[PATCH] ath10k: avoid leaving .bss_info_changed prematurely

From: Sven Eckelmann ath10k_bss_info_changed() handles various events from the upper layers. It parses the changed bitfield and then configures the driver/firmware accordingly. Each detected event is handled in a separate scope which is independent of each other - but in the same function. The

[ath6kl:ath11k-bringup 3/44] drivers/net/wireless/ath/ath11k/mac.c:2186 ath11k_set_key() warn: impossible condition '(arvif->def_wep_key_index == -1) => (0-255 == (-1))'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: e495d474d12aaf6e6288bf7cb3ba0eab4888f27f commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/44] ath11k: add driver New smatch warnings: drivers/net/wireless/ath/ath11k/mac.c:2186 ath11k_set_key() warn:

[PATCH 2/2] ath10k: Fix NSS tx stats for legacy rates

The ratecode field given by firmware in the tx stats gives the details of NSS and MCS, if the preamble specifies that it is HT/VHT. In case of OFDM/CCK, as specified by the preamble, the ratecode indicates the legacy rate instead of NSS/MCS data. For OFDM/CCK cases, the NSS should always be 1,

[PATCH 1/2] ath10k: Fix rate table updation in tx stats

The index for updating rate table, which is displayed in the tx stats via debugfs, is calculated using the bandwidth value. The bandwidth values do not map correctly with the bandwidth values shown in the rate table. Correct the bandwidth value calculation which is used to calculate the index for

[PATCH 0/2] Fix tx stats inconsistencies

The rate table indexes and the NSS values are incorrect, causing the tx stats to be displayed incorrectly. This patchset fix these issues in the tx stats displayed via debugfs. Rakesh Pillai (2): ath10k: Fix rate table updation in tx stats ath10k: Fix NSS tx stats for legacy rates

Re: [PATCH 1/2] ath10k: Fix rate table updation in tx stats

Hi Rakesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on next-20190306] [cannot apply to v5.0] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] ath10k: Fix rate table updation in tx stats

Hi Rakesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on next-20190306] [cannot apply to v5.0] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: