[PATCH v2 4/5] ath10k: Clean up peer when sta goes away.

From: Ben Greear If WMI and/or firmware has issues removing the peer object, then we still need to clean up the peer object in the driver. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 12 ++-- 1 file changed,

[PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.

From: Ben Greear Not sure this can happen, but seems like a reasonable sanity check. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/txrx.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 2/5] ath10k: Ensure peer_map references are cleaned up.

From: Ben Greear While debugging OS crashes due to firmware crashes, I enabled kasan, and it noticed that peer objects were being used-after-freed. Looks like there are two places we could be leaving stale references in the peer-map, so clean that up. Signed-off-by:

[PATCH v2 5/5] ath10k: Fix deadlock when peer cannot be created.

From: Ben Greear We must not attempt to send WMI packets while holding the data-lock, as it may deadlock: BUG: sleeping function called from invalid context at drivers/net/wireless/ath/ath10k/wmi.c:1824 in_atomic(): 1, irqs_disabled(): 0, pid: 2878, name:

[PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

From: Ben Greear Otherwise, the txrx-compl-task may access some bad memory? Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c

Re: [PATCH 1/3] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

On 03/31/2016 11:12 PM, Michal Kazior wrote: On 31 March 2016 at 22:59, wrote: From: Ben Greear Otherwise, the txrx-compl-task may access some bad memory? Signed-off-by: Ben Greear ---

Re: [PATCH 3/3] ath10k: Add BUG_ON if we over-write peer-map pointer.

On 03/31/2016 11:09 PM, Michal Kazior wrote: On 31 March 2016 at 22:59, wrote: From: Ben Greear Not sure this can happen, but seems like a reasonable sanity check. Signed-off-by: Ben Greear ---

Re: [RFC] ath10k: implement dql for htt tx

Re-posting text only as it was blocked by most mailing list servers: The original attachment can be fetched at: http://kazikcz.github.io/dl/2016-04-01-flent-ath10k-dql.tar.gz On 25 March 2016 at 10:55, Michal Kazior wrote: > On 25 March 2016 at 10:39, Michal Kazior

Re: Ath10k seems to be using stale mac80211 txq references.

On 31 March 2016 at 23:57, Ben Greear wrote: > On 03/31/2016 02:30 PM, Ben Greear wrote: >> >> hacked 4.4.6 (with most of linux.ath ath10k patches backported), hacked >> 10.4.3 firmware. >> >> I enabled kasan to help track down various bugs. This one has me a bit >>

Re: hacked 4.4.6+, 10.4.3 firmware, Running out of ring-index for pipe-id 3 (WMI).

On 1 April 2016 at 07:23, Ben Greear wrote: > > > On 03/31/2016 10:18 PM, Michal Kazior wrote: >> >> On 31 March 2016 at 18:44, Ben Greear wrote: >>> >>> On 03/30/2016 11:51 PM, Michal Kazior wrote: > > >>> >>> So, I am using MSI-X, I guess? >>>

Re: [PATCH 2/3] ath10k: Ensure peer_map references are cleaned up.

On 31 March 2016 at 22:59, wrote: [...] > @@ -812,6 +813,15 @@ static void ath10k_peer_cleanup(struct ath10k *ar, u32 > vdev_id) > ar->peer_map[peer_id] = NULL; > } > > + /* Double check that peer is properly

Re: [PATCH 1/3] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

On 31 March 2016 at 22:59, wrote: > From: Ben Greear > > Otherwise, the txrx-compl-task may access some bad memory? > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ > 1 file

Re: [PATCH 3/3] ath10k: Add BUG_ON if we over-write peer-map pointer.

On 31 March 2016 at 22:59, wrote: > From: Ben Greear > > Not sure this can happen, but seems like a reasonable sanity > check. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/txrx.c | 1 + > 1