Re: [Cocci] [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Julia Lawall
On Sat, 17 Oct 2020, Joe Perches wrote: > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > This is a upcoming change to clean up a new warning treewide. > > I am wondering if the change could be one mega patch (see below) or > > normal patch per file about

[ath6kl:pending 106/110] drivers/net/wireless/ath/ath10k/mac.c:3033:6-25: duplicated argument to && or || (fwd)

2020-08-19 Thread Julia Lawall
On line 3033 there are two occurrences of arvif->rate_ctrl[i] julia -- Forwarded message -- Date: Wed, 19 Aug 2020 09:21:21 +0800 From: kernel test robot To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall Subject: [ath6kl:pending 106/110] drivers/net/wireless/

[ath6kl:pending 90/99] drivers/net/wireless/ath/ath11k/debug_htt_stats.c:4613:2-8: preceding lock on line 4604 (fwd)

2020-05-07 Thread Julia Lawall
Hello, An unlock may be missing on line 4613. julia -- Forwarded message -- Date: Thu, 7 May 2020 20:37:55 +0800 From: kbuild test robot To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall Subject: [ath6kl:pending 90/99] drivers/net/wireless/ath/ath11k

[ath6kl:pending 21/34] drivers/net/wireless/ath/ath11k/dp_rx.c:3078:5-11: WARNING: Unsigned expression compared with zero: buf_id < 0 (fwd)

2020-03-04 Thread Julia Lawall
Hello, Please check on the use of buf_id on line 3078. Idr_alloc returns an int, not an unsigned value. julia -- Forwarded message -- Date: Wed, 4 Mar 2020 21:19:46 +0800 From: kbuild test robot To: kbu...@lists.01.org Cc: Julia Lawall Subject: [ath6kl:pending 21/34

[ath6kl:ath11k-bringup 66/93] drivers/net/wireless/ath/ath11k/core.c:722:2-8: preceding lock on line 718 (fwd)

2019-04-10 Thread Julia Lawall
An unlock seems to be missing on line 722. julia -- Forwarded message -- Date: Wed, 10 Apr 2019 13:54:47 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [ath6kl:ath11k-bringup 66/93] drivers/net/wireless/ath/ath11k/core.c:722:2-8: preceding lock

Re: [PATCH] ath11k: fix noderef.cocci warnings

2019-03-08 Thread Julia Lawall
On Fri, 8 Mar 2019, Kalle Valo wrote: > Julia Lawall writes: > > > From: kbuild test robot > > > > sizeof when applied to a pointer typed expression gives the size of > > the pointer > > > > Generated by: scripts/coccinelle/misc/noderef.cocci

[PATCH] ath11k: fix bugon.cocci warnings

2019-03-07 Thread Julia Lawall
From: kbuild test robot Use BUG_ON instead of if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash") CC: Venkateswara Naralasetty Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall

[ath6kl:ath11k-bringup 3/42] drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1965 (fwd)

2019-03-07 Thread Julia Lawall
? The message about unsigned in dp_tx.c is because the variable ring_entry_sz is declared as u32 (line 561). julia -- Forwarded message -- Date: Fri, 8 Mar 2019 05:28:10 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [ath6kl:ath11k-bringup 3/42] drivers/net

[PATCH] ath11k: fix itnull.cocci warnings

2019-03-07 Thread Julia Lawall
From: kbuild test robot Iterator variable bound on line 976 cannot be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci Fixes: 258bbf525e65 ("ath11k: add driver") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/li

[PATCH] ath11k: fix noderef.cocci warnings

2019-03-07 Thread Julia Lawall
From: kbuild test robot sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci Fixes: 258bbf525e65 ("ath11k: add driver") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tre

[PATCH] ath11k: fix semicolon.cocci warnings

2019-03-07 Thread Julia Lawall
From: kbuild test robot Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 258bbf525e65 ("ath11k: add driver") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.g

[ath6kl:pending 31/37] drivers/net/wireless/ath/ath10k/mac.c:5516:3-9: preceding lock on line 5476 (fwd)

2019-02-15 Thread Julia Lawall
It looks like a mutex_unlock(>conf_mutex); may be needed before ilne 5516. julia -- Forwarded message -- Date: Sat, 16 Feb 2019 04:08:51 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [ath6kl:pending 31/37] drivers/net/wireless/ath/ath10k/mac.c:551

[ath6kl:pending 11/35] drivers/net/wireless/ath/ath10k/htt_rx.c:2544:6-14: WARNING: Unsigned expression compared with zero: rate_idx < 0 (fwd)

2018-09-13 Thread Julia Lawall
rate_idx on line 2544 will not be less than 0. julia -- Forwarded message -- Date: Fri, 14 Sep 2018 13:15:09 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [ath6kl:pending 11/35] drivers/net/wireless/ath/ath10k/htt_rx.c:2544:6-14: WARNING

Re: [PATCH 2/4] ath10k: Add support to update btcoex priority value via nl80211

2016-11-09 Thread Julia Lawall
It seems possible that one might like to release the mutex lock before the return on line 7556. julia On Wed, 9 Nov 2016, kbuild test robot wrote: > Hi Tamizh, > > [auto build test WARNING on ath6kl/ath-next] > [cannot apply to v4.9-rc4 next-20161108] > [if your patch is applied to the wrong

[PATCH 8/8] ath10k: fix error return code

2014-12-29 Thread Julia Lawall
!= ret *if(...) { ... when != ret = e2 when forall return ret; } // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/ath/ath10k/htt_tx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers