[PATCH v2 5/7] wifi: brcm80211: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Arend van Spriel --- Depends on the patch in mmc tree. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2 7/7] wifi: wfx: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Kalle Valo --- Depends on the patch in mmc tree. --- drivers/net/wireless/silabs/wfx/bus_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net

[PATCH v2 4/7] wifi: ath10k: sdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Jeff Johnson --- Depends on the patch in mmc tree. --- drivers/net/wireless/ath/ath10k/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net

[PATCH v2 2/7] Bluetooth: btmtksdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the patch in mmc tree. --- drivers/bluetooth/btmtksdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth

[PATCH v2 6/7] wifi: mwifiex: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Kalle Valo Reviewed-by: Francesco Dolcini --- Depends on the patch in mmc tree. --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 - 1 file changed, 1 deletion

[PATCH v2 1/7] Bluetooth: btmrvl_sdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the patch in mmc tree. --- drivers/bluetooth/btmrvl_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers

[PATCH v2 0/7] mmc/wifi/bluetooth: store owner from modules with sdio_register_driver()

2024-04-03 Thread Krzysztof Kozlowski
this task away from the drivers to the core code, just like we did for platform_driver in commit 9447057eaff8 ("platform_device: use a macro instead of platform_driver_register"). Best regards, Krzysztof --- Krzysztof Kozlowski (7): Bluetooth: btmrvl_sdio: drop driver

[PATCH v2 3/7] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Acked-by: Jeff Johnson Acked-by: Kalle Valo Signed-off-by: Krzysztof Kozlowski --- Changes in v2 moved from other patchset to avoid conflicts. --- drivers/net/wireless/ath/ath10k

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:05, Marc Gonzalez wrote: > On 02/04/2024 17:55, Dmitry Baryshkov wrote: > >> On Tue, 2 Apr 2024 at 18:31, Marc Gonzalez wrote: >> >>> So, if I understand correctly, I take this to mean that I should: >>> >>> 1) DELETE the qcom,no-msa-ready-indicator boolean property, >>> 2) ADD a

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:50, Kalle Valo wrote: > Jeff Johnson writes: > >> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>> This driver's initialization functions do not perform any custom code, >>> except printing messages. Printing messages on modules >>> l

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:50, Kalle Valo wrote: > Jeff Johnson writes: > >> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>> This driver's initialization functions do not perform any custom code, >>> except printing messages. Printing messages on modules >>> l

Re: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-04-03 Thread Krzysztof Kozlowski
On 30/03/2024 23:04, Marc Gonzalez wrote: > On 30/03/2024 19:23, Krzysztof Kozlowski wrote: > >> On 30/03/2024 19:20, Krzysztof Kozlowski wrote: >> >>> On 28/03/2024 18:36, Marc Gonzalez wrote: >>> >>>> The ath10k driver waits for an "

Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()

2024-04-01 Thread Krzysztof Kozlowski
On 31/03/2024 22:37, Francesco Dolcini wrote: > Hello Krzysztof, > > On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote: >> Modules registering driver with sdio_register_driver() might >> forget to set .owner field. The field is used by

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-03-30 Thread Krzysztof Kozlowski
On 28/03/2024 18:39, Marc Gonzalez wrote: > The ath10k driver waits for an "MSA_READY" indicator > to complete initialization. If the indicator is not > received, then the device remains unusable. > > cf. ath10k_qmi_driver_event_work() > > Several msm8998-based devices are affected by this

Re: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-30 Thread Krzysztof Kozlowski
On 30/03/2024 19:20, Krzysztof Kozlowski wrote: > On 28/03/2024 18:36, Marc Gonzalez wrote: >> The ath10k driver waits for an "MSA_READY" indicator >> to complete initialization. If the indicator is not >> received, then the device remains unusable. >>

Re: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-30 Thread Krzysztof Kozlowski
On 28/03/2024 18:36, Marc Gonzalez wrote: > The ath10k driver waits for an "MSA_READY" indicator > to complete initialization. If the indicator is not > received, then the device remains unusable. > > cf. ath10k_qmi_driver_event_work() > > Several msm8998-based devices are affected by this

[PATCH 5/7] wifi: brcm80211: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/broadcom

[PATCH 7/7] wifi: silabs: wfx: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/net/wireless/silabs/wfx/bus_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c

[PATCH 6/7] wifi: marvell: mwifiex: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c

[PATCH 4/7] wifi: ath10k: sdio: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/net/wireless/ath/ath10k/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b

[PATCH 3/7] bluetooth: btmtksdio: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/bluetooth/btmtksdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth

[PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()

2024-03-29 Thread Krzysztof Kozlowski
iaTek WiFi drivers, Realtek WiFi drivers, rsi, siano, wilc1000, wl1251 and more. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/core/sdio_bus.c | 9 ++--- include/linux/mmc/sdio_func.h | 5 - 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/sdio_bus.c

[PATCH 2/7] bluetooth: btmrvl_sdio: drop driver owner initialization

2024-03-29 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch. --- drivers/bluetooth/btmrvl_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth

[PATCH 0/7] mmc/wifi/bluetooth: store owner from modules with sdio_register_driver()

2024-03-29 Thread Krzysztof Kozlowski
by moving this task away from the drivers to the core code, just like we did for platform_driver in commit 9447057eaff8 ("platform_device: use a macro instead of platform_driver_register"). Best regards, Krzysztof --- Krzysztof Kozlowski (7): mmc: sdio: store owner fr

[PATCH 3/6] wifi: rsi: sdio: simplify module initialization

2024-03-29 Thread Krzysztof Kozlowski
whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 31 + 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers

[PATCH 4/6] wifi: ti: wl1251: simplify module initialization

2024-03-29 Thread Krzysztof Kozlowski
whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ti/wl1251/sdio.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net

[PATCH 5/6] wifi: microchip: wilc1000: replace open-coded module_sdio_driver()

2024-03-29 Thread Krzysztof Kozlowski
Use module_sdio_driver() instead of open-coding it. No functional difference. Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/microchip/wilc1000/sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers

[PATCH 6/6] wifi: marvell: mwifiex: replace open-coded module_sdio_driver()

2024-03-29 Thread Krzysztof Kozlowski
Use module_sdio_driver() instead of open-coding it. No functional difference. Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net

[PATCH 2/6] wifi: ath6kl: sdio: simplify module initialization

2024-03-29 Thread Krzysztof Kozlowski
whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- --- drivers/net/wireless/ath/ath6kl/sdio.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net

[PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-03-29 Thread Krzysztof Kozlowski
whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- FYI: I have ongoing patchset touching few lines above this patch chunk (sdio_driver) which might go via different tree. If that patchset

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Krzysztof Kozlowski
On 04/03/2024 21:21, Dmitry Baryshkov wrote: > On Mon, 4 Mar 2024 at 22:17, Conor Dooley wrote: >> >> On Mon, Mar 04, 2024 at 09:59:13PM +0200, Dmitry Baryshkov wrote: >>> On Mon, 4 Mar 2024 at 21:46, Conor Dooley wrote: On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote:

Re: [PATCH] dt-bindings: net: wireless: qcom: Update maintainers

2024-02-20 Thread Krzysztof Kozlowski
On 17/02/2024 22:30, Jeff Johnson wrote: > Add Jeff Johnson as a maintainer of the qcom,ath1*k.yaml files. > > Signed-off-by: Jeff Johnson > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RFC 1/4] dt-bindings: net: wireless: ath10k: describe firmware-name property

2024-01-31 Thread Krzysztof Kozlowski
; > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 6 ++ > 1 file changed, 6 insertions(+) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH net-next 1/2] wifi: ath11k: fix Wvoid-pointer-to-enum-cast warning

2023-08-10 Thread Krzysztof Kozlowski
'hw_rev' is an enum, thus cast of pointer on 64-bit compile test with W=1 causes: h11k/ahb.c:1124:11: error: cast to smaller integer type 'enum ath11k_hw_rev' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ath/ath11k

[PATCH net-next 2/2] wifi: ath10k: fix Wvoid-pointer-to-enum-cast warning

2023-08-10 Thread Krzysztof Kozlowski
'hw_rev' is an enum, thus cast of pointer on 64-bit compile test with W=1 causes: ath10k/ahb.c:736:11: error: cast to smaller integer type 'enum ath10k_hw_rev' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ath/ath10k

Re: [PATCH v2] dt-bindings: net: wireless: ath10k: add ieee80211-freq-limit property

2023-06-12 Thread Krzysztof Kozlowski
uced so much that it makes no sense." > > The driver supported this since ~2018 by > commit 34d5629d2ca8 ("ath10k: limit available channels via DT > ieee80211-freq-limit") > > Link: > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=e3b8ae2b09e137ce2eae33551923d

Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML

2023-04-12 Thread Krzysztof Kozlowski
uld > be reconsidered on the driver side, especially the latter one. > > Somewhat based on the ath11k bindings. > > Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof ___ ath10k mailing list ath10k@lists.infr

Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-11 Thread Krzysztof Kozlowski
On 06/04/2023 14:55, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be reconsidered on the

Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-06 Thread Krzysztof Kozlowski
On 06/04/2023 20:26, Konrad Dybcio wrote: >>> +interrupts: >>> + items: >>> +- description: CE0 >>> +- description: CE1 >>> +- description: CE2 >>> +- description: CE3 >>> +- description: CE4 >>> +-

Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-06 Thread Krzysztof Kozlowski
On 06/04/2023 14:55, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be reconsidered on the

Re: [PATCH 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-06 Thread Krzysztof Kozlowski
On 06/04/2023 02:59, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be reconsidered on the

Re: [PATCH 2/2] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties

2023-04-06 Thread Krzysztof Kozlowski
On 06/04/2023 02:59, Konrad Dybcio wrote: > Drop the qcom,snoc-host-cap-skip-quirk that was never introduced to > solve schema warnings. > > Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof ___ at

Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply

2023-03-02 Thread Krzysztof Kozlowski
On 03/03/2023 03:42, Konrad Dybcio wrote: > Mention the newly added vdd-smps supply. There is no explanation here, but looking at your driver change it suggests name is not correct. You named it based on regulator (so the provider), not the consumer. Best regards, Krzysztof

Re: [PATCH] ath10k: do not enforce interrupt trigger type

2022-05-14 Thread Krzysztof Kozlowski
On 14/05/2022 20:09, Steev Klimaszewski wrote: >> wcn3990 hw1.0 target 0x0008 chip_id 0x sub : >> kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 >> firmware verĀ  api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 >> b3d4b790 >> htt-ver 3.86 wmi-op 4 htt-op 3 cal

Re: [PATCH] ath10k: do not enforce interrupt trigger type

2022-05-14 Thread Krzysztof Kozlowski
On 13/05/2022 17:57, Kalle Valo wrote: > Krzysztof Kozlowski writes: > >> Interrupt line can be configured on different hardware in different way, >> even inverted. Therefore driver should not enforce specific trigger >> type - edge rising - but instead rely on

[PATCH] ath10k: do not enforce interrupt trigger type

2022-05-13 Thread Krzysztof Kozlowski
763130] ath10k_snoc 1880.wifi: error -ENXIO: IRQ index 0 not found [ 44.763140] ath10k_snoc 1880.wifi: failed to initialize resource: -6 Fixes: c963a683e701 ("ath10k: add resource init and deinit for WCN3990") Signed-off-by: Krzysztof Kozlowski --- Separate question is