Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support

2023-02-21 Thread Wen Gong
On 2/15/2023 11:10 PM, Johannes Berg wrote: Why is this even needed? You should always get reg_notifier after this anyway? Currently when channel flag changed through the beacon hints are not informed to driver. reg_notifier will be triggered for regdomain changes but not for channel flag

Re: [PATCH 2/2] wifi: ath10k: update the channel list if change in channel flags.

2023-01-18 Thread Wen Gong
On 12/22/2022 8:42 PM, Youghandhar Chintala wrote: ... +static void ath10k_mac_beacon_notifier(struct wiphy *wiphy) +{ + struct ieee80211_hw *hw = wiphy_to_ieee80211_hw(wiphy); + struct ath10k *ar = hw->priv; + + if (ath10k_update_channel_list(ar)) +

[PATCH v2] wifi: ath10k: add peer map clean up for peer delete in ath10k_sta_state()

2022-08-01 Thread Wen Gong
[21713.800623] netlink_rcv_skb+0x89/0xf7 <4>[21713.800628] genl_rcv+0x28/0x36 <4>[21713.800632] netlink_unicast+0x179/0x24b <4>[21713.800637] netlink_sendmsg+0x3a0/0x40e <4>[21713.800642] sock_sendmsg+0x72/0x76 <4>[21713.800646] sys_sendmsg+0x16d/0x1e3 <4>[21713.80

[PATCH] ath10k: add peer map clean up for peer delete in ath10k_sta_state()

2022-08-01 Thread Wen Gong
[21713.800623] netlink_rcv_skb+0x89/0xf7 <4>[21713.800628] genl_rcv+0x28/0x36 <4>[21713.800632] netlink_unicast+0x179/0x24b <4>[21713.800637] netlink_sendmsg+0x3a0/0x40e <4>[21713.800642] sock_sendmsg+0x72/0x76 <4>[21713.800646] sys_sendmsg+0x16d/0

[PATCH] ath10k: fix regdomain info of iw reg set/get

2022-05-25 Thread Wen Gong
: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Tested-on: QCA9984 hw1.0 PCI 10.4-3.6-00104 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac

Re: [PATCH v2] ath10k: reset pointer after memory free to avoid kernel crash by multi-free

2022-04-08 Thread Wen Gong
Please ignore this patch. On 4/8/2022 3:23 PM, Wen Gong wrote: When WMI command timed out happened in ath10k_wmi_cmd_send(), recovery started, then ath10k_core_restart()->ath10k_halt()->ath10k_core_stop()-> ath10k_htt_rx_free() called for the 1st time, then ath10k_cor

[PATCH v2] ath10k: reset pointer after memory free to avoid kernel crash by multi-free

2022-04-08 Thread Wen Gong
2] ? pr_cont_work+0x58/0x58 [ 428.469558] ? kthread_blkcg+0x31/0x31 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- v2: 1. change commit log 2. remove NULL check before memory free since NULL is OK for dma_free_coherent()/kfree() drivers/net/wireless/ath/ath

[PATCH] ath10k: fix memory overwrite of the WoWLAN wakeup packet pattern

2021-12-21 Thread Wen Gong
QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Fixes: fa3440fa2fa1 ("ath10k: convert wow pattern from 802.3 to 802.11") Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/wow.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wo

[PATCH v2] ath10k: drop beacon and probe response which leak from other channel

2021-12-07 Thread Wen Gong
and probe response which is not the same channel of scanning. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Signed-off-by: Wen Gong --- v2: rebased to ath.git ath-202112071521 drivers/net/wireless/ath/ath10k/wmi.c | 28 ++- 1 file changed, 27 insertions(+), 1 deletion

Re: [PATCH] ath10k: Clean the HI_ACS_FLAGS_ALT_DATA_CREDIT_SIZE flag

2021-11-23 Thread Wen Gong
LAN.RMH.4.4.1-00017-QCARMSWP-1. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200410061400.14231-3-wg...@codeaurora.org ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH] ath10k: fix scan abort when duration is set for hw scan

2021-10-25 Thread Wen Gong
Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index bb6c5ee43ac0..a4bd6b9dcf6f 100644 --- a/drivers/net/wireless/ath/ath10k

[PATCH] ath10k: drop beacon and probe response which leak from other channel

2021-10-25 Thread Wen Gong
and probe response which is not the same channel of scanning. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Signed-off-by: Wen Gong --- This depends on commit 97981d89a1d47942a2d7517631d2400b99fe3f93 ("cfg80211: separate get channel number from ies") drivers/net/wireless/ath/at

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-03-07 Thread Wen Gong
On 2021-02-11 00:53, Steven Rostedt wrote: On Wed, 10 Feb 2021 11:48:23 -0500 Steven Rostedt wrote: On Wed, 10 Feb 2021 11:30:26 -0500 Steven Rostedt wrote: > Can you test this patch? v2: Bah! v3: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..90d7ade03499

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

2021-02-09 Thread Wen Gong
On 2021-02-10 08:42, Shuah Khan wrote: ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages, when it fails to find a match for mcs=7 and rate=1440. supported_ht_mcs_rate_nss2: {7, {1300, 2700, 1444, 3000} } ath10k_pci :02:00.0: invalid ht params rate 1440 100kbps nss 2

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 10:14, Brian Norris wrote: On Tue, Feb 9, 2021 at 6:12 PM Wen Gong wrote: On 2021-02-10 03:35, Brian Norris wrote: so this patch is to dump the top 1024 bytes only, its 1st goal is make log smaller. Agreed. I wasn't objecting to this patch. I just wanted to highlight the second

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 03:35, Brian Norris wrote: + Steven Rostedt Hi Wen, (Trimming down the description a bit:) On Mon, Feb 8, 2021 at 6:59 PM Wen Gong wrote: Kernel panic every time in kernel when running below case: steps: 1. connect to an AP with good signal strength 2. echo 0x7f > /sys/ker

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 05:34, Steven Rostedt wrote: On Tue, 9 Feb 2021 14:55:31 -0500 Steven Rostedt wrote: > [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events > https://lore.kernel.org/lkml/f16b14066317f6a926b6636df6974...@codeaurora.org/ Note, that is only used when filtering

[PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-08 Thread Wen Gong
e > 1 page trigger overflow and crash. Based on upper test, try and debugging, pass large buff size to function trace_ath10k_log_dbg_dump cause crash, and it has ath10k_dbg in ath10k_sdio_write to print the length of skb/buffer, it is not necessary to trace all content of the large skb. Tested-o

[PATCH] ath10k: restore tx sk_buff of htt header for SDIO

2021-02-08 Thread Wen Gong
.4.4.1-00049 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c index 9a109840a4c9..44c617834c56 100644 --- a/drivers/net/wireless/ath/ath10k

Re: [PATCH] ath: add support for special 0x0 regulatory domain

2020-12-21 Thread Wen Gong
On 2020-12-21 05:06, Sustek Goran wrote: Hi, on my ath10k Chipset, QCA9984(https://compex.com.sg/shop/wifi-module/802-11ac-wave-2/wle1216v5-20-2/) afetr this patch i can not longer to initialize my card. my dmesg log: So i need to revert this patch! Is my card need aditional support? Can you

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Wen Gong
On 2020-12-09 23:00, Ben Greear wrote: On 12/9/20 1:24 AM, Kalle Valo wrote: Wen Gong writes: On 2020-09-08 00:22, Kalle Valo wrote: Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Wen Gong
On 2020-12-09 17:24, Kalle Valo wrote: Wen Gong writes: On 2020-09-08 00:22, Kalle Valo wrote: Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we holding a lock? But then that sho

[PATCH] mac80211: fix a mistake check for rx_stats update

2020-12-08 Thread Wen Gong
come valid with this patch for the scene. Fixed: 09a740ce352e ("mac80211: receive and process S1G beacons") Signed-off-by: Wen Gong --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index ebd01ca9d2e6..dafde71af

Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons

2020-12-08 Thread Wen Gong
On 2020-12-09 02:19, Thomas Pedersen wrote: Hi Wen, On 2020-12-07 23:44, Wen Gong wrote: On 2020-09-22 10:28, Thomas Pedersen wrote: S1G beacons are 802.11 Extension Frames, so the fixed header part differs from regular beacons. Add a handler to process S1G beacons and abstract out

Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons

2020-12-07 Thread Wen Gong
On 2020-09-22 10:28, Thomas Pedersen wrote: S1G beacons are 802.11 Extension Frames, so the fixed header part differs from regular beacons. Add a handler to process S1G beacons and abstract out the fetching of BSSID and element start locations in the beacon body handler. Signed-off-by: Thomas

[PATCH 2/2] ath10k: pass the ssid info to get the correct bss entity

2020-12-06 Thread Wen Gong
in ieee80211_start_ap(), for STATION mode, it is filled in ieee80211_mgd_assoc(). Tested for both AP/STATION mode with QCA6174 hw3.2 PCI, it is success start/connect/ping for WPA/OPEN mode. Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- drivers/net/wireless/ath

[PATCH 0/2] mac80211/ath10k: save ssid info for STATION mode

2020-12-06 Thread Wen Gong
save the ssid info for STATION mode which could be used for ath10k to get the corret/exact cfg80211_bss. Wen Gong (2): mac80211: save ssid info to ieee80211_bss_conf while assoc ath10k: pass the ssid info to get the correct bss entity drivers/net/wireless/ath/ath10k/mac.c | 3 ++- net

[PATCH 1/2] mac80211: save ssid info to ieee80211_bss_conf while assoc

2020-12-06 Thread Wen Gong
assoc, save ssid info to ieee80211_bss_conf, then ssid info can be still access after assoc. Signed-off-by: Wen Gong --- net/mac80211/mlme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index ac870309b911..f3b3cba02be2 100644 --- a/net/mac80211

[PATCH] mac80211: change back to return true by default of ieee80211_chandef_he_6ghz_oper

2020-11-23 Thread Wen Gong
The default value is true returned by ieee80211_chandef_he_6ghz_oper, change it to true same with before. Fixes: 1d00ce807efa ("mac80211: support S1G association") Signed-off-by: Wen Gong --- net/mac80211/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ne

Re: drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool

2020-11-16 Thread Wen Gong
On 2020-11-16 15:53, Kalle Valo wrote: + ath10k list kernel test robot writes: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add firmware

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-13 Thread Wen Gong
On 2020-11-13 17:10, Johannes Berg wrote: On Fri, 2020-11-13 at 17:09 +0800, Wen Gong wrote: On 2020-11-13 16:51, Johannes Berg wrote: > On Fri, 2020-11-13 at 16:51 +0800, Wen Gong wrote: > > > yes. > > It can add check with supp_rates[band] of ieee80211_sta for > > NL8

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-13 Thread Wen Gong
On 2020-11-13 16:51, Johannes Berg wrote: On Fri, 2020-11-13 at 16:51 +0800, Wen Gong wrote: yes. It can add check with supp_rates[band] of ieee80211_sta for NL80211_IFTYPE_STATION type. for others, check with sdata->vif.bss_conf.basic_rates Right. Though, might need to check that o

Re: [PATCHv3 1/2] nl80211: add support for mcs masks

2020-11-13 Thread Wen Gong
On 2020-11-12 18:38, Wen Gong wrote: On 2012-01-29 00:25, Simon Wunderlich wrote: Allow to set mcs masks through nl80211. We also allow to set MCS rates but no legacy rates (and vice versa). Signed-off-by: Simon Wunderlich Signed-off-by: Mathias Kretschmer --- include/linux/nl80211.h

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-13 Thread Wen Gong
On 2020-11-13 16:35, Johannes Berg wrote: On Fri, 2020-11-13 at 16:35 +0800, Wen Gong wrote: > I guess if we really want to redefine the user rate mask to not apply > to > control frames, then we can relax this? > Yes, for AP mode, it is hard to calculate the usable rates over

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-13 Thread Wen Gong
On 2020-11-13 16:16, Johannes Berg wrote: On Fri, 2020-11-13 at 16:14 +0800, Wen Gong wrote: On 2020-11-13 15:38, Johannes Berg wrote: > On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: > > > Which was the intent of this change, wasn't it? > > Indeed. Permitting this leads

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-13 Thread Wen Gong
On 2020-11-13 15:38, Johannes Berg wrote: On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: > Which was the intent of this change, wasn't it? Indeed. Permitting this leads to warnings later. We need to set the tx rate to fixed at a single rate, e.g., 54M/48M/36M... for a test case. I

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-12 Thread Wen Gong
On 2020-11-12 20:49, Arend Van Spriel wrote: On 11/12/2020 11:55 AM, Wen Gong wrote: On 2017-03-08 21:20, Johannes Berg wrote: From: Johannes Berg [...] @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct wiphy *wiphy, return ret

Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

2020-11-12 Thread Wen Gong
On 2017-03-08 21:20, Johannes Berg wrote: From: Johannes Berg If the user rate mask results in no (basic) rates being usable, clear it. Also, if we're already operating when it's set, reject it instead. Technically, selecting basic rates as the criterion is a bit too restrictive, but

Re: [PATCHv3 1/2] nl80211: add support for mcs masks

2020-11-12 Thread Wen Gong
On 2012-01-29 00:25, Simon Wunderlich wrote: Allow to set mcs masks through nl80211. We also allow to set MCS rates but no legacy rates (and vice versa). Signed-off-by: Simon Wunderlich Signed-off-by: Mathias Kretschmer --- include/linux/nl80211.h |4 +++ include/net/cfg80211.h |3

[PATCH] ath10k: cancel rx worker in hif_stop for SDIO

2020-11-04 Thread Wen Gong
no napi_schedule before napi_synchronize, otherwise it lead napi_synchronize wait untill napi_complete. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/sdio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath

Re: lockdep splat in kvallo ath tree

2020-09-11 Thread Wen Gong
git show 4913e675630ec commit 4913e675630ec1a15c92651f426a63755c71b91b Author: Wen Gong Date: Thu Apr 23 10:27:58 2020 +0800 ath10k: enable rx duration report default for wmi tlv When run command "iw dev wlan0 station dump", the rx duration is 0. When firm

Re: [PATCH v5] ath10k: add atomic protection for device recovery

2020-09-07 Thread Wen Gong
On 2020-08-21 12:31, Wen Gong wrote: v6 sent. https://patchwork.kernel.org/patch/11762445/ [v6] ath10k: add atomic protection for device recovery ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v6] ath10k: add atomic protection for device recovery

2020-09-07 Thread Wen Gong
it in ath10k_reconfig_complete, because it is the last thing called from drv_reconfig_complete of function ieee80211_reconfig, after it, the restart process finished. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Signed-off-by: Wen Gong --- v6: change commit log v5: change ref count to BIT

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-09-07 Thread Wen Gong
On 2020-09-07 23:55, Kalle Valo wrote: Wen Gong writes: On 2020-08-15 01:19, Kalle Valo wrote: ... I have been thinking a different approach for this. I think another option is to have a function like this: ath10k_core_firmware_crashed() { queue_work(ar->workqueue, >restar

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-09-07 Thread Wen Gong
On 2020-09-08 00:22, Kalle Valo wrote: Wen Gong writes: [...] Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we holding a lock? But then that should be documented with lockdep_assert_h

Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events

2020-08-29 Thread Wen Gong
On 2020-08-29 06:55, Steven Rostedt wrote: On Fri, 28 Aug 2020 18:54:50 -0400 Steven Rostedt wrote: On Fri, 28 Aug 2020 18:49:55 -0400 Steven Rostedt wrote: > On Fri, 28 Aug 2020 15:53:06 +0800 > Wen Gong wrote: > > > this patch commit id is : 0fc1b09ff1ff404ddf753f5ffa5cd0a

Re: [PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-28 Thread Wen Gong
On 2020-08-25 16:24, Krishna Chaitanya wrote: v3 sent: https://patchwork.kernel.org/patch/11742675/ ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-08-28 Thread Wen Gong
while (test_and_set_bit(NAPI_STATE_NPSVC, >state)) msleep(1); hrtimer_cancel(>timer); clear_bit(NAPI_STATE_DISABLE, >state); } Add flag for it avoid the hang and crash. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 Tested-on: QCA6174

Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events

2020-08-28 Thread Wen Gong
On 2016-05-04 21:52, Steven Rostedt wrote: From: "Steven Rostedt (Red Hat)" Filtering of events requires the data to be written to the ring buffer before it can be decided to filter or not. This is because the parameters of the filter are based on the result that is written to the ring buffer

Re: [PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-25 Thread Wen Gong
On 2020-08-25 16:24, Krishna Chaitanya wrote: On Tue, Aug 25, 2020 at 9:11 AM Wen Gong wrote: On 2020-08-24 19:15, Krishna Chaitanya wrote: > On Mon, Aug 24, 2020 at 4:15 PM Wen Gong wrote: >> >> On 2020-08-24 18:03, Krishna Chaitanya wrote: >> > On Mon, Aug 24,

Re: [PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-24 Thread Wen Gong
On 2020-08-24 19:15, Krishna Chaitanya wrote: On Mon, Aug 24, 2020 at 4:15 PM Wen Gong wrote: On 2020-08-24 18:03, Krishna Chaitanya wrote: > On Mon, Aug 24, 2020 at 3:10 PM Wen Gong wrote: >> >> On 2020-08-24 16:35, Krishna Chaitanya wrote: >> > On Mon, Aug 24, 2

Re: [PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-24 Thread Wen Gong
On 2020-08-24 18:03, Krishna Chaitanya wrote: On Mon, Aug 24, 2020 at 3:10 PM Wen Gong wrote: On 2020-08-24 16:35, Krishna Chaitanya wrote: > On Mon, Aug 24, 2020 at 10:03 AM Wen Gong wrote: >> >> It happened "Kernel panic - not syncing: hung_task: blocked tasks"

Re: [PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-24 Thread Wen Gong
On 2020-08-24 16:35, Krishna Chaitanya wrote: On Mon, Aug 24, 2020 at 10:03 AM Wen Gong wrote: It happened "Kernel panic - not syncing: hung_task: blocked tasks" when test simulate crash and ifconfig down/rmmod meanwhile. ... #ifdef CONFIG_PM Even though your DUT is SDI

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-23 Thread Wen Gong
On 2020-08-21 10:45, Wen Gong wrote: ... I have 2 cmd, each one can reproduce the hang. echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash;sleep 0.05;ifconfig wlan0 down echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash;rmmod ath10k_sdio and with

[PATCH v2] ath10k: add flag to protect napi operation to avoid dead loop hang for SDIO

2020-08-23 Thread Wen Gong
isable void napi_disable(struct napi_struct *n) { might_sleep(); set_bit(NAPI_STATE_DISABLE, >state); while (test_and_set_bit(NAPI_STATE_SCHED, >state)) msleep(1); while (test_and_set_bit(NAPI_STATE_NPSVC, >state)) msleep(1);

[PATCH v5] ath10k: add atomic protection for device recovery

2020-08-20 Thread Wen Gong
-by: Wen Gong --- v5: change ref count to BIT dev flag, change all queue_work(ar->workqueue, >restart_work) to ath10k_core_start_recovery v4: add atomic_dec(>restart_count) if state is not on v3: change atomic_inc_and_test to atomic_add_return, remove check of ATH10K_STATE_ON v2:

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
wrote: On 8/20/20 10:00 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:02 PM Ben Greear wrote: On 8/20/20 9:08 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: On 2020-08-20 18:52, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 18:52, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: On 2020-08-20 17:19, Krishna Chaitanya wrote: ... >> I'm not really convinced that this is the right fix, but I'm no NAPI >> expert. Can anyone else help? > Calling napi_disable()

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 17:26, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 2:49 PM Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 2:03 PM Kalle Valo wrote: > > Wen Gong writes: > ... > I'm not really convinced that this is the right fix, but I'm no NAPI > expert. Can a

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 17:19, Krishna Chaitanya wrote: ... > diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c > index 7b894dcaad2e..b71499b171c6 100644 > --- a/drivers/net/wireless/ath/ath10k/sdio.c > +++ b/drivers/net/wireless/ath/ath10k/sdio.c > @@ -1756,8

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-08-20 Thread Wen Gong
On 2020-08-15 01:19, Kalle Valo wrote: ... I have been thinking a different approach for this. I think another option is to have a function like this: ath10k_core_firmware_crashed() { queue_work(ar->workqueue, >restart_work); } In patch 1 we would convert all existing callers to call

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-08-19 Thread Wen Gong
On 2020-08-15 01:19, Kalle Valo wrote: ... I have been thinking a different approach for this. I think another option is to have a function like this: ath10k_core_firmware_crashed() { queue_work(ar->workqueue, >restart_work); } In patch 1 we would convert all existing callers to call

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-08-18 Thread Wen Gong
On 2020-08-15 01:19, Kalle Valo wrote: Wen Gong writes: ... diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 91f131b87efc..0e31846e6c89 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c

[PATCH] ath10k: correct the array index from mcs index for HT mode for QCA6174

2020-08-14 Thread Wen Gong
00048 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k

[PATCH 1/3] ath10k: add wmi service peer stat info for wmi tlv

2020-08-13 Thread Wen Gong
ted-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/wmi-tlv.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/

[PATCH 3/3] ath10k: enable supports_peer_stats_info for QCA6174 PCI devices

2020-08-13 Thread Wen Gong
/s MCS 4 rx bitrate: 26.0 MBit/s MCS 3 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath

[PATCH 2/3] ath10k: remove return for NL80211_STA_INFO_TX_BITRATE

2020-08-13 Thread Wen Gong
S has no effect. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/n

[PATCH 0/3] ath10k: correct tx/rx bitrate for QCA6174 PCIe and SDIO

2020-08-13 Thread Wen Gong
DIO. After that, set true for supports_peer_stats_info of QCA6174 PCIe, then it show same correct tx/rx bitrate. Wen Gong (3): ath10k: add wmi service peer stat info for wmi tlv ath10k: remove return for NL80211_STA_INFO_TX_BITRATE ath10k: enable supports_peer_stats_info for QCA6174 PCI devi

[PATCH v2 1/2] nl80211: vendor-cmd: qca: add dynamic SAR power limits

2020-07-26 Thread Wen Gong
0x00 0x00 means of bytes: 0x1374: vendor id 0x92: vendor subcmd id 0x22: 2.4G power limit 0x11: 5G power limit Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo --- include/uapi/nl80211-vnd-qca.h | 68

[PATCH v2 2/2] ath10k: allow dynamic SAR power limits to be configured

2020-07-26 Thread Wen Gong
command will be set to firmware, otherwise it will not set to firmware at this moment. When STATION connect next time, it will set to firmware. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k

[PATCH v2 0/2] ath10k: SAR power limit vendor command

2020-07-26 Thread Wen Gong
nel.org/en/developers/documentation/nl80211#vendor-specific_api Wen Gong (2): nl80211: vendor-cmd: qca: add dynamic SAR power limits ath10k: allow dynamic SAR power limits to be configured drivers/net/wireless/ath/ath10k/Makefile | 1 + drivers/net/wireless/ath/ath10k/core.c | 2 + drivers/ne

Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames

2020-06-23 Thread Wen Gong
On 2020-06-23 19:48, Kalle Valo wrote: Wen Gong writes: On 2020-06-17 16:25, Wen Gong wrote: + + skb_queue_tail(>wmi_mgmt_tx_queue, skb); + ieee80211_queue_work(ar->hw, >wmi_mgmt_tx_work); https://patchwork.kernel.org/patch/294729

Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames

2020-06-18 Thread Wen Gong
On 2020-06-18 12:09, Wen Gong wrote: On 2020-06-17 16:25, Wen Gong wrote: + + skb_queue_tail(>wmi_mgmt_tx_queue, skb); + ieee80211_queue_work(ar->hw, >wmi_mgmt_tx_work); https://patchwork.kernel.org/patch/2947291/ (https://git.kernel.or

Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames

2020-06-17 Thread Wen Gong
On 2020-06-17 16:25, Wen Gong wrote: + + skb_queue_tail(>wmi_mgmt_tx_queue, skb); + ieee80211_queue_work(ar->hw, >wmi_mgmt_tx_work); https://patchwork.kernel.org/patch/2947291/ (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g

Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames

2020-06-17 Thread Wen Gong
+ + skb_queue_tail(>wmi_mgmt_tx_queue, skb); + ieee80211_queue_work(ar->hw, >wmi_mgmt_tx_work); https://patchwork.kernel.org/patch/2947291/

Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv

2020-04-28 Thread Wen Gong
On 2020-04-28 17:33, Kalle Valo wrote: Kalle Valo writes: Wen Gong wrote: For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware. Enable

[PATCH v2 0/4] ath10k: sdio: add support for rx/tx bitrate reporting

2020-04-27 Thread Wen Gong
MBit/s MCS 7 short GI rx bitrate: 54.0 MBit/s rx bitrate: 48.0 MBit/s tx bitrate: 54.0 MBit/s Wen Gong (4): ath10k: enable firmware peer stats info for wmi tlv ath10k: add rx bitrate report for SDIO ath10k: add bitrate parse for peer stats info ath10k: correct tx bitrate of iw for SDIO

[PATCH v2 4/4] ath10k: correct tx bitrate of iw for SDIO

2020-04-27 Thread Wen Gong
th QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.h| 2 ++ drivers/net/wireless/ath/ath10k/mac.c | 10 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/drivers/ne

[PATCH v2 2/4] ath10k: add rx bitrate report for SDIO

2020-04-27 Thread Wen Gong
SDIO chip, ath10k_mac_sta_get_peer_stats_info has check for bitrate_statistics of hw_params, this patch only enable it for "qca6174 hw3.2 sdio". Tested with QCA6174 SDIO firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.c| 2 + drivers/net/wirele

[PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv

2020-04-27 Thread Wen Gong
WMI command. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 5 + drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 + drivers/net/wireless/ath/ath10k/wmi.h | 1

[PATCH v2 3/4] ath10k: add bitrate parse for peer stats info

2020-04-27 Thread Wen Gong
sted with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.h| 20 +++ drivers/net/wireless/ath/ath10k/mac.c | 161 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 9 ++ 3 files changed, 190 insertions(+) diff -

[PATCH 4/4] ath10k: correct tx bitrate of iw for SDIO

2020-04-23 Thread Wen Gong
th QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.h| 2 ++ drivers/net/wireless/ath/ath10k/mac.c | 10 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/drivers/ne

[PATCH 2/4] ath10k: add rx bitrate report for SDIO

2020-04-23 Thread Wen Gong
SDIO chip, ath10k_mac_sta_get_peer_stats_info has check for bitrate_statistics of hw_params, this patch only enable it for "qca6174 hw3.2 sdio". Tested with QCA6174 SDIO firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.c| 2 + drivers/net/wirele

[PATCH 0/4] ath10k: sdio: add support for rx/tx bitrate reporting

2020-04-23 Thread Wen Gong
: 54.0 MBit/s rx bitrate: 48.0 MBit/s tx bitrate: 54.0 MBit/s Wen Gong (4): ath10k: enable firmware peer stats info for wmi tlv ath10k: add rx bitrate report for SDIO ath10k: add bitrate parse for peer stats info ath10k: correct tx bitrate of iw for SDIO drivers/net/wireless/ath/ath10k

[PATCH 3/4] ath10k: add bitrate parse for peer stats info

2020-04-23 Thread Wen Gong
sted with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.h| 20 +++ drivers/net/wireless/ath/ath10k/mac.c | 161 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 9 ++ 3 files changed, 190 insertions(+) diff -

[PATCH 1/4] ath10k: enable firmware peer stats info for wmi tlv

2020-04-23 Thread Wen Gong
WMI command. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 5 + drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 + drivers/net/wireless/ath/ath10k/wmi.h | 1

Re: Killer WiFi card keeps disconnecting due to latest firmware

2020-04-23 Thread Wen Gong
On 2020-04-22 15:14, Kalle Valo wrote: Kalle Valo writes: Nicola Mori writes: Hi, I have an issue with the WiFi card in my laptop, that keeps disconnecting from the network in a strange way: randomly every 1-2 hours I can't access web pages or even ping the gateway, but existing

Re: Compex WLE600VX AP mode 5GHz doesn't work since kernel 5.6

2020-04-23 Thread Wen Gong
://bbs.archlinux.org/viewtopic.php?id=254535 So if I read the link correctly this commit causes the regression (which was introduced in v5.6-rc1): commit 2dc016599cfa9672a147528ca26d70c3654a5423 Author: Wen Gong AuthorDate: Fri Nov 29 07:34:09 2019 + Commit: Kalle Valo CommitDate: Mon

[PATCH] ath10k: add statistics of tx retries and tx failed when tx complete disable

2020-04-22 Thread Wen Gong
ith QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/htt_rx.c | 7 +++ drivers/net/wireless/ath/ath10k/mac.c| 7 +++ 3 files changed, 16 insertions(+) diff --git a/drivers/net

[PATCH] ath10k: enable rx duration report default for wmi tlv

2020-04-22 Thread Wen Gong
WMI_REQUEST_STATS_CMDID is safely sent after condition checked by ath10k_peer_stats_enabled in ath10k_sta_statistics. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/debug.c | 2 +- drivers/net/wireless/ath/ath10k/debug.h |

[PATCH v2] ath10k: drop the TX packet which size exceed credit size for sdio

2020-04-22 Thread Wen Gong
sdio chip use DMA buffer to receive TX packet from ath10k, and it has limitation of each buffer, if the packet size exceed the credit size, it will trigger error in firmware. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00017-QCARMSWP-1. Signed-off-by: Wen Gong --- v2: rebase to ath

Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio

2020-04-18 Thread Wen Gong
On 2020-04-16 20:27, Kalle Valo wrote: Kalle Valo writes: How much does it drop? Please add the justification (with numbers) for the new thread to the commit log, so that the reason is properly documented. I see that you already submitted v10. If you can give the numbers I can add them to

Re: [PATCH] ath10k: improve power save performance for sdio

2020-04-17 Thread Wen Gong
On 2020-04-17 15:17, Kalle Valo wrote: Wen Gong writes: On 2020-04-16 20:38, Kalle Valo wrote: Wen Gong writes: +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool enable_sleep) +{ + if (ar->hif.ops->set_mbox_sleep) + return ar-&g

Re: [PATCH] ath10k: improve power save performance for sdio

2020-04-16 Thread Wen Gong
On 2020-04-16 20:38, Kalle Valo wrote: Wen Gong writes: +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool enable_sleep) +{ + if (ar->hif.ops->set_mbox_sleep) + return ar->hif.ops->set_mbox_sleep(ar, enable_sleep); + return 0;

test mail, please ignore

2020-04-15 Thread Wen Gong
sent directly with codeaurora webmail. ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH] ath10k: add flush tx packets for SDIO chip

2020-04-15 Thread Wen Gong
5: ath10k_log_warn: ath10k_sdio mmc1:0001:1 HTT_T2H_MSG_TYPE_MGMT_TX_COMPLETION status:0 <...>-1513 [001] 25377.982973: ath10k_log_err: ath10k_sdio mmc1:0001:1 ath10k_mac_wait_tx_complete time_left:1810, pending:0-0 Flush all pending TX packets for the 1st ath10k_flush reduced the wai

Re: [PATCH v9 0/4] ath10k: improve throughout of TX of sdio

2020-04-10 Thread Wen Gong
On 2020-02-12 16:04, Wen Gong wrote: v10 sent https://patchwork.kernel.org/cover/11482763/ ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v10 1/2] ath10k: add htt TX bundle for sdio

2020-04-10 Thread Wen Gong
. It only enable bundle for sdio chip. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00017-QCARMSWP-1. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.c | 14 +- drivers/net/wireless/ath/ath10k/core.h | 4 +- drivers/net/wireless/ath/ath10k/htc.c| 372

[PATCH v10 0/2] ath10k: improve throughout of TX of sdio

2020-04-10 Thread Wen Gong
of sdio bus. These patches only affect sdio bus chip, explanation is mentioned in each patch's commit log. Wen Gong (2): ath10k: add htt TX bundle for sdio ath10k: enable alt data of TX path for sdio drivers/net/wireless/ath/ath10k/core.c | 22 +- drivers/net/wireless/ath/ath10k/cor

[PATCH v10 2/2] ath10k: enable alt data of TX path for sdio

2020-04-10 Thread Wen Gong
.4.4.1-00017-QCARMSWP-1. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/core.c | 8 drivers/net/wireless/ath/ath10k/htc.c | 12 ++-- drivers/net/wireless/ath/ath10k/htc.h | 13 +++-- 3 files changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/net

  1   2   3   4   >