Re: [PATCH] ath10k: Add missing CONFIG_ATH10K_DEBUGFS check

Benjamin Berg writes: > The patch "ath10k: allow setting coverage class" was missing a check for > CONFIG_ATH10K_DEBUGFS so it would try to use non-existing struct elements > in some configurations. Fix this by adding the appropriate ifdef. > > Signed-off-by: Benjamin

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

gree...@candelatech.com writes: > From: Ben Greear > > When firmware crashes, stack can continue to send packets > for a bit, and existing code was spamming logs. > > So, rate-limit the error message for tx failures. > > Signed-off-by: Ben Greear

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

gree...@candelatech.com writes: > From: Ben Greear > > Helps keep messages off of (serial) console when > that is desired. > > Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print exactly for this purpose? At least I recall using it. --

Re: [PATCH v2 12/21] ath10k: Support up to 64 vdevs.

gree...@candelatech.com writes: > From: Ben Greear > > The (1 << x) - 1 trick won't work when you > are trying to fill up all 64 bits, so add special > case for that. > > And, move the limits to the per-nic structure instead > of per-driver to allow better dynamic use of

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

gree...@candelatech.com writes: > From: Ben Greear > > There are not many of these messages producted by the > firmware, but they are generally fairly useful, so print > them at info level. > > Signed-off-by: Ben Greear > --- >

Re: [PATCH v2 19/21] ath10k: Enable adhoc mode for CT firmware.

gree...@candelatech.com writes: > From: Ben Greear > > CT firmware can support IBSS mode, so allow users to configure this. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/mac.c | 5 + > 1 file changed, 5 insertions(+)

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

On 09/14/2016 07:07 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error message for tx failures. Signed-off-by:

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

gree...@candelatech.com writes: > From: Ben Greear > > Using debugfs. More convenient than module options > in some cases. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/debug.c | 62 > +

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

On 09/14/2016 07:30 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Add placeholder so CT firmware can more easily co-exist with upstream kernel. CT firmware should be backwards compatible with existing kernels, but it also has many new

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

On 09/14/2016 07:06 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Using debugfs. More convenient than module options in some cases. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 62

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

gree...@candelatech.com writes: > From: Ben Greear > > This allows user-space tools to decode debug-log > messages by parsing dmesg or /var/log/messages. > > Signed-off-by: Ben Greear Don't tracing points already provide the same information?

Re: [PATCH v2 19/21] ath10k: Enable adhoc mode for CT firmware.

On 09/14/2016 07:37 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear CT firmware can support IBSS mode, so allow users to configure this. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 5

Re: [PATCH v2 11/21] ath10k: add fw-powerup-fail to ethtool stats.

gree...@candelatech.com writes: > From: Ben Greear > > This gives user-space a normal-ish way to detect that > firmware has failed to start and that a reboot is > probably required. > > Signed-off-by: Ben Greear > --- >

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

On 09/14/2016 07:19 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Helps keep messages off of (serial) console when that is desired. Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print exactly for this

[PATCH] ath10k: Fix spinlock use in coverage class hack

ath10k_hw_qca988x_set_coverage_class needs to hold both conf_mutex and the data_lock spin lock for parts of the function. However, data_lock is only needed while storing the coverage_class to store the value that the card is configured to. Fix the locking issue by only holding data_lock for the

Re: accessing ath10k calibration data

I sent out the patch. I ran into another related issue. Let me explain what we are trying to do: We want to examine cal_data for a possibly mis-calibrated OTP, and if so, patch it and store the result in /tmp (creating a symlink from /ilb/firmware/ath10k/cal-pci-0001:01:00.0.bin to /tmp). But

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

Bartosz Markowski writes: > On 12 September 2016 at 17:35, Valo, Kalle wrote: > >> > +#ifdef CONFIG_ACPI >> > +#define WRD_METHOD "WRDD" >> > +#define WRDD_WIFI (0x07) >> > + >> > +static u32 ath10k_mac_wrdd_get_mcc(struct ath10k *ar, union