Re: accessing ath10k calibration data

2016-09-15 Thread Michal Kazior
On 15 September 2016 at 01:54, Marty Faltesek wrote: > I sent out the patch. > > I ran into another related issue. Let me explain what we are trying to do: > > We want to examine cal_data for a possibly mis-calibrated OTP, and if > so, patch it and store > the result in /tmp (creating a symlink fr

QCA6174 Performance

2016-09-15 Thread Daniel Holz
Hello, the network performance of the Qualcom QCA6174 in my Lenovo Yoga 3 11 is only around 7-8 Mbyte/s in tests with iperf when using a wireless ac connection. Disabling power management resulted in 10 MByte/s. Under the same conditions my Android phone achieved 384 MByte/s. Currently I'm u

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:07 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> When firmware crashes, stack can continue to send packets >>> for a bit, and existing code was spamming logs. >>> >>> So, rate-limit the error message for tx failure

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:12 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> There are not many of these messages producted by the >>> firmware, but they are generally fairly useful, so print >>> them at info level. >>> >>> Signed-off-by: Ben

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:18 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> This allows user-space tools to decode debug-log >>> messages by parsing dmesg or /var/log/messages. >>> >>> Signed-off-by: Ben Greear >> >> Don't tracing points al

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:19 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Helps keep messages off of (serial) console when >>> that is desired. >>> >>> Signed-off-by: Ben Greear >> >> Isn't /proc/sys/kernel/print exactly for this purpose?

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:30 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Add placeholder so CT firmware can more easily co-exist with upstream >>> kernel. CT firmware should be backwards compatible with existing kernels, >>> but it also

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

2016-09-15 Thread Valo, Kalle
Ben Greear writes: > On 09/14/2016 07:06 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Using debugfs. More convenient than module options >>> in some cases. >>> >>> Signed-off-by: Ben Greear >>> --- >>> drivers/net/wireless/ath/ath10k/debug.c | 62

[PATCH] ath10k: Provide provision to get Transmit Power Control stats for 10.4

2016-09-15 Thread c_mkenna
From: Maharaja Kennadyrajan This patch helps to get the TPC stats for 10.4 fw variants. Signed-off-by: Maharaja Kennadyrajan --- drivers/net/wireless/ath/ath10k/wmi.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/at

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:15 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:30 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Add placeholder so CT firmware can more easily co-exist with upstream kernel. CT firmware should be backwards compatible with existi

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:19 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:06 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Using debugfs. More convenient than module options in some cases. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/de

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:06 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:18 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This allows user-space tools to decode debug-log messages by parsing dmesg or /var/log/messages. Signed-off-by: Ben Greear Don't tr

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

2016-09-15 Thread Ben Greear
On 09/15/2016 07:02 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:12 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear There are not many of these messages producted by the firmware, but they are generally fairly useful, so print them at info level. Sig

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

2016-09-15 Thread Ben Greear
On 09/15/2016 06:59 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:07 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error mes

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

2016-09-15 Thread Ben Greear
On 09/15/2016 07:12 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:19 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear Helps keep messages off of (serial) console when that is desired. Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print exactly fo

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Grumbach, Emmanuel
On Thu, 2016-09-15 at 08:14 -0700, Ben Greear wrote: > On 09/15/2016 07:06 AM, Valo, Kalle wrote: > > Ben Greear writes: > > > > > On 09/14/2016 07:18 AM, Valo, Kalle wrote: > > > > gree...@candelatech.com writes: > > > > > > > > > From: Ben Greear > > > > > > > > > > This allows user-space to

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote: On Thu, 2016-09-15 at 08:14 -0700, Ben Greear wrote: On 09/15/2016 07:06 AM, Valo, Kalle wrote: Ben Greear writes: On 09/14/2016 07:18 AM, Valo, Kalle wrote: gree...@candelatech.com writes: From: Ben Greear This allows user-space tools t

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Ben Greear
On 09/15/2016 10:59 AM, Ben Greear wrote: On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote: I have other patches that remember the last 100 or so firmware log messages from the kernel and provide that in a binary dump image when firmware crashes. This is indeed very useful. But, when debuggi

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

2016-09-15 Thread Grumbach, Emmanuel
On Thu, 2016-09-15 at 10:59 -0700, Ben Greear wrote: > On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote: > > On Thu, 2016-09-15 at 08:14 -0700, Ben Greear wrote: > > > On 09/15/2016 07:06 AM, Valo, Kalle wrote: > > > > Ben Greear writes: > > > > > > > > > On 09/14/2016 07:18 AM, Valo, Kalle wrote

Re: QCA6174 Performance

2016-09-15 Thread Valo, Kalle
Daniel Holz writes: > the network performance of the Qualcom QCA6174 in my Lenovo Yoga 3 11 > is only around 7-8 Mbyte/s in tests with iperf when using a wireless > ac connection. Disabling power management resulted in 10 MByte/s. > Under the same conditions my Android phone achieved 384 MByte/s.