Re: [ath9k-devel] ath9k: move RELAY and DEBUG_FS to ATH9K[_HTC]_DEBUGFS

2017-01-13 Thread Kalle Valo
Christian Lamparter wrote: > Currently, the common ath9k_common module needs to have a > dependency on RELAY and DEBUG_FS in order to built. This > is usually not a problem. But for RAM and FLASH starved > AR71XX devices, every little bit counts. > > This patch adds a

Re: [ath9k-devel] Searching new home for ath[59]k-devel mailing lists

2017-01-13 Thread Kalle Valo
ew one, for example from infradead.org. So feel free to close both of the lists and thanks for the heads up. Are you planning to update the MAINTAINERS file or should I? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: fix spelling mistake: "meaurement" -> "measurement"

2017-01-12 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath_err message > > Signed-off-by: Colin Ian King Patch applied to ath-next branch of ath.git, thanks. 714ee339ff90 ath9k: fix

Re: [ath9k-devel] [1/2] ath9k: ar9002_mac: kill off ACCESS_ONCE()

2017-01-12 Thread Kalle Valo
gt; > > virtual patch > > @ depends on patch @ > expression E1, E2; > @@ > > - ACCESS_ONCE(E1) = E2 > + WRITE_ONCE(E1, E2) > > @ depends on patch @ > expression E; > @@ > > - ACCESS_ONCE(E) > + READ_ONCE(E) > > > Signed-off-by: Mark Ru

Re: [ath9k-devel] [RFC] ath9k: move RELAY and DEBUG_FS to ATH9K[_HTC]_DEBUGFS

2017-01-09 Thread Kalle Valo
8> No complaints so far so I guess people don't have any issues :) Please submit this as a proper patch and if there are no comments I'll apply it. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 00/19] Pending Cleanup patches for 4.7

2017-01-08 Thread Kalle Valo
or you. That does help, but I started to wonder what happened to them (did I do something wrong etc) before I realised that you actually dropped them yourself. Patchwork is sometimes a bit clumsy like this, so maybe an email reply like "dropping these from patchwork" or similar is a good i

Re: [ath9k-devel] [PATCH 00/19] Pending Cleanup patches for 4.7

2017-01-08 Thread Kalle Valo
Julian Calaby <julian.cal...@gmail.com> writes: > On Fri, Apr 8, 2016 at 10:56 AM, Julian Calaby <julian.cal...@gmail.com> > wrote: >> Hi Kalle, >> >> On Fri, Apr 8, 2016 at 2:37 AM, Kalle Valo <kv...@codeaurora.org> wrote: >>> Kalle Val

Re: [ath9k-devel] [PATCH 00/19] Pending Cleanup patches for 4.7

2017-01-08 Thread Kalle Valo
remove the original patches from deferred queue by moving them to state "superseded", but I might missed something. [1] Oddly I cannot find patch 19 from patchwork, I don't know what happened to it. I do see it on the mailing list, though. -- Kalle Valo __

Re: [ath9k-devel] [PATCH 00/19] Pending Cleanup patches for 4.7

2017-01-08 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Julian Calaby <julian.cal...@gmail.com> writes: > >> This is a set of all patches in patchwork which were pending when the 4.6 >> merge window opened that meet the following criteria: >> >> 1. They're sane >

Re: [ath9k-devel] ath9k_htc: don't use HZ for usb msg timeouts

2016-12-01 Thread Kalle Valo
Anthony Romano wrote: > The usb_*_msg() functions expect a timeout in msecs but are given HZ, > which is ticks per second. If HZ=100, firmware download often times out > when there is modest USB utilization and the device fails to initialize. > > Replaces HZ in

Re: [ath9k-devel] wireless: ath: ath9k: constify ath_bus_ops structure

2016-12-01 Thread Kalle Valo
Bhumika Goyal wrote: > Declare the structure ath_bus_ops as const as it is only passed as an > argument to the function ath9k_init_device. This argument is of type > const struct ath_bus_ops *, so ath_bus_ops structures with this property > can be declared as const. > Done

Re: [ath9k-devel] ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Kalle Valo
regression, meaning that it didn't crash on older kernels but crashes on newer ones? Or has it always crashed? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

2016-11-23 Thread Kalle Valo
Matthias Schiffer wrote: > Commit b2d70d4944c1 ("ath9k: make GPIO API to support both of WMAC and > SOC") refactored ath9k_hw_gpio_get() to support both WMAC and SOC GPIOs, > changing the return on success from 1 to BIT(gpio). This broke some callers > like

Re: [ath9k-devel] [PATCH] ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

2016-11-19 Thread Kalle Valo
d-off-by: Matthias Schiffer <mschif...@universe-factory.net> Can you describe more about the symptoms, how did this break from user's point of view? I can add that to the commit log. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k_htc: fix minor mistakes in dev_err messages

2016-11-19 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Add missing space in a dev_err message and join wrapped text so > it does not span multiple lines. Fix spelling mistake on "unknown". > > Signed-off-by: Colin Ian King

Re: [ath9k-devel] [PATCH] ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

2016-11-19 Thread Kalle Valo
Matthias Schiffer <mschif...@universe-factory.net> writes: > On 11/16/2016 03:08 PM, Kalle Valo wrote: >> Matthias Schiffer <mschif...@universe-factory.net> writes: >> >>> Commit b2d70d4944c1 ("ath9k: make GPIO API to support both of WMAC and >>&g

Re: [ath9k-devel] [4.9.0-rc5] AR9300 calibration problems with antenna selected

2016-11-19 Thread Kalle Valo
Krzysztof wrote: > Hi, > > I recently tried to select a single antenna on AR9300 and it works for > 30 seconds only. The subsequent calibration makes the RX signal level to > drop from the usual -30/-40 dBm to -70/-80 dBm, and the transmission > practically stops. > > With the attached patch it

Re: [ath9k-devel] [v8, 1/3] Documentation: dt: net: add ath9k wireless device binding

2016-11-19 Thread Kalle Valo
Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl > Acked-by: Rob Herring 3 patches applied to ath-next

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-27 Thread Kalle Valo
Antonio Quartulli <a...@unstable.cc> writes: > On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: >> Antonio Quartulli <a...@unstable.cc> writes: >> >> > From: Antonio Quartulli <anto...@open-mesh.com> >> > >> > Thi

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-26 Thread Kalle Valo
ng it. GPL? AFAICS ath9k is under ISC. I'm not sure what you mean with the sentence above, but it's possible to interpret it so that this patch is not under ISC license, which is problematic. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists

Re: [ath9k-devel] [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Kalle Valo
"Vittorio Gambaletta (VittGam)" <linux-wirel...@vittgam.net> writes: > Hello, > > On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: >> "Vittorio Gambaletta (VittGam)" <linux-wirel...@vittgam.net> writes: >> >>> If generic e

Re: [ath9k-devel] [PATCH v2 0/7] ath9k: EEPROM swapping improvements

2016-10-12 Thread Kalle Valo
ot;add devicetree support to ath9k" - see [4] I think this looks pretty good. If there's a bug somewhere it should be quite easy to fix so I'm not that worried and would be willing to take these as soon as I have applied the dependency series. IIRC your devicetree patches wil

Re: [ath9k-devel] [v7, 1/3] Documentation: dt: net: add ath9k wireless device binding

2016-10-07 Thread Kalle Valo
Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl Looks good to me but missing the ack from DT maintainers, will wait for

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2016-10-05 Thread Kalle Valo
Toke Høiland-Jørgensen <t...@toke.dk> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >>> Kalle Valo <kv...@codeaurora.org> writes: >>> >>>> Toke Høiland-Jørgensen &l

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2016-10-05 Thread Kalle Valo
Toke Høiland-Jørgensen <t...@toke.dk> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >> I understand your point, but I don't want to rush this to 4.9 and then >> start getting lot

Re: [ath9k-devel] [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-04 Thread Kalle Valo
g to send this? Only one CC header is valid according to the spec (thanks to Luca for checking) even though mailers seem to handle multiple CC headers. But for example my patchwork script fails with this and uses only the first CC header. -- Kalle Valo ___

Re: [ath9k-devel] [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-09-27 Thread Kalle Valo
Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources,

Re: [ath9k-devel] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-07 Thread Kalle Valo
well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-current branch of ath.git:

Re: [ath9k-devel] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-07 Thread Kalle Valo
Kalle Valo <kv...@qca.qualcomm.com> writes: > Giedrius Statkevi?ius <giedrius.statkevic...@gmail.com> wrote: >> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup >> led_pin initial") that broken the WLAN status led on my laptop with &g

Re: [ath9k-devel] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-07 Thread Kalle Valo
well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-next branch of ath.git: 088a

Re: [ath9k-devel] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-03 Thread Kalle Valo
well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> I'm planning to queue

Re: [ath9k-devel] [v2] ath9k: mark ath_fill_led_pin() static

2016-09-02 Thread Kalle Valo
Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the ath9k gpio driver when building with W=1: > drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype > for 'ath_fill_led_pin' [-Wmissing-prototypes] > > In fact,

Re: [ath9k-devel] [patch] ath9k: indent an if statement

2016-08-31 Thread Kalle Valo
... error: patch failed: drivers/net/wireless/ath/ath9k/main.c:919 error: drivers/net/wireless/ath/ath9k/main.c: patch does not apply stg import: Diff does not apply cleanly -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https:

Re: [ath9k-devel] [PATCH] fix:gpio: mark symbols static where possible

2016-08-29 Thread Kalle Valo
io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The commit title should be: ath9k: mark ath_fill_led_pin() static Check the wiki how to create titles: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo _

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2016-08-23 Thread Kalle Valo
...) I understand your point, but I don't want to rush this to 4.9 and then start getting lots of bug reports and eventually forced to revert it. If we just found a new serious regression the chances are that there are more lurking somewhere and this patch is just not ready yet. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2016-08-22 Thread Kalle Valo
Toke Høiland-Jørgensen <t...@toke.dk> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >>> This switches ath9k over to using the mac80211 intermediate software >>> queueing mech

Re: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

2016-08-22 Thread Kalle Valo
ot sure if this will be ready for 4.9. To get more testing time I wonder if we should wait for 4.10? IMHO applying this in the end of the cycle is too risky and we should try to maximise the time linux-next by applying this just after -rc1 is released. Thoughts? -- Kalle Valo

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2016-08-22 Thread Kalle Valo
Benjamin Berg <benjamin.b...@open-mesh.com> writes: > On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: >> Actually, I see two patches which might be related but not identical: >> >> ath9k: fix client mode beacon configuration >> https://patchwork.kernel.org

Re: [ath9k-devel] [1/1,V3] ath9k: consider return code on

2016-08-19 Thread Kalle Valo
Eduardo Abinader wrote: > just to comply with current ath9k_hw_nvram_read to return value, hence > behaving reacting accordingly. > > Signed-off-by: Eduardo Abinader Thanks, 1 patch applied to ath-next branch of ath.git:

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2016-08-19 Thread Kalle Valo
Kalle Valo <kv...@qca.qualcomm.com> writes: > Adi Ratiu <a...@adirat.com> wrote: >> commit cfda2d8e2314 ("ath9k: Fix beacon configuration for >> addition/removal of interfaces") reworked beacon configs to happen at >> IF changes and missed cases

Re: [ath9k-devel] ath9k: Fix beacon configuration assertion failure

2016-08-19 Thread Kalle Valo
Adi Ratiu wrote: > commit cfda2d8e2314 ("ath9k: Fix beacon configuration for > addition/removal of interfaces") reworked beacon configs to happen at > IF changes and missed cases when NL80211_IFTYPE_STATION has no beacons > with the corresponding values

Re: [ath9k-devel] [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-15 Thread Kalle Valo
Please don't top post, it breaks patchwork which is extremely annoying for me: https://patchwork.kernel.org/patch/9266265/ https://patchwork.kernel.org/patch/9266617/ -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [v2] ath9k: simplify the code-paths when not using the built-in EEPROM

2016-07-19 Thread Kalle Valo
Martin Blumenstingl wrote: > There were two paths in the code for "external" eeprom sources. The code > in eeprom.c only handled the cases where the eeprom data was loaded via > request_firmware. ahb.c and pci.c on the other hand had some duplicate > code which

Re: [ath9k-devel] [PATCH v4 1/3] Documentation: dt: net: add ath9k wireless device binding

2016-07-13 Thread Kalle Valo
? ath9k is the driver name and something like ar9462 is the chip name. I know in ath10k we used "qca,ath10k" but I'm starting to suspect that was a mistake. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [v3] ath9k: Switch to using mac80211 intermediate software queues.

2016-07-08 Thread Kalle Valo
Toke Høiland-Jørgensen wrote: > This switches ath9k over to using the mac80211 intermediate software > queueing mechanism for data packets. It removes the queueing inside the > driver, except for the retry queue, and instead pulls from mac80211 when > a packet is needed. The retry queue is used to

Re: [ath9k-devel] [v2, 1/6] ath9k: Correct TSF adjustment to align the beacon time correctly

2016-07-08 Thread Kalle Valo
Benjamin Berg wrote: > From: Benjamin Berg > > Beacons were not send out at (timestamp % beacon_time == 0) for interfaces > other than the primary one. To send out beacons with the correct timestamp > according to 10.1.3.2 of the 802.11

Re: [ath9k-devel] [1/6] ath9k: Allow configuration of LED polarity in platform data.

2016-07-08 Thread Kalle Valo
Martin Blumenstingl wrote: > Some devices running OpenWrt need this and it makes sense to add this > to ath9k_platform_data as the next patches will add a devicetree > (boolean) property for it as well. > > Suggested-by: Vittorio Gambaletta

Re: [ath9k-devel] [PATCH V2] ath9k: consider return code on ar9300_eeprom_restore_flash

2016-07-08 Thread Kalle Valo
return -1; And here you can just return the error code: ret = ar9300_eeprom_restore_flash(ah, mptr, mdata_size); if (ret) return ret; -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k: Fix programming of minCCA power threshold

2016-06-30 Thread Kalle Valo
Sven Eckelmann wrote: > The function ar9003_hw_apply_minccapwr_thresh takes as second parameter not > a pointer to the channel but a boolean value describing whether the channel > is 2.4GHz or not. This broke (according to the origin commit) the ETSI > regulatory compliance on

Re: [ath9k-devel] ath9k: return false when reading wrong eeprom offset

2016-06-30 Thread Kalle Valo
Eduardo Abinader wrote: > Just setting the proper return for reading beyond the eeprom data. > > Signed-off-by: Eduardo Abinader > Reviewed-by: Julian Calaby Thanks, 1 patch applied to ath-next branch of

Re: [ath9k-devel] [PATCH RFC v3 1/3] Documentation: dt: net: add ath9k wireless device binding

2016-06-27 Thread Kalle Valo
umentation/devicetree/bindings/net/wireless/qca,ath9k.txt For device tree bindings document changes you should CC the device tree list: $ scripts/get_maintainer.pl -f Documentation/devicetree/bindings/net/wireless/ Kalle Valo <kv...@codeaurora.org> (maintainer:NETWORKING DRIVERS (WIRELESS

Re: [ath9k-devel] ath9k: Support 4.9Ghz channels on AR9580 adapter.

2016-06-20 Thread Kalle Valo
Ben Greear wrote: > From: Ben Greear > > NOTE: These channels must not be used in most regulatory > domains unless you have a license from the FCC or similar! > > A proper regulatory database is also required to actually use > these channels.

Re: [ath9k-devel] [PATCH] ath9k: return false when reading wrong eeprom offset

2016-06-16 Thread Kalle Valo
et fatal: corrupt patch at line 14 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ath9k: return false when reading wrong eeprom offset -- Kalle Valo ___ ath9k-devel mailing list ath9k-

Re: [ath9k-devel] [PATCH 4/6] ath9k: Expose tsf_adjustment in mac80211 tsf getters and setters.

2016-06-13 Thread Kalle Valo
to answer the question "Why?". -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 3/6] ath9k: Use tsf offset helper in ath9k_hw_reset

2016-06-13 Thread Kalle Valo
jamin Berg <benjamin.b...@open-mesh.com> Why we don't need that 1.5 ms delta anymore? It would be good to document that in the commit log in case someone else wonders why that change was made. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lis

Re: [ath9k-devel] [PATCH 2/6] ath9k: Handle channel context in get_/set_/reset_tsf

2016-06-13 Thread Kalle Valo
to answer "Why?" in the log. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k gpio request

2016-06-07 Thread Kalle Valo
; > > and maybe a Reported-by tag is also appropriate in this case. Yeah, I add those. Thanks Sudip. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k gpio request

2016-06-04 Thread Kalle Valo
>> Tested-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> > > Done, https://patchwork.kernel.org/patch/9151847/ But the patch 9151847 is different from what Sudip tested above? Why? And if you modify something _after_ the reporter has tested the patch cl

Re: [ath9k-devel] ath9k gpio request

2016-06-02 Thread Kalle Valo
ne AR9485_GPIO_MASK0x07FF >> #define AR9531_GPIO_MASK0x000F >> #define AR9550_GPIO_MASK0x000F >> #define AR9561_GPIO_MASK0x000F > > solves the problem. > >

[ath9k-devel] ath9k gpio request

2016-05-31 Thread Kalle Valo
void ath9k_hw_gpio_request_in(); void ath9k_hw_gpio_request_out(); void ath9k_hw_gpio_free(); NOTE, the BSP of the SOC chips(AR9340, AR9531, AR9550, AR9561) should set the corresponding MUX registers correctly. Signed-off-by: Miaoqing Pan <miaoq...@codeaurora

Re: [ath9k-devel] ath9k: Proper TX99 interrupt ref count

2016-05-28 Thread Kalle Valo
Eduardo Abinader wrote: > On TX99 mode, instead of assuming interrupt mask non ATH9K_INT_GLOBAL, > let ath9k_hw_disable_interrupts proper set interrupt ref count. > This prevents some PCI PERR occurring specialy when setting 11b and n rates. > > Signed-off-by: Eduardo

Re: [ath9k-devel] ath9k: allow tx99 for ar9002 based cards

2016-05-28 Thread Kalle Valo
Eduardo Abinader wrote: > As there is current support for ar9002 tx99 mode, just allow > to init debugfs and enable tx99. > > Signed-off-by: Eduardo Abinader Thanks, 1 patch applied to ath.git: e94610cc1c8f ath9k: allow tx99 for ar9002 based

Re: [ath9k-devel] ath9k: Remove empty test condition

2016-05-28 Thread Kalle Valo
Eduardo Abinader wrote: > Just some code cleanup to remove an empty if clause. > > Signed-off-by: Eduardo Abinader Thanks, 1 patch applied to ath.git: ceda5153d8cd ath9k: Remove empty test condition -- Sent by pwcli

Re: [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels

2016-05-09 Thread Kalle Valo
er evaluate to true. > > Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE > marcros instead. > > Signed-off-by: Helmut Schaa <helmut.sc...@googlemail.com> > Cc: Felix Fietkau <n...@openwrt.org> Thanks, applied to ath.git. -- Kalle Valo __

Re: [ath9k-devel] [PATCH 1/2] ath9k: Add a module parameter to invert LED polarity.

2016-04-25 Thread Kalle Valo
meter to 1 or 0 will force the LED respectively > active high or active low. > > Cc: <linux-wirel...@vger.kernel.org> > Cc: <ath9k-de...@qca.qualcomm.com> > Cc: <ath9k-devel@lists.ath9k.org> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Vittorio Ga

Re: [ath9k-devel] [PATCH] ath9k: remove repetitions of mask array size

2016-04-22 Thread Kalle Valo
that we don't repeat ourselves. > > Signed-off-by: Bob Copeland <m...@bobcopeland.com> As this depends on a patch in wireless-drivers (at least I assume so), and I cannot apply a cleanup patch like this to that repository, I'm planning to apply this only after 4.7-rc1 is

Re: [ath9k-devel] [PATCH] ath9k: remove duplicate assignment of variable ah

2016-04-19 Thread Kalle Valo
Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com&g

Re: [ath9k-devel] [PATCH v2] ath9k: interpret requested txpower in EIRP domain

2016-04-19 Thread Kalle Valo
that antenna-gain is considered > whenever the txpower limit is adjusted and with that > the user set limits are kept. > > Signed-off-by: Zefir Kurtisi <zefir.kurt...@neratec.com> Applied, thanks. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

2016-04-19 Thread Kalle Valo
Replace an explicit initialisation for one local variable at the beginning >> by a conditional assignment. >> >> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > > This looks sane to me. > > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Ap

Re: [ath9k-devel] [PATCH] ath9k: remove repetitions of mask array size

2016-04-18 Thread Kalle Valo
Oleksij Rempel <li...@rempel-privat.de> writes: > Kalle should be in CC. Actually no need, CCing me is useless as I use patchwork. Most important is that the patch is submitted to linux-wireless from where patchwork picks it up. -- K

Re: [ath9k-devel] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_pinitialisation

2016-04-15 Thread Kalle Valo
te.") > Reported-by: Gustav Frederiksen <lkml2...@openmailbox.org> > Tested-by: Gustav Frederiksen <lkml2...@openmailbox.org> > Cc: <sta...@vger.kernel.org> # 4.2+ > Signed-off-by: Oleksij Rempel <li...@rempel-privat.de> Thanks, applied to wireless-drivers.gi

Re: [ath9k-devel] [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

2016-04-15 Thread Kalle Valo
.cal...@gmail.com> Before I commit I'll just change the commit title to: ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation

2016-04-13 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Oleksij Rempel <li...@rempel-privat.de> writes: > >> by moving common code to ar5008_hw_cmn_spur_mitigate i forgot to move >> mask_m & mask_p initialisation. This coused a performance regression >> on ar9281.

Re: [ath9k-devel] [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation

2016-04-13 Thread Kalle Valo
igate and reuse common > code in ar9002_hw_spur_mitigate.") > Reported-by: Gustav Frederiksen <lkml2...@openmailbox.org> > Tested-by: Gustav Frederiksen <lkml2...@openmailbox.org> > Signed-off-by: Oleksij Rempel <li...@rempel-privat.de> I

Re: [ath9k-devel] [01/19] ath9k: Remove unnecessary ?: operator

2016-04-07 Thread Kalle Valo
riable initialisation 37190b269491 rsi: Move variable initialisation into error code c2fd34469d16 iwl4965: Fix a memory leak in error handling code of __il4965_up 84d17a2a5a0f iwl4965: Fix more memory leaks in __il4965_up() Kalle Valo ___ ath9k-devel mail

Re: [ath9k-devel] [PATCH 4/5] ath9k: fix misleading indentation

2016-03-21 Thread Kalle Valo
d-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 499afaccf6f3 ("ath9k: Isolate ath9k_use_chanctx module parameter") > Fixes: eb61f9f623f7 ("ath9k: advertise p2p dev support when chanctx") Dave already applied this so I can skip this. -- Kalle Valo ___

Re: [ath9k-devel] [PATCH 3/5] ath9k: fix buffer overrun for ar9287

2016-03-21 Thread Kalle Valo
es all three > instances to use that variable. The other two instances were > already correct, but it's more consistent this way. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 940cd2c12ebf ("ath9k_hw: merge the ar9287 version of > ath9k_hw_ge

Re: [ath9k-devel] [PATCH v2 09/13] ath9k: request NOA update when chanctx active

2016-01-28 Thread Kalle Valo
The dependency is now in ath.git and I have applied this, thanks. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k_htc: add device ID for Toshiba WLM-20U2/GN-1080

2016-01-28 Thread Kalle Valo
Alexander Tsoy <alexan...@tsoy.me> writes: > This device is available under different marketing names: > WLM-20U2 - Wireless USB Dongle for Toshiba TVs > GN-1080 - Wireless LAN Module for Toshiba MFPs. > > Signed-off-by: Alexander Tsoy <alexan...@tsoy.me> Applied to

Re: [ath9k-devel] [PATCH] ath9k: Drop useless const on chanctx_event_delta() return type

2016-01-28 Thread Kalle Valo
Geert Uytterhoeven <ge...@linux-m68k.org> writes: > drivers/net/wireless/ath/ath9k/channel.c:230: warning: type qualifiers > ignored on function return type > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Applied to ath.git,

Re: [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2016-01-07 Thread Kalle Valo
Dan Carpenter <dan.carpen...@oracle.com> writes: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Applied to ath.git,

Re: [ath9k-devel] [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate

2015-12-31 Thread Kalle Valo
ci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Applied to ath.git, thanks. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https:/

Re: [ath9k-devel] [PATCH] ath9k: fix inconsistent indenting on return statement

2015-12-11 Thread Kalle Valo
Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > minor change, indenting is one tab out. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied to

Re: [ath9k-devel] [PATCH v2 11/13] ath9k: MCC add sta_ap_ratio module param

2015-12-11 Thread Kalle Valo
> Why? What's the use case? And isn't there a better way to do this? Like using nl80211 (via wpasupplicant?) or debugfs? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH V2] ath9k: Simplify and fix eeprom endianness swapping

2015-12-08 Thread Kalle Valo
de and moves it from eeprom_* to > eeprom.c. The new code is derived from eeprom_def, while taking into > account the specifics from the other implementations. > > Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> Applied to ath.git, thanks. -- Kalle Valo __

Re: [ath9k-devel] [PATCH v2 01/13] ath9k: add debug messages to aggr/chanctx funcs

2015-12-08 Thread Kalle Valo
A update when chanctx active [v2,11/13] ath9k: MCC add sta_ap_ratio module param -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 09/13] ath9k: request NOA update when chanctx active

2015-12-01 Thread Kalle Valo
t would make my life a lot easier if you could submit patches like this (which depend on something else) in a separate patchset instead of hiding them inside a 13 patch set. I'll postpone this patch for now and apply it once I have the mac80211 commit. -- Kalle Valo __

Re: [ath9k-devel] ath9k_htc: check for underflow in ath9k_htc_rx_msg()

2015-11-26 Thread Kalle Valo
> We check for overflow here, but we don't check for underflow so it > causes a static checker warning. > > Fixes: fb9987d0f748 ('ath9k_htc: Support for AR9271 chipset.') > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied to wireless-drivers-

Re: [ath9k-devel] [PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Kalle Valo
ueue status, which is 2(q), and if it is full and we > have to stop it, we end stopping the wrong queue, 8, which is not > full. From this point onwards stations are unable to connect to the > AP. This information should be in the commit log. -- Kalle Valo

Re: [ath9k-devel] [PATCH 05/12] ath9k: use u32 when calculate tsf

2015-11-12 Thread Kalle Valo
Janusz Dziedzic <janusz.dzied...@tieto.com> writes: > Signed-off-by: Janusz Dziedzic <janusz.dzied...@tieto.com> Why? And no empty commit logs, please. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://

Re: [ath9k-devel] [PATCH] ath9k: incorrect queue may be stopped/awaken

2015-11-12 Thread Kalle Valo
Borja Salazar <borja.sala...@fon.com> writes: > When channel context is enabled, we could be > stopping/awakening an incorrect queue. Signed-off-by line is missing, I can't take this. -- Kalle Valo ___ ath9k-devel mailing list

Re: [ath9k-devel] ath9k: fix phyerror codes

2015-10-28 Thread Kalle Valo
ompletion made in > the enum, the patch also extends the display of > the related counters in the debugfs. > > Signed-off-by: Zefir Kurtisi <zefir.kurt...@neratec.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [RESEND] ath9k: Fix NF CCA limits for AR9287 and AR9227

2015-10-14 Thread Kalle Valo
...@googlemail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH RESEND] ath9k: Fix NF CCA limits for AR9287 and AR9227

2015-10-06 Thread Kalle Valo
r9287.h > > Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> So what should I do with this patch? Is this good to apply? Discussion here: https://patchwork.kernel.org/patch/6841051/ -- Kalle Valo ___ ath9k-devel m

Re: [ath9k-devel] ath9k: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k_htc: wmi: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] ath9k_htc: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_ATH9K_HTC=m Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [ath9k-devel] [v3, 1/4] ath9k: advertise p2p dev support when chanctx

2015-08-06 Thread Kalle Valo
patches applied to wireless-drivers-next.git: eb61f9f623f7 ath9k: advertise p2p dev support when chanctx d83520b7cd6e ath9k: handle RoC cancel correctly f3771c08282a ath9k: setup rxfilter for all chanctx 1738203ee729 ath9k: setup rxfilter when offchannel Kalle Valo

Re: [ath9k-devel] ath9k: fix moredata flag endianness in cabq tx

2015-07-21 Thread Kalle Valo
for frames that would never come. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2] ath9k: spectral - simplify max_index calculation

2015-07-20 Thread Kalle Valo
to be shared with the DFS module. Signed-off-by: Zefir Kurtisi zefir.kurt...@neratec.com Please edit your quotes, leaving this extra cruft makes it hard for me to use patchwork. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

  1   2   3   4   5   >