Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Joe Perches
On Tue, 2011-06-14 at 15:39 +1000, Julian Calaby wrote: My issue here is that you mention in the commit log that this relates to the removal of netdev_priv and dev_priv, but the casts removed (mostly) don't. Sorry if that was unclear to you. None of these patches remove casts of netdev_priv.

Re: [ath9k-devel] APSM, AR9285 and bus hangs

2011-06-14 Thread Stanislaw Gruszka
On Mon, Jun 13, 2011 at 07:10:56PM +0530, Mohammed Shafi wrote: I see this commit in 2.6.39, missed in 2.6.38 and 2.6.35 currently. Is possible this is the fix which do not break other things? hi, no, this fix only affects AR9280 and it does not affects AR9285. That could be another

Re: [ath9k-devel] ath9k causes lockups since kernel 2.6.35

2011-06-14 Thread Tony Houghton
On Mon, 13 Jun 2011 19:20:17 -0500 Jonathan Nieder jrnie...@gmail.com wrote: Jonathan Nieder wrote: Adrian Chadd wrote: Also, is there a kernel.org bugzilla report entry for this? I'll update it with the relevant information so the regression isn't forgotten about. Let's use

Re: [ath9k-devel] APSM, AR9285 and bus hangs

2011-06-14 Thread Mohammed Shafi
On Tue, Jun 14, 2011 at 3:39 PM, Stanislaw Gruszka sgrus...@redhat.com wrote: On Mon, Jun 13, 2011 at 07:10:56PM +0530, Mohammed Shafi wrote: I see this commit in 2.6.39, missed in 2.6.38 and 2.6.35 currently. Is possible this is the fix which do not break other things? hi, no, this fix

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Bing Zhao
- pt = (T *)pv; + pt = pv; Signed-off-by: Joe Perches j...@perches.com ... drivers/net/wireless/mwifiex/11n.c |5 ++--- drivers/net/wireless/mwifiex/cmdevt.c |3 +-- drivers/net/wireless/mwifiex/join.c|2 +- drivers/net/wireless/mwifiex/scan.c

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Bing Zhao
diff --git a/drivers/net/wireless/mwifiex/11n.c b/drivers/net/wireless/mwifiex/11n.c @@ -191,7 +191,7 @@ int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp, void *data_buf) struct host_cmd_ds_11n_cfg *htcfg = resp-params.htcfg; if (data_buf) { - tx_cfg =

Re: [ath9k-devel] ath9k causes lockups since kernel 2.6.35

2011-06-14 Thread Mohammed Shafi
On Sat, Jun 11, 2011 at 12:42 PM, Adrian Chadd adr...@freebsd.org wrote: ok. Mohammed, APSM is broken in a different way on some laptops. maybe the state transition between sleep states is different somehow. Which model notebook is this Camilo? :) adrian On 11 June 2011 14:42, Camilo

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Pavel Roskin
On 06/14/2011 12:02 AM, Joe Perches wrote: /* Get the message ID */ - msg_id = (__be16 *) ((void *) htc_hdr + - sizeof(struct htc_frame_hdr)); + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr); I would never do

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Joe Perches
On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote: On 06/14/2011 12:02 AM, Joe Perches wrote: /* Get the message ID */ - msg_id = (__be16 *) ((void *) htc_hdr + -sizeof(struct htc_frame_hdr)); + msg_id = (void *)htc_hdr +

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

2011-06-14 Thread Christian Lamparter
On Tuesday 14 June 2011 18:43:51 Joe Perches wrote: On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote: On 06/14/2011 12:02 AM, Joe Perches wrote: /* Get the message ID */ - msg_id = (__be16 *) ((void *) htc_hdr + -

Re: [ath9k-devel] APSM, AR9285 and bus hangs

2011-06-14 Thread Tony Houghton
On Tue, 14 Jun 2011 19:47:35 +0800 Adrian Chadd adr...@freebsd.org wrote: I don't have any new thoughts, no. I think it's more likely something to do with how the bus is being setup, how APSM is being used, how power saving in general is handled, quirks of that chipset (all the laptops with

Re: [ath9k-devel] ath9k causes lockups since kernel 2.6.35

2011-06-14 Thread Adrian Chadd
On 14 June 2011 21:20, Mohammed Shafi shafi.wirel...@gmail.com wrote: I had removed a check that looks redundant. this will be anyway called in radio_disable.  if some one has time and has easy way of applying the patch like in compat wireless, can they see if it fixes by any chance(less