Hi Kalle,
On Fri, Apr 8, 2016 at 10:56 AM, Julian Calaby <julian.cal...@gmail.com> wrote:
> Hi Kalle,
>
> On Fri, Apr 8, 2016 at 2:37 AM, Kalle Valo <kv...@codeaurora.org> wrote:
>> Kalle Valo <kv...@codeaurora.org> writes:
>>
>>>
43: Fix memory leaks in b43_bus_dev_ssb_init and
b43_bus_dev_bcma_init
rtl818x_pci: Disable pci device in error handling code
rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring
iwl4965: Fix a memory leak in error handling code of __il4965_up
Julian Calaby (1):
iwl4965: F
Hi Kalle,
On Fri, Apr 8, 2016 at 2:37 AM, Kalle Valo <kv...@codeaurora.org> wrote:
> Kalle Valo <kv...@codeaurora.org> writes:
>
>> Julian Calaby <julian.cal...@gmail.com> writes:
>>
>>> This is a set of all patches in patchwork which were pending w
Hi All,
On Thu, Aug 4, 2016 at 4:43 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> It looks like this code is correct, but it just needs to be indented a
> bit.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Looks right to me.
Reviewed-by: J
k: The GPIO mask
> +- qca,gpio-val: The GPIO value
> +- qca,led-pin: The GPIO number to which the LED is connected
> +- qca,led-active-high: The LED is active when the GPIO is HIGH
> +- qca,clk-25mhz: Defines that at 25MHz clock is used
> +- qca,no-eeprom: Indicates that there is on phy
ail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
___
ath9k-devel mailing list
ath
s right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
h
Hi All,
On Fri, Jun 17, 2016 at 2:58 AM, Eduardo Abinader
<eduardo.abina...@riverbed.com> wrote:
> Just setting the proper return for reading beyond the eeprom data.
>
> Signed-off-by: Eduardo Abinader <eduardo.abina...@riverbed.com>
This makes sense to me.
Revie
Hi Jouni,
On Tue, Jun 21, 2016 at 7:41 PM, Jouni Malinen <j...@w1.fi> wrote:
> On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote:
>> I've only done this work as I hate to see people's efforts go to
>> waste and I feel that there's enough roadblocks in the way
om>
[Hide this support behind a Kconfig option]
Signed-off-by: Julian Calaby <julian.cal...@gmail.com>
---
drivers/net/wireless/ath/ath9k/Kconfig | 19 +++
drivers/net/wireless/ath/ath9k/ath9k.h | 2 +-
drivers/net/wireless/ath/ath9k/
to
> DFS channels, tx power, and such, but maybe having driver support is
> considered to make it
> too easy for users to hack around restrictions?
Maybe hide this behind CFG80211_CERTIFICATION_ONUS or equivalent?
(Maybe a new symbol CFG80211_LICENSE_REQUIRED
queuing based drivers
> achieve better performance by utilizing airtime
> more efficiently with big aggregates.
>
> Signed-off-by: Michal Kazior <michal.kaz...@tieto.com>
As this patch is passing through your hands, you need to add your
Signed-off-by
Hi Kalle,
On Fri, Apr 15, 2016 at 10:09 PM, Kalle Valo <kv...@codeaurora.org> wrote:
> Julian Calaby <julian.cal...@gmail.com> writes:
>
>> Hi Kalle,
>>
>> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring
>> <elfr...@users.sourcefor
;colin.k...@canonical.com>
Looks right to me.
Signed-off-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c
nning
> by a conditional assignment.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
This looks sane to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++--
From: Ivan Safonov <insafo...@gmail.com>
"(thermometer < 0) ? 0 : (thermometer == X)" is equivalent to
"thermometer == X" for X >= 0.
Signed-off-by: Ivan Safonov <insafo...@gmail.com>
[Updated commit message]
Signed-off-by: Julian Calaby <julian.cal...
From: Markus Elfring <elfr...@users.sourceforge.net>
In ath9k_hif_usb_rx_stream(), i is initialised in the for loop it's
used in.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Reviewed-by: Oleksij Rempel <li...@rempel-privat.de>
[Rewrote commit message]
Sig
of this particular driver.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
config combinations that don't build, even
if they're utterly insane.
You should really change the ath9k Kconfig rules or move or add ifdefs
to prevent this from being possible.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan
Hi Rajkumar,
On Thu, May 22, 2014 at 12:38 AM, Rajkumar Manoharan
rmano...@qti.qualcomm.com wrote:
On Wed, May 21, 2014 at 10:12:26PM +1000, Julian Calaby wrote:
Hi Rajkumar,
On Wed, May 21, 2014 at 9:01 PM, Rajkumar Manoharan
rmano...@qti.qualcomm.com wrote:
On Mon, May 19, 2014 at 09:31
@@ -387,11 +387,13 @@ void ath9k_stop_btcoex(struct ath_softc *sc)
void ath9k_deinit_btcoex(struct ath_softc *sc)
{
+ struct ath_hw *ah = sc-sc_ah;
+
Why introduce a new variable if you only use it once?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http
)
+ hw-flags |= IEEE80211_HW_AMPDU_AGGREGATION;
This doesn't look like it belongs with the rest of the patch.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby
);
void ar9003_mci_get_isr(struct ath_hw *ah, enum ath9k_int *masked);
-static inline bool ar9003_mci_is_ready(struct ath_hw *ah)
+#else
+
+#define ar9003_mci_is_ready(...) false
You missed one =)
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com
is to create a inline
function that returns false, rather than the #define - this way the
type checking of the function's arguments still happens when
CONFIG_ATH9K_BTCOEX_SUPPORT is disabled.
You've done this a couple of other times in this patch too.
Thanks,
--
Julian Calaby
Email: julian.cal
,
+ Original: Chn %diq_corr_meas = 0x%08x\n,
You haven't put a space after the %d like you did in the other file.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby
that the compiler is smart enough to handle automatic
casts between pointer types, some of these, in particular the mwiflex
bits, add some documentation to the code.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http
Joe,
On Tue, Jun 14, 2011 at 15:32, Joe Perches j...@perches.com wrote:
On Tue, 2011-06-14 at 15:23 +1000, Julian Calaby wrote:
Joe,
Hi Julian.
On Tue, Jun 14, 2011 at 14:02, Joe Perches j...@perches.com wrote:
Unnecessary casts of void * clutter the code.
These are the remainder casts
= ar9200_initvals.h}
(100%)
Should this possibly be ar9002_initvals.h as to match up with ar9002_hw.c?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
.Plan: http://sites.google.com/site/juliancalaby/
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
28 matches
Mail list logo
