Re: [ath9k-devel] [PATCH] ath9k: Fix basic connectivity issue

2009-01-10 Thread Kalle Valo
configuration. [...] +static int btcoex_enable; +module_param(btcoex_enable, bool, 0); +MODULE_PARM_DESC(btcoex_enable, Enable Bluetooth coexistence support); Somehow I guessed that this was coming :) I still think that a proper nl80211 interface for this is in order. -- Kalle Valo

Re: [ath9k-devel] ath9k module-Unable to set channel-since ath comes

2009-05-18 Thread Kalle Valo
have no idea if it's practical or not. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print

2009-10-26 Thread Kalle Valo
+ AR_RADIO_SREV_MAJOR)), + ah-hw_version.phyRev); + } +} I think you should provide the size of hw_name to this function and use snprintf() to avoid writing out of bounds. -- Kalle Valo ___ ath9k-devel mailing

Re: [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print

2009-10-26 Thread Kalle Valo
to be careful. Yeah, you never know if someone (for example a crazy Finn just after a refreshing sauna) comes along, changes the function a bit to clean it up and creates a subtle bug ;) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] ath9k ps poll performance

2009-12-13 Thread Kalle Valo
. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k: fix MGMT packets when using TKIP

2011-08-22 Thread Kalle Valo
Bill Jordan bjor...@rajant.com writes: Prevent 8 bytes from being truncated from MGMT packets when using TKIP. A bit more information in the commit log would be nice. Is this is a regression or an old bug? Maybe a stable candidate? -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h

2011-11-15 Thread Kalle Valo
Hi Sangwook, On 11/15/2011 01:23 PM, Sangwook Lee wrote: The patch series proposes to rename ath9k_platform.h to ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well. We can take wl12xx.h as as a example. Please let us change this file

Re: [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h

2011-11-17 Thread Kalle Valo
Hi Sangwook, On 11/16/2011 01:34 PM, Sangwook Lee wrote: On 15 November 2011 16:37, Kalle Valo kv...@adurom.com mailto:kv...@adurom.com wrote: Hi Sangwook, On 11/15/2011 01:23 PM, Sangwook Lee wrote: The patch series proposes to rename ath9k_platform.h

Re: [ath9k-devel] [PATCH] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state.

2011-11-21 Thread Kalle Valo
retried). If this happened ath_tx_aggr_stop would leave TID in cleanup state permanently. Fix this by making ath_tx_flush_tid remove AGGR_ADDBA_COMPLETE and AGGR_CLEANUP flags from TID status if TID is empty. And word wrap your commits to 72 chars or so. -- Kalle Valo

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

2011-11-29 Thread Kalle Valo
seem to be beacons and their BSSID is '0', as our curbssid is also '0' they seem to be wrongly identified as 'my_beacons'. This is a perfect addition to the commit log. Remember that the commit log should especially answer the question why?. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-08 Thread Kalle Valo
Ben Greear gree...@candelatech.com writes: No, there is a check later that does a BUG_ON if our we have screwed up the indexing of the stats. Please, no BUG_ON() calls in wifi drivers. They just make users life miserable. WARN_ON() with a safe bailout is enough. -- Kalle Valo

Re: [ath9k-devel] [PATCH 4/6] ath9k: Only spectral scan relay file when it was created

2013-01-31 Thread Kalle Valo
as well, but I didn't check that carefully. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] mac80211: regression: fd0f979 no long authenticates w/ath9k_htc

2013-03-06 Thread Kalle Valo
. You should use trace-cmd. Something like this: trace-cmd record -e mac80211 -e cfg80211 And then send compressed trace.dat to Johannes. More info: http://wireless.kernel.org/en/developers/Documentation/mac80211/tracing -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 0/3] remaining ath10k_ prefixes for sub-modules

2013-04-17 Thread Kalle Valo
into htt_tx functions ath10k: add ath10k_ prefixes into htt_rx functions Thanks, all applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/4] small cleanups

2013-04-17 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Bartosz Markowski (4): ath10k: fix indentation ath10k: remove odd 'todo' comment ath10k: remove 'todo' comments ath10k: remove obsolete define Thanks, all four applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: split way to long line of code

2013-04-17 Thread Kalle Valo
that's any better either. I'll split the output into two lines. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: wmi_mgmt_rx setup band

2013-04-17 Thread Kalle Valo
(u32 phy_mode) I also removed the extra new line. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: wmi_mgmt_rx setup band

2013-04-17 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Janusz Dziedzic janusz.dzied...@tieto.com writes: Setup band using wmi_event and phy_mode reported by FW/HW. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Both applied, thanks. Forgot to mention that there were conflicts with both

Re: [ath9k-devel] [PATCH 1/2] ath10k: don't defer mgmt_rx frames

2013-04-18 Thread Kalle Valo
...@tieto.com Thanks, both applied. Patch 1 had conflicts, I also did a minor change to that patch. Please check. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/5] ath10k: replace debug_mtx with conf_mutex

2013-04-18 Thread Kalle Valo
-ENOMEM; init_completion(ar-debug.event_stats_compl); - mutex_init(ar-debug.debug_mtx); + mutex_init(ar-conf_mutex); Can this be right? We already initialise conf_mutex in core.c. -- Kalle Valo ___ ath9k-devel mailing list ath9k

Re: [ath9k-devel] [PATCH 0/5] ath10k: cleanups

2013-04-18 Thread Kalle Valo
can you also rebase the patches, please? Quite a lot of conflicts in wmi.c -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: improve FW QoS workaround

2013-04-18 Thread Kalle Valo
work around this FW issue for now. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix double-prefixed functions

2013-04-18 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: A few functions have been double-prefixed 'ath10k_ath10k_'. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Ouch, apparently I was sloppy when reviewing patches :) Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/3] ath10k: pci memleak fix

2013-04-18 Thread Kalle Valo
(3): ath10k: drop dead code ath10k: make htc cancellation a generic thing ath10k: reorder pci shutdown sequences Skipping this as there's v2. (This is just for my own bookkeping :) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/5] ath10k: pci memleak fix

2013-04-18 Thread Kalle Valo
shutdown sequences ath10k: fix memory leak during PCI teardown Thanks, all five applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/6] various cleanup patches

2013-04-18 Thread Kalle Valo
functions ath10k: remove fw event chain for target dump notification Thanks, all six applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/5] ath10k: pci memleak fix

2013-04-18 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: The v2 fixes patch 2, and introduces new patches 4 and 5. There were two possible memleaks. Michal Kazior (5): ath10k: drop dead code ath10k: make HTC cancellation a generic thing ath10k: fix

Re: [ath9k-devel] [PATCH 2/7] ath10k: move suspend/resume exports to core.c file

2013-04-18 Thread Kalle Valo
that. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 4/7] ath10k: reindent ath10k_pci_suspend

2013-04-18 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Also throw an error to PCI if WMI suspend command fails. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Separate patches for reindent and the new error, please. -- Kalle Valo

Re: [ath9k-devel] [PATCH 5/7] ath10k: fix pointer casts in debug code

2013-04-18 Thread Kalle Valo
; -#if defined(CONFIG_PM_SLEEP) wait_queue_head_t event_queue; bool is_target_paused; -#endif I think this is leftovers from a previous patch. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman

Re: [ath9k-devel] [PATCH 1/3] ath10k: kill CE_SEND_CB/CE_RECV_CB

2013-04-18 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: kill typedefs CE_SEND_CB/CE_RECV_CB Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, all three patches applied. Patch 2 had conflicts, please check I didn't break anything. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/7] ath10k: non-functional cleanups

2013-04-18 Thread Kalle Valo
ath10k_warn() instead of WARN() ath10k: remove old function prototype Thanks, all seven applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: add bmi_read32/bmi_write32 function

2013-04-18 Thread Kalle Valo
= le32_to_cpu(tmp);\ ret;\ }) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH v2 0/5] ath10k: pci memleak fix

2013-04-18 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 18/04/13 12:29, Kalle Valo wrote: Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: The v2 fixes patch 2, and introduces new patches 4 and 5. There were two possible memleaks. Michal Kazior (5

Re: [ath9k-devel] [PATCH 0/7] ath10k: htt tx cleanup

2013-04-22 Thread Kalle Valo
to fix. Can you rebase there three and resend, please? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: cleanup ath10k_bmi_fast_download()

2013-04-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: kill vdev_mtx and use conf_mutex

2013-04-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: The vdev_mtx doesn't serve any purpose anymore. The locking should be done with conf_mutex (it was already, implicitly anyway). Signed-off-by: Michal Kazior michal.kaz...@tieto.com Patch 1 applied, but I have a question with patch 2. -- Kalle

Re: [ath9k-devel] [PATCH 2/2] ath10k: refactor scan locking

2013-04-22 Thread Kalle Valo
failed (%d)\n, __func__, ret); + ath10k_wmi_flush_tx(ar); Is this by accident? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/5] ath10k: cleanups

2013-04-22 Thread Kalle Valo
ath10k_warn() instead of ath10k_info() ath10k: fix function prototype argument name Thanks, all five applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix unused variable warning

2013-04-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. I just added the function name to the title. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH 2/2] ath10k: refactor scan locking

2013-04-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 22/04/13 10:08, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Since we have data_lock it is no longer necessary to have scan.lock. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- [...] ret

Re: [ath9k-devel] [PATCH v3] ath10k: move suspend/resume exports to core.c file

2013-04-22 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, patch 1 applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman

Re: [ath9k-devel] [PATCH v2 0/7] various fixes

2013-04-22 Thread Kalle Valo
. Patches 2-5 applied, but with conflicts. Please check Patches 6-7 not applied due to conflicts, please resend. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: simplify FW binary names

2013-04-22 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: If we have a folder tree to store the fw files, there's no need to keep the names so complicated. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: split ath10k_pci_target_ps_control

2013-04-22 Thread Kalle Valo
ath10k_target_ps to static now. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix QoS tx

2013-04-22 Thread Kalle Valo
michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix HW version/revision names

2013-04-22 Thread Kalle Valo
? Both actually. QCA9888 is the chip part for the computing cards and QCA9880 is for Access Points. Maybe we can have QCA988x. Yeah, qca988x is a good choise. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org

Re: [ath9k-devel] [PATCH] ath10k: move QCA9880_1.0 PCI-specific hacks to pci sub-module

2013-04-22 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH v2] ath10k: fix HW version/revision names

2013-04-22 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: In this patch we change only the string values we print during hw_params initialization. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH 1/3] ath10k: remove per-packet completion handling

2013-04-22 Thread Kalle Valo
applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/3] ath10k: remove per-packet completion handling

2013-04-22 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: Having a tx completion handler in the ath10k_skb_cb is very costly (memory wise). The saved space will be used to merge htt_tx_info. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- rebased

Re: [ath9k-devel] [PATCH 0/6] ath10k: cleanups

2013-04-22 Thread Kalle Valo
, but there are just too many conflicts for me to fix and three merge didn't work as the patches didn't have valid commit ids. Can you rebase, please? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo

Re: [ath9k-devel] [PATCH] ath10k: split ath10k_pci_target_ps_control

2013-04-22 Thread Kalle Valo
Markowski Bartosz bartosz.markow...@tieto.com writes: On 22/04/13 10:50, bartosz.markow...@tieto.com wrote: -Original Message- From: Kalle Valo [mailto:kv...@qca.qualcomm.com] And I think we can change ath10k_target_ps to static now. Yes. I will send a patch-set

Re: [ath9k-devel] [PATCH 0/3] ath10k: htc cleanup

2013-04-22 Thread Kalle Valo
. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/2] rebase patch 6 and 7 from 'various fixes' patch-set

2013-04-22 Thread Kalle Valo
, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: add bmi_read32/bmi_write32 functions

2013-04-22 Thread Kalle Valo
case you can simplify the code like this: ath10k_bmi_write32(ar, hi_serial_enable, 0); It's a lot more comfortable to read code like that. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo

Re: [ath9k-devel] [PATCH] ath10k: Fix PCI probe

2013-04-22 Thread Kalle Valo
-by: Sujith Manoharan c_man...@qca.qualcomm.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: tag ath10k_target_ps as static

2013-04-22 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied with conflicts. Please check. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH] ath10k: tag ath10k_target_ps as static

2013-04-22 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied with conflicts. Please check. Actually, I was too hasty. I cannot apply this as after Sujith's ath10k: Fix PCI probe

Re: [ath9k-devel] [RFC] ath10k: kill regtable

2013-04-22 Thread Kalle Valo
the question Why?. I know why, but rest of the community doesn't. I added a comment explaining that. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: ath10k_bmi_write32() calls cleanup

2013-04-22 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Remove not needed param_host variable, simplify code. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 0/2] ath10k: scan fixes

2013-04-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This is a result of a patch split. Michal Kazior (2): ath10k: sync wmi before starting scan timeout ath10k: refactor scan locking Thanks, both patches applied. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: simplify txi lifespan

2013-04-23 Thread Kalle Valo
); + if (--ATH10K_SKB_CB(txi-txdesc)-htt.refcount 0) return; - } The 'if (--foo 0)' is correct but IMHO bad style. It's easy to miss the operator in front and that's why I would prefer: foo--; if (foo 0) ... -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/2] ath10k: kill off htt_tx_info wrapper

2013-04-23 Thread Kalle Valo
truly awesome that we can work directly with sk_buffs now. It's pain in the butt to deal with struct htc_packet, struct htt_tx_info and whatnot. Thank you very much for working on this. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH] ath10k: use config_enabled() for CONFIG_PM_SLEEP

2013-04-23 Thread Kalle Valo
? The overhead from init_waitqueue_head() is meaningless and I doubt the wake_up() call makes any pratical difference either. Thoughts? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/2] ath10k: wmi fixes

2013-04-23 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Michal Kazior (2): ath10k: use skb_queue_purge() instead of custom loop ath10k: fix mgmt rx processing Thanks, both patches applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 1/3] ath10k: kill A_PCIE_LOCAL_REG_READ

2013-04-23 Thread Kalle Valo
and call it ath10k_pci_reg_read32() or something like that. And the same for the write function. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/3] ath10k: kill unnecessary macros

2013-04-23 Thread Kalle Valo
applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: WMI overhaul

2013-04-23 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: From: Sujith Manoharan c_man...@qca.qualcomm.com Sync with internal WMI changes. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com Thanks, both patches applied. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

2013-04-23 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: From: Sujith Manoharan c_man...@qca.qualcomm.com To sync with new FW. What version? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

2013-04-23 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: To sync with new FW. What version? I think with version .603. Please add the firmware version to the commit log and update SUPPORTED_FW_BUILD accordingly. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH 3/3] ath10k: Initialize CW mode

2013-04-23 Thread Kalle Valo
needs to be documented.) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

[ath9k-devel] [PATCH 5/5] ath10k: copy ieee80211_supported_band for each instance

2013-04-24 Thread Kalle Valo
modifies that structure, but that needs to be verified. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.h |4 ++ drivers/net/wireless/ath/ath10k/mac.c | 63 2 files changed, 43 insertions(+), 24 deletions(-) diff --git

[ath9k-devel] [PATCH 1/5] ath10k: make rx_legacy_rate_idx variable const

2013-04-24 Thread Kalle Valo
It's not modified in any way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/txrx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c index 6a66dc2..239eff5

[ath9k-devel] [PATCH 2/5] ath10k: make host_ce_config_wlan static variable const

2013-04-24 Thread Kalle Valo
Nothing modifies it. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c |8 drivers/net/wireless/ath/ath10k/ce.h |2 +- drivers/net/wireless/ath/ath10k/pci.c |8 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[ath9k-devel] [PATCH 3/5] ath10k: make target_ce_config_wlan and target_service_to_ce_map_wlan const

2013-04-24 Thread Kalle Valo
Nothing modifies them. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 22a5451..7a35234

[ath9k-devel] [PATCH 0/5] ath10k: making static variables const

2013-04-24 Thread Kalle Valo
Did some review of static variables and noticed that we had quite a few variables which were not const. Please review carefully, I might have missed something. --- Kalle Valo (5): ath10k: make rx_legacy_rate_idx variable const ath10k: make host_ce_config_wlan static variable const

[ath9k-devel] [PATCH 4/5] ath10k: make iee80211 iface combination structures static

2013-04-24 Thread Kalle Valo
Nothing modifies them. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 60855fb..8f58dda

Re: [ath9k-devel] [PATCH 4/5] ath10k: make iee80211 iface combination structures static

2013-04-24 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 24/04/13 08:37, Kalle Valo wrote: Nothing modifies them. I think the title should be s/static/const/ Yup, I fixed that in my branch. Thanks for review. -- Kalle Valo ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH] ath10k: kill ar9888def.h file

2013-04-24 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Move ar9888 definitions to hw.h file. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

2013-04-24 Thread Kalle Valo
proper sha1 information. It makes my life so much easier. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/3] ath10k: cleanup - respin

2013-04-24 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Couple of updated patches. Bartosz Markowski (3): ath10k: remove excessive CONFIG_PM_SLEEP checks ath10k: kill PCIE_LOCAL_REG_READ/WRITE macros ath10k: update supported firmware tag to .599 Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/3] ath10k: PCI cleanups

2013-04-24 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Bartosz Markowski (3): ath10k: update FIXME comments ath10k: rename WAR_CE_SRC_RING_WRITE_IDX_SET ath10k: replace TARGET_READ/WRITE macros with inline funcitons Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 0/7] ath10k: more cleanup

2013-04-24 Thread Kalle Valo
/wireless/ath/ath10k/pci.c:2150:6: warning: unused variable 'hif_type' [-Wunused-variable] -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: cleanups

2013-04-24 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 24/04/13 12:35, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Rebased on the tip of master branch. Michal Kazior (6): ath10k: rename htt_struct ath10k: fix code style ath10k: fix code style of handling errors

Re: [ath9k-devel] [PATCH 0/5] ath10k: making static variables const

2013-04-24 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Did some review of static variables and noticed that we had quite a few variables which were not const. Please review carefully, I might have missed something. --- Kalle Valo (5): ath10k: make rx_legacy_rate_idx variable const ath10k

Re: [ath9k-devel] [PATCH] ath10k: kill static int max_delay

2013-04-24 Thread Kalle Valo
with it. Unless I'm missing something, of course. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/2] ath10k: htt fixes

2013-04-24 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This one addresses a rare memory leak when FW hangs leaving some HTT tx transactions unfinished. Michal Kazior (2): ath10k: clear pending_tx[] upon tx completion ath10k: cleanup htt pending tx Thanks, applied. -- Kalle Valo

[ath9k-devel] [PATCH 0/5] ath10k: checkpatch fixes 20130424

2013-04-24 Thread Kalle Valo
Few checkpatch fixes. --- Kalle Valo (5): ath10k: cosmetic checkpatch fixes to bmi.h, hw.h and txrx.h ath10k: shorten lines in ath10k_debug_read_target_stats() ath10k: fix checkpatch warnings from bmi.c, debug.c, htc.h and pci.h ath10k: fix checkpatch warnings in ce.h

[ath9k-devel] [PATCH 1/5] ath10k: cosmetic checkpatch fixes to bmi.h, hw.h and txrx.h

2013-04-24 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.h |2 +- drivers/net/wireless/ath/ath10k/hw.h |7 +++ drivers/net/wireless/ath/ath10k/txrx.h |6 -- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless

[ath9k-devel] [PATCH 2/5] ath10k: shorten lines in ath10k_debug_read_target_stats()

2013-04-24 Thread Kalle Valo
This makes checkpatch a happy boy. No functional changes. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.h | 117 +-- drivers/net/wireless/ath/ath10k/wmi.h |2 - 2 files changed, 65 insertions(+), 54 deletions

[ath9k-devel] [PATCH 3/5] ath10k: fix checkpatch warnings from bmi.c, debug.c, htc.h and pci.h

2013-04-24 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.c |7 --- drivers/net/wireless/ath/ath10k/debug.c | 15 ++- drivers/net/wireless/ath/ath10k/htc.h | 27 ++- drivers/net/wireless/ath/ath10k/pci.h | 25

[ath9k-devel] [PATCH 4/5] ath10k: fix checkpatch warnings in ce.h, core.c, htc.c, htt_tx.c and txrx.c

2013-04-24 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.h |4 +-- drivers/net/wireless/ath/ath10k/core.c | 12 +--- drivers/net/wireless/ath/ath10k/htc.c| 45 - drivers/net/wireless/ath/ath10k/htt_tx.c | 46

[ath9k-devel] [PATCH 5/5] ath10k: fix some checkpatch warnings in htt_rx.c and ce.c

2013-04-24 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c | 32 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 27 + 2 files changed, 36 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath

Re: [ath9k-devel] [PATCH] ath10k: fix supported band setup

2013-04-25 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This fixes a crash and a possible memleak. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Damn, I broke this. Sorry about it. Applied, thank you for fixing my bug! -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: Handle P2P_GO NOA notification FW 599+

2013-04-25 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: In FW 599+ NOA structure was changed. So we have to change this in case of using newest firmware. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

2013-04-25 Thread Kalle Valo
reliable that way. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

2013-04-25 Thread Kalle Valo
feature jeopardizes normal functionality. What if we just don't support the monitor mode while associated feature? Can we do that? Disclaimer: I haven't looked at your patches -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH] ath10k: fix compilation warning

2013-04-25 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: In function ‘ath10k_pci_probe’: /wireless-testing/drivers/net/wireless/ath/ath10k/pci.c:2150: warning: unused variable ‘hif_type’ Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH v2] ath10k: kill static int max_delay

2013-04-25 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Kill not used max_delay variable Signed-off-by: Janusz Dziedzic janusz.dzie...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

  1   2   3   4   5   >