Re: [PATCH] First HTTP functional test of the RPC interface

2020-04-14 Thread Frédéric Mangano-Tarumi
Lukas Fleischer [2020-04-14 09:36:11 -0400] > On Tue, 14 Apr 2020 at 09:26:44, Frédéric Mangano-Tarumi wrote: > > No way! aur_location refers to the development setup address. Its > > default value in our sample configuration is http://localhost:8080, > > which is fine. Note that in my first test

Re: [PATCH] First HTTP functional test of the RPC interface

2020-04-14 Thread Lukas Fleischer
On Tue, 14 Apr 2020 at 09:26:44, Frédéric Mangano-Tarumi wrote: > Hi Lukas, > > Lukas Fleischer [2020-04-14 08:54:03 -0400] > > On Sun, 12 Apr 2020 at 12:55:46, Frédéric Mangano-Tarumi wrote: > > > +base_uri = aurweb.config.get("options", "aur_location") > > > +proxy =

Re: [PATCH] First HTTP functional test of the RPC interface

2020-04-14 Thread Frédéric Mangano-Tarumi
Hi Lukas, Lukas Fleischer [2020-04-14 08:54:03 -0400] > On Sun, 12 Apr 2020 at 12:55:46, Frédéric Mangano-Tarumi wrote: > > +base_uri = aurweb.config.get("options", "aur_location") > > +proxy = WsgiHttpProxy(base_uri) > > +return werkzeug.test.Client(proxy, Response) > > If I

Re: [PATCH] First HTTP functional test of the RPC interface

2020-04-14 Thread Lukas Fleischer
Hi Frédéric, Thanks for the work! My first thoughts below. On Sun, 12 Apr 2020 at 12:55:46, Frédéric Mangano-Tarumi wrote: > Though barely useful in its current state, it shows how to integrate > pytest with SQLAlchemy and Werkzeug, providing a test framework for the > potential future Flask