Re: [aur-dev] Adding the HE language.

2011-02-17 Thread Lukas Fleischer
On Wed, Feb 16, 2011 at 07:51:32PM +0100, PyroPeter wrote: I changed the things you mentioned and also removed the CSS adjustments. Thanks.

Re: [aur-dev] Adding the HE language.

2011-02-16 Thread Lukas Fleischer
On Tue, Feb 15, 2011 at 09:46:36PM +0100, PyroPeter wrote: On 02/15/2011 09:45 PM, PyroPeter wrote: On 02/12/2011 01:34 PM, Lukas Fleischer wrote: 0004. 76a874a Right-to-left written languages now supported Basically looks ok, except that you revert some previous bug fixes. Also, where's

Re: [aur-dev] Adding the HE language.

2011-02-15 Thread PyroPeter
On 02/12/2011 01:34 PM, Lukas Fleischer wrote: 0003. df02d42 pkg_search_results: replace blind-table with floating div's Basically sounds like a good idea. I'll look into that! I finished updating this. I will now look into the next patch, actually adding rtl-support.

Re: [aur-dev] Adding the HE language.

2011-02-15 Thread PyroPeter
On 02/12/2011 01:34 PM, Lukas Fleischer wrote: 0004. 76a874a Right-to-left written languages now supported Basically looks ok, except that you revert some previous bug fixes. Also, where's that css/languages.css that you link to in the new header template? I now updated this, too. What

Re: [aur-dev] Adding the HE language.

2011-02-14 Thread PyroPeter
On 02/12/2011 01:34 PM, Lukas Fleischer wrote: Wow, I finally found some time to rebase and review all those patches... 0001. 00e497a pkg_search_results: rewrite of page navigation I have to admit that I don't really like that way of pagination. It just feels odd and counter-intuitive imho.

Re: [aur-dev] Adding the HE language.

2011-02-14 Thread Lukas Fleischer
On Mon, Feb 14, 2011 at 09:58:50PM +0100, PyroPeter wrote: I rewrote the pagination a second time, this time without changing the behavoir. Probably the world isn't ready yet for a commit that turns searching into something awesome (tm). (Children would have known what logarithmic scaling

Re: [aur-dev] Adding the HE language.

2011-02-12 Thread Lukas Fleischer
Wow, I finally found some time to rebase and review all those patches... On Tue, Aug 17, 2010 at 04:51:03PM +0200, PyroPeter wrote: I am now splitting the commit into smaller ones. Attached are the first four patches: 0001. 00e497a pkg_search_results: rewrite of page navigation I have to

Re: [aur-dev] Adding the HE language.

2010-11-30 Thread PyroPeter
On 08/17/2010 04:51 PM, PyroPeter wrote: On 08/16/2010 05:47 AM, Loui Chang wrote: I appreciate your efforts PyroPeter. I have some suggestions though. I recommend you to keep your patches small and focused. Here's a guideline: Each of those bullet points above should be at least one commit.

Re: [aur-dev] Adding the HE language.

2010-09-02 Thread PyroPeter
On 08/17/2010 04:51 PM, PyroPeter wrote: Sorry for that, I will try to avoid that in the future. I am now splitting the commit into smaller ones. Attached are the first four patches: 0001. 00e497a pkg_search_results: rewrite of page navigation 0002. b65a5a3 pkg_search_results: increase size of

Re: [aur-dev] Adding the HE language.

2010-08-15 Thread PyroPeter
On 08/14/2010 04:28 PM, Loui Chang wrote: Beats me. It's just a result of people doing whatever needs doing without caring too much where things go. Believe me it was a lot worse. Things have been cleaned up a lot in the last couple years. Anyways if something in particular bothers you, try

Re: [aur-dev] Adding the HE language.

2010-08-15 Thread PyroPeter
On 08/15/2010 02:29 PM, PyroPeter wrote: This is what I have now: (long patch) As AUR is a system mainly used by users of a bleeding-edge distro, I assumed everyone is using a browser supporting CSS 3. The search-results table looks pretty much like

Re: [aur-dev] Adding the HE language.

2010-08-15 Thread Loui Chang
On Mon 16 Aug 2010 01:53 +0200, PyroPeter wrote: Attached is a patch that adds Right-To-Left-support. From the commit message: This replaces most parts of pkg_search_results.php, as this file was the first one I looked at more closely that had great flaws: * The obscure

Re: [aur-dev] Adding the HE language.

2010-08-14 Thread foo bar
On 08/08/2010 12:17 AM, Netanel Shine wrote: btw, it should be RTL, if you didnt know, mybe because of that it display like a bug. If we set the lang-attribute on the body-tag, we can use CSS to swich the whole body to direction:rtl;. (Somehow my chromium does not check the xml-tag's

Re: [aur-dev] Adding the HE language.

2010-08-14 Thread PyroPeter
On 08/14/2010 02:28 PM, foo bar wrote: On 08/08/2010 12:17 AM, Netanel Shine wrote: btw, it should be RTL, if you didnt know, mybe because of that it display like a bug. If we set the lang-attribute on the body-tag, we can use CSS to swich the whole body to direction:rtl;. (Somehow my

Re: [aur-dev] Adding the HE language.

2010-08-14 Thread PyroPeter
On 08/14/2010 03:24 PM, PyroPeter wrote: I just noticed you are setting xml:lang and lang on the html-tag. So there isn't even any change needed. (Btw. that why I hate php, mixing markup and code is extremely obscure) The main problem seems to be the frequency of text-align-declarations in the

Re: [aur-dev] Adding the HE language.

2010-08-14 Thread Loui Chang
On Sat 14 Aug 2010 16:13 +0200, PyroPeter wrote: On 08/14/2010 03:24 PM, PyroPeter wrote: I just noticed you are setting xml:lang and lang on the html-tag. So there isn't even any change needed. (Btw. that why I hate php, mixing markup and code is extremely obscure) The main problem seems

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Loui Chang
On Sun 08 Aug 2010 06:21 +0300, Netanel Shine wrote: For the non-translate strings ill send you a patch, but we have another problem, its shows ok, but it should be RTL not LTR. can you do it some way that if use will choose hebrew the page will become to be RTL? I would appreciate your help

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Ng Oon-Ee
On Sun, 2010-08-08 at 12:33 -0400, Loui Chang wrote: On Sun 08 Aug 2010 06:21 +0300, Netanel Shine wrote: For the non-translate strings ill send you a patch, but we have another problem, its shows ok, but it should be RTL not LTR. can you do it some way that if use will choose hebrew the

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Netanel Shine
Not exactly. you can see in the israeli archlinux communiuty : http://archlinux.org.ilhow the page is RTL (not like the main site of arch.) for now you could deploy to translation (yep, meantime in LTR) but we should all work for working RTL Support. The israeli community is the first archlinux

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread PyroPeter
On 08/08/2010 07:08 PM, Netanel Shine wrote: Not exactly. you can see in the israeli archlinux communiuty : http://archlinux.org.ilhow the page is RTL (not like the main site of arch.) for now you could deploy to translation (yep, meantime in LTR) but we should all work for working RTL

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Netanel Shine
Good idea, i hope someone will do that ;) (and also will deploy and HE lang) On Sun, Aug 8, 2010 at 8:39 PM, PyroPeter abi1...@googlemail.com wrote: On 08/08/2010 07:08 PM, Netanel Shine wrote: Not exactly. you can see in the israeli archlinux communiuty : http://archlinux.org.ilhow the

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Loui Chang
On Sun 08 Aug 2010 20:43 +0300, Netanel Shine wrote: Good idea, i hope someone will do that ;) (and also will deploy and HE lang) On Sun, Aug 8, 2010 at 8:39 PM, PyroPeter abi1...@googlemail.com wrote: It seems like it would be a good idea to add direction:rtl; to the CSS. This makes text

Re: [aur-dev] Adding the HE language.

2010-08-08 Thread Netanel Shine
you can provide for now the HE support? (even its temp without RTL?) On Mon, Aug 9, 2010 at 12:53 AM, Loui Chang louipc@gmail.com wrote: On Sun 08 Aug 2010 20:43 +0300, Netanel Shine wrote: Good idea, i hope someone will do that ;) (and also will deploy and HE lang) On Sun, Aug 8,

Re: [aur-dev] Adding the HE language.

2010-08-07 Thread Loui Chang
On Sat 07 Aug 2010 17:16 +0300, Netanel Shine wrote: Hey there, i was working on translating the AUR to my language, Hebrew. I am adding to this message the gzipped patched file. btw. i know his name lame, but i think he will work just fine. Ah yeah something went wrong with your commit

Re: [aur-dev] Adding the HE language.

2010-08-07 Thread Netanel Shine
Thanks a lot :) fixing it now, something like an hour and i will send just the he.po again On Sun, Aug 8, 2010 at 12:23 AM, Loui Chang louipc@gmail.com wrote: On Sat 07 Aug 2010 17:16 +0300, Netanel Shine wrote: Hey there, i was working on translating the AUR to my language, Hebrew. I

Re: [aur-dev] Adding the HE language.

2010-08-07 Thread Netanel Shine
he.po File, Fixed: On Sun, Aug 8, 2010 at 12:27 AM, Netanel Shine netanelsh...@gmail.comwrote: Thanks a lot :) fixing it now, something like an hour and i will send just the he.po again On Sun, Aug 8, 2010 at 12:23 AM, Loui Chang louipc@gmail.com wrote: On Sat 07 Aug 2010 17:16

Re: [aur-dev] Adding the HE language.

2010-08-07 Thread Loui Chang
On Sun 08 Aug 2010 01:17 +0300, Netanel Shine wrote: btw, it should be RTL, if you didnt know, mybe because of that it display like a bug. Sorry I don't really know what Hebrew is supposed to look like. Is there a problem displaying it properly? http://louipc.mine.nu/images/he.po.jpg

Re: [aur-dev] Adding the HE language.

2010-08-07 Thread Netanel Shine
For the non-translate strings ill send you a patch, but we have another problem, its shows ok, but it should be RTL not LTR. can you do it some way that if use will choose hebrew the page will become to be RTL? On Sun, Aug 8, 2010 at 4:30 AM, Loui Chang louipc@gmail.com wrote: On Sun 08 Aug