Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:48:23, Gordian Edenhofer wrote: [...] Having a dummy file in the git repo and the true file for the checksum is somewhat odd. Using SKIP is also not a true alternative IMHO. True. Missing source files are somewhat odd, too, though. You could argue that pretending to

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Gordian Edenhofer
[...] This kind of check would see files which are named e.g. lp:foo as not missing even if they are. Sure, we only check local files and lp:foo is a remote file. Checking remote sources is something that we cannot do properly. I did not suggest checking remote sources. My question

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread carstene1ns
Am 31.05.2015 um 20:14 schrieb Daniel Wallace: How does this affect stuff like the different humble bundle games in the aur? You have to download the source and put it in the source directory so I don't think it will be in the commit tree? Thanks Sent from my iPhone On May 31,

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Marcel Korpel
* Lukas Fleischer lfleisc...@archlinux.org (Mon, 01 Jun 2015 00:28:56 +0200): On Mon, 01 Jun 2015 at 00:07:58, Marcel Korpel wrote: Isn't there a check of checksums before files are added to the index (through mksrcinfo/makepkg)? If that's not the case, I stand corrected. Right, I forgot

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 15:09:43, Gordian Edenhofer wrote: [...] This kind of check would see files which are named e.g. lp:foo as not missing even if they are. Sure, we only check local files and lp:foo is a remote file. Checking remote sources is something that we cannot do

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Gordian Edenhofer
On Mon, 2015-06-01 at 15:34 +0200, Lukas Fleischer wrote: On Mon, 01 Jun 2015 at 15:09:43, Gordian Edenhofer wrote: [...] This kind of check would see files which are named e.g. lp:foo as not missing even if they are. Sure, we only check local files and lp:foo is a

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Marcel Korpel
* Daniel Wallace danielwall...@gtmanfred.com (Sun, 31 May 2015 14:33:38 -0500): The names usually end in 'hib' instead of humble bundle, standing for Humble Indie Bundle, but there are several other things out there that are similar to this. Ah, now I understand. But those packages contain

[aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
Suggested-by: Marcel Korpel marcel.li...@gmail.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- scripts/git-integration/git-update.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/git-integration/git-update.py b/scripts/git-integration/git-update.py index

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Sun, 31 May 2015 at 20:14:22, Daniel Wallace wrote: How does this affect stuff like the different humble bundle games in the aur? You have to download the source and put it in the source directory so I don't think it will be in the commit tree? [...] Good question. There are two

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: * Daniel Wallace danielwall...@gtmanfred.com (Sun, 31 May 2015 14:33:38 -0500): The names usually end in 'hib' instead of humble bundle, standing for Humble Indie Bundle, but there are several other things out there that are similar to

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Marcel Korpel
* Lukas Fleischer lfleisc...@archlinux.org (Sun, 31 May 2015 21:16:09 +0200): On Sun, 31 May 2015 at 20:14:22, Daniel Wallace wrote: How does this affect stuff like the different humble bundle games in the aur? You have to download the source and put it in the source directory so I don't

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:07:58, Marcel Korpel wrote: * Lukas Fleischer lfleisc...@archlinux.org (Sun, 31 May 2015 22:49:19 +0200): On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: Nevertheless, there are other cases I didn't think of, like

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Gordian Edenhofer
On Mon, 2015-06-01 at 00:25 +0200, Lukas Fleischer wrote: On Mon, 01 Jun 2015 at 00:00:31, Gordian Edenhofer wrote: [...] Why are checksums an issue? You can use the checksum of the correct file. It doesn't match the checksum of the dummy file but I don't see how that is an

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Marcel Korpel
* Lukas Fleischer lfleisc...@archlinux.org (Sun, 31 May 2015 22:49:19 +0200): On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: Nevertheless, there are other cases I didn't think of, like https://aur.archlinux.org/packages/ttf-ms-win8/ where source files should be provided by the user.

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:00:31, Gordian Edenhofer wrote: [...] Why are checksums an issue? You can use the checksum of the correct file. It doesn't match the checksum of the dummy file but I don't see how that is an issue (it is even good since the user immediately notices that

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Gordian Edenhofer
On Sun, 2015-05-31 at 22:49 +0200, Lukas Fleischer wrote: On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: * Daniel Wallace danielwall...@gtmanfred.com (Sun, 31 May 2015 14:33:38 -0500): The names usually end in 'hib' instead of humble bundle, standing for Humble Indie Bundle,

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Daniel Wallace
The names usually end in 'hib' instead of humble bundle, standing for Humble Indie Bundle, but there are several other things out there that are similar to this. https://aur.archlinux.org/packages/?O=0C=0SeB=ndK=hiboutdated=SB=nSO=aPP=50do_Search=Go On Sun, May 31, 2015 at 2:23 PM, Marcel Korpel