One of the opt-depend packages my disklow is using, "msmtp-mta", is
containing a single symlink (/usr/bin/sendmail => msmtp). Perhaps, I should
have a look at its PKGBUILD (it's most likely simply calling "ln -s" in its
install() section).
But what would the symbolic link be needed for?
On Tue, Sep 03, 2019 at 10:52:36 +1200, Holger Jahn wrote:
> > The AUR does not provide source code hosting, on the grounds that other
> > places like Github, Gitlab, git.sr.ht, amd so on are doing it better.
> > Moreover, source code hosting is a resource burden on the provider,
> > which in our
The AUR does not provide source code hosting, on the grounds that other
places like Github, Gitlab, git.sr.ht, amd so on are doing it better.
Moreover, source code hosting is a resource burden on the provider,
which in our case we do not have either a business or community
rationale for
On September 2, 2019 4:47:08 PM GMT+02:00, Eli Schwartz via aur-general
wrote:
>On 9/2/19 6:50 AM, Khorne via aur-general wrote:
>
>> More importantly it seems to me that you switched url and source
>> around. The source array is used to define where to find (and
>> potentially download) the
On 9/2/19 6:50 AM, Khorne via aur-general wrote:
> Few style things:
> - remove unused directives
> - packages always provide themselves
Or as I prefer to describe it:
Packages cannot logically provide themselves, they already *are* themselves.
> More importantly it seems to me that you
On 9/2/19 7:31 AM, Holger Jahn wrote:
> Hi Daniel,
>
> Thanks for your review.
>
>> You'll need to install the PerlArtistic license.
>
> What exactly do you mean by "install the license"? Put a copy of it into
> the package?
core/licenses provides
Holger,
On Mon, Sep 02, 2019 at 11:31:27PM +1200, Holger Jahn wrote:
> What exactly do you mean by "install the license"? Put a copy of it into the
> package?
I spoke too hastily here. Per the packaging guidelines [1] unusual
licenses should be installed in /usr/share/licenses/${pkgname}.
Hi Daniel,
Thanks for your review.
You'll need to install the PerlArtistic license.
What exactly do you mean by "install the license"? Put a copy of it into
the package?
This may be a small tool, but you're not really supposed to host the
source code in the AUR. It should be hosted
Hi Khorne,
Thanks for your review.
More importantly it seems to me that you switched url and source around. The
source array is used to define where to find (and potentially download) the
sources. The url array is just a general hint, for example to an upstream
project page.
I understand.
On 02/09/2019 12:31, Holger Jahn wrote:
Good evening,
If someone would be interested in reviewing my first contribution to
Arch, disklow, then that would be much appreciated.
Many thanks,
Holger
In addition to what have already been said; should always quote
variables containing paths
See my comments inline.
On Mon, Sep 02, 2019 at 10:31:54PM +1200, Holger Jahn wrote:
> Good evening,
>
> If someone would be interested in reviewing my first contribution to Arch,
> disklow, then that would be much appreciated.
>
> Many thanks,
>
> Holger
>
>
> ###
> ### maintainer: holger
On September 2, 2019 12:31:54 PM GMT+02:00, Holger Jahn
wrote:
>Good evening,
>
>If someone would be interested in reviewing my first contribution to
>Arch, disklow, then that would be much appreciated.
>
>Many thanks,
>
>Holger
Hi Holger,
Few style things:
- remove unused directives
-
12 matches
Mail list logo
