Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-12 Thread Paolo Bonzini
>> ac_c_check_func() { >> if test $ac_cv...; then >> ... >> else >> ac_c_link_ifelse() { >> } >> fi >> } >> >> which does not work of course. > > For me mere mortal, who doesn't wade in the problems you've studied in > detail, what exactly is problematic here? S

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-12 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Sun, Oct 12, 2008 at 06:20:53PM CEST: > Hi, I know I should be writing testcases for AS_ME_PREPARE. :-) But > while I was looking at adding shell functions to Autoconf proper, I > decided that the current basic implementation of AS_REQUIRE is not > scalable. > >

[PATCH] use m4_require to implement AS_REQUIRE

2008-10-12 Thread Paolo Bonzini
Hi, I know I should be writing testcases for AS_ME_PREPARE. :-) But while I was looking at adding shell functions to Autoconf proper, I decided that the current basic implementation of AS_REQUIRE is not scalable. In particular, AC_CHECK_FUNC will need its own shell function, plus the one for AC_LI

Re: [PATCH 2/3] Add and document AS_ME_PREPARE and AS_LINENO_PREPARE

2008-10-12 Thread Paolo Bonzini
Paolo Bonzini wrote: >> How about also adding tests for them? > > Okay, I will. This should be enough for AS_LINENO_PREPARE: 2008-10-12 Paolo Bonzini <[EMAIL PROTECTED]> * tests/m4sh.at: Use documented AS_LINENO_PREPARE. diff --git a/tests/m4sh.at b/tests/m4sh.at index d8542ed..854b4

Re: [PATCH 2/3] Add and document AS_ME_PREPARE and AS_LINENO_PREPARE

2008-10-12 Thread Paolo Bonzini
> How about also adding tests for them? Okay, I will. > In fact, I think this is a good first approximation (note embedded TAB): > > git diff HEAD ChangeLog | > sed -n '/^+$/,$s/^+ //p' | > sed '1a\ > ' Aha, I see. I'm currently using my own script for that as a prepare-commit-msg hook, I'll

Re: [PATCH 2/3] Add and document AS_ME_PREPARE and AS_LINENO_PREPARE

2008-10-12 Thread Ralf Wildenhues
Hi, > Paolo Bonzini writes: > > > > This patch documents $as_me and $LINENO, which are the sole constructs > > (for now) that explicitly require a *_PREPARE macro because they are > > variables. So those are defined without the hyphen and documented. How about also adding tests for them? Anyth

Re: [PATCH] paginate output of configure --help

2008-10-12 Thread Ralf Wildenhues
Hi William, * William Pursell wrote on Sun, Oct 12, 2008 at 08:57:50AM CEST: > Eric Blake wrote: >> >> Furthermore, your patch still has some portability problems. For example, >> ... you cannot rely on the existence of mktemp. > > I don't want to consume a lot of your time answering ignorant > q