Hello Ralf.
There's still a wart to be fixed before this patch series can be
committed ...
On Thursday 13 January 2011, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET:
On Wednesday 12 January 2011, Ralf Wildenhues wrote:
So, now with that said, I'm
[Ralf Wildenhues]
If some code later calls it like
process_option_list (first-set-of-options);
process_option_list (second-set-of-options);
then things will go wrong again. I suspect that it will mean that
AM_INIT_AUTOMAKE([foreign -Wno-portability])
* Stefano Lattarini wrote on Thu, Jan 13, 2011 at 10:27:48PM CET:
On Thursday 13 January 2011, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET:
On Wednesday 12 January 2011, Ralf Wildenhues wrote:
So, now with that said, I'm not sure whether I
* Stefano Lattarini wrote on Fri, Jan 14, 2011 at 12:11:27AM CET:
[Ralf Wildenhues]
If some code later calls it like
process_option_list (first-set-of-options);
process_option_list (second-set-of-options);
then things will go wrong again. I suspect that it will mean
Here comes my (belated, as always) re-review; I am not repeating nits
already dealt with before.
* Stefano Lattarini wrote on Wed, Jan 05, 2011 at 08:22:13PM CET:
On Wednesday 05 January 2011, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET:
This is
On Wednesday 12 January 2011, Ralf Wildenhues wrote:
Here comes my (belated, as always) re-review; I am not repeating nits
already dealt with before.
* Stefano Lattarini wrote on Wed, Jan 05, 2011 at 08:22:13PM CET:
On Wednesday 05 January 2011, Ralf Wildenhues wrote:
* Stefano Lattarini
* Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET:
On Wednesday 12 January 2011, Ralf Wildenhues wrote:
So, now with that said, I'm not sure whether I should approve this
patch. What do you think?
I think that you should, provided that I add the sanity check you
suggested
* Stefano Lattarini wrote on Wed, Jan 05, 2011 at 08:22:13PM CET:
On Wednesday 05 January 2011, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET:
+ # will take precedence over warning settings defined implicitly by the
+ # strictness.
Well,
On Wednesday 05 January 2011, Ralf Wildenhues wrote:
Hi Stefano,
* Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET:
This is derived from [PATCH 07/10] of the older series.
It requires a review.
Thank you for rewriting the patch.
Really you should thank git rebase -i ;-)
