Re: [PATCH] awful.tag: fix tag history

2009-08-30 Thread koniu
On Fri, Aug 28, 2009 at 09:57, Julien Danjoujul...@danjou.info wrote: +        if not data.history[screen] then +          data.history[screen] = {} Bad indent. Fixed. +        -- limit history +        elseif #data.history[screen] == history.limit then +            

Re: [PATCH] awful.tag: fix tag history

2009-08-28 Thread Julien Danjou
At 1251393183 time_t, koniu wrote: +if not compare_select(curtags, data.history.current[screen]) and #selectedlist(screen) 0 then +-- create history table +if not data.history[screen] then + data.history[screen] = {} Bad indent. +-- limit history +

Re: [PATCH] awful.tag: fix tag history

2009-08-27 Thread koniu
W: awesome: luaA_dofunction:113: error while running function stack traceback:        /usr/local/share/awesome/lib/awful/tag.lua:107: in function 'press'        /usr/local/share/awesome/lib/awful/key.lua:36: in function /usr/local/share/awesome/lib/awful/key.lua:36 error:

Re: [PATCH] awful.tag: fix tag history

2009-08-27 Thread Julien Danjou
At 1251387477 time_t, koniu wrote: Sometimes meaning right after reload or after repeated restore until you run out of history entries? Indeed, I didnt add handling of restore when there's nothing recorded. No, I don't think so. I'm using it like a dumb user: I switch to tag 1; I switch to

Re: [PATCH] awful.tag: fix tag history

2009-08-27 Thread Julien Danjou
At 1251387674 time_t, koniu wrote: Actually this is different issue, L107:s/screen/s/ ? Try the amended patch as attached. Seems better indeed! Seems ok to merge, except that there's still 3 things that I'd like: - Configurable history limit (20 is arbitrary) a variable in the module that

Re: [PATCH] awful.tag: fix tag history

2009-08-27 Thread koniu
A little amendment to the 1st patch - typo in a comment + dirty whitespace. k From 275eeb31ab4e2e9badc63cbcf637efff3b0c8a8b Mon Sep 17 00:00:00 2001 From: koniu gkusni...@gmail.com Date: Thu, 27 Aug 2009 15:03:45 +0100 Subject: [PATCH 1/4] awful.tag: fix and improve tag history This fixes a long