[Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I'm currently trying to make my config work with current master. One thing I found: awful.widget.graph and .progressbar don't offer the same features their C counterparts had. I'll see if I write some patches on this... The first patch makes

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: The first patch makes awful.wibox() work with non-north orientation and user-specified geometries. I'm just a human Attached is a New and Improved (tm) version of this first patch. Cheers, Uli - -- Do you know that

Re: [Patch] Some fixes

2009-06-06 Thread calmar c.
On Sat, Jun 06, 2009 at 03:23:03PM +0200, Julien Danjou wrote: Let's see which other patches I will come up with... (Anyone wants to enhance awful.widget.*? vertical progressbars and graphs with more than one graph sound like a goal (I use one graph which shows used mem and

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244286306 time_t, Uli Schlachter wrote: I'm currently trying to make my config work with current master. One thing I found: awful.widget.graph and .progressbar don't offer the same features their C counterparts had.

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 calmar c. wrote: On Sat, Jun 06, 2009 at 03:23:03PM +0200, Julien Danjou wrote: Let's see which other patches I will come up with... (Anyone wants to enhance awful.widget.*? vertical progressbars and graphs with more than one graph sound

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244300756 time_t, Marco Candrian wrote: the graph has more than one thing. You can use a line style to have one over all others. You would be able to do the same with the widget layouts, AFAIU. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244305993 time_t, Uli Schlachter wrote: @Julien: Apropos, any reason why we can't have 'scale = true'? Would you mind a patch which adds this back, too? And if we have auto-scaling, adding back max_value (currently it requires values between 0 and 1) wouldn't be much work either I

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244303844 time_t, Uli Schlachter wrote: And if I want this now and not in 6 months? You help Gregor? Or stay with 3.3 or the old widget for the time being. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD //

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244306622 time_t, Julien Danjou wrote: You help Gregor? Or stay with 3.3 or the old widget for the time being. FWIW, I don't think like I need to justificate what I did, but removing the progressbar and graph from the C side will drop around 1K SLOC, which is just around 8 % of core size. A

Re: [Patch] Some fixes

2009-06-06 Thread calmar c.
On Sat, Jun 06, 2009 at 06:33:13PM +0200, Uli Schlachter wrote: [...] [fg_center] = beautiful.gr_cpu_nice_center, [fg_end] = beautiful.gr_cpu_nice_end, [vertical_gradient] = true, [scale] = false, [max_value] = 100.0, [style] = line }) This doesn't work in master

Re: [Patches] wibox handling in git

2009-06-06 Thread Gregor Best
Any updates on rejection / integration? -- GCS/IT/M d- s+:- a--- C++ UL+++ US UB++ P+++ L+++ E--- W+ N+ o-- K- w--- O M-- V PS+ PE- Y+ PGP+++ t+ 5 X+ R tv+ b++ DI+++ D+++ G+ e- h! r y+ Gregor Best pgpUX5eOU8t6l.pgp Description: PGP signature

Re: [Patch] Some fixes

2009-06-06 Thread Gregor Best
On Sat, Jun 06, 2009 at 07:50:08PM +0200, Julien Danjou wrote: At 1244307769 time_t, Gregor Best wrote: I think Uli means not stacking two graphs on top of each other, which is certainly possible with widget layouts, but he means superimposing two graphs so that they are both drawn in the

Re: [Patch] Some fixes

2009-06-06 Thread Gregor Best
On Sat, Jun 06, 2009 at 07:59:45PM +0200, Julien Danjou wrote: At 1244310858 time_t, Gregor Best wrote: Only if imageboxes and their drawing code support transparency :) Else the last-drawn graph would completely occlude the first-drawn which would make the first-drawn invisible It does,

Re: [Patches] wibox handling in git

2009-06-06 Thread Julien Danjou
At 1244224475 time_t, Gregor Best wrote: Pushed, thanks Gregor. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // This is the end of my signature. signature.asc Description: Digital signature

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244286306 time_t, Uli Schlachter wrote: If a wibox with non-north geometry was created and a wibox size was specified, this function happily ignored it when it made the wibox fit. The hunk in wibox.c partly reverts 7cc0b13eae2638aaab40bfd1632036a6bea4d8d4. No idea if this is a good idea

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244292328 time_t, Uli Schlachter wrote: I'm just a human Attached is a New and Improved (tm) version of this first patch. Me too, ignore my previous mail. --- lib/awful/wibox.lua.in | 11 +-- wibox.c|4 ++-- 2 files changed, 11 insertions(+), 4

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244311597 time_t, Gregor Best wrote: Maybe I should write awful.widget.layout.sameplace then which draws all its widgets onto the same space. I'd be grateful for test cases, because my experience with graph and progressbar widgets is nearly nil Hum, IIRC 'sameplace' algo was the default is

Re: [Patch] Some fixes

2009-06-06 Thread Gregor Best
On Sat, Jun 06, 2009 at 08:35:19PM +0200, Julien Danjou wrote: At 1244311597 time_t, Gregor Best wrote: Maybe I should write awful.widget.layout.sameplace then which draws all its widgets onto the same space. I'd be grateful for test cases, because my experience with graph and progressbar

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244292328 time_t, Uli Schlachter wrote: I'm just a human Attached is a New and Improved (tm) version of this first patch. Me too, ignore my previous mail. --- lib/awful/wibox.lua.in | 11 +--

Re: [Patch] Some fixes

2009-06-06 Thread calmar c.
On Sat, Jun 06, 2009 at 08:08:28PM +0200, Julien Danjou wrote: No, it's about code maintainability. 200 SLOC of Lua beats - by large - more than 1 K SLOC of C. :-) then again, the C code seemed to have worked nicely. It's also a seperate file etc. - nothing to care for all the time? I actually

Re: [Patch] Some fixes

2009-06-06 Thread Julien Danjou
At 1244317804 time_t, Marco Candrian wrote: then again, the C code seemed to have worked nicely. It's also a seperate file etc. - nothing to care for all the time? Not really. That's evolution: adapt or die. And that's how every part of awesome's code works. I'm sorry that people feel sad when

Re: [ANNOUNCE] awesome 3.3 released

2009-06-06 Thread Julien Danjou
At 1244321281 time_t, Martin Stubenschrott wrote: Is there a roadmap wiki or something? I'd be nice to know which are the 3-4 most relevant things which are being worked on for 3.4? Not really, I keep my TODO private for no reasons. I used to use FS, but I'm not that comfortable with it

Re: [Patch] Some fixes

2009-06-06 Thread calmar c.
On Sat, Jun 06, 2009 at 10:45:54PM +0200, Julien Danjou wrote: At 1244317804 time_t, Marco Candrian wrote: then again, the C code seemed to have worked nicely. It's also a seperate file etc. - nothing to care for all the time? awesome's code works. I'm sorry that people feel sad when their