Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 00:39, Anurag Priyam wrote: On Fri, Feb 17, 2012 at 4:01 AM, Anurag Priyam anurag08pri...@gmail.com wrote: [...] However, most of the times starting to iterate from the currently focused client helps, so I can iterate through Chrome instances in order starting from the one

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:04 PM, Uli Schlachter psyc...@znc.in wrote: I just noticed that this would bring us awful.util.cycle and awful.util.table.cycle which do completely different things. How about awful.util.table.iterate? Anyone has any good ideas? (I definitely don't) I want to keep the

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:41 PM, Anurag Priyam anurag08pri...@gmail.com wrote: Also: Urgh, really have to add br / inside of code examples? :-( Yeah.  Otherwise all code comes up on the same line in the final HTML out.  This is the most important reason for which I want to see markdown in

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 16:11, Anurag Priyam wrote: On Fri, Feb 17, 2012 at 8:04 PM, Uli Schlachter psyc...@znc.in wrote: [...] Thanks, both patches are merged. However, I had to mess with the commit messages (my git hooks refuse commits with a too long summary) and I added some luadoc for the new s

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:52 PM, Uli Schlachter psyc...@znc.in wrote: Thanks, both patches are merged. However, I had to mess with the commit messages (my git hooks refuse commits with a too long summary) and I added some luadoc for the new s argument. Yeah, first one was 80 or 81 chars.

Re: Need help submitting menubar

2012-02-17 Thread Uli Schlachter
On 15.02.2012 23:22, Alexander Yakushev wrote: OK, then here's the first round. I've put the whole extension into the separate lib/menubar directory and modified existing lib/awful/prompt.lua. Things I changed inside prompt.lua: - introduced two more arguments to run() function -

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 16:44, Anurag Priyam wrote: On Fri, Feb 17, 2012 at 8:52 PM, Uli Schlachter psyc...@znc.in wrote: Thanks, both patches are merged. However, I had to mess with the commit messages (my git hooks refuse commits with a too long summary) and I added some luadoc for the new s

Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
Thanks for the detailed review, Uli! I completely agree with nearly everything you noted. There are but a few things that I don't quite understand. +-- Generate a pattern matching expression that ignores case. +-- @param s Original pattern matching expresion. +local function nocase (s) +s

Re: Need help submitting menubar

2012-02-17 Thread Uli Schlachter
On 17.02.2012 22:55, Alexander Yakushev wrote: Thanks for the detailed review, Uli! I completely agree with nearly everything you noted. There are but a few things that I don't quite understand. +-- Generate a pattern matching expression that ignores case. +-- @param s Original pattern

Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
On 02/18/2012 12:03 AM, Uli Schlachter wrote: How about doing stuff the other way around: Instead of making a magic-pattern, you could run the client's name through string.lower(). That is an option, but then I need to run string.lower() on every application name I'm filtering through. Not that

Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
Oh, and one more thing. On 02/17/2012 05:53 PM, Uli Schlachter wrote: +prompt.run({ prompt = Run app: , bg_cursor = #22 }, instance.prompt.widget, function(s) end, + nil, awful.util.getdir(cache) .. /history_menu, nil, hide, + menulist_update, +