[PATCH] Error out when creating a simplewindow with invalid geometries

2009-03-17 Thread Uli Schlachter
the following lua fragment: naughty.config.border_width = 50 naughty.notify({ text = test }) Signed-off-by: Uli Schlachter psyc...@znc.in - --- swindow.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/swindow.c b/swindow.c index 487ad8e..423d174 100644

[PATCH] awesome-client: Don't go into an endless loop if awesome dies

2009-03-17 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This patch makes awesome-client give up after 10 tries when it lost the connection to awesome. Also it now waits for some time between reconnect attempts. I like the behaviour of this, but some of the code seems a little icky... Signed-off-by: Uli

Re: openafs+awesome bug

2009-03-18 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alex Cornejo wrote: Hi ppl, A lot of universities (and corporations) use kerberos for authentication and OpenAFS to host the folders. However, it is not possible to create sockets on OpenAFS (this is probably true for other remote/distributed

Leaking FDs to childs started by awful.util.spawn() and close-on-exec

2009-04-02 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, recently I noticed that all my processes had a pipe as FD 3 and 4 which seemed to come from awesome. Some investigation revealed that they come from my .xsession (I don't know why yet), but I also found cases where awesome leaked FDs to child

[PATCH 2/4] Make the sockets which listens for new awesome-clients close-on-exec

2009-04-02 Thread Uli Schlachter
Signed-off-by: Uli Schlachter psyc...@znc.in --- common/socket.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/socket.c b/common/socket.c index a8d148f..7d6e461 100644 --- a/common/socket.c +++ b/common/socket.c @@ -122,6 +122,8 @@ socket_getclient(void

[PATCH 3/4] Mark the connection to the X server as close-on-exec

2009-04-02 Thread Uli Schlachter
Signed-off-by: Uli Schlachter psyc...@znc.in --- awesome.c |4 luaa.c|2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/awesome.c b/awesome.c index 26bd86c..507fcbe 100644 --- a/awesome.c +++ b/awesome.c @@ -44,6 +44,7 @@ #include common/version.h #include

[PATCH 4/4] Mark new sockets to awesome-clients as close-on-exec

2009-04-02 Thread Uli Schlachter
Signed-off-by: Uli Schlachter psyc...@znc.in --- luaa.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/luaa.c b/luaa.c index f624841..74a32fd 100644 --- a/luaa.c +++ b/luaa.c @@ -1100,6 +1100,11 @@ luaA_conn_cb(EV_P_ ev_io *w, int revents) ev_io *csio_conn

[PATCH 1/4] Add socket_close_on_exec() for marking sockets as close-on-exec

2009-04-02 Thread Uli Schlachter
Signed-off-by: Uli Schlachter psyc...@znc.in --- common/socket.c | 13 + common/socket.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/common/socket.c b/common/socket.c index 80e1438..a8d148f 100644 --- a/common/socket.c +++ b/common/socket.c @@ -25,6

Re: [PATCH 3/4] Mark the connection to the X server as close-on-exec

2009-04-02 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1238670195 time_t, Uli Schlachter wrote: Useless, libxcb already does it. Cheers, Then... why does awesome still close that socket by hand? - -- Do you know that books smell like nutmeg or some spice from a foreign

[PATCH] luaA_isloop() should only check for tables appearing multiple times

2009-04-03 Thread Uli Schlachter
For example, without this patch, the following table would be said to be looping: { a = asd, b = asd } I think this could also be triggered if a widget appeared twice in a wibox. Signed-off-by: Uli Schlachter psyc...@znc.in --- luaa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [PATCH] luaA_isloop() should only check for tables appearing multiple times

2009-04-03 Thread Uli Schlachter
Julien Danjou wrote: At 1238751148 time_t, Uli Schlachter wrote: For example, without this patch, the following table would be said to be looping: { a = asd, b = asd } I think this could also be triggered if a widget appeared twice in a wibox. Hum, yeah. Fixed it in an other way. Can

Re: [PATCH] why hardcode the 'default' tag

2009-04-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 koniu wrote: Hi, I was wondering if there's a strong reason for having the hardcoded bit forcing default tag to be created if there are no tags in the screen. I think that this should be left to lua side - with the current default rc.lua never

Re: [PATCH] why hardcode the 'default' tag

2009-04-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 koniu wrote: Hi, if you restart awesome and the rc.lua doesnt create any tags at all, what happens? When I was using shifty I used to lose a couple of windows across awesome restart. They just disappeared, but the app was still running. If

[PATCH] Rename LAYER_OUTOFSPACE to LAYER_MAX

2009-04-10 Thread Uli Schlachter
The name LAYER_OUTOFSPACE suggests that this is a real layer on which windows can be put, but it's only used as an integer which describes the maximum allowed / used layer. Therefor, renaming it to LAYER_MAX and adding a comment which describes this might make sense. Signed-off-by: Uli Schlachter

[PATCH] wibox: Don't display garbage when a wibox is made visible

2009-04-10 Thread Uli Schlachter
I did the following and the wibox displayed garbage: local w = wibox({ position = floating, bg = #ff }) w.visible = false w.screen = 1 do some other stuff w.visible = true Signed-off-by: Uli Schlachter psyc...@znc.in --- wibox.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH] client_stack(): Only stack windows once per mainloop

2009-04-10 Thread Uli Schlachter
which is later checked. This should reduce the number of restacks to the bare minimum. With this patch, neither xcb_configure_window() nor anything else client_stack() related shows up as having a lot of calls or using much cpu time. Signed-off-by: Uli Schlachter psyc...@znc.in --- client.c | 21

[PATCH] Rename LAYER_OUTOFSPACE to LAYER_COUNT

2009-04-10 Thread Uli Schlachter
The name LAYER_OUTOFSPACE suggests that this is a real layer on which windows can be put, but it's only used as an integer which describes the maximum allowed / used layer. Therefor, renaming it to LAYER_COUNT and adding a comment which describes this might make sense. Signed-off-by: Uli

[PATCH] Move the definition of globalconf into a header file

2009-04-10 Thread Uli Schlachter
Pretty much every single source file needs this struct, so it makes sense to define it in a common header instead of in every single .c file. Signed-off-by: Uli Schlachter psyc...@znc.in --- client.c |2 -- dbus.c|2 -- draw.c|2

Re: [PATCH] wibox: Don't display garbage when a wibox is made visible

2009-04-10 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1239354821 time_t, Uli Schlachter wrote: local w = wibox({ position = floating, bg = #ff }) w.visible = false w.screen = 1 do some other stuff w.visible = true Good catch. --- wibox.c |2 ++ 1 files

Re: [PATCH] wibox: Don't display garbage when a wibox is made visible

2009-04-10 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1239369215 time_t, Uli Schlachter wrote: attached is the new version of that patch. It adds a new function wibox_map() which maps the wibox's window and makes sure it is correctly drawn. In my testing this results

Re: [PATCH] client_stack(): Only stack windows once per mainloop

2009-04-10 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1239378506 time_t, Uli Schlachter wrote: Here is the new version of the patch, rebased on top of latest master. Pushed. PS: I'd suggest you publish a branch online so I can merge, since you are sending a lot of patch

Re: [Patch] export image drawing routines to Lua

2009-04-16 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1239844131 time_t, Gregor Best wrote: +static int +luaA_image_draw_rectangle(lua_State *L) +{ +size_t len; +xcolor_t color; +image_t *image = luaL_checkudata(L, 1, image); +int x = luaL_checkint(L, 2);

Re: [Patch] export image drawing routines to Lua

2009-04-16 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1239871750 time_t, Uli Schlachter wrote: How bad would it be to add color objects to lua? They do xcolor_init_unchecked() when they are created and the xcolor_init_reply() can be delayed until they are actually used

color management API thoughts

2009-04-16 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, despite having no time I looked into the xcolor_t API. I noticed that for colors like #123456 this code splits everything up into red / green / blue components and then does a query to the X server for the pixel value which goes together with

Re: New color management API

2009-04-18 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: Hi Uli, At 1239996846 time_t, Uli Schlachter wrote: First, thanks for your work. +/** Send a request to initialize a color. + * \param color color_t struct to store color into. + * \param colstr Color specification

[PATCH] Fix typo

2009-04-18 Thread Uli Schlachter
. Signed-off-by: Uli Schlachter psyc...@znc.in - --- Since thunderbird seems to wrap my patches again and I'm too lazy to attach it: This patch is also available at: git://git.znc.in/psychon/awesome.git naughty-fix lib/naughty.lua.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Using rlwrap in awesome-client

2009-04-18 Thread Uli Schlachter
) iEYEARECAAYFAknprPgACgkQABixOSrV99/wjwCfQUPXYm8ekmNl32n19w3w5tqS bAYAni9zKFfqNaIhzcjdvcFxJPBr5AWB =KZiS -END PGP SIGNATURE- From 60595c55cbe64de8f34f5084b3517c85a1d7d1af Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Sat, 18 Apr 2009 12:26:31 +0200 Subject: [PATCH] awesome-client: Use

Re: [RFC + PATCH] awful.doc

2009-04-24 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Danjou wrote: At 1240582243 time_t, koniu wrote: I'm not 100% sure what you mean here, you didn't give an explicit reason why it's but from what I understand you don't want the filter function hardcoded like this. We can give possibility of

Speeding up awful.client.setslave() / tasklist

2009-05-08 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, today I had some fun with wm_torture[1] thanks to jd_ and I also had some fun with another profiler[2] for lua which produces callgrind-like files which can be opened in kcachegrind. The throughput test was interesting (tests done with awesome

3.3-rc1 crash bug (?)

2009-05-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, no idea what exactly just happened, but awesome crashed when I pressed ctrl-q in konqueror. Syslog says: May 9 10:49:21 psytux kernel: [ 8809.790642] awesome[4487]: segfault at 257a000 ip 0032a5c7d511 sp 7fffbd55e868 error 4 in

Re: 3.3-rc1 crash bug (?)

2009-05-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1241861577 time_t, Uli Schlachter wrote: I have no idea what caused this and it doesn't seem reproducible which is why I won't open a bug report. I'm updating to rc2 now and I will run awesome in valgrind. Let's see

Re: 3.3-rc1 crash bug (?)

2009-05-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mariusz Ceier wrote: Uli Schlachter pisze: Julien Danjou wrote: At 1241861577 time_t, Uli Schlachter wrote: I have no idea what caused this and it doesn't seem reproducible which is why I won't open a bug report. I'm updating to rc2 now and I

Pull request - random build stuff and some minor config cleanup

2009-05-09 Thread Uli Schlachter
for libs are available in the git repository at: git://git.znc.in/psychon/awesome.git for-jd Uli Schlachter (8): Fix a wrong leading space in gperf.sh's shebang Remove some useless use of cat Fix a bashism in gperf.sh Use 'sh' instead of 'sh -e' Use tr [:lower

Re: 3.3-rc1 crash bug (?)

2009-05-11 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1241874772 time_t, Uli Schlachter wrote: Well, I went with valgrind and now got this backtrace (man, I miss debugging symbols... btw I still can't compile awesome due to some missing dependencies). Anyone got some ideas

Re: 3.3-rc1 crash bug (?)

2009-05-12 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Julien Danjou wrote: At 1241874772 time_t, Uli Schlachter wrote: Well, I went with valgrind and now got this backtrace (man, I miss debugging symbols... btw I still can't compile awesome due to some missing dependencies

Invalid _NET_WM_ICONs not properly caught

2009-05-12 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, while trying to find a reason for the crash I've been seeing with rc2, I noticed that awesome doesn't properly handle invalid _NET_WM_ICONs. It just assumes the width and height reported in the property is valid, even if the property is much

Re: 3.3-rc1 crash bug (?)

2009-05-14 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Nikos Ntarmos wrote: Hi there. FWIW I've also been experiencing segfaults on FreeBSD/i386, however only when X goes down before awesome. A short look into this revealed it was due to widgets update hooks being scheduled for some time after

Re: 3.3-rc1 crash bug (?)

2009-05-14 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Uli Schlachter wrote: Julien Danjou wrote: At 1241874772 time_t, Uli Schlachter wrote: Well, I went with valgrind and now got this backtrace (man, I miss debugging symbols... btw I still can't compile awesome due to some

Re: 3.3-rc1 crash bug (?)

2009-05-18 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1242331287 time_t, Uli Schlachter wrote: And another backtrace, this time with gdb... The plan for is to finally use -O0 -fno-inline and see what happens. (btw yay, finally done with school and I got time for this!) (Oh

Build breakage [was: Updated patch: Unfocused titlebar icons look bad on non-black background]

2009-05-18 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1242491867 time_t, Johan Kiviniemi wrote: Sorry for the flood. Attached is a new version of the patch with the values tweaked to resemble the original icons more closely when using a dark background. A comparison

Re: Invalid _NET_WM_ICONs not properly caught

2009-05-18 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: Hi Uli, Sorry for the delay. At 1242329343 time_t, Uli Schlachter wrote: Subject: [PATCH 1/2] Restructure the code in ewmh_window_icon_from_reply() slightly Ack. No changes to this patch (afaik). Subject: [PATCH

[Patch] Allow setting wibox.opacity if wibox.screen is nil (was: Re: [PATCH] naughty: set screen first and opacity afterwards)

2009-05-19 Thread Uli Schlachter
2d822a1b9503638cf4082db77e25c2c2796689b7 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Tue, 19 May 2009 12:56:34 +0200 Subject: [PATCH] Handle opacity for invisible wiboxes If a wibox is not attached to a screen, it does not have window and thus wibox-sw.window is XCB_NONE. Obviously, we

Re: [Patch] Allow setting wibox.opacity if wibox.screen is nil (was: Re: [PATCH] naughty: set screen first and opacity afterwards)

2009-05-19 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1242731066 time_t, Uli Schlachter wrote: I marked this mail as hey Uli, this sounds like a neat idea, why don't you implement this when you have the time. Find the patch attached. Since you seems to have time :-) I'd

Re: Thanks, Uli!

2009-05-19 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: I've just noticed that Uli writes tonnes of little finicky patches for internals that people don't think about and optimization. He also catches/fixes a lot of subtle bugs this way. I find that it's very uncommon for someone

[Patches] Fix some minor compiler warnings found in rc3

2009-05-24 Thread Uli Schlachter
commit 40710e43ba517b63b42579228d4efd0e7c42954a: Johan Kiviniemi (1): themes/sky: Titlebar icons: use current default theme paths are available in the git repository at: git://git.znc.in/psychon/awesome.git for-jd Uli Schlachter (2): Fix a harmless compiler warning Fix

Re: New logo / Web site contest

2009-05-27 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: Hi fellow users and developers, I'd like to fresh awesome a bit. We still used a logo from the 2.x branch, and a website half-designed by me. I won't judge the logo, but as for my Web design skills, they suck hard. With

rounded wibox corners

2009-05-29 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, Garoth (jokingly?) asked for rounded corners on wiboxes. With the help of plagman I took a look at the X nonrectangular window shape extension and came up with the attached C file. It creates a window and adds some rounded corners on it. All

Re: rounded wibox corners

2009-05-30 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: Hi, At 1243625625 time_t, Uli Schlachter wrote: Should I try to do so or are there some issues with the current code that would have to be sorted out first? (E.g. farhaven suggested to load the mask for the rounded

[Patch] Some fixes

2009-06-06 Thread Uli Schlachter
- From 304cc3c9f787719a043d81368bd0171f1dbbca5c Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Fri, 5 Jun 2009 23:28:54 +0200 Subject: [PATCH 1/3] awful.wibox(): Honour user specified geometries If a wibox with non-north geometry was created and a wibox size was specified

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: The first patch makes awful.wibox() work with non-north orientation and user-specified geometries. I'm just a human Attached is a New and Improved (tm) version of this first patch. Cheers, Uli - -- Do you know

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244286306 time_t, Uli Schlachter wrote: I'm currently trying to make my config work with current master. One thing I found: awful.widget.graph and .progressbar don't offer the same features their C counterparts had

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 calmar c. wrote: On Sat, Jun 06, 2009 at 03:23:03PM +0200, Julien Danjou wrote: Let's see which other patches I will come up with... (Anyone wants to enhance awful.widget.*? vertical progressbars and graphs with more than one graph sound

Re: [Patch] Some fixes

2009-06-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244292328 time_t, Uli Schlachter wrote: I'm just a human Attached is a New and Improved (tm) version of this first patch. Me too, ignore my previous mail. --- lib/awful/wibox.lua.in | 11

[Patch] Add a scale option to awful.widget.graph

2009-06-07 Thread Uli Schlachter
/zK972gpa7uK1DZDsq4Bu2n4WBUjynDknR1qexp PRWZeva10ciyrBT39G7cnEEXlC9iXkZus1EJG5vfQQzMgkWw0ErfZ30nlBNkxUBQ OVVcMXFhFkul7RiDqYTGGt/MLDB3CZHokDkChMWqFmuWje991JGT0LmkcdoQb7I= =gsYk -END PGP SIGNATURE- From 300b668b29ea1224585e5f44d4734fe1492e2f67 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Sun, 7

Re: [Patch] Add a scale option to awful.widget.graph

2009-06-07 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244379036 time_t, Uli Schlachter wrote: @@ -121,7 +136,6 @@ local function add_value(graph, value) if not graph then return end local value = value or 0 -value = math.min(1, math.max(0, value

Re: [Patch] Add a scale option to awful.widget.graph

2009-06-08 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244394267 time_t, Uli Schlachter wrote: Hm, perhabs... update() checks for larger than or equal to 0 already, but I'm not really sure what should be done about less than or equal to 1. Check for 'scale' in :add_value

[Patch] minor simplification

2009-06-09 Thread Uli Schlachter
GdNFfn7nQ3JJckfSDrsK3LIw+Coihx6S8z9LGEFZCEqyaBz38OouHYDMxCYix5q+ 5vTS4lKrAL9ulBB81kCbZqlFwtdbalO85eQMh4kmb56e/L6Sha4A5h5z/WdVah4= =uUBp -END PGP SIGNATURE- From b03953dd34e1b27df747ba9feab393b943deb1b8 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Fri, 22 May 2009 11:22:16 +0200 Subject

[Patch] High impact variable removal ;)

2009-06-11 Thread Uli Schlachter
From: Uli Schlachter psyc...@znc.in Date: Wed, 3 Jun 2009 11:58:15 +0200 Subject: [PATCH] draw_context_t's depth member is unused, remove it Signed-off-by: Uli Schlachter psyc...@znc.in --- draw.c |1 - draw.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/draw.c b

Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua

2009-06-13 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question

Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua

2009-06-13 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Maarten Maathuis wrote: Personally i like the ability of above and below, please don't remove it. Just make it optional if you feel strongly about it. Heh, read the diff! ;) I'm not removing anything here, the current patch moves some behavior

Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua

2009-06-14 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question

Re: lua pixmap drawing api in preparation for arbitrary shaped wiboxes

2009-06-15 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Julien Danjou wrote: At 1243673434 time_t, Uli Schlachter wrote: Looking at the current image lua API, I kinda doubt that it's worth to use this for generating a 1bit pixmap. Plus, if a window is resized you pretty much

[Patch] Another high-impact patch ;)

2009-06-17 Thread Uli Schlachter
1ynI3ZR3gX0CuUglCW4gRD7PJl1V4UTe98KJtRJrBU4qBGai+7b+8/eu3yJEAoDO Kpsj12kueAyZZzMbXFvyGjqjoK/6dI4cxIc4onEgCtZ/R7ctedY3RO/fX6ow/7H6 YerYEilIy2a5Ew6poZfNAvG/3AOKdDOaIZl1RSjMXexkbR49VX8Cqss8cq1D0hs= =Y918 -END PGP SIGNATURE- From 8adad4a7a085d38b1d00e1b06f1d233924fdf7b8 Mon Sep 17 00:00:00 2001 From: Uli Schlachter

[Patch] Yes, another Really Important Thingie (tm)

2009-06-18 Thread Uli Schlachter
+x7G+xM+2Gt3Rxf8o30c1U j8OQx7i09pag2WNA8vMOYuYSrbo3KtvM0yxUKPdDkSkOUiIK7yR+TDKbsdUItkKc c695Boa3zv9+0JhYj1jMQ3Vt8SLMiyQEoAkvhikCFJGptcYWFO+C6++FdVGp3g== =4Ayn -END PGP SIGNATURE- From 6b9b422164fb846c0b0e61575df92d7bc020620b Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date

Fighting memleaks with valgrind - making awesome crash via lua_close()

2009-06-19 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi list, today I took a look at valgrind's 'leak-check=full' output and thought wtf? I gotta improve this!. As a first step I added a call to lua_close() in awesome_atexit() which (finally?) frees the complete lua state during cleanup. The

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1245756208 time_t, Uli Schlachter wrote: +size = width * height; Seems unused. Seems you are right. http://git.znc.in/?p=psychon/awesome.git;a=commitdiff;h=56d73102ea8995c911664f0203f77f7a3dc0767d +static void

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1245761941 time_t, Uli Schlachter wrote: Uhm, how would I do that? I would need to do some evil math with cos and sin for this and then loop through the single pixels... I'm not a geometry expert but if you need

[Patch] Make window_hasproto non-blocking (was: [awesome bugs] #543 - Split window_hasproto)

2009-06-24 Thread Uli Schlachter
+XhQIUk1J10TPBHBPTbOXdaLzlEJMghJr3xEoar1Re5aolDSv4EBy5OvXGEpog 93476UQuZpM/5FyMviMIuLJspkseMTd+nquxCJByHNMexPiCnDgPO3TFEqjOUHM= =SIjM -END PGP SIGNATURE- From 5367b92bf497baa906e0c34ff2b3784a38b50a9b Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Wed, 24 Jun 2009 17:59:19 +0200

Re: [Obvious] Pull Request: Pop-up Run Prompt Done

2009-06-24 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: - Settings to control the speed, shape and so on of the wibox Shape? Oh and I would propose to mark some of the variables and functions as local. Don't ask me which ones, but at least inited looks like a candidate. Cheers,

Re: [Obvious] Pull Request: Pop-up Run Prompt Done

2009-06-24 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: Excerpts from Uli Schlachter's message of Wed Jun 24 16:37:07 -0400 2009: Andrei Thorp wrote: - Settings to control the speed, shape and so on of the wibox Shape? You know, height, width, border_width. You've got too much

Re: [Patch] Make window_hasproto non-blocking

2009-06-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Julien Danjou wrote: At 1245919316 time_t, Uli Schlachter wrote: So it doesn't really forbid it. ;) Should I use 'protocols-_reply != NULL' as a check when to xcb_get_wm_protocols_reply_wipe()? Yes. Attached

Re: [Draft] Introduction of Widget Layouts

2009-06-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All of the following stuff are proposals and small comments. Don't take me too seriously and feel free to disagree wherever you disagree. Gregor Best wrote: Okay, I attached all patches I wrote so far (quite a few :). Subject: [PATCH 01/12]

Re: [Draft] Introduction of Widget Layouts

2009-06-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: On Thu, Jun 25, 2009 at 03:26:48PM +0200, Uli Schlachter wrote: Subject: [PATCH 07/12] invaders: add support for widget layouts diff --git a/lib/invaders.lua.in b/lib/invaders.lua.in +gamedata.highscore.window:geometry

Re: [Draft] Introduction of Widget Layouts

2009-06-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1245947013 time_t, Gregor Best wrote: Subject: [PATCH 10/12] systray: don't crap up on odd-sized windows diff --git a/widgets/systray.c b/widgets/systray.c index 0504be8..bd53ef6 100644 --- a/widgets/systray.c +++

Re: [awesome bugs] #554 - save pointer coordinates when switching screens

2009-07-08 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: Excerpts from Uli Schlachter's message of Wed Jul 08 14:13:13 -0400 2009: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: Excerpts from awesome's message of Wed Jul 08 13:53:50 -0400 2009: Details -

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: Once again, I'm very thankful for every little bit of advice, so please review :) From a93c80d17c649446b2d80477db8b1dfa7cece886 Mon Sep 17 00:00:00 2001 From: Gregor Best farha...@googlemail.com Date: Fri, 29 May 2009

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1247096479 time_t, Gregor Best wrote: The layouts now use the bounds parameter only to determine the available width and height they can put their widgets into, the X and Y coordinates are modified by the calling

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: On Thu, Jul 09, 2009 at 10:53:52AM +0200, Uli Schlachter wrote: Where exactly is that endless loop? I can't seem to find it. And frankly said, if you use looping tables for your widgets, you shouldn't be surprised :P You

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1247139117 time_t, Uli Schlachter wrote: Where exactly is that endless loop? I can't seem to find it. And frankly said, if you use looping tables for your widgets, you shouldn't be surprised :P You get what you deserve

Request for icons (was: Spiral Layout)

2009-07-12 Thread Uli Schlachter
/gr5OrZPPkyrObTqdUoT5 1OJEzMPGrGpLVj8ttm9SD3tA2C+mPWR+bxWv1YRGKlZFToG+bLDkmFAPnLQHBek= =sjBN -END PGP SIGNATURE- From 7c3399a71eae23077b8bbb6356769b01f1455c5b Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Sun, 12 Jul 2009 20:27:41 +0200 Subject: [PATCH] Add fibanocci layouts ported

Re: [Draft] Introduction of Widget Layouts

2009-07-14 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: On Tue, Jul 14, 2009 at 05:31:35PM +0200, Julien Danjou wrote: At 1247583756 time_t, Gregor Best wrote: I can provide arguments why your idea is suboptimal :) At the moment, from the C point of view we simply have a table

wibox' geometry weirdness

2009-07-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi list, today I noticed the following weirdness: w = wibox({border_width = 30, border_color = blue}) w.screen = 1 w:geometry({width = 90, height = 90}) The above lua snippet creates a wibox whose out border (wibox content + wibox border) is

Re: [RFC Patches] SHAPE extension support for lua

2009-07-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Hi list, these patches implement support for the SHAPE extension. ^ Nope, *these* patches (damn...). - -- Do you know that books smell like nutmeg or some spice from a foreign land

Re: [RFC Patches] SHAPE extension support for lua

2009-07-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: On Sat, Jul 25, 2009 at 02:58:58PM +0200, Uli Schlachter wrote: [...] I'm not sure if this code is ready to go in. E.g. there is no way to check if the SHAPE extension is available for lua code. Would we need something like

Re: [RFC Patches] SHAPE extension support for lua

2009-07-27 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1248526949 time_t, Uli Schlachter wrote: +// Convert an image to a 1bit pixmap +xcb_pixmap_t +image_to_1bit_pixmap(image_t *image, xcb_drawable_t d) +{ +xcb_pixmap_t pixmap; +xcb_gcontext_t gc

Re: [RFC Patches] SHAPE extension support for lua

2009-07-27 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1248687430 time_t, Uli Schlachter wrote: man XCreateGC says that The GC can be used with any destination drawable having the same root and depth as the specified drawable. What is the root of a pixmap? If it's the root

[Patch] Fix naughty's margin calculation

2009-07-29 Thread Uli Schlachter
-END PGP SIGNATURE- From 8e866ba152eca6a4d1a784df2a4fb804d33f81e4 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Wed, 29 Jul 2009 14:37:23 +0200 Subject: [PATCH] Naughty: Fix the text margin No idea where this comes from or why it worked before, but it's obviously wrong

[Patch] Some more naughty fixage

2009-07-29 Thread Uli Schlachter
+CyDwkQVMImyvjMO12ZbRE2dfJIyi5HUeprd3OAP 70eznzci5WwaWKPMoLJmBOKKHrlglU64CC07lcDNzSRMmjt/9WJKO31b9/MuRW6W 38eP5fDmXY5P7H6AJyAbnv/JHWUcMVhDghh9spbGLJyAOEzX8rRq0kh4FJxQfg8= =tiDR -END PGP SIGNATURE- From 649b434e8a6b042cc81b041e39488bd06884e51b Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in

Re: [Obvious] Next branch patches (for easy review)

2009-07-30 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Andrei Thorp wrote: I wanna get my patches reviewed dammit ;) Ok, here we go: Subject: [PATCH 1/4] Lib: hooks lib w/ awful timer wrapper functions [...] diff --git a/lib/hooks/init.lua b/lib/hooks/init.lua new file

Re: [Obvious] Next branch patches (for easy review)

2009-07-30 Thread Uli Schlachter
Andrei Thorp wrote: Subject: [PATCH 2/4] Lib/Util: Added bold colour functions diff --git a/lib/util/init.lua b/lib/util/init.lua new file mode 100644 index 000..6360f87 --- /dev/null +++ b/lib/util/init.lua @@ -0,0 +1,21 @@ +-- +-- Author:

Re: [Obvious] Next branch patches (for easy review)

2009-07-30 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: Excerpts from Uli Schlachter's message of Thu Jul 30 09:43:46 -0400 2009: Andrei Thorp wrote: @@ -97,25 +113,33 @@ function show_wibox(s) }) runwibox[s].visible = true -f = function () -

[Patch Obvious] High impact code rewrite, again

2009-08-01 Thread Uli Schlachter
61GAXD1WtO2YTMAvskEauHYdKyPAYgfefrAWYrAClHR+S7DOAiaXR9cF32+wQpk= =TN35 -END PGP SIGNATURE- From aaf7a74b93efcc7598bb278f1b5418e9d3a60fc6 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Sat, 1 Aug 2009 20:50:06 +0200 Subject: [PATCH] obvious.wlan: Minor cleanup This patch

[Obvious RFC Patches] Add the concept of data sources

2009-08-05 Thread Uli Schlachter
b0ebfcd37a9dd64d7cd7209d8630dfad9e52bcb6 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date: Wed, 5 Aug 2009 16:24:13 +0200 Subject: [PATCH 1/3] Add the concept of data sources obvious.data.* are supposed to be a collection of general data sources. Via obvious.widget.progressbar() one can turn one of them

Re: [Obvious RFC Patches] Add the concept of data sources

2009-08-05 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Hi list, if you don't use obvious stop here. This patch series adds the concept of general data sources to obvious. This splits the widget-part from the collect-data-about-the-system-part. Any data source is a table

Re: [Obvious Patch] Some fun

2009-08-06 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Andrei Thorp wrote: On Mon, Aug 03, 2009 at 06:21:42PM +0200, Uli Schlachter wrote: [...] Subject: [PATCH 2/4] Add a general function for creating widgets [...] Nifty, nifty. What we might want to investigate in the future is having widget

[Obvious Patch] Fix volume_alsa

2009-08-07 Thread Uli Schlachter
/SzbngtymnVnEQifLWFAcMJmdC4r5TLBMZSktyn6qUkCnI8RJFHE3ajTyJ IxEhCVDkD20yI8Erm5i4M+XHCK+PKcUiM6uIwgNrMBPCuayYQQOsMLcraq7zrkx9 8H6qLM4uRhwNPZJ4v92s/DHAKLGKESanEL265QACUsIRA6zGeUwxB/pjXg6IydM= =apHw -END PGP SIGNATURE- From ff572e814868befe45ff4a4d3ab69cfd3b65cfa8 Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc...@znc.in Date

[Patch] Place new client's on their direct transient_for's screen, not the top-level one

2009-08-07 Thread Uli Schlachter
+CW6Vr3h4lBbjpd407Etqr5b6e6vpdY+t5Q7/KNrFKUGzkF sISn/wb7u68n0VHGJ/Lw3qRR53bKUOG37GB/I/r5CgjHuTXGyemkaeX088WTTjbl jhk2zNI+h4O0Ib/hGzh+M9IIhQBfywtxkU6uIP1P4A5Oss682JOpv8E/aaOFVHo= =HcZq -END PGP SIGNATURE- From feb1c98218c9e56e8feab8480acae0cefcc174de Mon Sep 17 00:00:00 2001 From: Uli Schlachter psyc

Re: [PATCH] awful.completion: sort matches

2009-08-08 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: On Sat, Aug 08, 2009 at 12:14:39PM +0100, koniu wrote: Hi, Dunno if it's just me but here, at least with zsh completion, the available matches are pretty randomly ordered with gajtab giving gajim-remote first, then

[Patch] Let graph and progressbar return their own widget in :set_* functions

2009-08-08 Thread Uli Schlachter
table. This most likely doesn't break any existing configs and it adds a quite nice syntax which can be used for in-place configuration of new widgets. Signed-off-by: Uli Schlachter psyc...@znc.in --- lib/awful/widget/graph.lua.in |4 lib/awful/widget/progressbar.lua.in |4

Re: [Patch] Let graph and progressbar return their own widget in :set_* functions

2009-08-08 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: This change enables stuff like the following: [snip] I hate it when this happens. Attached is a fixed version of the patch. The only change: return pbar instead of return pb in progressbar's set_value(). Uli - -- Do you

  1   2   3   4   5   >