Re: [Draft] Introduction of Widget Layouts

2009-07-07 Thread Maarten Maathuis
I suggest being consistent with the other code and push the geometry to lua with borders included. Like the client code does, or change that, at least be consistent. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Draft] Introduction of Widget Layouts

2009-07-07 Thread Maarten Maathuis
I just saw a fragment of code in my mailbox, if jd has a better suggestion, then by all means go ahead. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Maarten Maathuis
Could the interface be simplified to leave the border related calculations on the C side? This was done for geometry to make the code clearer, is there any reason to not do that here? Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Maarten Maathuis
I wasn't expecting custom borders, so ignore me. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: lua pixmap drawing api in preparation for arbitrary shaped wiboxes

2009-06-15 Thread Maarten Maathuis
Personally this sounds like a case for using xrender composite, src (square) mask (8bits alpha pixmap) - dst (rounded, smooth?). The reason cairo doesn't support 1 bit is because no hw from this century will support it. Just use 8bits. I think the SRC operator is appropriate in this case. The

Re: lua pixmap drawing api in preparation for arbitrary shaped wiboxes

2009-06-15 Thread Maarten Maathuis
Oh, so you are not manually responsible for making the right shape? Just to be clear, xrender composite (the act of blending images together) is not the same as the composite extention. And the first works fine without the a compositing manager. Maarten. -- To unsubscribe, send mail to

Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua

2009-06-13 Thread Maarten Maathuis
Personally i like the ability of above and below, please don't remove it. Just make it optional if you feel strongly about it. Maarten. On Sat, Jun 13, 2009 at 10:00 AM, Uli Schlachterpsyc...@znc.in wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357

Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua

2009-06-13 Thread Maarten Maathuis
Oh btw, the reason they are above by default, is because dialogs are too. And these are longlasting dialogs. I don't think the ewmh does or should explicitly demand them to be above. The same goes for any dialog. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] Some fixes

2009-06-07 Thread Maarten Maathuis
There is a certain flexibility that comes with C, so i don't see if disappearing completely. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH] 0001-hooks-add-exit-hook

2009-05-24 Thread Maarten Maathuis
Without even judging the idea i wonder, shouldn't an exit hook also mean a startup hook (maybe just for the real start up)? Especially if you want to do session management'ish things. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH] 0001-hooks-add-exit-hook

2009-05-24 Thread Maarten Maathuis
rc.lua is also loaded on awesome restart, i can't imagine that you want to do session management'ish stuff then -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH] 0001-hooks-add-exit-hook

2009-05-24 Thread Maarten Maathuis
Property on the root window? On Sun, May 24, 2009 at 8:00 PM, Gregor Best farha...@googlemail.com wrote: At Sun, 24 May 2009 19:11:42 +0200 Maarten Maathuis wrote: rc.lua is also loaded on awesome restart, i can't imagine that you want to do session management'ish stuff then How would

Re: Pager problem with ban offscreen

2009-05-19 Thread Maarten Maathuis
I don't know, i've looked around and all i've seen so far is either unmap(most) or moving (dwm) or a choice between unmapping and moving (ion3). An alternative is looking at gnome-panel and see what it checks for, but the sourcecode is not very transparent. Maarten. -- To unsubscribe, send

Re: 3.3-rc1 crash bug (?)

2009-05-09 Thread Maarten Maathuis
 Do you have git version of xcb-proto ? If yes revert commit fe7b12db4fc0e95f3eef038581bf2154e1727c7a, Correct the length calculation for the value field of GetPropertyReply. ... and rebuild libxcb and xcb-util ... :p Shouldn't you get it reverted if it's a bad commit? -- To unsubscribe,

Re: [ANNOUNCE] awesome 3.3-rc2 released

2009-05-08 Thread Maarten Maathuis
Not that i personally care, but awesome's dependencies have become more bleeding edge lately. In a sense awesome is rather extreme at it's dependencies and api stability. This is fine if you have a niche audience, but it will annoy some people. Especially the mega-freeze distributions are

[PATCH] layout: rearrange ban/unban sequence to avoid seeing the background during tag switch

2009-04-13 Thread Maarten Maathuis
--- layout.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/layout.c b/layout.c index 87dca76..067ffad 100644 --- a/layout.c +++ b/layout.c @@ -47,13 +47,22 @@ arrange(int screen) /* Restore titlebar before client, so geometry is ok again. */

[PATCH] client: fix luadoc typo, minimize should be minimized

2009-04-11 Thread Maarten Maathuis
--- client.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client.c b/client.c index c1ff443..8ce793d 100644 --- a/client.c +++ b/client.c @@ -1729,7 +1729,7 @@ luaA_client_newindex(lua_State *L) * \lfield screen Client screen number. * \lfield hide Define if the

[PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
- I don't see why we should guess about what we recieved and whatnot. --- client.c | 15 +-- client.h |1 + event.c | 24 3 files changed, 30 insertions(+), 10 deletions(-) diff --git a/client.c b/client.c index 3d9c8a7..771bd2c 100644 --- a/client.c

[PATCH 2/3] event: also filter leave notify events

2009-04-04 Thread Maarten Maathuis
--- event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index ae90783..c89dbb6 100644 --- a/event.c +++ b/event.c @@ -456,6 +456,9 @@ event_handle_leavenotify(void *data __attribute__ ((unused)), wibox_t *wibox; client_t *c; +

[PATCH 3/3] wibox: kill misuse of phys_screen

2009-04-04 Thread Maarten Maathuis
- emwh and systray has some too, but the respective ewmh code is broken anyway and systrays are made on the first screen probably for a xinerama config --- wibox.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/wibox.c b/wibox.c index

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
The satellite window is a noinput window, why would it ever get focus? Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
I'm not quite sure why it broke (tried various extra changes), but i confirm that reverting the commit works. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [awesome bugs] #489 - SqlDeveloper (Java) does not work

2009-04-03 Thread Maarten Maathuis
That won't work on java 1.5 and 1.6, you need 1.4 for that workaround. Other workarounds exist as well, faking the window manager name to be on java's internal workaround list (http://bbs.archlinux.org/viewtopic.php?id=58349). Maarten. -- To unsubscribe, send mail to

[PATCH 2/2] screen, client: clamp strut size to relevant dimension

2009-03-30 Thread Maarten Maathuis
- gnome-panel (for example) requests the space for all it's windows - this approach can never work for multiple applications, so we clamp it --- screen.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/screen.c b/screen.c index c75453f..adf023b 100644 ---

[PATCH 1/2] client: handle struts (a lot) better

2009-03-30 Thread Maarten Maathuis
- WINDOW_TYPE_DOCK are chosen first. - Top/Bottom take precedence over Left/Right. - Struts are automatically updated. - Automatically avoid overlap with other struts or wibox'es. --- client.c | 168 client.h |1 +

Re: [PATCH 8/8] wibox: choose wibox positions before adding struts

2009-03-28 Thread Maarten Maathuis
Are you in principle ok with the idea, it's probably a matter of moving emwh clients a bit if they set struts. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

[PATCH] client: handle struts (a lot) better

2009-03-28 Thread Maarten Maathuis
- WINDOW_TYPE_DOCK are chosen first. - Top/Bottom take precedence over Left/Right. - Struts are automatically updated. - Automatically avoid overlap with other struts or wibox'es. --- client.c | 168 client.h |1 +

[PATCH 8/8] wibox: choose wibox positions before adding struts

2009-03-27 Thread Maarten Maathuis
--- wibox.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/wibox.c b/wibox.c index b7d7170..c67f592 100644 --- a/wibox.c +++ b/wibox.c @@ -294,8 +294,9 @@ wibox_position_update(wibox_t *wibox) globalconf.screens[wibox-screen].need_arrange = true; +/* Place

[PATCH 1/3] titlebar: redo the handling a bit

2009-03-26 Thread Maarten Maathuis
--- client.c | 24 +--- layout.c |7 +++ structs.h |2 ++ titlebar.c | 52 +++- titlebar.h | 25 +++-- wibox.h| 10 -- 6 files changed, 84 insertions(+), 36 deletions(-)

[PATCH 2/3] client: allow special non-transient windows to be !above

2009-03-26 Thread Maarten Maathuis
--- client.c |7 --- ewmh.c |5 + property.c |1 + 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/client.c b/client.c index 5c88d2c..a496e12 100644 --- a/client.c +++ b/client.c @@ -414,15 +414,8 @@ client_layer_translator(client_t *c) /* then deal

[PATCH 3/3] client: fix typo

2009-03-26 Thread Maarten Maathuis
--- client.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client.c b/client.c index a496e12..d654b21 100644 --- a/client.c +++ b/client.c @@ -311,7 +311,7 @@ client_focus(client_t *c, bool sendmessage) c-win, XCB_CURRENT_TIME);

[PATCH 2/7] client: allow special non-transient windows to be !above

2009-03-26 Thread Maarten Maathuis
--- client.c |7 --- ewmh.c |5 + property.c |1 + 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/client.c b/client.c index 5c88d2c..a496e12 100644 --- a/client.c +++ b/client.c @@ -414,15 +414,8 @@ client_layer_translator(client_t *c) /* then deal

[PATCH 3/7] client: fix typo

2009-03-26 Thread Maarten Maathuis
--- client.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client.c b/client.c index a496e12..d654b21 100644 --- a/client.c +++ b/client.c @@ -311,7 +311,7 @@ client_focus(client_t *c, bool sendmessage) c-win, XCB_CURRENT_TIME);

[PATCH 6/7] client: add dockable.{set/get}

2009-03-26 Thread Maarten Maathuis
--- lib/awful/client.lua.in | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib/awful/client.lua.in b/lib/awful/client.lua.in index 96509c8..443b6d1 100644 --- a/lib/awful/client.lua.in +++ b/lib/awful/client.lua.in @@ -38,6 +38,7 @@ focus =

[PATCH 7/7] client: fix luadoc'ish typo

2009-03-26 Thread Maarten Maathuis
--- lib/awful/client.lua.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/awful/client.lua.in b/lib/awful/client.lua.in index 443b6d1..5be03c8 100644 --- a/lib/awful/client.lua.in +++ b/lib/awful/client.lua.in @@ -547,7 +547,7 @@ end -- Floating client are not

Re: [PATCH 7/7] client: fix luadoc'ish typo

2009-03-26 Thread Maarten Maathuis
This is obviously wrong, sorry. On Thu, Mar 26, 2009 at 10:13 PM, Maarten Maathuis madman2...@gmail.com wrote: ---  lib/awful/client.lua.in |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/awful/client.lua.in b/lib/awful/client.lua.in index 443b6d1..5be03c8

[PATCH 2/2] client: allow special non-transient windows to be !above

2009-03-24 Thread Maarten Maathuis
--- client.c |7 --- ewmh.c |5 + property.c |1 + 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/client.c b/client.c index 5c88d2c..a496e12 100644 --- a/client.c +++ b/client.c @@ -414,15 +414,8 @@ client_layer_translator(client_t *c) /* then deal

[PATCH 1/2] titlebar: redo the handling a bit

2009-03-24 Thread Maarten Maathuis
--- client.c | 24 +--- layout.c |7 +++ structs.h |2 ++ titlebar.c | 58 +- titlebar.h | 25 +++-- wibox.h| 10 -- 6 files changed, 90 insertions(+), 36

Re: [PATCH] titlebar: hide when the client is fullscreen

2009-03-24 Thread Maarten Maathuis
I think the latest patch should cover all the holes in titlebar handling i know of. It was quite a hunt getting it right, i tested fullscreening and changing visibility of titlebars (including resizing while they are not visible). Maarten. -- To unsubscribe, send mail to

Re: [PATCH] titlebar: hide when the client is fullscreen

2009-03-23 Thread Maarten Maathuis
Should a hidden titlebar still take space? If not (=geometry deducted), then there's not much i can do about the code size. I can make it different, but not much smaller. So is the problem purely one of size or style? Maarten. -- To unsubscribe, send mail to

[PATCH] titlebar: hide when the client is fullscreen

2009-03-22 Thread Maarten Maathuis
--- client.c |8 structs.h |4 titlebar.c | 18 -- 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/client.c b/client.c index da6262d..2d8a3a4 100644 --- a/client.c +++ b/client.c @@ -845,6 +845,11 @@ client_setfullscreen(client_t *c, bool

Re: [PATCH] titlebar: hide when the client is fullscreen

2009-03-22 Thread Maarten Maathuis
What if a client is already unbanned, it will never hit the unban codepath. It just seemed unnatural to hack around it there. Completely separating client and titlebar banning might work. I don't have time right now to take a deeper look at that. Maarten. -- To unsubscribe, send mail to

_NET_WORKAREA, _NET_CURRENT_DESKTOP and friends are handled incorrectly

2009-03-20 Thread Maarten Maathuis
It takes the first screen in a xinerama'ish config. It sets the workarea of all tags based upon the struts of the currently visible clients. I would dump these properties, as they make no sense in awesome. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

[PATCH] unbreak client: stop using otable

2009-03-14 Thread Maarten Maathuis
- Some tag icons were disappearing. --- lib/awful/widget/taglist.lua.in |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/awful/widget/taglist.lua.in b/lib/awful/widget/taglist.lua.in index 5f8f264..e489fb8 100644 --- a/lib/awful/widget/taglist.lua.in +++

[PATCH] client: fix client_setborder

2009-02-19 Thread Maarten Maathuis
- Don't know why I didn't do this correctly in the first place :-| --- client.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client.c b/client.c index e17951d..894e5ef 100644 --- a/client.c +++ b/client.c @@ -1261,15 +1261,15 @@ client_setborder(client_t *c, int

[PATCH 2/7] event: handle border size changes in configurerequest

2009-02-15 Thread Maarten Maathuis
--- event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index f4bfd63..cd26821 100644 --- a/event.c +++ b/event.c @@ -291,6 +291,9 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), if(ev-value_mask

[PATCH 4/7] event: small code harmonisation.

2009-02-15 Thread Maarten Maathuis
--- event.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/event.c b/event.c index 2def556..944c241 100644 --- a/event.c +++ b/event.c @@ -427,12 +427,12 @@ event_handle_motionnotify(void *data __attribute__ ((unused)),

[PATCH 5/7] placement: allow centering on a parent.

2009-02-15 Thread Maarten Maathuis
- Typical usecase awful.placement.centered(c, c.transient_for). --- lib/awful/placement.lua.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/awful/placement.lua.in b/lib/awful/placement.lua.in index 7a6b7c2..debbe89 100644 --- a/lib/awful/placement.lua.in

[PATCH 6/7] screen: replace need_arrange with a reference counted mechanism.

2009-02-15 Thread Maarten Maathuis
- This is needed to properly process certain changes triggered by arrange, that need yet another arrange. --- client.h |6 +++--- layout.c | 10 -- screen.c |9 ++--- structs.h |4 ++-- tag.c |6 -- titlebar.c |3 ++- wibox.c|9 ++---

[PATCH 7/7] client: remove a few useless client_need_arrange().

2009-02-15 Thread Maarten Maathuis
--- client.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/client.c b/client.c index 612627b..eaa3171 100644 --- a/client.c +++ b/client.c @@ -800,7 +800,6 @@ client_setminimized(client_t *c, bool s) { if(c-isminimized != s) { -

[PATCH 1/5] event: Actually modify ev-x and ev-y for banned clients.

2009-02-14 Thread Maarten Maathuis
--- event.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/event.c b/event.c index 57886c1..f4bfd63 100644 --- a/event.c +++ b/event.c @@ -295,8 +295,8 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), { /* We'll be sending

[PATCH 3/5] event: block stacking related changes in configurerequest.

2009-02-14 Thread Maarten Maathuis
--- event.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index cd26821..2def556 100644 --- a/event.c +++ b/event.c @@ -294,6 +294,10 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), if (ev-value_mask

[PATCH 4/5] event: small code harmonisation.

2009-02-14 Thread Maarten Maathuis
--- event.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/event.c b/event.c index 2def556..944c241 100644 --- a/event.c +++ b/event.c @@ -427,12 +427,12 @@ event_handle_motionnotify(void *data __attribute__ ((unused)),

[PATCH 5/5] placement: allow centering on a parent.

2009-02-14 Thread Maarten Maathuis
- Typical usecase awful.placement.centered(c, c.transient_for). --- lib/awful/placement.lua.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/awful/placement.lua.in b/lib/awful/placement.lua.in index 7a6b7c2..debbe89 100644 --- a/lib/awful/placement.lua.in

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
On Wed, Feb 11, 2009 at 3:36 PM, Gregor Best farha...@googlemail.com wrote: Hi people, the attached patch removes the UrgencyHint flag from a client if it gets focused. This is to comply with the EWMH specs which say it's the window managers job to care for removal of that hint. --

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
property_update_wm_hints is not a set function, but a get function, my bad. You can probably leave out that call. Strange thing is that property_update_wm_hints() is only called upon manage, which suggests it doesn't even work atm for windows that enable this hint. But that should be fixed (if

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
/* execute hook */ hooks_property(c, urgent); This needs to go into the function i think. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
Either way i think, as long as there is change. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

[PATCH 2/2] client: fix titlebar stacking

2009-02-10 Thread Maarten Maathuis
--- client.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/client.c b/client.c index 51bebd9..758bd09 100644 --- a/client.c +++ b/client.c @@ -314,7 +314,11 @@ client_stack_above(client_t *c, xcb_window_t previous) {

[PATCH 1/2] client: add above and below to capi + related fixes

2009-02-10 Thread Maarten Maathuis
--- client.c | 36 common/tokenize.gperf |2 ++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/client.c b/client.c index 92c64d5..51bebd9 100644 --- a/client.c +++ b/client.c @@ -792,6 +792,10 @@

[PATCH 1/2] client: fix titlebar stacking

2009-02-10 Thread Maarten Maathuis
--- client.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/client.c b/client.c index d14f290..7186f09 100644 --- a/client.c +++ b/client.c @@ -312,9 +312,8 @@ client_stack_above(client_t *c, xcb_window_t previous) node; node = node-prev)

Re: [PATCH] client: add above and below to capi + related fixes

2009-02-09 Thread Maarten Maathuis
On Mon, Feb 9, 2009 at 10:40 AM, Julien Danjou jul...@danjou.info wrote: At 1234133730 time_t, Maarten Maathuis wrote: Ack; I think we miss the EWMH function behind that? above, below and fullscreen are exposed in the emwh, and those functions call ewmh_client_update_hints(). I don't get what

[PATCH 1/5] client: implement client struts in the capi.

2009-02-08 Thread Maarten Maathuis
--- client.c | 71 +++- ewmh.c | 28 ++- ewmh.h |3 +- property.c |2 +- 4 files changed, 99 insertions(+), 5 deletions(-) diff --git a/client.c b/client.c index ba4b1cf..22cbbd2 100644 ---

[PATCH 2/5] mouse: allow utility, toolbar and dock windows to snap to the edge of the window

2009-02-08 Thread Maarten Maathuis
--- lib/awful/mouse.lua.in | 44 +--- 1 files changed, 41 insertions(+), 3 deletions(-) diff --git a/lib/awful/mouse.lua.in b/lib/awful/mouse.lua.in index aff565a..0c85b7d 100644 --- a/lib/awful/mouse.lua.in +++ b/lib/awful/mouse.lua.in @@ -64,17 +64,22

[PATCH 3/5] client: client_isvisible_exclude_banned() isn't needed anymore.

2009-02-08 Thread Maarten Maathuis
--- client.h | 20 layout.c |2 +- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/client.h b/client.h index 58eb08f..77c4cf1 100644 --- a/client.h +++ b/client.h @@ -41,7 +41,7 @@ DO_RCNT(client_t, client, client_delete) #define client_need_arrange(c)

[PATCH 4/5] client: change border handling slightly + remove some old cruft

2009-02-08 Thread Maarten Maathuis
--- client.c | 15 ++- screen.c |8 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/client.c b/client.c index 22cbbd2..9fedca0 100644 --- a/client.c +++ b/client.c @@ -475,8 +475,9 @@ client_manage(xcb_window_t w, xcb_get_geometry_reply_t *wgeom, int

[PATCH 5/5] event: fix configurerequest

2009-02-08 Thread Maarten Maathuis
- We have to be careful with geometry around protocol code. --- client.c |9 +++-- client.h |2 +- event.c | 27 ++- 3 files changed, 18 insertions(+), 20 deletions(-) diff --git a/client.c b/client.c index 9fedca0..c6b804a 100644 --- a/client.c +++

[PATCH] titlebar: remove some old/unneeded code

2009-02-07 Thread Maarten Maathuis
- This fixes the resize upon titlebar removal issue. --- lib/awful/titlebar.lua.in | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index 5e751c0..0c3b65f 100644 --- a/lib/awful/titlebar.lua.in +++

[PATCH 1/2] client: implement client struts in the capi.

2009-02-07 Thread Maarten Maathuis
--- client.c | 71 +++- ewmh.c | 28 ++- ewmh.h |3 +- property.c |2 +- 4 files changed, 99 insertions(+), 5 deletions(-) diff --git a/client.c b/client.c index ba4b1cf..22cbbd2 100644 ---

some notes about the patches

2009-02-07 Thread Maarten Maathuis
That 2nd patch title should have said, snap to the edge of the screen, not window. The kind of windows we're talking about is gimp's toolbar for example, which tends to be in the way normally, so now you can snap it to the edge of the screen and your tiled clients will adjust. Maarten. -- To

[PATCH] titlebar: don't resize window when adding titlebar.

2009-02-06 Thread Maarten Maathuis
--- lib/awful/titlebar.lua.in | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index c86d6bf..5e751c0 100644 --- a/lib/awful/titlebar.lua.in +++ b/lib/awful/titlebar.lua.in @@ -117,18 +117,8 @@ function add(c,

[PATCH 1/2] titlebar: don't resize window when adding titlebar.

2009-02-06 Thread Maarten Maathuis
--- lib/awful/titlebar.lua.in | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index c86d6bf..5e751c0 100644 --- a/lib/awful/titlebar.lua.in +++ b/lib/awful/titlebar.lua.in @@ -117,18 +117,8 @@ function add(c,

[PATCH 2/2] client: update client geometry when adding and removing titlebars

2009-02-06 Thread Maarten Maathuis
- This fixes titlebars again. --- titlebar.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/titlebar.c b/titlebar.c index 7fa6e97..d5de3e4 100644 --- a/titlebar.c +++ b/titlebar.c @@ -181,6 +181,8 @@ titlebar_client_detach(client_t *c) /* If client has a

Re: [PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
Please ignore, better patches are underway. On Mon, Feb 2, 2009 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: jd: does this patchset work equally well for you? The idea is that jd's change also allows clients to leave their hidden area, which is ofcource bad. Maarten

Re: [PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
On Mon, Feb 2, 2009 at 8:07 PM, Maarten Maathuis madman2...@gmail.com wrote: Please ignore, better patches are underway. On Mon, Feb 2, 2009 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: jd: does this patchset work equally well for you? The idea is that jd's change also allows

[PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
jd: does this patchset work equally well for you? The idea is that jd's change also allows clients to leave their hidden area, which is ofcource bad. Maarten. 0001-Revert-event-do-not-store-resize-events-of-banned.patch Description: Binary data

Re: [PATCH] netwm

2008-12-14 Thread Maarten Maathuis
On 12/14/2008 08:46 PM, Arnaud VALLAT wrote: Hello, please find along with this email a patch for awesome 3.1 (git version) which handles _NET_ACTIVE_WINDOW to ewmh_process_client_message. Regards, Rno -- Given enough eyeballs, all bugs are shallow Eric Steven Raymond What i should

[PATCH] naughty: avoid nil global 'tostring'

2008-12-12 Thread Maarten Maathuis
Why this is needed all of the sudden, i do not know. Maarten. From 2715f38e90e729208871f6951f9338ee13013006 Mon Sep 17 00:00:00 2001 From: Maarten Maathuis madman2...@gmail.com Date: Fri, 12 Dec 2008 12:53:47 +0100 Subject: [PATCH] naughty: Add tostring to the lua environment. Signed-off

[PATCH] Check for io.popen failure

2008-12-11 Thread Maarten Maathuis
See title. Maarten. From c7b7f32da7041f6c5251b78611f6c817df6b59fc Mon Sep 17 00:00:00 2001 From: Maarten Maathuis madman2...@gmail.com Date: Thu, 11 Dec 2008 22:14:07 +0100 Subject: [PATCH] completion, util: Check for io.popen failure. Signed-off-by: Maarten Maathuis madman2...@gmail.com

[take this PATCH] Re: More patches

2008-12-11 Thread Maarten Maathuis
On 12/11/2008 09:50 PM, Maarten Maathuis wrote: On 12/11/2008 10:39 AM, Julien Danjou wrote: At 1228953600 time_t, Maarten Maathuis wrote: The first 5 are fixes for various problems. Subject: [PATCH] client: compensate for titlebars when maximizing. Merged into: client: maximize

More patches

2008-12-10 Thread Maarten Maathuis
interested in the size of a window without it's border, so why even expose it, it creates only confusion (especially the fact that x and y are including border and width and height without). Maarten. From 8d5409df85fea7c5f390be002a03b00ff39ee081 Mon Sep 17 00:00:00 2001 From: Maarten Maathuis [EMAIL

Re: PATCHES for next

2008-12-01 Thread Maarten Maathuis
On Mon, Dec 1, 2008 at 10:55 AM, Julien Danjou [EMAIL PROTECTED] wrote: At 1228051332 time_t, Maarten Maathuis wrote: The first is a fairly straightforward update to include all non-override redirect window types, this makes gimp work in tiled mode for example. This can go into master as far

2 patches for next

2008-11-26 Thread Maarten Maathuis
One minor fix and one to fix that focus issue. Maarten. From ef34abe9a244f472a928a6bb413288d6ed400353 Mon Sep 17 00:00:00 2001 From: Maarten Maathuis [EMAIL PROTECTED] Date: Tue, 25 Nov 2008 18:51:37 +0100 Subject: [PATCH] awful.client: fix minor luadoc issue Signed-off-by: Maarten Maathuis

Re: patches for next

2008-11-22 Thread Maarten Maathuis
On Sat, Nov 22, 2008 at 8:40 AM, Julien Danjou [EMAIL PROTECTED] wrote: At 1227290525 time_t, Maarten Maathuis wrote: The last one is only for next and fixes an issue with wine apps. I've included an extended comment with the change. Even though i think it's strange to depend on iconified

patches for next

2008-11-21 Thread Maarten Maathuis
The first two should apply to master. The last one is only for next and fixes an issue with wine apps. I've included an extended comment with the change. Even though i think it's strange to depend on iconified == unmapped as client, it's not illegal (after yet another look at the ICCCM). number

Re: patches for next

2008-11-21 Thread Maarten Maathuis
On Fri, Nov 21, 2008 at 7:02 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: The first two should apply to master. The last one is only for next and fixes an issue with wine apps. I've included an extended comment with the change. Even though i think it's strange to depend on iconified

Re: patch series for next

2008-11-20 Thread Maarten Maathuis
On Thu, Nov 20, 2008 at 5:28 PM, Julien Danjou [EMAIL PROTECTED] wrote: At 1227198277 time_t, Maarten Maathuis wrote: I'm quite sure titlebars work here, just to be sure, the titlebars all stay visible on their original position? Depends on what you call original position? The position

Re: Firefox in apptags not working

2008-11-18 Thread Maarten Maathuis
On Wed, Nov 19, 2008 at 1:04 AM, Julien Danjou [EMAIL PROTECTED] wrote: At 1227000928 time_t, Martin Stubenschrott wrote: Sorry for hijacking this thread, but apptags seem very unsexy for me. The problem is, that the window shortly appears on the current tag before it is moved to the final

Re: [PATCH needs testing] redesign client_{ban,unban} aka the composite patch

2008-11-15 Thread Maarten Maathuis
On Fri, Nov 14, 2008 at 8:58 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: On Fri, Nov 14, 2008 at 5:12 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: This should be pretty much it, i fixed/cleaned up the titlebar visibility stuff (which is the big change from the last patch). I'd appreciate

Re: [PATCH needs testing] redesign client_{ban,unban} aka the composite patch

2008-11-14 Thread Maarten Maathuis
On Fri, Nov 14, 2008 at 5:12 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: This should be pretty much it, i fixed/cleaned up the titlebar visibility stuff (which is the big change from the last patch). I'd appreciate feedback ofcource. Maarten. New patch: - some changes to client_manage

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:32 PM, Julien Danjou [EMAIL PROTECTED] wrote: At 1226615131 time_t, Maarten Maathuis wrote: Last time i checked the data was malloc'ed, and the initial state really needs to be false. But i'll double check. No, it's p_new() which is calloc() so everything is always

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:56 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: On Thu, Nov 13, 2008 at 11:36 PM, Maarten Maathuis [EMAIL PROTECTED] wrote: On Thu, Nov 13, 2008 at 11:32 PM, Julien Danjou [EMAIL PROTECTED] wrote: At 1226615131 time_t, Maarten Maathuis wrote: Last time i checked

lua titlebar patch for more consistent beheaviour

2008-11-05 Thread Maarten Maathuis
This should make the titlebar behave like the rest of the window, minus ofcource clicking on the close button. Maarten. 0001-titlebar-generate-mouse_enter-and-button-events-for.patch Description: Binary data