Re: [Patch] Allow setting wibox.opacity if wibox.screen is nil (was: Re: [PATCH] naughty: set screen first and opacity afterwards)

[Julien Danjou]

At 1242731066 time_t, Uli Schlachter wrote:
 I marked this mail as hey Uli, this sounds like a neat idea, why don't you
 implement this when you have the time. Find the patch attached.

Since you seems to have time :-) I'd have another suggestion for the
implementation for this patch. That should be done in at least 2 parts,
because currently, there's a drawback with opacity handling in
client also.

For clients, we store opacity and set it via window_opacity_set().
So far so good.

But if someone changes the opacity via something else like transset, our
internal value of opacity (in client_t) is... wrong.

So I suggest that:
1. you fix that for client: that's easy, you just need to add a watcher
   for _NET_WM_WINDOW_OPACITY in property.c and update client
   accordingly.
   To do things cleanly, you may need to split window_opacity_get in
   another function that does not send a GetProperty request (since you
  already that property reply when dealing with property handler in
  property.c)

2. you do the exact same thing for wiboxes; that means you do not need to
   use window_opacity_get, since it will be always up to date

I can provide help or deeper explanation if needed.
And I'd merge that into next.

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// I'm no superman.


signature.asc
Description: Digital signature

Re: [Patch] Allow setting wibox.opacity if wibox.screen is nil (was: Re: [PATCH] naughty: set screen first and opacity afterwards)

[Uli Schlachter]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Julien Danjou wrote:
 At 1242731066 time_t, Uli Schlachter wrote:
 I marked this mail as hey Uli, this sounds like a neat idea, why don't you
 implement this when you have the time. Find the patch attached.
 
 Since you seems to have time :-) I'd have another suggestion for the
 implementation for this patch. That should be done in at least 2 parts,
 because currently, there's a drawback with opacity handling in
 client also.
 
 For clients, we store opacity and set it via window_opacity_set().
 So far so good.
 
 But if someone changes the opacity via something else like transset, our
 internal value of opacity (in client_t) is... wrong.
 
 So I suggest that:
 1. you fix that for client: that's easy, you just need to add a watcher
for _NET_WM_WINDOW_OPACITY in property.c and update client
accordingly.
To do things cleanly, you may need to split window_opacity_get in
another function that does not send a GetProperty request (since you
   already that property reply when dealing with property handler in
   property.c)
 
 2. you do the exact same thing for wiboxes; that means you do not need to
use window_opacity_get, since it will be always up to date
 
 I can provide help or deeper explanation if needed.
 And I'd merge that into next.
 
 Cheers,

Yay, I get to learn more X stuff. :)

I'll give this idea a try tomorrow, thanks for the suggestion.

Uli
- --
Do you know that books smell like nutmeg or some spice from a foreign land?
  -- Faber in Fahrenheit 451
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iQEcBAEBCAAGBQJKErEFAAoJECLkKOvLj8sGoH4IAMWbBfz3cPPWwi45K5a2i0uY
UngJoO5CA3h4ug0DdV4xwrcNKjWbXYmHV3jrpnPwPcf7FwpzWZ7FM+di88HgtN4Z
uroysBF6F834ro+0SYrhngYDCLttDakVtFQje/wZS/fA0eTd7/FNZR1jOYSs16lZ
gYh46o59DWwZ422Zu+7P9j07yRAPecg75QXVO7Yol807zjVCGYASFM2JofYkvCVT
pfkwKN2L3JGQhfywwsz0Oa+bnV8ieTAam42eiqcZHN09WJvimAt3p4kb33FLmur5
p+YY4N04WJJZ0PZkGGcwUkCTahKJUjemHZbb7RiOkyIWfJ72iSbAnFolJqqAP28=
=sgnC
-END PGP SIGNATURE-

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.