Re: AWT Dev Review request for 7154030: java.awt.Component.hide() does not repaint parent container

2012-03-20 Thread Jonathan Lu
Hi Artem, Thanks for your time. 2012/3/19 Artem Ananiev artem.anan...@oracle.com Hi, Jonathan, given the code in java.awt.Component, your statement about difference between hide() and setVisible(false) looks pretty strange to me. Indeed, here is the implementation: public void

Re: AWT Dev [7u4] Review request for 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Anthony Petrov
Hi Sergey, Thanks for the review. Indeed, a test case should be fine for this fix, so here's the updated webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/ As to the 2), I prefer to not add tests for things that should be improved eventually, so instead I've filed a

Re: AWT Dev Swing Dev Review request for 7154030: java.awt.Component.hide() does not repaint parent container

2012-03-20 Thread Pavel Porvatov
Hi Jonathan, Hi Artem, 2012/3/20 Artem Ananiev artem.anan...@oracle.com mailto:artem.anan...@oracle.com Hi, Jonathan, I'm adding swing-dev to CC as we now consider changing Swing code. What you propose sounds technically reasonable, but I don't think it is worth doing

Re: AWT Dev [7u4] Review request for 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Sergey Bylokhov
Hi, Anthony. looks good. 20.03.2012 16:07, Anthony Petrov wrote: Hi Sergey, Thanks for the review. Indeed, a test case should be fine for this fix, so here's the updated webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/ As to the 2), I prefer to not add tests for