Re: AWT Dev Code Review Request for CR 7146237 - closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19

2012-04-02 Thread Artem Ananiev
Looks fine. Thanks, Artem On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote: Hi Anthony, thank you for this clarification, I modified those places: http://cr.openjdk.java.net/~bagiras/8/7146237.2 Thanks, Oleg. 3/30/2012 2:06 PM, Anthony Petrov wrote: Hi Oleg, The modern tagging approach for

Re: AWT Dev Swing Dev Request for review: 7155298 : Editable TextArea blocks GUI application from exit

2012-04-02 Thread Anthony Petrov
Thank you! -- best regards, Anthony On 03/31/12 13:01, Charles Lee wrote: Hi Sean, The patch has been committed @ Changeset: 96340349e35b Author:zhouyx Date: 2012-03-31 16:55 +0800 URL:http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96340349e35b 7155298: Editable TextArea/TextField are

Re: AWT Dev [8] Review request for 7123476: DesktopOpenTests:When enter the file path and click the open button, it crash

2012-04-02 Thread Anthony Petrov
Hi Denis, The fix looks good to me. Thanks! -- best regards, Anthony On 04/02/12 16:35, Denis S. Fokin wrote: Hi Anthony, I took you suggestions into account. I have not Please take another look. http://cr.openjdk.java.net/~denis/7123476/webrev.04/ Thank you, Denis. On 3/29/2012 4:48 PM,

Re: AWT Dev [8] Review request for 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-04-02 Thread Anthony Petrov
Hi Mike, Have you had a chance to take a look at the issue? -- best regards, Anthony On 03/27/12 20:49, Anthony Petrov wrote: On 3/27/2012 8:44 PM, Anthony Petrov wrote: Artem: this is a good idea, thanks. Mike: I'm trying to do something like this:

AWT Dev [8] Request for review: 7154025 [macosx] XAWTDifference case load nothing about the components in standframe except gray.

2012-04-02 Thread Sergey Bylokhov
Hi Everyone, See comments from the bug description: /1. The image in Standard frame is not painted, until the frame is [manually] resized./ Fixed: Observer was added to the drawImage(). / 2. Test instructions should be corrected to have an explicit statement about components layout.

AWT Dev [8] Request for review: 7124534 [macosx] Submenu title overlaps with Submenu indicator in JPopupMenu

2012-04-02 Thread Sergey Bylokhov
Hi Everyone, This testcase was targeted to the bug in metal and motif lf. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124534 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124534/webrev.00/ Webrev against closed part:

Re: AWT Dev [8] Review request for 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-04-02 Thread Mike Swingler
This seems like a reasonable approach, though setting window icons is generally discouraged on OS X. Regards, Mike Swingler Apple Inc. On Apr 2, 2012, at 7:16 AM, Anthony Petrov wrote: Hi Mike, Have you had a chance to take a look at the issue? -- best regards, Anthony On 03/27/12

Re: AWT Dev [8] Review request for 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-04-02 Thread Anthony Petrov
But this approach doesn't work as one would expect. Please read my quote bellow. In a nutshell we've got 2 options: 1. Pass all images representations in one NSImage to setMiniwindowImage:. This doesn't work - if the dock is small, still the largest image is chosen only. Is there way to fix