Re: RFR 8028019 Doclint cleanup of java.awt

2013-12-09 Thread Petr Pchelko
Hello, Roger. The fix looks good to me. With best regards. Petr. On 03.12.2013, at 2:53, roger riggs wrote: > Hi Yuri, > > I updated the webrev to remove conflicts with the changeset in the 2D > repository. > I will push on Tuesday based on your OK comment unless I hear otherwise. > > Webre

Re: [7u] Review request for 8025775: JNI warnings in TryXShmAttach

2013-12-09 Thread Artem Ananiev
Looks fine to me as well. Thanks, Artem On 12/9/2013 5:15 PM, Anthony Petrov wrote: Hi Anton, The fix looks good to me. -- best regards, Anthony On 12/07/2013 02:03 AM, Anton Litvinov wrote: Hello Artem and Anthony, Could you please review this backport of the fix, which was approved by

Re: [7u] Review request for 8025775: JNI warnings in TryXShmAttach

2013-12-09 Thread Anthony Petrov
Hi Anton, The fix looks good to me. -- best regards, Anthony On 12/07/2013 02:03 AM, Anton Litvinov wrote: Hello Artem and Anthony, Could you please review this backport of the fix, which was approved by you for JDK 8, from JDK 8 to JDK 7. Bug: http://bugs.sun.com/view_bug.do?bug_id=8025775

Re: [8] Review Request: 8001472 api/java_awt/Window/indexTGF_* tests fail because expected colors aren't equal

2013-12-09 Thread Alexander Zvegintsev
HI Sergey, this fix looks fine to me. Thanks, Alexander. On 12/07/2013 03:31 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8. According to the documentation of XSetWindowBackground [1]: "Changing the background does not cause the window contents to be changed. To repaint th