[9] Review request for 8031694: [macosx] TwentyThousandTest test intermittently hangs

Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8031694.1/ for https://bugs.openjdk.java.net/browse/JDK-8031694 During forward-port of JDK-7189350 EDT.doDispatch was not taken into account when calling EventQueue.detachDispatchThread(). As a result harmful optimization of thi

Re: JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

On 27/01/2014 19:52, Joe Darcy wrote: : Alan, I strongly prefer to limit this patch to just cast cleanup. I understand, I was just pointing it out that some of these could use for-each and that would also eliminate the cast. : Based on the results of an exploratory jprt job, listed below

Re: JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

On 01/27/2014 12:04 AM, Alan Bateman wrote: On 26/01/2014 09:30, Alan Bateman wrote: The only non-client changes that I see are to Setup.gmk (previously reviewed on build-dev) and Sdp.java. I see the others now, just hard to spot in a large mind-numbing patch :-) All looks good but as I look a

Re: [9] Review Request: JDK-8031964 [macosx] Dragging images from the browser does not work

Hi, Petr. The fix looks good. On 27.01.2014 18:23, Petr Pchelko wrote: Hello, Sergey. Typo in the test description 3) When the image is dropped you should se the list of available DataFlavors", Thank you. Updated: http://cr.openjdk.java.net/~pchelko/9/8031964/webrev.03/

Re: [9] Review Request: JDK-8031964 [macosx] Dragging images from the browser does not work

Hello, Sergey. > Typo in the test description > 3) When the image is dropped you should se the list of available DataFlavors", Thank you. Updated: http://cr.openjdk.java.net/~pchelko/9/8031964/webrev.03/ > I assume we always use different long id as a key, otherwise a cached Long > objects will

Re: [9] Review Request: JDK-8031964 [macosx] Dragging images from the browser does not work

Hi, Petr. Typo in the test description 3) When the image is dropped you should se the list of available DataFlavors", I assume we always use different long id as a key, otherwise a cached Long objects will brake our map. formatMap.put((long) i, predefinedClipboardNames[i]); On 27.01.2014 17:

Re: [9] Review Request: JDK-8031964 [macosx] Dragging images from the browser does not work

Hello, Sergey. After more investigation I've decided to take a more aggressive approach to this fix. The new version is available here: http://cr.openjdk.java.net/~pchelko/9/8031964/webrev.01/ The HTMLSupport class and HTMLDecodingInputStream class were copy-pasted from WDataTransferer in the e

Re: [9] Review Request: 8032435 Cleanup of sun.awt.windows package

Hello, Sergey. The fix looks good to me. With best regards. Petr. On 27.01.2014, at 15:42, Sergey Bylokhov wrote: > I added @Override, because it make code refactoring safer. > I have separate CR for lamdafication > https://bugs.openjdk.java.net/browse/JDK-8031781 > > On 27.01.2014 14:42, Ar

Re: [9] Review Request: 8032435 Cleanup of sun.awt.windows package

I added @Override, because it make code refactoring safer. I have separate CR for lamdafication https://bugs.openjdk.java.net/browse/JDK-8031781 On 27.01.2014 14:42, Artem Ananiev wrote: Since you're adding @Override in many places, didn't you think about replacing some of the inner Runnable

Re: [9] Review Request: 8032435 Cleanup of sun.awt.windows package

Since you're adding @Override in many places, didn't you think about replacing some of the inner Runnable classes with lambdas? Thanks, Artem On 1/24/2014 6:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This is cleanup of the sun.awt.windows package: - Encapsulatio

Re: JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

On 26/01/2014 09:30, Alan Bateman wrote: The only non-client changes that I see are to Setup.gmk (previously reviewed on build-dev) and Sdp.java. I see the others now, just hard to spot in a large mind-numbing patch :-) All looks good but as I look at this again then I see a few Iterator usage