Re: AWT Dev [9] Review Request: 8075956 Fix some tidy warnings for java.awt

2015-03-26 Thread alexander stepanov
Thanks! On 26.03.2015 0:10, Alexander Zvegintsev wrote: Hello Alexander, the fix looks fine to me. -- Thanks, Alexander. On 25.03.2015 19:32, alexander stepanov wrote: Hello, Could you please review the fix for https://bugs.openjdk.java.net/browse/JDK-8075956 Webrev:

Re: AWT Dev [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

2015-03-26 Thread Anton Nashatyrev
Hi Sergey, yes it looks like I've missed the notifyChanged. you are right, this will remove the unnecessary AWT upcall from Toolkit thread (was it your intention?) Please take a look at the new fix version (the test has also been updated to check flavorsChanged):

Re: AWT Dev [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-03-26 Thread Hendrik Schreiber
On Mar 13, 2015, at 14:34, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Could you review the proposed API based on MultiresolutionImage interface: http://cr.openjdk.java.net/~alexsch/8029339/webrev.06/ Not that it counts much, but to me the proposed API looks good in

Re: AWT Dev RFR: JDK-8076106: [macosx] Drag image of TransferHandler does not honor MultiResolutionImage

2015-03-26 Thread Hendrik Schreiber
On Mar 26, 2015, at 17:17, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Could you add the automated test to the fix? Frankly, I provided a manual test in the bug report, because I'm not sure how to write an automated one for this issue. Once you pass the image into the

Re: AWT Dev RFR: JDK-8076106: [macosx] Drag image of TransferHandler does not honor MultiResolutionImage

2015-03-26 Thread Alexander Scherbatiy
Could you add the automated test to the fix? Thanks, Alexandr. On 3/26/2015 7:09 PM, Hendrik Schreiber wrote: Please review the following JDK9 patch, which adds the ability to display MultiResolutionImages as drag images on OS X. bug: https://bugs.openjdk.java.net/browse/JDK-8076106

AWT Dev RFR: JDK-8076106: [macosx] Drag image of TransferHandler does not honor MultiResolutionImage

2015-03-26 Thread Hendrik Schreiber
Please review the following JDK9 patch, which adds the ability to display MultiResolutionImages as drag images on OS X. bug: https://bugs.openjdk.java.net/browse/JDK-8076106 webrev: http://cr.openjdk.java.net/~alexsch/hendrik-schreiber/8076106 I signed a Oracle Contributor Agreement a while

Re: AWT Dev [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-03-26 Thread Jim Graham
Hi Alexander, MRI.java: Who is the intended audience for the recommendation in the interface to cache image variants? Are we asking the developers who call the methods on the interface to cache the answers? That would be unwise because the list of variants may change over time for some

AWT Dev [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

2015-03-26 Thread Semyon Sadetsky
Hello, Please review fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-6980209#comment-13623256 Webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6980209/webrev.00/ ***The root cause: There are 2 issues in WaitDispatchSupport: 1. If exit() is called before the secondary

Re: AWT Dev [Review ID: JI-9020036]: [macosx] Drag image of TransferHandler does not honor MultiResolutionImage

2015-03-26 Thread Alexander Scherbatiy
On 3/26/2015 6:35 PM, Hendrik Schreiber wrote: Hey there, I just filed [Review ID: JI-9020036], which includes a patch for Java9. It's a very straight forward, simple change. I'd appreciate it, if someone sponsored this and it found it's way into Java8 (where it would help me). The issue

AWT Dev [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

2015-03-26 Thread Anton Nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8071668/9/webrev.00/ http://cr.openjdk.java.net/%7Eanashaty/8071668/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8071668 Problem: On Mac Java doesn't see external clipboard

Re: AWT Dev [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

2015-03-26 Thread Sergey Bylokhov
Hi, Anton. Should we call CClipboard.notifyChanged when the owner was changed?(at least CClipboard.checkPasteboard call it). If yes then it seems that the previous fix(8010925) for this bug can be reworked in pure java using checkPasteboardWithoutNotification? 26.03.15 17:29, Anton