Re: AWT Dev [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

Hi Anton, the code was changed according to our offline discussion: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6980209/webrev.01/ added a test case for deterministic scenario bug root cause description extended --Semyon On 3/27/2015 5:32 PM, Anton V. Tarasov wrote: Hi Semyon, It

Re: AWT Dev [9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

The fix looks good to me. 27.03.15 14:10, Anton Nashatyrev wrote: Hello the second reviewer still wanted. Thanks! Anton. On 19.03.2015 14:11, Anton V. Tarasov wrote: Ok, great! Thanks, Anton. On 19.03.2015 14:09, Anton Nashatyrev wrote: Hi Anton, thanks for review! I've run

Re: AWT Dev [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

The fix looks good. I recall that checkPasteboard can be used outside of awt in fx. Anton T. can clarify this. 26.03.15 20:32, Anton Nashatyrev wrote: Hi Sergey, yes it looks like I've missed the notifyChanged. you are right, this will remove the unnecessary AWT upcall from Toolkit

Re: AWT Dev AWT [9] Review Request: JDK-8076151 Fix for Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails

The fix looks good to me. Just update the copyright year in the TestFontFile.sh. Thanks, Alexandr. On 3/27/2015 8:33 PM, pooja chopra wrote: Hello, Please review a fix for issue : 8076151 [TEST_BUG] Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails Test bug fix.

Re: AWT Dev [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

Hi Anton, Currently JFXPanel calls checkPasteboard via reflection. I had filed JDK-8061315 to provide a public method instead. But with your fix it's not needed. So, I've closed JDK-8061315. Also, I will back out the related fix in JFXPanel: https://javafx-jira.kenai.com/browse/RT-38922

Re: AWT Dev [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi Kevin, Right, I just assumed we would need some coordination. Thanks, Anton. On 30.03.2015 17:48, Kevin Rushforth wrote: Hi Anton, Yes, there are concerns regarding this, mainly due to the timing and build issues. After this week we are no longer auto-syncing changes from 8u-dev into 9,

Re: AWT Dev [9] Review Request JDK-6980209: Make tracking SecondaryLoop.enter/exit methods easier

Hi Semyon, The new version looks fine to me, however it seems to have a flaw currently: - Suppose exit is called when enter is executing on EDT, at line 181. In this case afterExit won't be reset to false by enter. - Suppose, exit is called when enter is executing on non-dispatch thread, at

Re: AWT Dev [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi Anton, Yes, there are concerns regarding this, mainly due to the timing and build issues. After this week we are no longer auto-syncing changes from 8u-dev into 9, so we are at a good point to do this, but it will need to be done carefully. I expect that we will need at least 2 weeks to

Re: AWT Dev JDK-8075070 [macosx] system menu bar disabled when using webstart to start

FYI the fix for 8074668 did not resolve this issue. Downloaded Java 8 Update 60 from https://jdk8.java.net/download.html Java Console still shows Insecure property and our main symptom (Mac menus are missing) still occurs. Mac OS X 10.9.3 Java Web Start 11.60.2.08 Using JRE version

Re: AWT Dev JDK 9 RFR of JDK-8075081 : Fix missing doclint warnings in java.awt

Hi Sergey, In the docs build with this change in, the javadoc for java.awt.List.getListeners uses the @param T information from the method being overrident in the superclass java.awt.Component, which is updated in the patch. With the patch, not doclint issues are reported in awt. Thanks,