Re: AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Semyon Sadetsky
Hi Sergey, - size remains unchanged on other platforms as well. I'm not sure that there should be exception for window peer on Linux. Do you have any solid info on that? - the utility method was introduced because decorated window can be moved and it is utilized from several places. It is not

Re: AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Sergey Bylokhov
Hi, Semyon. A few questions. - Why only location is fixed, an update of size if not necessary(if for some reason the size was changed by the system like location in this case)? - Note that we should update the target state before we post an event that the size is changed(we post them in

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
There are plenty classes extending CFRetainedResource, TryIcon for example. Will disposing them cause the same issue inside the native app? On 7/31/2015 4:37 PM, Sergey Bylokhov wrote: Yes, it is possible if this simple native application emulate initialization of these libraries. On

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 16:51, Semyon Sadetsky wrote: There are plenty classes extending CFRetainedResource, TryIcon for example. Will disposing them cause the same issue inside the native app? The crash occurs when any of these subclasses will be disposed, in some cases app will crash immediately, in

Re: AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 17:19, Semyon Sadetsky wrote: Hi Sergey, - size remains unchanged on other platforms as well. I'm not sure that there should be exception for window peer on Linux. Do you have any solid info on that? On OSX it is changed in LWWindowPeer.notifyReshape. On windows is changed in

Re: AWT Dev JDK-8015471 Deadlock or infinit loop in XAWT on Ubuntu 12.04

2015-07-31 Thread Christian
I tried to reproduce it, first by starting my app 20 times using this version. Five times I got a gray window. java version 1.8.0_45 Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) Then the same test on this version, and

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
Is it possible to reproduce the scenario using simple native application which embeds the Java VM? On 7/31/2015 3:37 PM, Sergey Bylokhov wrote: On 31.07.15 10:30, Semyon Sadetsky wrote: JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469

Re: AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 18:00, Semyon Sadetsky wrote: On windows is changed in awt_Window.cpp. WmMove What I see there: (env)-SetIntField(target, AwtComponent::xID, rect.left); (env)-SetIntField(target, AwtComponent::yID, rect.top); Are you talking about size or screen position? Sorry the method

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a binary files to the ws, It will require an xcode and comandline tools. On 7/31/2015 5:18

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a binary files to the ws, It will require an

Re: AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Semyon Sadetsky
On windows is changed in awt_Window.cpp. WmMove What I see there: (env)-SetIntField(target, AwtComponent::xID, rect.left); (env)-SetIntField(target, AwtComponent::yID, rect.top); Are you talking about size or screen position? The initial window size is preserved on Windows. On OSX it

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? Since we do not place a

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
On 31.07.15 10:30, Semyon Sadetsky wrote: JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469 description contains manual steps executed using SwingSet2, right? All sqe tests is not a part of openjdk project. These particular tests cannot

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Sergey Bylokhov
Yes, it is possible if this simple native application emulate initialization of these libraries. On 31.07.15 16:07, Semyon Sadetsky wrote: Is it possible to reproduce the scenario using simple native application which embeds the Java VM? On 7/31/2015 3:37 PM, Sergey Bylokhov wrote: On

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
So the test could use one of these java resources inside the native app without any external libraries only using JNI library, right? On 7/31/2015 5:18 PM, Sergey Bylokhov wrote: On 31.07.15 16:51, Semyon Sadetsky wrote: There are plenty classes extending CFRetainedResource, TryIcon for

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
On 7/31/2015 6:28 PM, Sergey Bylokhov wrote: On 31.07.15 18:12, Semyon Sadetsky wrote: On 7/31/2015 5:55 PM, Sergey Bylokhov wrote: On 31.07.15 17:29, Semyon Sadetsky wrote: So the test could use one of these java resources inside the native app without any external libraries only using

Re: AWT Dev [9] Review Request: 8132382 [macosx] Crash during JMC execution

2015-07-31 Thread Semyon Sadetsky
JMC-4034 is not an OpenJDK project. Souldn't this test be copied to the client-libs test base? JDK-8132469 description contains manual steps executed using SwingSet2, right? --Semyon On 7/30/2015 5:55 PM, Sergey Bylokhov wrote: Hi, Semyon. There are two tests which failed, see JMC-4034(

AWT Dev Awt Dev [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-07-31 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8011616 webrev: http://cr.openjdk.java.net/~ssadetsky/8011616/webrev.00/ WM sends the real window position in the configuration event but window peer does not set it to the target. Solution is: do set. --Semyon

Re: AWT Dev [9] Review request for 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows

2015-07-31 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/30/2015 6:56 PM, Sergey Bylokhov wrote: Looks fine. On 30.07.15 16:13, Yuri Nesterenko wrote: Colleagues, please review this small test-only fix for https://bugs.openjdk.java.net/browse/JDK-6544871 Webrev: