Re: [9] Review Request for 8150535: [TEST_BUG] fix @library for test/java/awt/TrayIcon/MouseMovedTest/MouseMovedTest.java

Gentle unassuming reminder!! (I would also ask someone to push it to Jake upon approval). (Or, after ~b111, I'll push them myself) -yan On 02/29/2016 06:45 PM, Yuri Nesterenko wrote: Colleagues, please review this test-only fix for some tray icon AWT tests in 9-jigsaw repository. CR is

Re: RFE: Windows awt FileDialog in JDK9

> On Mar 10, 2016, at 07:26, Semyon Sadetsky wrote: > > In my opinion the switching to old/new file dialog should be presented in > more explicit way. The automatic fallback may cause unexpected behavior. May > be it is worth to introduce a new system property to

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

Looks good. --Semyon On 3/10/2016 9:39 AM, Vikrant Agarwal wrote: Hi Semyon, Updated webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.03/ Justification: Yes, we can change the number of times the mouse moves up and down and this should not break the original scenario because

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

Hi Semyon, Updated webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.03/ Justification: Yes, we can change the number of times the mouse moves up and down and this should not break the original scenario because the up and down movement is being performed so that there is enough

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

On 3/2/2016 9:50 PM, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. Added a free call for duplicate file name in splashscreen_sys.c :: SplashGetScaledImageName http://cr.openjdk.java.net/~rchamyal/8145173/webrev.02/

Re: [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

The fix looks good to me. Thanks, Alexandr. On 3/2/2016 9:51 PM, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. Added a free call for duplicate file name in splashscreen_sys.c :: SplashGetScaledImageName http://cr.openjdk.java.net/~rchamyal/8145174/webrev.03/

Re: [9] RFR for 8151269: [TEST] add test covering getSource() method for multiresolution image

But probably getSource() should return something like MultiSourcexxx? Current behavior seems unspecified. On 09.03.16 19:51, Sergey Bylokhov wrote: +1 On 09.03.16 19:18, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 04/03/16 17:17, Alexander Stepanov

Re: Taking screenshots on x11 composite desktop produce wrong result

This looks preferable to the Gtk+ version. The Gtk+2 version will hit issues when loading Gtk+2 in Java code where the native code is using Gtk+3 (e.g. Eclipse, LibreOffice). At the moment, loading Gtk+2 is confined to loading the look and feel, but the current changes in 9 would expand its use

Re: [9] RFR for 8151269: [TEST] add test covering getSource() method for multiresolution image

+1 On 09.03.16 19:18, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 04/03/16 17:17, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151269/webrev.00/ for

Re: Taking screenshots on x11 composite desktop produce wrong result

- Original Message - > Hi Sergey, > > Here is a proposed fix for JDK9, it removes the dependencies on GTK > and use only X11 calls: > > http://cr.openjdk.java.net/~neugens/8150954/webrev.02/ > > I only tried this on a RHEL 7.2 so far but it seems to compile and > work as expected, and

Re: [9] RFR for 8151269: [TEST] add test covering getSource() method for multiresolution image

The test looks good to me. Thanks, Alexandr. On 04/03/16 17:17, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151269/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151269 ? Just a single test added. Thanks,

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

They are used for the further coordinates obtaining (on OS X the icon sizes are not equal for the buttons and the tabbed pane - please see the screenshot attached to JDK-8151060): Please see lines 187-189: 187 Component tc = tabbedPane.getTabComponentAt(1); 188 x =

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Can you please clarify these lines: 117 tabbedPane.addTab("", new JPanel()); 118 tabbedPane.setTabComponentAt(1, new JLabel()); On 09.03.16 18:48, Alexander Stepanov wrote: Hello, Sergey, Please see the updated version of the test:

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Hello, Sergey, Please see the updated version of the test: http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/ (covers JDK-8151303 as well). > I suggest to add these lines to the test instead of replace the old lines done. please see "@requires tag" - for now it will stop test run on OS

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi All, Please review webrev.01 updated with Avik’s review comments. http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.01/ Thanks, Manajit > On 09-Mar-2016, at 3:18 pm, Avik Niyogi wrote: > > Hi Manajit, > > Following are my inputs: > CRobot.m : Line 359 :

Re: RFE: Windows awt FileDialog in JDK9

> On Mar 9, 2016, at 10:45, Artem Ananiev wrote: > > as far as I remember, AWT team investigated the new file dialog, when Vista > was released. It looks fine, but there's an issue: it doesn't provide a way > to implement > >

Re: [9] Review-request for 6353518: Creation of a WritableRaster with a custom DataBuffer causes erroneous Exception

Changes for 2d area.(cc) On 07.03.16 11:20, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6353518 Issue : (Text from bug description) An attempt to create a WritableRaster via Raster.createWritableRaster(SampleModel sm, DataBuffer db, Point location) using a custom

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, Following are my inputs: CRobot.m : Line 359 : retval not needed alphabetical objC header list convention not followed. Line 36 should be placed at line 32 CRobotKeyCode.m : Line 171: retval not needed. use else block for cases undefined. Use non-Swing implementations for test case.

Re: RFE: Windows awt FileDialog in JDK9

Hi, Hendrik, as far as I remember, AWT team investigated the new file dialog, when Vista was released. It looks fine, but there's an issue: it doesn't provide a way to implement FileDialog.setFilenameFilter(FilenameFilter filter) method. The chances are Microsoft has introduced new APIs for

Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8149456 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.00/ Issue:

Re: [9] RFR for 8142406: [TEST] MultiResolution image: need test to cover the case when @2x image is corrupted

Hello, Sergey, Semyon, Thank you! Regards, Alexander On 3/9/2016 10:32 AM, Semyon Sadetsky wrote: +1 --Semyon On 3/4/2016 8:25 PM, Sergey Bylokhov wrote: Looks fine. On 02.03.16 16:47, Alexander Stepanov wrote: Hello, Could you please review the following fix