Looks fine.
On 16.03.16 20:03, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8150844/webrev.02/
The GTKLookAndFeel setting is changed to the system L&F in the
HiDPIPropertiesUnixTest.
Thanks,
Alexandr.
On 16/03/16 20:34, Se
Looks good.
--Semyon
On 3/17/2016 10:15 AM, Alexander Stepanov wrote:
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame() and dispose() operations in doTest (the final
'dispose' is indeed should be run on EDT as
Hi,
Please review the fix for JDK9,
Bug: https://bugs.openjdk.java.net/browse/JDK-8033936
Webrev: http://cr.openjdk.java.net/~arapte/8033936/webrev.00/
Issue:
In a multi select list, when multiple items are selected and
then deselected,
Thanks, looks fine (not a reviewer).
Regards,
Alexander
On 3/16/2016 3:12 PM, Alexander Scherbatiy wrote:
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8150844/webrev.01/
- the is2x() method is removed from the tests
- imports are updated
On 16/03/16 13:25, Alexa
Looks good.
--Semyon
On 3/13/2016 12:17 AM, Ambarish Rapte wrote:
Hi All,
I have updated the webrev with a change in Text Area code.
There was an issue with webrev.01 that, In Text Area last line does
not get selected while selecting vertically downards.
Please review the updated webrev.0
On Mar 16, 2016, at 06:25, Alexandr Scherbatiy
wrote:
>
>
> The JDK fixes should be pushed to the JDK 9 first and then be back-ported
> to JDK 8.
>
> Could you prepare the fix for JDK 9?
Hi Alexandr,
I've created a patch for JDK9. You can find it at
http://cr.openjdk.java.net/~hschreib
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8150844/webrev.01/
- the is2x() method is removed from the tests
- imports are updated
On 16/03/16 13:25, Alexander Stepanov wrote:
Hello Alexandr,
just a minor remark about is2x() in tests:
do we still need this meth
The MultiResolutionJOptionPaneIconTest extends JFrame so it shoud be
created and used on EDT as others Swing components.
Thanks,
Alexndr.
On 14/03/16 18:26, Alexander Stepanov wrote:
Hello Semyon,
> JOptionPane.showInternalInputDialog() is an utility method
Yes, the initial intention was to
Thanks!
On 3/17/2016 12:45 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 17/03/16 11:15, Alexander Stepanov wrote:
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame() and dispose
Is it possible to move it under ifdef? So we can grep and drop it in the
future.
On 16.03.16 16:27, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8151998
webrev: http://cr.openjdk.java.net/~alexsch/8151998/webrev.00
The fi
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8151998
webrev: http://cr.openjdk.java.net/~alexsch/8151998/webrev.00
The fix uses the "ROUND_TO_INT(num) ((int) floor((num) + 0.5))"
instead round function which is not compiled by VS2010.
Thanks,
Alexandr.
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8150844/webrev.02/
The GTKLookAndFeel setting is changed to the system L&F in the
HiDPIPropertiesUnixTest.
Thanks,
Alexandr.
On 16/03/16 20:34, Sergey Bylokhov wrote:
HiDPIPropertiesUnixTest will be noop on O
ES_AUTOHSCROLL enables the automatic horizontal scrolling and you are
using bScrollDown. Dont we need to use bScrollUp portion of the code
also for scrolling up once we scroll down to bottom and we then move up?
if (bScrollUp == TRUE) {
296 SendMessage(EM_LINESCROLL, 0, -1);
One of the test u
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame() and dispose() operations in doTest (the final
'dispose' is indeed should be run on EDT as well). The robot
operations/checks are executed on main thread using vol
Hi Prasanta,
Thanks for the review.
The ES_AUTOVSCROLL enables vertical scrolling, but last line
does not get selected while selecting vertically downwards.
Hence bScrollDown is retained.
But there is no issue with selecting upwards, hence bS
The fix looks good to me.
Thanks,
Alexandr.
On 17/03/16 11:15, Alexander Stepanov wrote:
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame() and dispose() operations in doTest (the final
'dispose' is indeed shoul
Looks good to me.
Regards
Prasanta
On 3/18/2016 12:02 PM, Ambarish Rapte wrote:
Hi Prasanta,
Thanks for the review.
The ES_AUTOVSCROLL enables vertical scrolling, but last line does not
get selected while selecting vertically downwards.
Hence bScrollDown is retained.
But there is no issue
On 3/16/2016 3:21 PM, Sergey Bylokhov wrote:
So fast, I just prepared the similar fix
Why the scale is "1" when isUIScaleEnabled is not enabled?
Because sun.java2d.uiScale.enabled property explicitly disables the
HiDPI graphics support.
Thanks,
Alexandr.
252 private void ini
18 matches
Mail list logo
