Re: [10] JDK-8146537: TrayIcon Action Listener doesnt work in WIndows 10

Hi Sergey, Here is the Webrev containing fixes for your comments. http://cr.openjdk.java.net/~sveerabhadra/8146537/webrev.01/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 22, 2017 4:31 AM To: Shashidhara Veerabhadraiah

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Hi Manajit, The changes look good. As this is a new test in open, can you please confirm whether it passes on Windows and Linux as well? Regards, Ajit From: Manajit Halder Sent: Monday, November 27, 2017 4:35 PM To: Ajit Ghaisas Cc: Prem Balakrishnan; Sergey Bylokhov;

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

On 27/11/2017 14:02, Semyon Sadetsky wrote: > The current changes get my "+1" as comformant HTML5. This is not true.  The empty tags produce warnings in HTML5 validator: https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html The

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

> The current changes get my "+1" as comformant HTML5. This is not true.  The empty tags produce warnings in HTML5 validator: https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html -phil. On 11/22/2017 07:58 PM, Jonathan Gibbons

Re: [OpenJDK 2D-Dev] [10] Review Request: 8182410, 8183508, 8181289

The current changes get my "+1" as comformant HTML5. -phil. On 11/22/2017 07:58 PM, Jonathan Gibbons wrote: Semyon, You may indeed have explained why the behavior as it is, but we cannot and should not link this review with changes to the javadoc stylesheets, when the specific changes in

Re: [10] JDK-8148344: Java robot keypress should be able to use extended key code characters as ? ? ?.

Hi, Shashi. Also we should check what events are come to the application when this new API will be used. For example if 'm' will be pressed what notifications will be posted to the application?(keyTyped/keyPressed/keyReleased) The test is still manual, I suggest to change it to automated and

Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

+1 Regards Prasanta On 11/27/2017 5:13 PM, Sreeprakash Sreedharan wrote: Thanks for your review Prasanta. I have updated the webrev with the change. Updated Webrev : http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.01/

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Hi Ajit, Modified the code as per your review comments. Please review the changes. http://cr.openjdk.java.net/~mhalder/8158366/webrev.01/ Thanks, Manajit > On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas wrote: > >

Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

You need to set "cfr" here 3877 cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0; Regards Prasanta On 11/27/2017 2:56 PM, Sreeprakash Sreedharan wrote: Hi, Please review this webrev for JDK-8u backport. Webrev:

[8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

Hi, Please review this webrev for JDK-8u backport. Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.00/ Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504 JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

1) This test lacks copyright banner at the top 2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception. Regards, Ajit -Original Message- From: Prem Balakrishnan Sent: Monday, November 27, 2017 12:02 PM To: Sergey Bylokhov;