Hi,
Is there a good reason this is a closed change?
If not, could you please open it up?
Thanks,
Goetz.
> -Original Message-
> From: awt-dev On Behalf Of Philip
> Race
> Sent: Wednesday, December 4, 2019 2:33 AM
> To: Sergey Bylokhov
> Cc: awt-dev@openjdk.java.net
> Subject: Re:
rowse/JDK-8191678
https://bugs.openjdk.java.net/browse/JDK-8185500
Best regards,
Goetz.
> -Original Message-
> From: Sergey Bylokhov
> Sent: Saturday, February 16, 2019 3:10 AM
> To: Lindenmaier, Goetz ; awt-
> d...@openjdk.java.net
> Subject: Re: RFR(XS): 8219095: [testbug] Add
Hi,
please review this tiny fix for the test. It fails in our headless
runs:
http://cr.openjdk.java.net/~goetz/wr19/8219095-headfulTest/01/
Best regards,
Goetz.
Hi Matthias,
You can push this now. There are two Reviewers,
the change sat there more than 24h, and it’s a simple fix.
Thanks, Goetz
From: Langer, Christoph
Sent: Monday, October 8, 2018 10:01 AM
To: Baesken, Matthias ; Lindenmaier, Goetz
; awt-dev@openjdk.java.net
Subject: RE: RFR : 8211317
Hi Matthias,
good catch, thanks for fixing this.
Looks good.
Best regards,
Goetz.
From: Baesken, Matthias
Sent: Donnerstag, 4. Oktober 2018 08:45
To: awt-dev@openjdk.java.net
Cc: Lindenmaier, Goetz ; Langer, Christoph
Subject: RE: RFR : 8211317: avoid memory leak
ta Sadhukhan ; awt-
> d...@openjdk.java.net
> Cc: Lindenmaier, Goetz
> Subject: RE: RFR [XS] : 8207941 :
> javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails on
> machines without Arial font [testbug]
>
> Hi, could I have a second review please so that
Hi,
I ran coverity on the jdk11 jdk sources and want to propose the following
fixes. I scanned the linux x86_64 build. Some issues are similar to previous
parfait fixes (check for NULL). I also identified some issues I consider real
problems. If you think some are tooo conservative, I'm happy
Thanks Sergey!
Best regards,
Goetz.
> -Original Message-
> From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
> Sent: Donnerstag, 18. Januar 2018 04:59
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net
> Cc: core-l
twoch, 17. Januar 2018 12:55
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Volker Simonis
> <volker.simo...@gmail.com>
> Cc: core-libs-...@openjdk.java.net; Baesken, Matthias
> <matthias.baes...@sap.com>
> Subject: Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt te
Thanks a lot!
Best regards,
Goetz.
> -Original Message-
> From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
> Sent: Donnerstag, 30. November 2017 21:36
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net
> Subject: Re: R
; From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
> Sent: Mittwoch, 29. November 2017 14:49
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net
> Subject: Re: RFR(S): 8191678: [TESTBUG] Add keyword headful in
> java/awt and javax tests.
Hi,
I added @key headful to some more tests where it was missing.
Also, I fixed some NPEs I get when running the tests headless.
Please review.
http://cr.openjdk.java.net/~goetz/wr17/8191678-headfulKey/webrev.01/
Best regards,
Goetz.
It was changed in client to 2017, I reverted it to avoid merge conflicts.
Best regards,
Goetz.
> -Original Message-
> From: Baesken, Matthias
> Sent: Montag, 14. August 2017 13:36
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net
&g
regards,
Goetz.
> -Original Message-
> From: awt-dev [mailto:awt-dev-boun...@openjdk.java.net] On Behalf Of
> Lindenmaier, Goetz
> Sent: Freitag, 11. August 2017 13:58
> To: Baesken, Matthias <matthias.baes...@sap.com>; awt-
> d...@openjdk.java.net
> Subject:
Best regards,
Goetz.
From: Baesken, Matthias
Sent: Freitag, 11. August 2017 09:29
To: awt-dev@openjdk.java.net; Lindenmaier, Goetz <goetz.lindenma...@sap.com>
Subject: re : AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords
Ø I added more headful tests that are only run on
Thanks Sergey!
If I have the second review, can I push it to jdk10/jdk10?
That's where we run these tests.
Best regards,
Goetz.
> -Original Message-
> From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
> Sent: Freitag, 11. August 2017 04:52
> To: Linden
to:awt-dev-boun...@openjdk.java.net] On Behalf Of
> Lindenmaier, Goetz
> Sent: Freitag, 4. August 2017 13:53
> To: awt-dev@openjdk.java.net
> Subject: Re: RFR(M): 8185500: [TESTBUG] Add keywords
> headful/printer in java/awt and javax tests.
>
> Hi,
>
> I add
Hi,
I added another approx. 20 tests which are headful but are run only on mac.
http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 2. August 2017 11:13
>
Hi,
I looked at all the remaining tests failing in our test environment, and I
think I have now identified the last set of headful tests that lack the
@key headful tag.
Also, I identified a row of tests that require a printer. For these I introduced
the new keyword 'printer' and marked them
Hi Phil,
does that mean I can push the change, or will this happen through jprt?
Best regards,
Goetz.
> -Original Message-
> From: Philip Race [mailto:philip.r...@oracle.com]
> Sent: Tuesday, December 06, 2016 4:21 AM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.co
Hi,
the fix to imageDecompressor.cpp is already reported in
https://bugs.openjdk.java.net/browse/JDK-8170663
I'll send RFR for that today.
I'll add you to contributors.
Best regards,
Goetz.
> -Original Message-
> From: awt-dev [mailto:awt-dev-boun...@openjdk.java.net] On Behalf Of
>
-Original Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Monday, December 05, 2016 7:26 PM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov
> <sergey.bylok...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.j
Hi Phil,
that would be great, unfortunately I don't have access to JPRT.
Thanks,
Goetz.
> -Original Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Friday, December 02, 2016 8:46 PM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
,
Goetz.
> -Original Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Donnerstag, 1. Dezember 2016 22:31
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov
> <sergey.bylok...@oracle.com>; Vincent Ryan <vincent.x.
Ah, no, that is just the field that is initialized with the
Result of gtk3_get_color_for_flags() why I need to initialize it there.
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Donnerstag, 1. Dezember 2016 12:10
> To: 'Prasan
rgey.bylok...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RF
Langer, Christoph
> Sent: Mittwoch, 30. November 2016 20:47
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net; 2d-
> d...@openjdk.java.net; Vincent Ryan <vincent.x.r...@oracle.com>
> Subject: RE: RFR(M): 817052
Hi Vincent,
I fixed the typo and added a remark to the first line of the bug text.
Best regards,
Goetz.
> -Original Message-
> From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
> Sent: Mittwoch, 30. November 2016 17:10
> To: Lindenmaier, Goetz <goetz.lindenma..
regards,
Goetz.
(Am I correct that your openJdk name is Vinnie?)
> -Original Message-
> From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
> Sent: Mittwoch, 30. November 2016 14:53
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: awt-dev@openj
Hi,
I'd like to propose a row of smaller fixes where code is noted down a bit
questionable.
SAP's quality process requires that we fix these in our internal delivery, and I
Would like to share my fixes with openJdk. Some of these fixes are of more
theoretical nature as how I understand the code
regards,
Goetz.
> -Original Message-
> From: Vadim Pakhnushev [mailto:vadim.pakhnus...@oracle.com]
> Sent: Friday, July 22, 2016 9:09 AM
> To: Phil Race <philip.r...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>
> Subject: Re: [OpenJDK 2D-Dev] R
age-
> From: Volker Simonis [mailto:volker.simo...@gmail.com]
> Sent: Mittwoch, 20. Juli 2016 15:30
> To: Sergey Bylokhov <sergey.bylok...@oracle.com>
> Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net; swing-...@openjdk.java.net; 2d-de
Hi
This changes fixes two memory issues.
In awt_PrintControl.cpp, a wrong pointer is freed.
In LigatureSubstProc2.cpp, line 157:
stack[++mm] = componentGlyph;
can overwrite the stack by one element. It will write
stack[nComponents], because ++mm increments before
accessing the array.
Fix:
Hi Volker,
thanks for looking at this, and doing the test example!
Best regards,
Goetz.
> -Original Message-
> From: Volker Simonis [mailto:volker.simo...@gmail.com]
> Sent: Freitag, 15. Juli 2016 12:09
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc
Hi,
could someone please have a look at this?
It's L, but the change is only one line in a lot of tests ...
Thanks!
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Donnerstag, 7. Juli 2016 17:01
> To: 'awt-dev@openjdk.java.net' <awt-dev@openjdk.java.n
Hi,
This change is 'L' because there are changes to a lot of files, but the changes
are all similar, so it's rather easy to review.
Similar to 8159690 I added @key headful to another around 600 tests.
I used different patterns to grep for the headful exceptions.
These are now all I could find
Hi,
can I consider this reviewed?
Remi Forax and Phil Race had a look at this.
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Montag, 4. Juli 2016 08:33
> To: 'Phil Race' <philip.r...@oracle.com>; awt-dev@openjdk.java.net; 2d-dev
> <
Hi Remi,
thanks, your're right, that's better.
Best regards
Goetz.
> -Original Message-
> From: Remi Forax [mailto:fo...@univ-mlv.fr]
> Sent: Freitag, 1. Juli 2016 17:57
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: awt-dev@openjdk.java.net
&
016 19:35
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt-
> d...@openjdk.java.net
> Subject: Re: RFR(XS): 8160721: Avoid deoptimizations in
> Font.equals.
>
> Please resend this to 2d-dev. All font related API and implementation
> is part of 2D, not AWT.
Hi,
This small fix improves performance of the C2 compiler.
We see deoptimizations due to class casts in Font.equals.
Use instanceof check instead of catching the exception.
Please review this change:
http://cr.openjdk.java.net/~goetz/wr16/8160721-deoptFont/
Best regards,
Goetz.
regards,
Goetz.
> -Original Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Montag, 20. Juni 2016 22:18
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: Sergey Bylokhov <sergey.bylok...@oracle.com>; Alexandr Scherbatiy
> <alexan
Hi Alexandr,
Thanks for reviewing!
Best regards,
Goetz.
> -Original Message-
> From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com]
> Sent: Freitag, 17. Juni 2016 16:04
> To: Volker Simonis <volker.simo...@gmail.com>
> Cc: Lindenmaier, Goetz <g
this change so that we get all of them at once.
Best regards,
Goetz.
> -Original Message-
> From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com]
> Sent: Freitag, 17. Juni 2016 14:53
> To: Volker Simonis <volker.simo...@gmail.com>
> Cc: Lindenmaier, Goetz <g
cle.com]
> Sent: Donnerstag, 16. Juni 2016 17:56
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; swing-
> d...@openjdk.java.net; awt-dev@openjdk.java.net
> Subject: Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with
> @key headful.
>
> On 6/16/2016 5:40 PM,
Hi,
we have test machines without X server. On these many of the jdk
jtreg tests fail with a headless exception.
We grepped for this exception in the test output and identified
about 450 tests.
In these tests, we added with another script "@key headful".
So that the script generates better
45 matches
Mail list logo
