Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
> On 17 May 2018, at 20:04, Sergey Bylokhov wrote: > > On 17/05/2018 11:35, Dmitry Markov wrote: >> So if I got you right, it is not necessary to call these methods if the >> target has been resized. In other words we should NOT change the if-statement >> FROM: >>

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Sergey Bylokhov
On 17/05/2018 11:35, Dmitry Markov wrote: So if I got you right, it is not necessary to call these methods if the target has been resized. In other words we should NOT change the if-statement FROM: if (pResized || isNewDevice) TO: if (pResized || *tResized *|| isNewDevice) Is my understanding

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
> On 17 May 2018, at 19:25, Sergey Bylokhov wrote: > > On 17/05/2018 02:05, Dmitry Markov wrote: >> Hi Sergey, >> According to your fix replacSurfaceData() and updateMinimumSize() are >> invoked only if the graphics device has been changed or the peer has been >>

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Sergey Bylokhov
On 17/05/2018 02:05, Dmitry Markov wrote: Hi Sergey, According to your fix replacSurfaceData() and updateMinimumSize() are invoked only if the graphics device has been changed or the peer has been resized: 734 if (pResized || isNewDevice) { 735 replaceSurfaceData();

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
Hi Sergey, According to your fix replacSurfaceData() and updateMinimumSize() are invoked only if the graphics device has been changed or the peer has been resized: > 734 if (pResized || isNewDevice) { > 735 replaceSurfaceData(); > 736 updateMinimumSize(); >

[11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-16 Thread Sergey Bylokhov
Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8201364 Webrev: http://cr.openjdk.java.net/~serb/8201364/webrev.00 Description: The bug occurs when the application tries to set location of the window to the point, where the window cannot be placed. For