Ok, Looks fine.
>
> Hi Sergey,
>
> I ran JCK tests and didn't observe any problems introduced by the fix.
>
> Thanks,
> Dmitry
> On 06/03/2017 22:24, Sergey Bylokhov wrote:
>> Ok, But will it be possible to use this custom cursor? For example according
>> to the spec:
>> * @param hotSpot
Hi Sergey,
I ran JCK tests and didn't observe any problems introduced by the fix.
Thanks,
Dmitry
On 06/03/2017 22:24, Sergey Bylokhov wrote:
Ok, But will it be possible to use this custom cursor? For example according to
the spec:
* @param hotSpot the X and Y of the large cursor's hot sp
Ok, But will it be possible to use this custom cursor? For example according to
the spec:
* @param hotSpot the X and Y of the large cursor's hot spot; the
* hotSpot values must be less than the Dimension returned by
* {@code getBestCursorSize}
* @exception IndexOutOfBoundsE
I am fine with the proposed fix as it fixes the exception and should be
safe to backport.
-phil.
On 3/3/2017 4:09 AM, dmitry markov wrote:
Hi Sergey,
In my opinion if zero size is returned as a result of
getBestCursorsize() invocation, the cursor should have initial size
defined by the para
Hi Sergey,
In my opinion if zero size is returned as a result of
getBestCursorsize() invocation, the cursor should have initial size
defined by the parameter of its constructor. I am sorry, but it will
look very odd especially for end user, if we silently change an original
cursor's size to z
Hi, Dmitry.
I have only the one question: the size 0,0 can be returned if the custom
cursors are not supported. I wonder should our CustomCursor have an initial
size, of it should have zero size?
> Hello,
>
> Could you review a fix for jdk9, please?
>
> bug: https://bugs.openjdk.java.net
Hello,
Could you review a fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8173853
webrev: http://cr.openjdk.java.net/~dmarkov/8173853/webrev.00/
Problem description:
Sometimes XQueryBestCursor may return zero-dimension to the code inside
XCustomCursor.getBes
