Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-13 Thread Semyon Sadetsky
Hi Ambarish, I confirm that your solution fixes the bug on 32-bit Ubuntu. But it doesn't help 64-bit Ubuntu and the test fails there. I 'd like to note that we should fix the root cause of the issue. Solutions like test workaround need to be substantiated. --Semyon On 11/6/2015 12:19 PM,

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-06 Thread Ambarish Rapte
Hi Semyon, I use 32 bit ubuntu 14.04 LTS on Oracle virtual box 5.0.6. ( Downloaded from here http://www.ubuntu.com/download/desktop ) After creating the image, I did not install any updates on ubuntu. Installed only basic needed packages

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-05 Thread Semyon Sadetsky
Hi Ambarish, I have double-checked the fix, but again I got it failed for jdk8 and jdk9-b88 on Ubuntu 14.04 LTS. See what I get: Testing Choice The test failed: Opacity test mismatchs The test failed: Opacity test mismatchs The test is over, hit Ctl-C to stop Java VM The test is over, hit

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-03 Thread Ambarish Rapte
Hi Semyon, The issue with Choice which I mentioned, is my observation for the test failure. There is no bug reported. Regarding the test failure, because mouseClicked() was not getting called at all. Without the fix, the test was failing

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-02 Thread Ambarish Rapte
Hi Semyon, OpaqueOverlapping :: performTest() function performs the test by generating mouse click event using, mouse press & mouse release events. But choice receives only mouse Press and mouse release event & does not receive the mouse

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-02 Thread Semyon Sadetsky
Hi Ambarish, But I did not touch the mouse. Usually mouse events come in the next sequence MOUSE_PRESSED, MOUSE_RELEASED,MOUSE_CLICKED. Why do you think that mouseClicked()->mousePressed() replacement should change something in the test? --Semyon On 11/2/2015 8:51 AM, Ambarish Rapte wrote:

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-11-01 Thread Ambarish Rapte
Dear Semyon, This test uses the mouse for input. While the test is running with or without fix, mouse should not be disturbed. -- guess we should not touch mouse while test in in progress, in

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-10-30 Thread prasanta sadhukhan
Hi Ambarish, The bug was test was throwing "java.lang.RuntimeException: Opacity test mismatchs". Did this fix solve that problem? It seems to fail in my linux even with this fix. Regards Prasanta On 10/29/2015 7:30 PM, Ambarish Rapte wrote: Dear All, Kindly review the fix

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-10-30 Thread prasanta sadhukhan
guess we should not touch mouse while test in in progress, in that case it passed. Fix looks fine to me. Regards Prasanta On 10/30/2015 12:09 PM, prasanta sadhukhan wrote: Hi Ambarish, The bug was test was throwing "java.lang.RuntimeException: Opacity test mismatchs". Did this fix solve that

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-10-30 Thread Semyon Sadetsky
Hi Ambarish, After your fix applying the test still fails. --Semyon On 10/29/2015 5:00 PM, Ambarish Rapte wrote: Dear All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8048171 Webrev:

Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-10-29 Thread Ambarish Rapte
Dear All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8048171 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/ambarish/8048171/webrev.00/"http://cr.openjdk.java.net/~rchamyal/ambarish/8048171/webrev.00/