Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-10-14 Thread Sergey Bylokhov
On 05.10.16 10:40, Semyon Sadetsky wrote: "in the way how bounds are used" what does it mean? In current code the bounds of the graphics config are used incorrectly. The thing is that the code produce the correct result, while the new code caused regression. Or you are insisting that the

Review request for JDK-8165144, JDK-8167159 and JDK-8167155

2016-10-14 Thread Andrey Rusakov
Hello, guys. Please have a look at my fixes for some test bugs: https://bugs.openjdk.java.net/browse/JDK-8167155, https://bugs.openjdk.java.net/browse/JDK-8167159 and https://bugs.openjdk.java.net/browse/JDK-8167155 and upload them if everything is ok. Thanks in advance.

Re: [9] Review request for 8167486: Device.getDisplayMode() doesn't report refresh rate on Linux in case of dual screen

2016-10-14 Thread Sergey Bylokhov
On 12.10.16 10:27, Semyon Sadetsky wrote: Should toString() method report zero HZ as unknown(os something like that) instead of 0? And probably "DEPTH_MULTI"also should be printed in some way, instead of empty line. http://cr.openjdk.java.net/~ssadetsky/8167486/webrev.01/ Looks fine. On

Re: [9] Review request for 8167565: [macosx] Maximization of a dialog hides it

2016-10-14 Thread Sergey Bylokhov
+1 On 14.10.16 9:48, Semyon Sadetsky wrote: Looks good. --Semyon On 13.10.2016 18:17, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8167565/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8167565 We trying to zoom to a

[9] Review request: 8167155 [PIT] failure and a test bug in MultiResolutionTrayIconTest.java

2016-10-14 Thread Andrey Rusakov
Hello, please review the fix http://cr.openjdk.java.net/~arusakov/8167155/webrev.00 for the issue https://bugs.openjdk.java.net/browse/JDK-8167155 This fix resolves issue which caused test to pass even if "fail" button was clicked and adds jtreg platform filter.

[9] Review request: 8167159 [PIT][TEST_BUG] java/awt/image/multiresolution/MultiResolutionIcon/MultiResIconTest.java

2016-10-14 Thread Andrey Rusakov
Hello, please review the fix http://cr.openjdk.java.net/~arusakov/8167159/webrev.00 for the issue https://bugs.openjdk.java.net/browse/JDK-8167159 This fix resolves issue which caused test to pass even if "fail" button was clicked and adds jtreg platform filter.

Re: [9] Review request for 8167565: [macosx] Maximization of a dialog hides it

2016-10-14 Thread Semyon Sadetsky
Looks good. --Semyon On 13.10.2016 18:17, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8167565/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8167565 We trying to zoom to a zero size window(standardFrame has zero size).

Re: [9] Review request: 8167155 [PIT] failure and a test bug in MultiResolutionTrayIconTest.java

2016-10-14 Thread Phil Race
> This fix resolves issue which caused test to pass even if "fail" button was clicked and adds jtreg platform filter. But what about the issue that (as I read it) the test does actually fail ? > The test fails adding not blue (as requested) but red icon to a tray. The test bug was secondary

Re: [9] Review request: 8167159 [PIT][TEST_BUG] java/awt/image/multiresolution/MultiResolutionIcon/MultiResIconTest.java

2016-10-14 Thread Alexandr Scherbatiy
The Windows OS is not listed in the test @requires tag but the test should work on Windows as well. Thanks, Alexandr. On 10/14/2016 7:02 PM, Andrey Rusakov wrote: Hello, please review the fix http://cr.openjdk.java.net/~arusakov/8167159/webrev.00 for the issue